)]}'
{"openstackclient/compute/v2/server.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e0660a465364d37ffee98b51c267b28f4a5b81c2","unresolved":false,"context_lines":[{"line_number":1471,"context_line":"            # format, we effectively guess what the user wants and switch"},{"line_number":1472,"context_line":"            # things around, issuing a giant warning in the process."},{"line_number":1473,"context_line":"            #"},{"line_number":1474,"context_line":"            # TODO(stephenfin): Remove this in OSC 4.0"},{"line_number":1475,"context_line":"            try:"},{"line_number":1476,"context_line":"                server \u003d utils.find_resource(compute_client.servers,"},{"line_number":1477,"context_line":"                                             parsed_args.host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_de389aef","line":1474,"range":{"start_line":1474,"start_character":12,"end_line":1474,"end_character":54},"updated":"2019-04-02 17:32:33.000000000","message":"In OSC 4.0 I\u0027d rather just not have the destination host as an argument and make it an option (--host), which is what we\u0027ve talked about before when thinking about ways to fix this and what the ideal command would be, because we\u0027re going to want to also eventually support cold migrating with a target host (microversion 2.56).","commit_id":"013a6ddfbe9ca8888b7370c25f68f361ddee48f3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4721e335aa49401c6ef4b0fd8eec8fd382142158","unresolved":false,"context_lines":[{"line_number":1471,"context_line":"            # format, we effectively guess what the user wants and switch"},{"line_number":1472,"context_line":"            # things around, issuing a giant warning in the process."},{"line_number":1473,"context_line":"            #"},{"line_number":1474,"context_line":"            # TODO(stephenfin): Remove this in OSC 4.0"},{"line_number":1475,"context_line":"            try:"},{"line_number":1476,"context_line":"                server \u003d utils.find_resource(compute_client.servers,"},{"line_number":1477,"context_line":"                                             parsed_args.host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_ae9f8e63","line":1474,"range":{"start_line":1474,"start_character":12,"end_line":1474,"end_character":54},"in_reply_to":"5fc1f717_de389aef","updated":"2019-04-03 09:35:46.000000000","message":"Hmm, if cold migrating with a host name is a thing, then I\u0027m not sure why you _wouldn\u0027t_ want the (optional) positional argument? That would be actually make for a nice CLI because the host would apply to both.","commit_id":"013a6ddfbe9ca8888b7370c25f68f361ddee48f3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e0660a465364d37ffee98b51c267b28f4a5b81c2","unresolved":false,"context_lines":[{"line_number":1476,"context_line":"                server \u003d utils.find_resource(compute_client.servers,"},{"line_number":1477,"context_line":"                                             parsed_args.host)"},{"line_number":1478,"context_line":"            except exceptions.CommandError:"},{"line_number":1479,"context_line":"                # the host is actually a host (well, it\u0027s not an instance)"},{"line_number":1480,"context_line":"                pass"},{"line_number":1481,"context_line":"            else:"},{"line_number":1482,"context_line":"                # the host is actually an instance :("}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_81171346","line":1479,"range":{"start_line":1479,"start_character":65,"end_line":1479,"end_character":73},"updated":"2019-04-02 17:32:33.000000000","message":"server","commit_id":"013a6ddfbe9ca8888b7370c25f68f361ddee48f3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4721e335aa49401c6ef4b0fd8eec8fd382142158","unresolved":false,"context_lines":[{"line_number":1476,"context_line":"                server \u003d utils.find_resource(compute_client.servers,"},{"line_number":1477,"context_line":"                                             parsed_args.host)"},{"line_number":1478,"context_line":"            except exceptions.CommandError:"},{"line_number":1479,"context_line":"                # the host is actually a host (well, it\u0027s not an instance)"},{"line_number":1480,"context_line":"                pass"},{"line_number":1481,"context_line":"            else:"},{"line_number":1482,"context_line":"                # the host is actually an instance :("}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_eec7d663","line":1479,"range":{"start_line":1479,"start_character":65,"end_line":1479,"end_character":73},"in_reply_to":"5fc1f717_81171346","updated":"2019-04-03 09:35:46.000000000","message":"I chose this on purpose and can/will change, but who thought server was a good idea, the first day? It\u0027s incredibly confusing, especially when I\u0027m talking about hosts here (most likely actual servers). Ugh. \u003c/rant\u003e","commit_id":"013a6ddfbe9ca8888b7370c25f68f361ddee48f3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e0660a465364d37ffee98b51c267b28f4a5b81c2","unresolved":false,"context_lines":[{"line_number":1479,"context_line":"                # the host is actually a host (well, it\u0027s not an instance)"},{"line_number":1480,"context_line":"                pass"},{"line_number":1481,"context_line":"            else:"},{"line_number":1482,"context_line":"                # the host is actually an instance :("},{"line_number":1483,"context_line":"                LOG.warning(_("},{"line_number":1484,"context_line":"                    \u0027openstackclient 3.19.0 changed the behavior of the \u0027"},{"line_number":1485,"context_line":"                    \u0027--live option and it no longer takes a required \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_012563ab","line":1482,"range":{"start_line":1482,"start_character":42,"end_line":1482,"end_character":50},"updated":"2019-04-02 17:32:33.000000000","message":"server","commit_id":"013a6ddfbe9ca8888b7370c25f68f361ddee48f3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c945b8a0e08fd63361c9196e3769a87f8fdb0edf","unresolved":false,"context_lines":[{"line_number":1481,"context_line":"            else:"},{"line_number":1482,"context_line":"                # the host is actually an instance :("},{"line_number":1483,"context_line":"                LOG.warning(_("},{"line_number":1484,"context_line":"                    \u0027openstackclient 3.19.0 changed the behavior of the \u0027"},{"line_number":1485,"context_line":"                    \u0027--live option and it no longer takes a required \u0027"},{"line_number":1486,"context_line":"                    \u0027argument. If you wish to specify a destination HOST \u0027"},{"line_number":1487,"context_line":"                    \u0027then this *must* be the last argument, following \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_01032375","line":1484,"range":{"start_line":1484,"start_character":21,"end_line":1484,"end_character":43},"updated":"2019-04-02 18:01:45.000000000","message":"Do you plan on backporting this change? If so, this would need to change per backported release...\n\nIf you\u0027re not planning on backporting, then we might as well just cut bait and fix this thing with breaking interface changes in 4.0.","commit_id":"013a6ddfbe9ca8888b7370c25f68f361ddee48f3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4721e335aa49401c6ef4b0fd8eec8fd382142158","unresolved":false,"context_lines":[{"line_number":1481,"context_line":"            else:"},{"line_number":1482,"context_line":"                # the host is actually an instance :("},{"line_number":1483,"context_line":"                LOG.warning(_("},{"line_number":1484,"context_line":"                    \u0027openstackclient 3.19.0 changed the behavior of the \u0027"},{"line_number":1485,"context_line":"                    \u0027--live option and it no longer takes a required \u0027"},{"line_number":1486,"context_line":"                    \u0027argument. If you wish to specify a destination HOST \u0027"},{"line_number":1487,"context_line":"                    \u0027then this *must* be the last argument, following \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_4e770a3d","line":1484,"range":{"start_line":1484,"start_character":21,"end_line":1484,"end_character":43},"in_reply_to":"5fc1f717_01032375","updated":"2019-04-03 09:35:46.000000000","message":"Not upstream, no, because it\u0027s a pretty functional change and I\u0027m not really sure why someone would ever use an older version of OSC (it\u0027s supposed to be able to support all versions of OpenStack ever, no?) If you think backporting is a good idea though, I\u0027ll simply remove this version reference","commit_id":"013a6ddfbe9ca8888b7370c25f68f361ddee48f3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e0660a465364d37ffee98b51c267b28f4a5b81c2","unresolved":false,"context_lines":[{"line_number":1486,"context_line":"                    \u0027argument. If you wish to specify a destination HOST \u0027"},{"line_number":1487,"context_line":"                    \u0027then this *must* be the last argument, following \u0027"},{"line_number":1488,"context_line":"                    \u0027the SERVER. It looks like the HOST value provided \u0027"},{"line_number":1489,"context_line":"                    \u0027here is actually an instance so the order of HOST \u0027"},{"line_number":1490,"context_line":"                    \u0027and SERVER the two has been reversed.\u0027"},{"line_number":1491,"context_line":"                    \u0027This is legacy behavior that will be removed in OSC \u0027"},{"line_number":1492,"context_line":"                    \u00274.0.0.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_813073ea","line":1489,"range":{"start_line":1489,"start_character":41,"end_line":1489,"end_character":49},"updated":"2019-04-02 17:32:33.000000000","message":"server","commit_id":"013a6ddfbe9ca8888b7370c25f68f361ddee48f3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"db11634c8735bef4aee1631747ab6f557457433a","unresolved":false,"context_lines":[{"line_number":1504,"context_line":"                \u0027block_migration\u0027: parsed_args.block_migration"},{"line_number":1505,"context_line":"            }"},{"line_number":1506,"context_line":""},{"line_number":1507,"context_line":"            if host:"},{"line_number":1508,"context_line":"                kwargs[\u0027host\u0027] \u003d host"},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":"            if compute_client.api_version \u003c api_versions.APIVersion(\u00272.25\u0027):"},{"line_number":1511,"context_line":"                kwargs[\u0027disk_over_commit\u0027] \u003d parsed_args.disk_overcommit"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_7ea64656","line":1508,"range":{"start_line":1507,"start_character":0,"end_line":1508,"end_character":37},"updated":"2019-04-02 17:28:41.000000000","message":"I think this should be protected by an APIVersion check?","commit_id":"013a6ddfbe9ca8888b7370c25f68f361ddee48f3"}]}