)]}'
{"openstackclient/network/v2/network.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ded56cb0a315b20f1a223f5fe407d5c18046db19","unresolved":false,"context_lines":[{"line_number":74,"context_line":"def _get_attrs_network(client_manager, parsed_args):"},{"line_number":75,"context_line":"    attrs \u003d {}"},{"line_number":76,"context_line":"    if parsed_args.name is not None:"},{"line_number":77,"context_line":"        attrs[\u0027name\u0027] \u003d six.text_type(parsed_args.name)"},{"line_number":78,"context_line":"    if parsed_args.enable:"},{"line_number":79,"context_line":"        attrs[\u0027admin_state_up\u0027] \u003d True"},{"line_number":80,"context_line":"    if parsed_args.disable:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_d03c5194","line":77,"updated":"2019-02-01 17:34:35.000000000","message":"very basic question: why do we need str() or six.text_type() here?\nDoesn\u0027t \"attrs[\u0027name\u0027] \u003d parsed_args.name\" work (as we do for  \u0027description\u0027)?","commit_id":"67f194c5b8639724a189186b3c83e2a853443515"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"14dcbdf7f1cf79d0141e7f1b2e7564409c1f11fa","unresolved":false,"context_lines":[{"line_number":74,"context_line":"def _get_attrs_network(client_manager, parsed_args):"},{"line_number":75,"context_line":"    attrs \u003d {}"},{"line_number":76,"context_line":"    if parsed_args.name is not None:"},{"line_number":77,"context_line":"        attrs[\u0027name\u0027] \u003d six.text_type(parsed_args.name)"},{"line_number":78,"context_line":"    if parsed_args.enable:"},{"line_number":79,"context_line":"        attrs[\u0027admin_state_up\u0027] \u003d True"},{"line_number":80,"context_line":"    if parsed_args.disable:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_24536c6d","line":77,"in_reply_to":"9fdfeff1_d03c5194","updated":"2019-02-13 09:42:15.000000000","message":"Basic but very good question, digging through the classes it looks OK indeed to get the value directly from parsed_args.\n\nI will amend the review, thanks!","commit_id":"67f194c5b8639724a189186b3c83e2a853443515"}],"openstackclient/network/v2/port.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"01d05db28535387da1935c8286303549ed1e0752","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import json"},{"line_number":19,"context_line":"import logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import six"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from osc_lib.cli import parseractions"},{"line_number":24,"context_line":"from osc_lib.command import command"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_978cda7f","line":21,"updated":"2019-01-28 14:58:24.000000000","message":"remove this line?","commit_id":"376c2a396934b63e6842f66030d2a9194ebb6379"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"d6b143d9be44f070e9b2fcd9622f41f0bd3f2502","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import json"},{"line_number":19,"context_line":"import logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import six"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from osc_lib.cli import parseractions"},{"line_number":24,"context_line":"from osc_lib.command import command"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_d772627b","line":21,"in_reply_to":"9fdfeff1_978cda7f","updated":"2019-01-28 15:04:55.000000000","message":"My bad, I did not save the last change before review, there is a str() call here too","commit_id":"376c2a396934b63e6842f66030d2a9194ebb6379"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"d6b143d9be44f070e9b2fcd9622f41f0bd3f2502","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        attrs[\u0027dns_name\u0027] \u003d parsed_args.dns_name"},{"line_number":137,"context_line":"    # It is possible that name is not updated during \u0027port set\u0027"},{"line_number":138,"context_line":"    if parsed_args.name is not None:"},{"line_number":139,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":140,"context_line":"    # The remaining options do not support \u0027port set\u0027 command, so they require"},{"line_number":141,"context_line":"    # additional check"},{"line_number":142,"context_line":"    if \u0027network\u0027 in parsed_args and parsed_args.network is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_775296e0","line":139,"updated":"2019-01-28 15:04:55.000000000","message":"\"openstack port create test™ --network private\" was actually the original command I wanted to get working","commit_id":"376c2a396934b63e6842f66030d2a9194ebb6379"}]}