)]}'
{"openstackclient/image/v2/image.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b8ba0582376ea4c3d8a52f8468285e45917da9d1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"DEFAULT_DISK_FORMAT \u003d \u0027raw\u0027"},{"line_number":38,"context_line":"DISK_CHOICES \u003d [\"ami\", \"ari\", \"aki\", \"vhd\", \"vmdk\", \"raw\", \"qcow2\", \"vhdx\","},{"line_number":39,"context_line":"                \"vdi\", \"iso\", \"ploop\"]"},{"line_number":40,"context_line":"MEMBER_STATUS_CHOISES \u003d [\"accepted\", \"pending\", \"rejected\", \"all\"]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_c7ed59f1","line":40,"updated":"2019-02-19 04:30:09.000000000","message":"minor nit: \"CHOICES\", not \"CHOISES\"","commit_id":"fcc465332c3debafdf7cb84bc211c5564ed5b0c8"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"9eebfcb893a420bd85fa050fa936475faf0302e5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"DEFAULT_DISK_FORMAT \u003d \u0027raw\u0027"},{"line_number":38,"context_line":"DISK_CHOICES \u003d [\"ami\", \"ari\", \"aki\", \"vhd\", \"vmdk\", \"raw\", \"qcow2\", \"vhdx\","},{"line_number":39,"context_line":"                \"vdi\", \"iso\", \"ploop\"]"},{"line_number":40,"context_line":"MEMBER_STATUS_CHOISES \u003d [\"accepted\", \"pending\", \"rejected\", \"all\"]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_c44f9268","line":40,"in_reply_to":"9fdfeff1_c7ed59f1","updated":"2019-02-19 08:55:31.000000000","message":"totally right. A dummy typo","commit_id":"fcc465332c3debafdf7cb84bc211c5564ed5b0c8"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b8ba0582376ea4c3d8a52f8468285e45917da9d1","unresolved":false,"context_lines":[{"line_number":535,"context_line":"            \u0027--member_status\u0027,"},{"line_number":536,"context_line":"            metavar\u003d\u0027\u003cmember_status\u003e\u0027,"},{"line_number":537,"context_line":"            default\u003dNone,"},{"line_number":538,"context_line":"            type\u003dlambda s: s.lower(),"},{"line_number":539,"context_line":"            choices\u003dMEMBER_STATUS_CHOISES,"},{"line_number":540,"context_line":"            help\u003d(_(\"Filter images based on member status. \""},{"line_number":541,"context_line":"                    \"The supported options are: %s. \") %"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_07cda185","line":538,"updated":"2019-02-19 04:30:09.000000000","message":"What\u0027s the point of this? I think type defaults to string, which is what the choices are.","commit_id":"fcc465332c3debafdf7cb84bc211c5564ed5b0c8"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"9eebfcb893a420bd85fa050fa936475faf0302e5","unresolved":false,"context_lines":[{"line_number":535,"context_line":"            \u0027--member_status\u0027,"},{"line_number":536,"context_line":"            metavar\u003d\u0027\u003cmember_status\u003e\u0027,"},{"line_number":537,"context_line":"            default\u003dNone,"},{"line_number":538,"context_line":"            type\u003dlambda s: s.lower(),"},{"line_number":539,"context_line":"            choices\u003dMEMBER_STATUS_CHOISES,"},{"line_number":540,"context_line":"            help\u003d(_(\"Filter images based on member status. \""},{"line_number":541,"context_line":"                    \"The supported options are: %s. \") %"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_24953e89","line":538,"in_reply_to":"9fdfeff1_07cda185","updated":"2019-02-19 08:55:31.000000000","message":"This gives a very nice possibility to get force transform values from input. It is very handy, when your processing is case-sensitive, but you don\u0027t want to make reading values from users more complex, while still staying user-friendly (user inputs \"All\", but you still get \"all\"). I do not remember where I have seen it first time, but liked it so much.","commit_id":"fcc465332c3debafdf7cb84bc211c5564ed5b0c8"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e1eda7a99f4e2aa6bca7670c385c332817b44977","unresolved":false,"context_lines":[{"line_number":535,"context_line":"            \u0027--member_status\u0027,"},{"line_number":536,"context_line":"            metavar\u003d\u0027\u003cmember_status\u003e\u0027,"},{"line_number":537,"context_line":"            default\u003dNone,"},{"line_number":538,"context_line":"            type\u003dlambda s: s.lower(),"},{"line_number":539,"context_line":"            choices\u003dMEMBER_STATUS_CHOISES,"},{"line_number":540,"context_line":"            help\u003d(_(\"Filter images based on member status. \""},{"line_number":541,"context_line":"                    \"The supported options are: %s. \") %"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_f68cc4d8","line":538,"in_reply_to":"9fdfeff1_24953e89","updated":"2019-02-19 14:16:59.000000000","message":"ah, cool!","commit_id":"fcc465332c3debafdf7cb84bc211c5564ed5b0c8"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b8ba0582376ea4c3d8a52f8468285e45917da9d1","unresolved":false,"context_lines":[{"line_number":536,"context_line":"            metavar\u003d\u0027\u003cmember_status\u003e\u0027,"},{"line_number":537,"context_line":"            default\u003dNone,"},{"line_number":538,"context_line":"            type\u003dlambda s: s.lower(),"},{"line_number":539,"context_line":"            choices\u003dMEMBER_STATUS_CHOISES,"},{"line_number":540,"context_line":"            help\u003d(_(\"Filter images based on member status. \""},{"line_number":541,"context_line":"                    \"The supported options are: %s. \") %"},{"line_number":542,"context_line":"                  \u0027, \u0027.join(MEMBER_STATUS_CHOISES))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_87b991ed","line":539,"updated":"2019-02-19 04:30:09.000000000","message":"same here: CHOICES","commit_id":"fcc465332c3debafdf7cb84bc211c5564ed5b0c8"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"9eebfcb893a420bd85fa050fa936475faf0302e5","unresolved":false,"context_lines":[{"line_number":536,"context_line":"            metavar\u003d\u0027\u003cmember_status\u003e\u0027,"},{"line_number":537,"context_line":"            default\u003dNone,"},{"line_number":538,"context_line":"            type\u003dlambda s: s.lower(),"},{"line_number":539,"context_line":"            choices\u003dMEMBER_STATUS_CHOISES,"},{"line_number":540,"context_line":"            help\u003d(_(\"Filter images based on member status. \""},{"line_number":541,"context_line":"                    \"The supported options are: %s. \") %"},{"line_number":542,"context_line":"                  \u0027, \u0027.join(MEMBER_STATUS_CHOISES))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_048cba7d","line":539,"in_reply_to":"9fdfeff1_87b991ed","updated":"2019-02-19 08:55:31.000000000","message":"Done","commit_id":"fcc465332c3debafdf7cb84bc211c5564ed5b0c8"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"c67ff8c171dc782fc3a5c7c9832d4740ca9eb72f","unresolved":false,"context_lines":[{"line_number":532,"context_line":"            help\u003d_(\"Filter images based on status.\")"},{"line_number":533,"context_line":"        )"},{"line_number":534,"context_line":"        parser.add_argument("},{"line_number":535,"context_line":"            \u0027--member_status\u0027,"},{"line_number":536,"context_line":"            metavar\u003d\u0027\u003cmember_status\u003e\u0027,"},{"line_number":537,"context_line":"            default\u003dNone,"},{"line_number":538,"context_line":"            type\u003dlambda s: s.lower(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_3462cc3f","line":535,"range":{"start_line":535,"start_character":15,"end_line":535,"end_character":28},"updated":"2019-02-25 22:38:05.000000000","message":"This should be --member-status (dash, not underscore)","commit_id":"a7552a06faee4b974929bdfbf1d21d8e7878356d"}],"openstackclient/tests/unit/image/v2/test_image.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"c67ff8c171dc782fc3a5c7c9832d4740ca9eb72f","unresolved":false,"context_lines":[{"line_number":644,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":645,"context_line":"        self.assertEqual(self.datalist, tuple(data))"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"    def test_image_list_shared_member_status_option(self):"},{"line_number":648,"context_line":"        arglist \u003d ["},{"line_number":649,"context_line":"            \u0027--shared\u0027,"},{"line_number":650,"context_line":"            \u0027--member_status\u0027, \u0027all\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_948b78be","line":647,"updated":"2019-02-25 22:38:05.000000000","message":"I would like to see a test of the lower() function in the --member-status argparse config.  It is novel, but should have something to ensure it doesn\u0027t break","commit_id":"a7552a06faee4b974929bdfbf1d21d8e7878356d"}],"releasenotes/notes/add-member-status-filter-2e118b2c93151223.yaml":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"c67ff8c171dc782fc3a5c7c9832d4740ca9eb72f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add member_status filter to image-list to show membership requests."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_74e05498","line":3,"updated":"2019-02-25 22:38:05.000000000","message":"Add ``--member-status`` option to ``image list`` command","commit_id":"a7552a06faee4b974929bdfbf1d21d8e7878356d"}]}