)]}'
{"id":"openstack%2Fpython-openstackclient~638495","triplet_id":"openstack%2Fpython-openstackclient~master~I71407a7982aff0cc072a4fcf23049b4628769ba4","project":"openstack/python-openstackclient","branch":"master","topic":"only-use-project-id-when-image-add-project","hashtags":[],"change_id":"I71407a7982aff0cc072a4fcf23049b4628769ba4","subject":"Only allow project ID in \u0027image add project\u0027","status":"ABANDONED","created":"2019-02-21 19:34:51.000000000","updated":"2022-03-09 17:49:07.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1213db6cb86fd26f30004aa26bc08d6d1eae26be","_number":638495,"virtual_id_number":638495,"owner":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2019-02-28 12:15:31.000000000","_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},{"date":"2019-02-27 19:57:29.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2019-02-22 17:18:35.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-02-22 17:18:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-02-27 19:57:29.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"}],"messages":[{"id":"17267928cee85c72add1813f0796293c2622097f","author":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"date":"2019-02-21 19:34:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ff48e1019237c669aaff24bcfdfdd57aac871e66","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-21 21:40:18.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstackclient-check-plugins http://logs.openstack.org/95/638495/1/check/openstackclient-check-plugins/dc205b8/ : SUCCESS in 7m 24s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/95/638495/1/check/osc-tox-py27-tips/23e3092/ : FAILURE in 7m 40s\n- osc-tox-py35-tips http://logs.openstack.org/95/638495/1/check/osc-tox-py35-tips/03a472c/ : FAILURE in 6m 48s\n- openstack-tox-cover http://logs.openstack.org/95/638495/1/check/openstack-tox-cover/ef3ca09/ : FAILURE in 6m 43s\n- openstack-tox-lower-constraints http://logs.openstack.org/95/638495/1/check/openstack-tox-lower-constraints/6c297d9/ : FAILURE in 8m 24s\n- openstack-tox-pep8 http://logs.openstack.org/95/638495/1/check/openstack-tox-pep8/bcbe5d8/ : FAILURE in 5m 46s\n- openstack-tox-py27 http://logs.openstack.org/95/638495/1/check/openstack-tox-py27/c01670a/ : FAILURE in 6m 03s\n- openstack-tox-py35 http://logs.openstack.org/95/638495/1/check/openstack-tox-py35/1beb288/ : FAILURE in 5m 55s\n- openstack-tox-py36 http://logs.openstack.org/95/638495/1/check/openstack-tox-py36/66c3d1d/ : FAILURE in 7m 02s\n- openstack-tox-docs http://logs.openstack.org/95/638495/1/check/openstack-tox-docs/3799816/html/ : SUCCESS in 6m 03s\n- tempest-full http://logs.openstack.org/95/638495/1/check/tempest-full/9b1d6da/ : SUCCESS in 1h 39m 55s\n- tempest-full-py3 http://logs.openstack.org/95/638495/1/check/tempest-full-py3/7501c0e/ : SUCCESS in 1h 48m 36s\n- osc-functional-devstack http://logs.openstack.org/95/638495/1/check/osc-functional-devstack/7c84591/ : SUCCESS in 45m 44s\n- osc-functional-devstack-tips http://logs.openstack.org/95/638495/1/check/osc-functional-devstack-tips/3a0a657/ : SUCCESS in 46m 42s","accounts_in_message":[],"_revision_number":1},{"id":"7bc768b16f41103a40e6aff1ad711268cbfd4cca","author":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"date":"2019-02-22 07:02:18.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"abd471c0a42f06daa6c5d231377bcc8b5936e4d2","author":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"date":"2019-02-22 11:09:29.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"891e4df18374ca26a29dddc8d77fa467f653cc80","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-22 13:23:38.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstackclient-check-plugins http://logs.openstack.org/95/638495/2/check/openstackclient-check-plugins/a05baf0/ : SUCCESS in 6m 00s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/95/638495/2/check/osc-tox-py27-tips/effb16c/ : FAILURE in 5m 58s\n- osc-tox-py35-tips http://logs.openstack.org/95/638495/2/check/osc-tox-py35-tips/93403c3/ : FAILURE in 7m 09s\n- openstack-tox-cover http://logs.openstack.org/95/638495/2/check/openstack-tox-cover/c788e46/ : FAILURE in 4m 45s\n- openstack-tox-lower-constraints http://logs.openstack.org/95/638495/2/check/openstack-tox-lower-constraints/a064b7a/ : FAILURE in 5m 21s\n- openstack-tox-pep8 http://logs.openstack.org/95/638495/2/check/openstack-tox-pep8/79fbf17/ : SUCCESS in 5m 23s\n- openstack-tox-py27 http://logs.openstack.org/95/638495/2/check/openstack-tox-py27/f2b8e96/ : FAILURE in 5m 05s\n- openstack-tox-py35 http://logs.openstack.org/95/638495/2/check/openstack-tox-py35/d7296c2/ : FAILURE in 7m 27s\n- openstack-tox-py36 http://logs.openstack.org/95/638495/2/check/openstack-tox-py36/78d3813/ : FAILURE in 4m 55s\n- openstack-tox-docs http://logs.openstack.org/95/638495/2/check/openstack-tox-docs/1d889c5/html/ : SUCCESS in 6m 10s\n- tempest-full http://logs.openstack.org/95/638495/2/check/tempest-full/f4dcb3a/ : SUCCESS in 2h 00m 49s\n- tempest-full-py3 http://logs.openstack.org/95/638495/2/check/tempest-full-py3/d983f0c/ : TIMED_OUT in 2h 04m 33s\n- osc-functional-devstack http://logs.openstack.org/95/638495/2/check/osc-functional-devstack/b43004d/ : SUCCESS in 48m 03s\n- osc-functional-devstack-tips http://logs.openstack.org/95/638495/2/check/osc-functional-devstack-tips/5c81120/ : SUCCESS in 43m 06s","accounts_in_message":[],"_revision_number":2},{"id":"b3273885cd76b6a2b97cf8632c3a0807367b8a61","author":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"date":"2019-02-22 15:22:35.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"d488de10a462db3dd36a0b2e763ac2b65d92223b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-22 17:18:35.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins http://logs.openstack.org/95/638495/3/check/openstackclient-check-plugins/d49fbd7/ : SUCCESS in 6m 03s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/95/638495/3/check/osc-tox-py27-tips/4192c98/ : SUCCESS in 6m 31s\n- osc-tox-py35-tips http://logs.openstack.org/95/638495/3/check/osc-tox-py35-tips/97343eb/ : SUCCESS in 7m 02s\n- openstack-tox-cover http://logs.openstack.org/95/638495/3/check/openstack-tox-cover/9f370fc/cover/ : SUCCESS in 6m 48s\n- openstack-tox-lower-constraints http://logs.openstack.org/95/638495/3/check/openstack-tox-lower-constraints/8078ad5/ : SUCCESS in 5m 49s\n- openstack-tox-pep8 http://logs.openstack.org/95/638495/3/check/openstack-tox-pep8/92a7ab7/ : SUCCESS in 5m 34s\n- openstack-tox-py27 http://logs.openstack.org/95/638495/3/check/openstack-tox-py27/621555d/ : SUCCESS in 5m 10s\n- openstack-tox-py35 http://logs.openstack.org/95/638495/3/check/openstack-tox-py35/3054ff6/ : SUCCESS in 6m 12s\n- openstack-tox-py36 http://logs.openstack.org/95/638495/3/check/openstack-tox-py36/e85483e/ : SUCCESS in 6m 31s\n- openstack-tox-docs http://logs.openstack.org/95/638495/3/check/openstack-tox-docs/f0fab0c/html/ : SUCCESS in 5m 42s\n- tempest-full http://logs.openstack.org/95/638495/3/check/tempest-full/e56a63f/ : SUCCESS in 1h 48m 53s\n- tempest-full-py3 http://logs.openstack.org/95/638495/3/check/tempest-full-py3/5825751/ : SUCCESS in 1h 24m 32s\n- osc-functional-devstack http://logs.openstack.org/95/638495/3/check/osc-functional-devstack/2d1ab9a/ : SUCCESS in 45m 29s\n- osc-functional-devstack-tips http://logs.openstack.org/95/638495/3/check/osc-functional-devstack-tips/6fda3dd/ : SUCCESS in 47m 13s","accounts_in_message":[],"_revision_number":3},{"id":"0d3590c80616c9260e6724e61e46329c2d7b709e","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-02-27 19:57:29.000000000","message":"Patch Set 3:\n\nI would much rather detect the failure than remove the capability.  Especially for admins, there is a non-zero chance that this will break currently-working scripts.  If it goes ahead it must wait until osc4 for a breaking change.","accounts_in_message":[],"_revision_number":3},{"id":"87015778dcee9a22c92a84a087532629da3947b7","author":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"date":"2019-02-28 12:15:31.000000000","message":"Patch Set 3:\n\n\u003e I would much rather detect the failure than remove the capability. \n \u003e Especially for admins, there is a non-zero chance that this will\n \u003e break currently-working scripts.  If it goes ahead it must wait\n \u003e until osc4 for a breaking change.\n\nYou are right.\nDo you know a way to verify if common.find_project() actually found a project or just returned a dummy object? Because that\u0027s the crucial part I think.","accounts_in_message":[],"_revision_number":3},{"id":"1213db6cb86fd26f30004aa26bc08d6d1eae26be","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-03-09 17:49:07.000000000","message":"Abandoned\n\nThis wasn\u0027t the solution and is clearly dead","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"86d18a79e7132382847f3b4918f3078f2a4e32f7","revisions":{"f2b69540ac75c2f0621cffb6b19b7dbf93c00813":{"kind":"REWORK","_number":1,"created":"2019-02-21 19:34:51.000000000","uploader":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"ref":"refs/changes/95/638495/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/95/638495/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/95/638495/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/95/638495/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/95/638495/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/95/638495/1"}}},"commit":{"parents":[{"commit":"55cbbbe4692002e58120b0c129eb2add4f0bc18a","subject":"Fix help message of image add project","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/55cbbbe4692002e58120b0c129eb2add4f0bc18a"}]}],"author":{"name":"David Rabel","email":"rabel@b1-systems.de","date":"2019-02-21 19:29:57.000000000","tz":60},"committer":{"name":"David Rabel","email":"rabel@b1-systems.de","date":"2019-02-21 19:29:57.000000000","tz":60},"subject":"Only allow project ID in \u0027image add project\u0027","message":"Only allow project ID in \u0027image add project\u0027\n\nOnly admin users could use the project name instead of project ID and\nfor non-admins we have no way of checking if the project does exist.\n\nThe current situation is therefore somewhat misleading: Admins can\nuse the project name. If a non-admin uses the project name, it will\nfail, but there is no error nor warning.\n\nThis patch unifies the behaviour of image add project by removing the\noption to use the project name entirely.\n\nThe help message has already been changed accordingly:\nhttps://review.openstack.org/#/c/637828/\nhttps://review.openstack.org/#/c/638113/\n\nChange-Id: I71407a7982aff0cc072a4fcf23049b4628769ba4\nTask: 22081\nStory: 2002535\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f2b69540ac75c2f0621cffb6b19b7dbf93c00813"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f2b69540ac75c2f0621cffb6b19b7dbf93c00813"}]},"branch":"refs/heads/master"},"a165feadabb86f60fa5c96790965f316a9936a50":{"kind":"REWORK","_number":2,"created":"2019-02-22 11:09:29.000000000","uploader":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"ref":"refs/changes/95/638495/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/95/638495/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/95/638495/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/95/638495/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/95/638495/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/95/638495/2"}}},"commit":{"parents":[{"commit":"55cbbbe4692002e58120b0c129eb2add4f0bc18a","subject":"Fix help message of image add project","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/55cbbbe4692002e58120b0c129eb2add4f0bc18a"}]}],"author":{"name":"David Rabel","email":"rabel@b1-systems.de","date":"2019-02-21 19:29:57.000000000","tz":60},"committer":{"name":"David Rabel","email":"rabel@b1-systems.de","date":"2019-02-22 11:09:17.000000000","tz":60},"subject":"Only allow project ID in \u0027image add project\u0027","message":"Only allow project ID in \u0027image add project\u0027\n\nOnly admin users could use the project name instead of project ID and\nfor non-admins we have no way of checking if the project does exist.\n\nThe current situation is therefore somewhat misleading: Admins can\nuse the project name. If a non-admin uses the project name, it will\nfail, but there is no error nor warning.\n\nThis patch unifies the behaviour of image add project by removing the\noption to use the project name entirely.\n\nThe help message has already been changed accordingly:\nhttps://review.openstack.org/#/c/637828/\nhttps://review.openstack.org/#/c/638113/\n\nChange-Id: I71407a7982aff0cc072a4fcf23049b4628769ba4\nTask: 22081\nStory: 2002535\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a165feadabb86f60fa5c96790965f316a9936a50"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a165feadabb86f60fa5c96790965f316a9936a50"}]},"branch":"refs/heads/master"},"86d18a79e7132382847f3b4918f3078f2a4e32f7":{"kind":"REWORK","_number":3,"created":"2019-02-22 15:22:35.000000000","uploader":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"ref":"refs/changes/95/638495/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/95/638495/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/95/638495/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/95/638495/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/95/638495/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/95/638495/3"}}},"commit":{"parents":[{"commit":"55cbbbe4692002e58120b0c129eb2add4f0bc18a","subject":"Fix help message of image add project","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/55cbbbe4692002e58120b0c129eb2add4f0bc18a"}]}],"author":{"name":"David Rabel","email":"rabel@b1-systems.de","date":"2019-02-21 19:29:57.000000000","tz":60},"committer":{"name":"David Rabel","email":"rabel@b1-systems.de","date":"2019-02-22 15:09:52.000000000","tz":60},"subject":"Only allow project ID in \u0027image add project\u0027","message":"Only allow project ID in \u0027image add project\u0027\n\nOnly admin users could use the project name instead of project ID and\nfor non-admins we have no way of checking if the project does exist.\n\nThe current situation is therefore somewhat misleading: Admins can\nuse the project name. If a non-admin uses the project name, it will\nfail, but there is no error nor warning.\n\nThis patch unifies the behaviour of image add project by removing the\noption to use the project name entirely.\n\nThe help message has already been changed accordingly:\nhttps://review.openstack.org/#/c/637828/\nhttps://review.openstack.org/#/c/638113/\n\nChange-Id: I71407a7982aff0cc072a4fcf23049b4628769ba4\nTask: 22081\nStory: 2002535\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/86d18a79e7132382847f3b4918f3078f2a4e32f7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/86d18a79e7132382847f3b4918f3078f2a4e32f7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}