)]}'
{"openstackclient/volume/v2/volume.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"513b2abdcb5edb6c4294a7a0900f0111a654dbe8","unresolved":false,"context_lines":[{"line_number":560,"context_line":"                   \u0027exercise caution when using)\u0027),"},{"line_number":561,"context_line":"        )"},{"line_number":562,"context_line":"        parser.add_argument("},{"line_number":563,"context_line":"            \"--attach-status\","},{"line_number":564,"context_line":"            metavar\u003d\"\u003cattach-status\u003e\","},{"line_number":565,"context_line":"            choices\u003d[\u0027attached\u0027, \u0027detached\u0027],"},{"line_number":566,"context_line":"            help\u003d_(\u0027New volume attachment status (\"attached\" or \"detached\") \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_d190fc50","line":563,"range":{"start_line":563,"start_character":0,"end_line":563,"end_character":30},"updated":"2019-02-27 20:02:50.000000000","message":"I\u0027d really prefer two options --attached and --detached to set this, OSC uses this this form when it can (ie, --enable|--disable rather than --status enable|disable).\n\nAlso, I prefer active tense but that may not make sense in this case (--attach rather than --attached) since it is just setting a db status and not actually performing an action.  I\u0027ll go with either choice for this.","commit_id":"e77da280956bdb0b513e005ad7d05a2944e3aa33"},{"author":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"change_message_id":"30459afca8073969dcef5360b9546adf601296a2","unresolved":false,"context_lines":[{"line_number":560,"context_line":"                   \u0027exercise caution when using)\u0027),"},{"line_number":561,"context_line":"        )"},{"line_number":562,"context_line":"        parser.add_argument("},{"line_number":563,"context_line":"            \"--attach-status\","},{"line_number":564,"context_line":"            metavar\u003d\"\u003cattach-status\u003e\","},{"line_number":565,"context_line":"            choices\u003d[\u0027attached\u0027, \u0027detached\u0027],"},{"line_number":566,"context_line":"            help\u003d_(\u0027New volume attachment status (\"attached\" or \"detached\") \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_12c8b31f","line":563,"range":{"start_line":563,"start_character":0,"end_line":563,"end_character":30},"in_reply_to":"9fdfeff1_d190fc50","updated":"2019-02-28 12:11:56.000000000","message":"Done","commit_id":"e77da280956bdb0b513e005ad7d05a2944e3aa33"}]}
