)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"88a1fd4316c3de487caf16ac147b8e6401061095","unresolved":false,"context_lines":[{"line_number":14,"context_line":"the issues that popped up when re-enabling tests."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Network segment range:"},{"line_number":17,"context_line":" - issue where we assert that a deleted network segment is still present"},{"line_number":18,"context_line":" - issue where we pass \u0027None\u0027 for the optional project id during create"},{"line_number":19,"context_line":"   of a non-shared network segment range if it is not present"},{"line_number":20,"context_line":" - issue where we assumed network-segment-range extension is always"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5fc1f717_770f0037","line":17,"range":{"start_line":17,"start_character":3,"end_line":17,"end_character":72},"updated":"2019-03-12 13:43:38.000000000","message":"addCleanup [1] won\u0027t delete the created range immediately. So there is no problem w/ the assertIn of list operation. The root cause is the typo of \"network segment list -f json\", which should be \"network segment range list -f json\".\n[1] https://review.openstack.org/#/c/642074/6..8/openstackclient/tests/functional/network/v2/test_network_segment_range.py@78","commit_id":"45fba49d919046cc97663568a33812697b206ac9"},{"author":{"_account_id":30081,"name":"Glenn Van de Water","email":"glenn.van_de_water@nuagenetworks.net","username":"glennvdw"},"change_message_id":"6b62d7f24b7fc1744d6c04992f0645c7e9077ca7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"the issues that popped up when re-enabling tests."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Network segment range:"},{"line_number":17,"context_line":" - issue where we assert that a deleted network segment is still present"},{"line_number":18,"context_line":" - issue where we pass \u0027None\u0027 for the optional project id during create"},{"line_number":19,"context_line":"   of a non-shared network segment range if it is not present"},{"line_number":20,"context_line":" - issue where we assumed network-segment-range extension is always"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5fc1f717_1ff00efe","line":17,"range":{"start_line":17,"start_character":3,"end_line":17,"end_character":72},"in_reply_to":"5fc1f717_770f0037","updated":"2019-03-12 16:32:46.000000000","message":"Done","commit_id":"45fba49d919046cc97663568a33812697b206ac9"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"88a1fd4316c3de487caf16ac147b8e6401061095","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Network segment range:"},{"line_number":17,"context_line":" - issue where we assert that a deleted network segment is still present"},{"line_number":18,"context_line":" - issue where we pass \u0027None\u0027 for the optional project id during create"},{"line_number":19,"context_line":"   of a non-shared network segment range if it is not present"},{"line_number":20,"context_line":" - issue where we assumed network-segment-range extension is always"},{"line_number":21,"context_line":"   present"},{"line_number":22,"context_line":" - issue where we compare integers and string representations of numbers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5fc1f717_9775cccd","line":19,"range":{"start_line":18,"start_character":3,"end_line":19,"end_character":61},"updated":"2019-03-12 13:43:38.000000000","message":"This is not accurate. the issue that https://review.openstack.org/#/c/642707/ addresses, is that we should not pass \u0027None\u0027 as attr for the \"shared\" ranges. Though indeed they do not have project_ids since they\u0027re shared, but the cause is that the API doesn\u0027t accept string type as \"project_id\" input. So either we do not populate \"project_id\" for shared or we go w/ empty string \"\".","commit_id":"45fba49d919046cc97663568a33812697b206ac9"},{"author":{"_account_id":30081,"name":"Glenn Van de Water","email":"glenn.van_de_water@nuagenetworks.net","username":"glennvdw"},"change_message_id":"6b62d7f24b7fc1744d6c04992f0645c7e9077ca7","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Network segment range:"},{"line_number":17,"context_line":" - issue where we assert that a deleted network segment is still present"},{"line_number":18,"context_line":" - issue where we pass \u0027None\u0027 for the optional project id during create"},{"line_number":19,"context_line":"   of a non-shared network segment range if it is not present"},{"line_number":20,"context_line":" - issue where we assumed network-segment-range extension is always"},{"line_number":21,"context_line":"   present"},{"line_number":22,"context_line":" - issue where we compare integers and string representations of numbers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5fc1f717_bff0dafe","line":19,"range":{"start_line":18,"start_character":3,"end_line":19,"end_character":61},"in_reply_to":"5fc1f717_9775cccd","updated":"2019-03-12 16:32:46.000000000","message":"Done","commit_id":"45fba49d919046cc97663568a33812697b206ac9"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"41be23b67bf28725bb43ecf4c65399272a69a1ee","unresolved":false,"context_lines":[{"line_number":22,"context_line":" - issue where we try to deepcopy an uncopyable object in UnsetSubnet"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Id3cc907c1ed2a25b49cf6f4a7233e0401a02383a"},{"line_number":25,"context_line":"Depends-On: Ia2bab12e39b4bb7e05ff2acfffb851252c100651"},{"line_number":26,"context_line":"Story: 2005169"},{"line_number":27,"context_line":"Task: 29908"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5fc1f717_e5fd686e","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":53},"updated":"2019-03-13 01:21:38.000000000","message":"Glenn, I suppose the \"Depends-On\" won\u0027t work inside one same project. It\u0027s used for cross-project dependencies.\nThe way to handle this might be to rebase this patch on top of [1]. And in this way you can then remove changes in [2] and leverage the ones in that dependency.\nI am not certain. I\u0027ll let Dean to comment.\n\n[1] https://review.openstack.org/#/c/642707/\n[2] https://review.openstack.org/#/c/642074/9/openstackclient/network/v2/network_segment_range.py","commit_id":"6b8e888dc767633148a26b72bcac68d5c502508e"}],"openstackclient/network/v2/network_segment_range.py":[{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"6dcae0b5626d3b97dea11605a778e01575110747","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            # is not specified."},{"line_number":208,"context_line":"            # Get the project id from the current auth."},{"line_number":209,"context_line":"            attrs[\u0027project_id\u0027] \u003d self.app.client_manager.auth_ref.project_id"},{"line_number":210,"context_line":"        else:"},{"line_number":211,"context_line":"            attrs[\u0027project_id\u0027] \u003d None"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        if parsed_args.physical_network:"},{"line_number":214,"context_line":"            attrs[\u0027physical_network\u0027] \u003d parsed_args.physical_network"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_b2a256fb","side":"PARENT","line":211,"range":{"start_line":210,"start_character":0,"end_line":211,"end_character":38},"updated":"2019-03-12 13:48:11.000000000","message":"Personally, I prefer this LOC go w/ https://review.openstack.org/#/c/642707/ as this can be covered at a unit test level and can be easily tracked.","commit_id":"c36e75d9868ed4a7a9eb80c080d2b9c9232f76bd"},{"author":{"_account_id":30081,"name":"Glenn Van de Water","email":"glenn.van_de_water@nuagenetworks.net","username":"glennvdw"},"change_message_id":"6b62d7f24b7fc1744d6c04992f0645c7e9077ca7","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            # is not specified."},{"line_number":208,"context_line":"            # Get the project id from the current auth."},{"line_number":209,"context_line":"            attrs[\u0027project_id\u0027] \u003d self.app.client_manager.auth_ref.project_id"},{"line_number":210,"context_line":"        else:"},{"line_number":211,"context_line":"            attrs[\u0027project_id\u0027] \u003d None"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        if parsed_args.physical_network:"},{"line_number":214,"context_line":"            attrs[\u0027physical_network\u0027] \u003d parsed_args.physical_network"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_7f235257","side":"PARENT","line":211,"range":{"start_line":210,"start_character":0,"end_line":211,"end_character":38},"in_reply_to":"5fc1f717_b2a256fb","updated":"2019-03-12 16:32:46.000000000","message":"I completely agree. I added a dependency on your patchset.","commit_id":"c36e75d9868ed4a7a9eb80c080d2b9c9232f76bd"}],"openstackclient/tests/functional/network/v2/test_network_segment_range.py":[{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"88a1fd4316c3de487caf16ac147b8e6401061095","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        json_output \u003d json.loads(self.openstack("},{"line_number":88,"context_line":"            \u0027network segment list -f json\u0027"},{"line_number":89,"context_line":"        ))"},{"line_number":90,"context_line":"        item_map \u003d {"},{"line_number":91,"context_line":"            item.get(\u0027ID\u0027): item.get(\u0027Name\u0027) for item in json_output"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_179c7c0d","line":88,"range":{"start_line":88,"start_character":21,"end_line":88,"end_character":28},"updated":"2019-03-12 13:43:38.000000000","message":"should be \"segment range\" here. my bad.","commit_id":"45fba49d919046cc97663568a33812697b206ac9"},{"author":{"_account_id":30081,"name":"Glenn Van de Water","email":"glenn.van_de_water@nuagenetworks.net","username":"glennvdw"},"change_message_id":"6b62d7f24b7fc1744d6c04992f0645c7e9077ca7","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        json_output \u003d json.loads(self.openstack("},{"line_number":88,"context_line":"            \u0027network segment list -f json\u0027"},{"line_number":89,"context_line":"        ))"},{"line_number":90,"context_line":"        item_map \u003d {"},{"line_number":91,"context_line":"            item.get(\u0027ID\u0027): item.get(\u0027Name\u0027) for item in json_output"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_5f177646","line":88,"range":{"start_line":88,"start_character":21,"end_line":88,"end_character":28},"in_reply_to":"5fc1f717_179c7c0d","updated":"2019-03-12 16:32:46.000000000","message":"Done","commit_id":"45fba49d919046cc97663568a33812697b206ac9"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"88a1fd4316c3de487caf16ac147b8e6401061095","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        item_map \u003d {"},{"line_number":91,"context_line":"            item.get(\u0027ID\u0027): item.get(\u0027Name\u0027) for item in json_output"},{"line_number":92,"context_line":"        }"},{"line_number":93,"context_line":"        self.assertNotIn(network_segment_range_id, item_map.keys())"},{"line_number":94,"context_line":"        self.assertNotIn(network_segment_range_name, item_map.values())"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_network_segment_range_set_show(self):"},{"line_number":97,"context_line":"        project_id \u003d json.loads(self.openstack("}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_9702ac3c","line":94,"range":{"start_line":93,"start_character":0,"end_line":94,"end_character":71},"updated":"2019-03-12 13:43:38.000000000","message":"It\u0027s not the root cause. Please kindly see my comment above.","commit_id":"45fba49d919046cc97663568a33812697b206ac9"},{"author":{"_account_id":30081,"name":"Glenn Van de Water","email":"glenn.van_de_water@nuagenetworks.net","username":"glennvdw"},"change_message_id":"6b62d7f24b7fc1744d6c04992f0645c7e9077ca7","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        item_map \u003d {"},{"line_number":91,"context_line":"            item.get(\u0027ID\u0027): item.get(\u0027Name\u0027) for item in json_output"},{"line_number":92,"context_line":"        }"},{"line_number":93,"context_line":"        self.assertNotIn(network_segment_range_id, item_map.keys())"},{"line_number":94,"context_line":"        self.assertNotIn(network_segment_range_name, item_map.values())"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_network_segment_range_set_show(self):"},{"line_number":97,"context_line":"        project_id \u003d json.loads(self.openstack("}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_3f1aaa6e","line":94,"range":{"start_line":93,"start_character":0,"end_line":94,"end_character":71},"in_reply_to":"5fc1f717_9702ac3c","updated":"2019-03-12 16:32:46.000000000","message":"Done","commit_id":"45fba49d919046cc97663568a33812697b206ac9"}]}