)]}'
{"openstackclient/network/v2/network_segment_range.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"dce4e88582d03d86360456b54ea69299cc47faa4","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        attrs \u003d {}"},{"line_number":182,"context_line":"        if parsed_args.shared or parsed_args.private:"},{"line_number":183,"context_line":"            attrs[\u0027shared\u0027] \u003d parsed_args.shared"},{"line_number":184,"context_line":"        else:"},{"line_number":185,"context_line":"            # default to be ``shared`` if not specified"},{"line_number":186,"context_line":"            attrs[\u0027shared\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_777dad7d","line":183,"range":{"start_line":182,"start_character":8,"end_line":183,"end_character":48},"updated":"2019-03-13 06:20:58.000000000","message":"(This is unrelated to this fix)\n\nThis logic is difficult to understand. What this means is:\n\n- if --shared is specified, attrs[\u0027shared\u0027] \u003d True\n- if --private is specified, attrs[\u0027shared\u0027] \u003d False\n- Otherwise, attrs[\u0027shared\u0027] \u003d True\n\nIt is better to be modified later.","commit_id":"142db12e835c71104374a9baa66887444eab22d8"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"c0393ab43aaa220f379a26c81b01f96401b5fd20","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        attrs \u003d {}"},{"line_number":182,"context_line":"        if parsed_args.shared or parsed_args.private:"},{"line_number":183,"context_line":"            attrs[\u0027shared\u0027] \u003d parsed_args.shared"},{"line_number":184,"context_line":"        else:"},{"line_number":185,"context_line":"            # default to be ``shared`` if not specified"},{"line_number":186,"context_line":"            attrs[\u0027shared\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_570751cb","line":183,"range":{"start_line":182,"start_character":8,"end_line":183,"end_character":48},"in_reply_to":"5fc1f717_777dad7d","updated":"2019-03-13 06:45:11.000000000","message":"Yes, I agree. It\u0027s better to refine it in an separate patch.","commit_id":"142db12e835c71104374a9baa66887444eab22d8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"dce4e88582d03d86360456b54ea69299cc47faa4","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        if parsed_args.name:"},{"line_number":191,"context_line":"            attrs[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        if not attrs[\u0027shared\u0027] and parsed_args.project:"},{"line_number":194,"context_line":"            project_id \u003d identity_common.find_project("},{"line_number":195,"context_line":"                identity_client,"},{"line_number":196,"context_line":"                parsed_args.project,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_978ff973","line":193,"updated":"2019-03-13 06:20:58.000000000","message":"Why do we need this change? L.171 already checks if --project is specified only when --private is specified.","commit_id":"142db12e835c71104374a9baa66887444eab22d8"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"a8d7f838616b033f5099e57834612229fa29a06f","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        if parsed_args.name:"},{"line_number":191,"context_line":"            attrs[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        if not attrs[\u0027shared\u0027] and parsed_args.project:"},{"line_number":194,"context_line":"            project_id \u003d identity_common.find_project("},{"line_number":195,"context_line":"                identity_client,"},{"line_number":196,"context_line":"                parsed_args.project,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_6a7dc07d","line":193,"in_reply_to":"5fc1f717_0a075c1a","updated":"2019-03-13 08:11:47.000000000","message":"Done","commit_id":"142db12e835c71104374a9baa66887444eab22d8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c8f846ed639885bd219d70c7d537e9b09c4a1189","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        if parsed_args.name:"},{"line_number":191,"context_line":"            attrs[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        if not attrs[\u0027shared\u0027] and parsed_args.project:"},{"line_number":194,"context_line":"            project_id \u003d identity_common.find_project("},{"line_number":195,"context_line":"                identity_client,"},{"line_number":196,"context_line":"                parsed_args.project,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_f7cf5d53","line":193,"in_reply_to":"5fc1f717_1726a969","updated":"2019-03-13 07:30:06.000000000","message":"I guess --public you mentioned is --shared.\n\nIf only --project is specified, parsed_args.private is False and parsed_args.project has some value. In this case, L.171 would raise an error.\n\nIf --shared and --project options are both specified, parsed_args.private is False (from mutually_exclusive) so L.171 would raise an error too.\n\nI still cannot understand why this change is needed.","commit_id":"142db12e835c71104374a9baa66887444eab22d8"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"c0393ab43aaa220f379a26c81b01f96401b5fd20","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        if parsed_args.name:"},{"line_number":191,"context_line":"            attrs[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        if not attrs[\u0027shared\u0027] and parsed_args.project:"},{"line_number":194,"context_line":"            project_id \u003d identity_common.find_project("},{"line_number":195,"context_line":"                identity_client,"},{"line_number":196,"context_line":"                parsed_args.project,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_1726a969","line":193,"in_reply_to":"5fc1f717_978ff973","updated":"2019-03-13 06:45:11.000000000","message":"When doing a create_minimum_options test like [1], if none of --public, --private and --project is specified, it would populate \"shared\" with True and \"project_id\" with the current project_id based on the current logic. \"project_id\" attr should only be populated on a private range creation.\n\n[1] https://review.openstack.org/#/c/642708/2/openstackclient/tests/unit/network/v2/test_network_segment_range.py@168","commit_id":"142db12e835c71104374a9baa66887444eab22d8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"bc30ea50a54f1c972672a6760c327fa7fb571396","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        if parsed_args.name:"},{"line_number":191,"context_line":"            attrs[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        if not attrs[\u0027shared\u0027] and parsed_args.project:"},{"line_number":194,"context_line":"            project_id \u003d identity_common.find_project("},{"line_number":195,"context_line":"                identity_client,"},{"line_number":196,"context_line":"                parsed_args.project,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_0a075c1a","line":193,"in_reply_to":"5fc1f717_f7cf5d53","updated":"2019-03-13 08:06:05.000000000","message":"we discussed in IRC and agreed that \"if parsed_args.project\" is enough.\n\nhttp://eavesdrop.openstack.org/irclogs/%23openstack-sdks/%23openstack-sdks.2019-03-13.log.html#t2019-03-13T07:51:34","commit_id":"142db12e835c71104374a9baa66887444eab22d8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"dce4e88582d03d86360456b54ea69299cc47faa4","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                msg \u003d (_(\"Failed to create the network segment range for \""},{"line_number":203,"context_line":"                         \"project %(project_id)s\") % parsed_args.project_id)"},{"line_number":204,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":205,"context_line":"        elif not attrs[\u0027shared\u0027] and not parsed_args.shared:"},{"line_number":206,"context_line":"            # default to the current project if no project specified and shared"},{"line_number":207,"context_line":"            # is not specified."},{"line_number":208,"context_line":"            # Get the project id from the current auth."}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_b78c757f","line":205,"updated":"2019-03-13 06:20:58.000000000","message":"same question as for L.193.","commit_id":"142db12e835c71104374a9baa66887444eab22d8"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"a8d7f838616b033f5099e57834612229fa29a06f","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                msg \u003d (_(\"Failed to create the network segment range for \""},{"line_number":203,"context_line":"                         \"project %(project_id)s\") % parsed_args.project_id)"},{"line_number":204,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":205,"context_line":"        elif not attrs[\u0027shared\u0027] and not parsed_args.shared:"},{"line_number":206,"context_line":"            # default to the current project if no project specified and shared"},{"line_number":207,"context_line":"            # is not specified."},{"line_number":208,"context_line":"            # Get the project id from the current auth."}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_0a6e7cc8","line":205,"in_reply_to":"5fc1f717_aa172845","updated":"2019-03-13 08:11:47.000000000","message":"Done","commit_id":"142db12e835c71104374a9baa66887444eab22d8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"bc30ea50a54f1c972672a6760c327fa7fb571396","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                msg \u003d (_(\"Failed to create the network segment range for \""},{"line_number":203,"context_line":"                         \"project %(project_id)s\") % parsed_args.project_id)"},{"line_number":204,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":205,"context_line":"        elif not attrs[\u0027shared\u0027] and not parsed_args.shared:"},{"line_number":206,"context_line":"            # default to the current project if no project specified and shared"},{"line_number":207,"context_line":"            # is not specified."},{"line_number":208,"context_line":"            # Get the project id from the current auth."}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_aa172845","line":205,"in_reply_to":"5fc1f717_b78c757f","updated":"2019-03-13 08:06:05.000000000","message":"Per IRC discussion above,\n\n  elis not attrs[\u0027shared\u0027]:\n\nis the right condition because parsed_args.shared is already considered at L.182-186. By doing so, we can consider parsed_args.shared and parsed_args.private at one place.","commit_id":"142db12e835c71104374a9baa66887444eab22d8"}]}