)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"7305a514867f2e66918e47a0404480066714ab9f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change add a new server recreate command to"},{"line_number":10,"context_line":"provide parity with the nova evacuate command."},{"line_number":11,"context_line":"The term \u0027recreate\u0027 was selected to convay that the"},{"line_number":12,"context_line":"original instance is destroyed and a new instance"},{"line_number":13,"context_line":"is created. This meaning was not convayed by the"},{"line_number":14,"context_line":"existing nova term \u0027evacuate\u0027 implied the instance"},{"line_number":15,"context_line":"was moved and not recreated."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ffb9cba7_bfd8b67a","line":12,"range":{"start_line":11,"start_character":10,"end_line":12,"end_character":30},"updated":"2019-05-01 20:46:13.000000000","message":"I would prefer \u0027resurrect\u0027 to eliminate any doubt that the original is already dead at the point at which this is run.  \u0027recreate\u0027 is a bit ambiguous in this respect - it could be misinterpreted to mean recreation of something which was shut down cleanly, or even cloning of something which is still running.","commit_id":"ee372f5319a4d77def1d34e53f506906051ebfcc"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"d19833971d735ac96bd406605f093bf1caebbf97","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change add a new server recreate command to"},{"line_number":10,"context_line":"provide parity with the nova evacuate command."},{"line_number":11,"context_line":"The term \u0027recreate\u0027 was selected to convay that the"},{"line_number":12,"context_line":"original instance is destroyed and a new instance"},{"line_number":13,"context_line":"is created. This meaning was not convayed by the"},{"line_number":14,"context_line":"existing nova term \u0027evacuate\u0027 implied the instance"},{"line_number":15,"context_line":"was moved and not recreated."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bfb3d3c7_7e83ce57","line":12,"range":{"start_line":11,"start_character":10,"end_line":12,"end_character":30},"in_reply_to":"bfb3d3c7_c37545fc","updated":"2019-05-17 12:20:11.000000000","message":"Thanks.  For the record, big bike-shedding discussion this morning on this:\n\nhttp://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-05-17.log.html#t2019-05-17T10:52:55","commit_id":"ee372f5319a4d77def1d34e53f506906051ebfcc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d42fce5231c24ca6a256893313b8ab8aba51bc68","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change add a new server recreate command to"},{"line_number":10,"context_line":"provide parity with the nova evacuate command."},{"line_number":11,"context_line":"The term \u0027recreate\u0027 was selected to convay that the"},{"line_number":12,"context_line":"original instance is destroyed and a new instance"},{"line_number":13,"context_line":"is created. This meaning was not convayed by the"},{"line_number":14,"context_line":"existing nova term \u0027evacuate\u0027 implied the instance"},{"line_number":15,"context_line":"was moved and not recreated."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ffb9cba7_d58ea977","line":12,"range":{"start_line":11,"start_character":10,"end_line":12,"end_character":30},"in_reply_to":"ffb9cba7_bfd8b67a","updated":"2019-05-01 22:45:36.000000000","message":"Discussion at the Train summit today [1] suggested we nest this as an option with the \"openstack server migrate\" command since (1) evacuate moves the server to another host (actually it rebuilds it on another host) and (2) server migrate is an admin-only command by default [people are used to that] and adding a top-level \"openstack server recreate\" command could confuse non-admin users into thinking they can perform the action by default.\n\n[1] https://etherpad.openstack.org/p/DEN-osc-compute-api-gaps","commit_id":"ee372f5319a4d77def1d34e53f506906051ebfcc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6791156a7a2e34c61d78662c30adc4c36179a484","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change add a new server recreate command to"},{"line_number":10,"context_line":"provide parity with the nova evacuate command."},{"line_number":11,"context_line":"The term \u0027recreate\u0027 was selected to convay that the"},{"line_number":12,"context_line":"original instance is destroyed and a new instance"},{"line_number":13,"context_line":"is created. This meaning was not convayed by the"},{"line_number":14,"context_line":"existing nova term \u0027evacuate\u0027 implied the instance"},{"line_number":15,"context_line":"was moved and not recreated."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bfb3d3c7_c37545fc","line":12,"range":{"start_line":11,"start_character":10,"end_line":12,"end_character":30},"in_reply_to":"ffb9cba7_d58ea977","updated":"2019-05-17 11:35:46.000000000","message":"ill update this to resurrect and make the other changes and reuplod thanks","commit_id":"ee372f5319a4d77def1d34e53f506906051ebfcc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"943511a4a616eef3a4715d156d35802eaaade61b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean Mooney \u003cwork@seanmooney.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-05-21 18:28:37 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add openstack server resurrect command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a new server resurrect command to"},{"line_number":10,"context_line":"provide parity with the nova evacuate command."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bfb3d3c7_2de73215","line":7,"range":{"start_line":7,"start_character":21,"end_line":7,"end_character":30},"updated":"2019-05-21 21:11:12.000000000","message":"Regarding naming:\n\n(4:10:17 PM) dansmith: I think keeping evacuate and relying on the scoping to disambiguate is the best plan at the moment","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"caec9a88ffe2ea52de0d0f9d9f9f8084fc560b93","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean Mooney \u003cwork@seanmooney.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-05-21 18:28:37 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add openstack server resurrect command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a new server resurrect command to"},{"line_number":10,"context_line":"provide parity with the nova evacuate command."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bfb3d3c7_b8f34c9e","line":7,"range":{"start_line":7,"start_character":21,"end_line":7,"end_character":30},"in_reply_to":"bfb3d3c7_2de73215","updated":"2019-05-22 16:46:58.000000000","message":"I\u0027m leaving this as-is for now because there\u0027s clearly some disagreement here. Could be a good discussion for the mailing list or the next nova meeting","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32cdff44ddf156f7c7a718ce353b9e94ae2624fe","unresolved":false,"context_lines":[{"line_number":10,"context_line":"provide parity with the nova evacuate command."},{"line_number":11,"context_line":"The term \u0027resurrect\u0027 was selected to convay that the"},{"line_number":12,"context_line":"original instance is destroyed when the host it was"},{"line_number":13,"context_line":"executing on dided and a new instance is created."},{"line_number":14,"context_line":"This meaning was not convayed by the existing nova"},{"line_number":15,"context_line":"term \u0027evacuate\u0027 which implied the instance"},{"line_number":16,"context_line":"was moved and not recreated."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bfb3d3c7_ea76e306","line":13,"range":{"start_line":13,"start_character":13,"end_line":13,"end_character":18},"updated":"2019-05-21 17:54:03.000000000","message":"died","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"caec9a88ffe2ea52de0d0f9d9f9f8084fc560b93","unresolved":false,"context_lines":[{"line_number":10,"context_line":"provide parity with the nova evacuate command."},{"line_number":11,"context_line":"The term \u0027resurrect\u0027 was selected to convay that the"},{"line_number":12,"context_line":"original instance is destroyed when the host it was"},{"line_number":13,"context_line":"executing on dided and a new instance is created."},{"line_number":14,"context_line":"This meaning was not convayed by the existing nova"},{"line_number":15,"context_line":"term \u0027evacuate\u0027 which implied the instance"},{"line_number":16,"context_line":"was moved and not recreated."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bfb3d3c7_d8d5e0e6","line":13,"range":{"start_line":13,"start_character":13,"end_line":13,"end_character":18},"in_reply_to":"bfb3d3c7_ea76e306","updated":"2019-05-22 16:46:58.000000000","message":"Done","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32cdff44ddf156f7c7a718ce353b9e94ae2624fe","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The term \u0027resurrect\u0027 was selected to convay that the"},{"line_number":12,"context_line":"original instance is destroyed when the host it was"},{"line_number":13,"context_line":"executing on dided and a new instance is created."},{"line_number":14,"context_line":"This meaning was not convayed by the existing nova"},{"line_number":15,"context_line":"term \u0027evacuate\u0027 which implied the instance"},{"line_number":16,"context_line":"was moved and not recreated."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bfb3d3c7_0a725712","line":14,"range":{"start_line":14,"start_character":21,"end_line":14,"end_character":29},"updated":"2019-05-21 17:54:03.000000000","message":"conveyed","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"caec9a88ffe2ea52de0d0f9d9f9f8084fc560b93","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The term \u0027resurrect\u0027 was selected to convay that the"},{"line_number":12,"context_line":"original instance is destroyed when the host it was"},{"line_number":13,"context_line":"executing on dided and a new instance is created."},{"line_number":14,"context_line":"This meaning was not convayed by the existing nova"},{"line_number":15,"context_line":"term \u0027evacuate\u0027 which implied the instance"},{"line_number":16,"context_line":"was moved and not recreated."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bfb3d3c7_9809a896","line":14,"range":{"start_line":14,"start_character":21,"end_line":14,"end_character":29},"in_reply_to":"bfb3d3c7_0a725712","updated":"2019-05-22 16:46:58.000000000","message":"Done","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32cdff44ddf156f7c7a718ce353b9e94ae2624fe","unresolved":false,"context_lines":[{"line_number":13,"context_line":"executing on dided and a new instance is created."},{"line_number":14,"context_line":"This meaning was not convayed by the existing nova"},{"line_number":15,"context_line":"term \u0027evacuate\u0027 which implied the instance"},{"line_number":16,"context_line":"was moved and not recreated."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I1e32ca51036c501862d8e89b3144a9695d98a06f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bfb3d3c7_ca651f47","line":16,"range":{"start_line":16,"start_character":10,"end_line":16,"end_character":17},"updated":"2019-05-21 17:54:03.000000000","message":"rather than","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"caec9a88ffe2ea52de0d0f9d9f9f8084fc560b93","unresolved":false,"context_lines":[{"line_number":13,"context_line":"executing on dided and a new instance is created."},{"line_number":14,"context_line":"This meaning was not convayed by the existing nova"},{"line_number":15,"context_line":"term \u0027evacuate\u0027 which implied the instance"},{"line_number":16,"context_line":"was moved and not recreated."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I1e32ca51036c501862d8e89b3144a9695d98a06f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bfb3d3c7_78063489","line":16,"range":{"start_line":16,"start_character":10,"end_line":16,"end_character":17},"in_reply_to":"bfb3d3c7_ca651f47","updated":"2019-05-22 16:46:58.000000000","message":"Done","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae5963b11674e04f319173e19f02b35987cfe520","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-05-23 15:29:31 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027openstack server resurrect\u0027 command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a new \u0027openstack server resurrect\u0027 command to provide"},{"line_number":10,"context_line":"parity with the \u0027nova evacuate\u0027 command. The term \"resurrect\" is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bfb3d3c7_25e4c5df","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":31},"updated":"2019-05-28 13:54:27.000000000","message":"Just noting again there is some disagreement with this new naming since it could be confused as a new thing rather than just being the CLI for the evacuate API (not to be confused with the nova admin orchestration commands to live migrate all instances off a host). I would like to see some link to a discussion for agreement either in the ML or nova meeting before moving forward with this.","commit_id":"54332d98017a4573d71b77c2a8eac7965b908191"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"52f1ba85d1563d5a57a413a6d1c0878a41f88799","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-05-23 15:29:31 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027openstack server resurrect\u0027 command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a new \u0027openstack server resurrect\u0027 command to provide"},{"line_number":10,"context_line":"parity with the \u0027nova evacuate\u0027 command. The term \"resurrect\" is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1fa4df85_bd2cfcab","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":31},"in_reply_to":"1fa4df85_dd6f7825","updated":"2020-03-10 20:59:10.000000000","message":"To correct myself, I realized it\u0027s not clear what Matt\u0027s opinion about the naming is -- he just noted that there\u0027s disagreement.\n\nI just read through all the comments again and now see that there are users that wish to change the terminology for this command because they think it\u0027s clearer.\n\nSo ... I\u0027ll just echo what Matt has said, let\u0027s take the topic to the ML and see if there\u0027s wider consensus on which direction to go with the name. I thought using a new term would be confusing, but maybe most people would not find it so. I\u0027d like to see a bit more input about it from more people before making the decision.","commit_id":"54332d98017a4573d71b77c2a8eac7965b908191"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"604b213dbecaac8c52de7c64421feb6871dd74c8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-05-23 15:29:31 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027openstack server resurrect\u0027 command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a new \u0027openstack server resurrect\u0027 command to provide"},{"line_number":10,"context_line":"parity with the \u0027nova evacuate\u0027 command. The term \"resurrect\" is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1fa4df85_dd6f7825","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":31},"in_reply_to":"bfb3d3c7_25e4c5df","updated":"2020-03-10 20:46:03.000000000","message":"I just found this review because someone from our downstream docs team asked me, \"Is there no openstack client command for \"nova evacuate\" or \"nova host-evacuate\"?\" and opened the good ol etherpad:\n\nhttps://etherpad.openstack.org/p/compute-api-microversion-gap-in-osc\n\nI just want to note that I agree with Matt that we should not change the terminology in this command -- it makes it sound like a new thing IMHO. I\u0027d prefer we stay consistent with the current name, even if it\u0027s not the best name.","commit_id":"54332d98017a4573d71b77c2a8eac7965b908191"}],"openstackclient/compute/v2/server.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"336101dc7a0eccf5688d4beee0009e531ede642b","unresolved":false,"context_lines":[{"line_number":1673,"context_line":""},{"line_number":1674,"context_line":""},{"line_number":1675,"context_line":"class RecreateServer(command.ShowOne):"},{"line_number":1676,"context_line":"    _description \u003d _(\"Recreate server on a different host\")"},{"line_number":1677,"context_line":""},{"line_number":1678,"context_line":"    def get_parser(self, prog_name):"},{"line_number":1679,"context_line":"        parser \u003d super(RecreateServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_f5e08d28","line":1676,"updated":"2019-05-01 22:51:55.000000000","message":"Should probably explain a bit more here like in the compute API reference, i.e. this will only work if compute service on which the server is running is down - and should only be used if the host is fenced.","commit_id":"ee372f5319a4d77def1d34e53f506906051ebfcc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"336101dc7a0eccf5688d4beee0009e531ede642b","unresolved":false,"context_lines":[{"line_number":1689,"context_line":"        )"},{"line_number":1690,"context_line":"        key_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":1691,"context_line":"        key_group.add_argument("},{"line_number":1692,"context_line":"            \u0027--host\u0027, metavar\u003d\u0027\u003chost\u003e\u0027, default\u003dNone,"},{"line_number":1693,"context_line":"            help\u003d_(\"Set the prefered host to recreate the server on, \""},{"line_number":1694,"context_line":"                   \"note the host will be validated by the scheduler.\"),"},{"line_number":1695,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_154c4140","line":1692,"updated":"2019-05-01 22:51:55.000000000","message":"This should only be supported with --os-compute-api-version \u003e\u003d 2.29 because with the default OSC behavior it will forcefully evacuate the server to the specified host, bypassing the scheduler, which is (as you know) not something we want to do.","commit_id":"ee372f5319a4d77def1d34e53f506906051ebfcc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c57b33ad44463de53d5d94e5a812153daab953a","unresolved":false,"context_lines":[{"line_number":1689,"context_line":"        )"},{"line_number":1690,"context_line":"        key_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":1691,"context_line":"        key_group.add_argument("},{"line_number":1692,"context_line":"            \u0027--host\u0027, metavar\u003d\u0027\u003chost\u003e\u0027, default\u003dNone,"},{"line_number":1693,"context_line":"            help\u003d_(\"Set the prefered host to recreate the server on, \""},{"line_number":1694,"context_line":"                   \"note the host will be validated by the scheduler.\"),"},{"line_number":1695,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_111a957c","line":1692,"in_reply_to":"ffb9cba7_154c4140","updated":"2019-05-21 10:41:58.000000000","message":"Done","commit_id":"ee372f5319a4d77def1d34e53f506906051ebfcc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"336101dc7a0eccf5688d4beee0009e531ede642b","unresolved":false,"context_lines":[{"line_number":1690,"context_line":"        key_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":1691,"context_line":"        key_group.add_argument("},{"line_number":1692,"context_line":"            \u0027--host\u0027, metavar\u003d\u0027\u003chost\u003e\u0027, default\u003dNone,"},{"line_number":1693,"context_line":"            help\u003d_(\"Set the prefered host to recreate the server on, \""},{"line_number":1694,"context_line":"                   \"note the host will be validated by the scheduler.\"),"},{"line_number":1695,"context_line":"        )"},{"line_number":1696,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_95d35160","line":1693,"range":{"start_line":1693,"start_character":42,"end_line":1693,"end_character":67},"updated":"2019-05-01 22:51:55.000000000","message":"on which to recreate the server","commit_id":"ee372f5319a4d77def1d34e53f506906051ebfcc"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"7305a514867f2e66918e47a0404480066714ab9f","unresolved":false,"context_lines":[{"line_number":1690,"context_line":"        key_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":1691,"context_line":"        key_group.add_argument("},{"line_number":1692,"context_line":"            \u0027--host\u0027, metavar\u003d\u0027\u003chost\u003e\u0027, default\u003dNone,"},{"line_number":1693,"context_line":"            help\u003d_(\"Set the prefered host to recreate the server on, \""},{"line_number":1694,"context_line":"                   \"note the host will be validated by the scheduler.\"),"},{"line_number":1695,"context_line":"        )"},{"line_number":1696,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_1fc78298","line":1693,"range":{"start_line":1693,"start_character":28,"end_line":1693,"end_character":36},"updated":"2019-05-01 20:46:13.000000000","message":"preferred","commit_id":"ee372f5319a4d77def1d34e53f506906051ebfcc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c57b33ad44463de53d5d94e5a812153daab953a","unresolved":false,"context_lines":[{"line_number":1690,"context_line":"        key_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":1691,"context_line":"        key_group.add_argument("},{"line_number":1692,"context_line":"            \u0027--host\u0027, metavar\u003d\u0027\u003chost\u003e\u0027, default\u003dNone,"},{"line_number":1693,"context_line":"            help\u003d_(\"Set the prefered host to recreate the server on, \""},{"line_number":1694,"context_line":"                   \"note the host will be validated by the scheduler.\"),"},{"line_number":1695,"context_line":"        )"},{"line_number":1696,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_f1182182","line":1693,"range":{"start_line":1693,"start_character":28,"end_line":1693,"end_character":36},"in_reply_to":"ffb9cba7_1fc78298","updated":"2019-05-21 10:41:58.000000000","message":"Done","commit_id":"ee372f5319a4d77def1d34e53f506906051ebfcc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c57b33ad44463de53d5d94e5a812153daab953a","unresolved":false,"context_lines":[{"line_number":1690,"context_line":"        key_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":1691,"context_line":"        key_group.add_argument("},{"line_number":1692,"context_line":"            \u0027--host\u0027, metavar\u003d\u0027\u003chost\u003e\u0027, default\u003dNone,"},{"line_number":1693,"context_line":"            help\u003d_(\"Set the prefered host to recreate the server on, \""},{"line_number":1694,"context_line":"                   \"note the host will be validated by the scheduler.\"),"},{"line_number":1695,"context_line":"        )"},{"line_number":1696,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_311f996d","line":1693,"range":{"start_line":1693,"start_character":42,"end_line":1693,"end_character":67},"in_reply_to":"ffb9cba7_95d35160","updated":"2019-05-21 10:41:58.000000000","message":"Done","commit_id":"ee372f5319a4d77def1d34e53f506906051ebfcc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"336101dc7a0eccf5688d4beee0009e531ede642b","unresolved":false,"context_lines":[{"line_number":1698,"context_line":"            help\u003d_(\"Set the password on the recreated instance\"),"},{"line_number":1699,"context_line":"        )"},{"line_number":1700,"context_line":"        parser.add_argument("},{"line_number":1701,"context_line":"            \u0027--shared-storage\u0027, default\u003dTrue, type\u003dbool,"},{"line_number":1702,"context_line":"            metavar\u003d\u0027\u003cshared_storage\u003e\u0027, dest\u003d\u0027shared_storage\u0027,"},{"line_number":1703,"context_line":"            help\u003d_(\"indicates if the instance is on shared storage\"),"},{"line_number":1704,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_35c4e590","line":1701,"range":{"start_line":1701,"start_character":46,"end_line":1701,"end_character":55},"updated":"2019-05-01 22:51:55.000000000","message":"This is weird, why not use action\u003d\u0027store_true\u0027?  That way it\u0027s a bool and defaults to false (which would match how --shared-storage works in the openstack server migrate --live command).","commit_id":"ee372f5319a4d77def1d34e53f506906051ebfcc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c57b33ad44463de53d5d94e5a812153daab953a","unresolved":false,"context_lines":[{"line_number":1698,"context_line":"            help\u003d_(\"Set the password on the recreated instance\"),"},{"line_number":1699,"context_line":"        )"},{"line_number":1700,"context_line":"        parser.add_argument("},{"line_number":1701,"context_line":"            \u0027--shared-storage\u0027, default\u003dTrue, type\u003dbool,"},{"line_number":1702,"context_line":"            metavar\u003d\u0027\u003cshared_storage\u003e\u0027, dest\u003d\u0027shared_storage\u0027,"},{"line_number":1703,"context_line":"            help\u003d_(\"indicates if the instance is on shared storage\"),"},{"line_number":1704,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_910d2540","line":1701,"range":{"start_line":1701,"start_character":46,"end_line":1701,"end_character":55},"in_reply_to":"ffb9cba7_35c4e590","updated":"2019-05-21 10:41:58.000000000","message":"Done","commit_id":"ee372f5319a4d77def1d34e53f506906051ebfcc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"336101dc7a0eccf5688d4beee0009e531ede642b","unresolved":false,"context_lines":[{"line_number":1700,"context_line":"        parser.add_argument("},{"line_number":1701,"context_line":"            \u0027--shared-storage\u0027, default\u003dTrue, type\u003dbool,"},{"line_number":1702,"context_line":"            metavar\u003d\u0027\u003cshared_storage\u003e\u0027, dest\u003d\u0027shared_storage\u0027,"},{"line_number":1703,"context_line":"            help\u003d_(\"indicates if the instance is on shared storage\"),"},{"line_number":1704,"context_line":"        )"},{"line_number":1705,"context_line":"        return parser"},{"line_number":1706,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_f5b96d14","line":1703,"range":{"start_line":1703,"start_character":37,"end_line":1703,"end_character":45},"updated":"2019-05-01 22:51:55.000000000","message":"server","commit_id":"ee372f5319a4d77def1d34e53f506906051ebfcc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"336101dc7a0eccf5688d4beee0009e531ede642b","unresolved":false,"context_lines":[{"line_number":1697,"context_line":"            \u0027--password\u0027, metavar\u003d\u0027\u003cpassword\u003e\u0027, default\u003dNone,"},{"line_number":1698,"context_line":"            help\u003d_(\"Set the password on the recreated instance\"),"},{"line_number":1699,"context_line":"        )"},{"line_number":1700,"context_line":"        parser.add_argument("},{"line_number":1701,"context_line":"            \u0027--shared-storage\u0027, default\u003dTrue, type\u003dbool,"},{"line_number":1702,"context_line":"            metavar\u003d\u0027\u003cshared_storage\u003e\u0027, dest\u003d\u0027shared_storage\u0027,"},{"line_number":1703,"context_line":"            help\u003d_(\"indicates if the instance is on shared storage\"),"},{"line_number":1704,"context_line":"        )"},{"line_number":1705,"context_line":"        return parser"},{"line_number":1706,"context_line":""},{"line_number":1707,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_b53d3590","line":1704,"range":{"start_line":1700,"start_character":8,"end_line":1704,"end_character":9},"updated":"2019-05-01 22:51:55.000000000","message":"This was removed in 2.14:\n\nhttps://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id12\n\nSo (1) mention that if you use --os-compute-api-version 2.14 or greater this is calculated automatically by the server and (2) don\u0027t pass this along to novaclient if --os-compute-api-versoin \u003e\u003d 2.14.","commit_id":"ee372f5319a4d77def1d34e53f506906051ebfcc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c57b33ad44463de53d5d94e5a812153daab953a","unresolved":false,"context_lines":[{"line_number":1697,"context_line":"            \u0027--password\u0027, metavar\u003d\u0027\u003cpassword\u003e\u0027, default\u003dNone,"},{"line_number":1698,"context_line":"            help\u003d_(\"Set the password on the recreated instance\"),"},{"line_number":1699,"context_line":"        )"},{"line_number":1700,"context_line":"        parser.add_argument("},{"line_number":1701,"context_line":"            \u0027--shared-storage\u0027, default\u003dTrue, type\u003dbool,"},{"line_number":1702,"context_line":"            metavar\u003d\u0027\u003cshared_storage\u003e\u0027, dest\u003d\u0027shared_storage\u0027,"},{"line_number":1703,"context_line":"            help\u003d_(\"indicates if the instance is on shared storage\"),"},{"line_number":1704,"context_line":"        )"},{"line_number":1705,"context_line":"        return parser"},{"line_number":1706,"context_line":""},{"line_number":1707,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_b10aa923","line":1704,"range":{"start_line":1700,"start_character":8,"end_line":1704,"end_character":9},"in_reply_to":"ffb9cba7_b53d3590","updated":"2019-05-21 10:41:58.000000000","message":"Done","commit_id":"ee372f5319a4d77def1d34e53f506906051ebfcc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32cdff44ddf156f7c7a718ce353b9e94ae2624fe","unresolved":false,"context_lines":[{"line_number":1674,"context_line":"        return zip(*sorted(six.iteritems(details)))"},{"line_number":1675,"context_line":""},{"line_number":1676,"context_line":""},{"line_number":1677,"context_line":"class ResurrectServer(command.ShowOne):"},{"line_number":1678,"context_line":"    _description \u003d _(\"Resurrects a server on a different host. \""},{"line_number":1679,"context_line":"                     \"This command is used to resurrect a server after \""},{"line_number":1680,"context_line":"                     \"the host it was on has failed. It can only be used \""}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_aac78b12","line":1677,"updated":"2019-05-21 17:54:03.000000000","message":"Need a release note for this.","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"66a951bd5ac683249f043625a5c9e32aa0b68c64","unresolved":false,"context_lines":[{"line_number":1674,"context_line":"        return zip(*sorted(six.iteritems(details)))"},{"line_number":1675,"context_line":""},{"line_number":1676,"context_line":""},{"line_number":1677,"context_line":"class ResurrectServer(command.ShowOne):"},{"line_number":1678,"context_line":"    _description \u003d _(\"Resurrects a server on a different host. \""},{"line_number":1679,"context_line":"                     \"This command is used to resurrect a server after \""},{"line_number":1680,"context_line":"                     \"the host it was on has failed. It can only be used \""}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_ba62763d","line":1677,"in_reply_to":"bfb3d3c7_aac78b12","updated":"2019-05-21 20:31:55.000000000","message":"ok ill add one in the next version","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1ab4e33d87e563e0619317fabd4d592f356730d9","unresolved":false,"context_lines":[{"line_number":1674,"context_line":"        return zip(*sorted(six.iteritems(details)))"},{"line_number":1675,"context_line":""},{"line_number":1676,"context_line":""},{"line_number":1677,"context_line":"class ResurrectServer(command.ShowOne):"},{"line_number":1678,"context_line":"    _description \u003d _(\"Resurrects a server on a different host. \""},{"line_number":1679,"context_line":"                     \"This command is used to resurrect a server after \""},{"line_number":1680,"context_line":"                     \"the host it was on has failed. It can only be used \""}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_9aed328d","line":1677,"in_reply_to":"bfb3d3c7_ba62763d","updated":"2019-05-21 20:36:24.000000000","message":"This doesn\u0027t show up in the docs either:\n\nhttp://logs.openstack.org/78/643578/4/check/openstack-tox-docs/256f05e/html/cli/command-list.html\n\nProbably because there is no entry in here:\n\nhttps://raw.githubusercontent.com/openstack/python-openstackclient/master/doc/source/cli/command-objects/server.rst","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32cdff44ddf156f7c7a718ce353b9e94ae2624fe","unresolved":false,"context_lines":[{"line_number":1683,"context_line":"                     \"after they have confirmed that the instance is not \""},{"line_number":1684,"context_line":"                     \"running on the faild host. \""},{"line_number":1685,"context_line":"                     \"If the server instance was created with a ephemeral \""},{"line_number":1686,"context_line":"                     \"root disk on non shared storage the server will be \""},{"line_number":1687,"context_line":"                     \"rebuilt using the original glance image preserving the \""},{"line_number":1688,"context_line":"                     \"ports and any attached data volumes. \""},{"line_number":1689,"context_line":"                     \"If the server use a boot for volume or other root disk \""}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_0a4b37b0","line":1686,"range":{"start_line":1686,"start_character":35,"end_line":1686,"end_character":45},"updated":"2019-05-21 17:54:03.000000000","message":"non-shared","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"caec9a88ffe2ea52de0d0f9d9f9f8084fc560b93","unresolved":false,"context_lines":[{"line_number":1683,"context_line":"                     \"after they have confirmed that the instance is not \""},{"line_number":1684,"context_line":"                     \"running on the faild host. \""},{"line_number":1685,"context_line":"                     \"If the server instance was created with a ephemeral \""},{"line_number":1686,"context_line":"                     \"root disk on non shared storage the server will be \""},{"line_number":1687,"context_line":"                     \"rebuilt using the original glance image preserving the \""},{"line_number":1688,"context_line":"                     \"ports and any attached data volumes. \""},{"line_number":1689,"context_line":"                     \"If the server use a boot for volume or other root disk \""}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_782e3444","line":1686,"range":{"start_line":1686,"start_character":35,"end_line":1686,"end_character":45},"in_reply_to":"bfb3d3c7_0a4b37b0","updated":"2019-05-22 16:46:58.000000000","message":"Done","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32cdff44ddf156f7c7a718ce353b9e94ae2624fe","unresolved":false,"context_lines":[{"line_number":1686,"context_line":"                     \"root disk on non shared storage the server will be \""},{"line_number":1687,"context_line":"                     \"rebuilt using the original glance image preserving the \""},{"line_number":1688,"context_line":"                     \"ports and any attached data volumes. \""},{"line_number":1689,"context_line":"                     \"If the server use a boot for volume or other root disk \""},{"line_number":1690,"context_line":"                     \"on shared storage the root disk will be preserved and \""},{"line_number":1691,"context_line":"                     \"reused for teh resurrected instnace on the new host.\")"},{"line_number":1692,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_2a563b5e","line":1689,"range":{"start_line":1689,"start_character":36,"end_line":1689,"end_character":39},"updated":"2019-05-21 17:54:03.000000000","message":"uses?","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"caec9a88ffe2ea52de0d0f9d9f9f8084fc560b93","unresolved":false,"context_lines":[{"line_number":1686,"context_line":"                     \"root disk on non shared storage the server will be \""},{"line_number":1687,"context_line":"                     \"rebuilt using the original glance image preserving the \""},{"line_number":1688,"context_line":"                     \"ports and any attached data volumes. \""},{"line_number":1689,"context_line":"                     \"If the server use a boot for volume or other root disk \""},{"line_number":1690,"context_line":"                     \"on shared storage the root disk will be preserved and \""},{"line_number":1691,"context_line":"                     \"reused for teh resurrected instnace on the new host.\")"},{"line_number":1692,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_d8fde0b1","line":1689,"range":{"start_line":1689,"start_character":36,"end_line":1689,"end_character":39},"in_reply_to":"bfb3d3c7_2a563b5e","updated":"2019-05-22 16:46:58.000000000","message":"Done","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32cdff44ddf156f7c7a718ce353b9e94ae2624fe","unresolved":false,"context_lines":[{"line_number":1688,"context_line":"                     \"ports and any attached data volumes. \""},{"line_number":1689,"context_line":"                     \"If the server use a boot for volume or other root disk \""},{"line_number":1690,"context_line":"                     \"on shared storage the root disk will be preserved and \""},{"line_number":1691,"context_line":"                     \"reused for teh resurrected instnace on the new host.\")"},{"line_number":1692,"context_line":""},{"line_number":1693,"context_line":"    def get_parser(self, prog_name):"},{"line_number":1694,"context_line":"        parser \u003d super(ResurrectServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_4a512f62","line":1691,"range":{"start_line":1691,"start_character":33,"end_line":1691,"end_character":36},"updated":"2019-05-21 17:54:03.000000000","message":"the","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"caec9a88ffe2ea52de0d0f9d9f9f8084fc560b93","unresolved":false,"context_lines":[{"line_number":1688,"context_line":"                     \"ports and any attached data volumes. \""},{"line_number":1689,"context_line":"                     \"If the server use a boot for volume or other root disk \""},{"line_number":1690,"context_line":"                     \"on shared storage the root disk will be preserved and \""},{"line_number":1691,"context_line":"                     \"reused for teh resurrected instnace on the new host.\")"},{"line_number":1692,"context_line":""},{"line_number":1693,"context_line":"    def get_parser(self, prog_name):"},{"line_number":1694,"context_line":"        parser \u003d super(ResurrectServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_b8026cb3","line":1691,"range":{"start_line":1691,"start_character":33,"end_line":1691,"end_character":36},"in_reply_to":"bfb3d3c7_4a512f62","updated":"2019-05-22 16:46:58.000000000","message":"Done","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32cdff44ddf156f7c7a718ce353b9e94ae2624fe","unresolved":false,"context_lines":[{"line_number":1707,"context_line":"            help\u003d_(\"Set the preferred host on which to resurrect the server, \""},{"line_number":1708,"context_line":"                   \"note the host will be validated by the scheduler. \""},{"line_number":1709,"context_line":"                   \"This is only supported with --os-compute-api-version \""},{"line_number":1710,"context_line":"                   \"\u003e\u003d 2.29\"),"},{"line_number":1711,"context_line":"        )"},{"line_number":1712,"context_line":"        parser.add_argument("},{"line_number":1713,"context_line":"            \u0027--password\u0027, metavar\u003d\u0027\u003cpassword\u003e\u0027, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_eae4a3ae","line":1710,"range":{"start_line":1710,"start_character":20,"end_line":1710,"end_character":27},"updated":"2019-05-21 17:54:03.000000000","message":"nit: avoid \u003e\u003d in help, so you could say \"--os-compute-api-version 2.29 or greater\".","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"caec9a88ffe2ea52de0d0f9d9f9f8084fc560b93","unresolved":false,"context_lines":[{"line_number":1707,"context_line":"            help\u003d_(\"Set the preferred host on which to resurrect the server, \""},{"line_number":1708,"context_line":"                   \"note the host will be validated by the scheduler. \""},{"line_number":1709,"context_line":"                   \"This is only supported with --os-compute-api-version \""},{"line_number":1710,"context_line":"                   \"\u003e\u003d 2.29\"),"},{"line_number":1711,"context_line":"        )"},{"line_number":1712,"context_line":"        parser.add_argument("},{"line_number":1713,"context_line":"            \u0027--password\u0027, metavar\u003d\u0027\u003cpassword\u003e\u0027, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_582b302f","line":1710,"range":{"start_line":1710,"start_character":20,"end_line":1710,"end_character":27},"in_reply_to":"bfb3d3c7_eae4a3ae","updated":"2019-05-22 16:46:58.000000000","message":"Done","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32cdff44ddf156f7c7a718ce353b9e94ae2624fe","unresolved":false,"context_lines":[{"line_number":1715,"context_line":"        )"},{"line_number":1716,"context_line":"        parser.add_argument("},{"line_number":1717,"context_line":"            \u0027--shared-storage\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027shared_storage\u0027,"},{"line_number":1718,"context_line":"            help\u003d_(\"indicates if the instance is on shared storage. \""},{"line_number":1719,"context_line":"                   \"This will be auto calulated after \""},{"line_number":1720,"context_line":"                   \"--os-compute-api-version 2.13 and should not be used\""},{"line_number":1721,"context_line":"                   \"with later micro versions\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_8aede78c","line":1718,"range":{"start_line":1718,"start_character":20,"end_line":1718,"end_character":29},"updated":"2019-05-21 17:54:03.000000000","message":"Indicates","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"caec9a88ffe2ea52de0d0f9d9f9f8084fc560b93","unresolved":false,"context_lines":[{"line_number":1715,"context_line":"        )"},{"line_number":1716,"context_line":"        parser.add_argument("},{"line_number":1717,"context_line":"            \u0027--shared-storage\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027shared_storage\u0027,"},{"line_number":1718,"context_line":"            help\u003d_(\"indicates if the instance is on shared storage. \""},{"line_number":1719,"context_line":"                   \"This will be auto calulated after \""},{"line_number":1720,"context_line":"                   \"--os-compute-api-version 2.13 and should not be used\""},{"line_number":1721,"context_line":"                   \"with later micro versions\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_d8eba0d9","line":1718,"range":{"start_line":1718,"start_character":20,"end_line":1718,"end_character":29},"in_reply_to":"bfb3d3c7_8aede78c","updated":"2019-05-22 16:46:58.000000000","message":"Done","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32cdff44ddf156f7c7a718ce353b9e94ae2624fe","unresolved":false,"context_lines":[{"line_number":1717,"context_line":"            \u0027--shared-storage\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027shared_storage\u0027,"},{"line_number":1718,"context_line":"            help\u003d_(\"indicates if the instance is on shared storage. \""},{"line_number":1719,"context_line":"                   \"This will be auto calulated after \""},{"line_number":1720,"context_line":"                   \"--os-compute-api-version 2.13 and should not be used\""},{"line_number":1721,"context_line":"                   \"with later micro versions\"),"},{"line_number":1722,"context_line":"        )"},{"line_number":1723,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_8aa2c74a","line":1720,"range":{"start_line":1720,"start_character":72,"end_line":1720,"end_character":73},"updated":"2019-05-21 17:54:03.000000000","message":"missing a space","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"caec9a88ffe2ea52de0d0f9d9f9f8084fc560b93","unresolved":false,"context_lines":[{"line_number":1717,"context_line":"            \u0027--shared-storage\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027shared_storage\u0027,"},{"line_number":1718,"context_line":"            help\u003d_(\"indicates if the instance is on shared storage. \""},{"line_number":1719,"context_line":"                   \"This will be auto calulated after \""},{"line_number":1720,"context_line":"                   \"--os-compute-api-version 2.13 and should not be used\""},{"line_number":1721,"context_line":"                   \"with later micro versions\"),"},{"line_number":1722,"context_line":"        )"},{"line_number":1723,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_b8f02ccb","line":1720,"range":{"start_line":1720,"start_character":72,"end_line":1720,"end_character":73},"in_reply_to":"bfb3d3c7_8aa2c74a","updated":"2019-05-22 16:46:58.000000000","message":"Done","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32cdff44ddf156f7c7a718ce353b9e94ae2624fe","unresolved":false,"context_lines":[{"line_number":1745,"context_line":"        server \u003d utils.find_resource("},{"line_number":1746,"context_line":"            compute_client.servers, parsed_args.server)"},{"line_number":1747,"context_line":"        server \u003d server.evacuate(host\u003dparsed_args.host,"},{"line_number":1748,"context_line":"                                 on_shared_storage\u003dparsed_args.shared_storage,"},{"line_number":1749,"context_line":"                                 password\u003dparsed_args.password)"},{"line_number":1750,"context_line":"        if parsed_args.wait:"},{"line_number":1751,"context_line":"            if utils.wait_for_status("}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_ca667f2a","line":1748,"range":{"start_line":1748,"start_character":33,"end_line":1748,"end_character":78},"updated":"2019-05-21 17:54:03.000000000","message":"This will blow up if you\u0027re using \u003e\u003d 2.14 because the kwarg doesn\u0027t exist on those versioned wrapped methods:\n\nhttps://github.com/openstack/python-novaclient/blob/dfb84228a2748bed82f9b83c1209d5e2e0557bfa/novaclient/v2/servers.py#L548","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"caec9a88ffe2ea52de0d0f9d9f9f8084fc560b93","unresolved":false,"context_lines":[{"line_number":1745,"context_line":"        server \u003d utils.find_resource("},{"line_number":1746,"context_line":"            compute_client.servers, parsed_args.server)"},{"line_number":1747,"context_line":"        server \u003d server.evacuate(host\u003dparsed_args.host,"},{"line_number":1748,"context_line":"                                 on_shared_storage\u003dparsed_args.shared_storage,"},{"line_number":1749,"context_line":"                                 password\u003dparsed_args.password)"},{"line_number":1750,"context_line":"        if parsed_args.wait:"},{"line_number":1751,"context_line":"            if utils.wait_for_status("}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_58b570cc","line":1748,"range":{"start_line":1748,"start_character":33,"end_line":1748,"end_character":78},"in_reply_to":"bfb3d3c7_5a681a20","updated":"2019-05-22 16:46:58.000000000","message":"Done","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"66a951bd5ac683249f043625a5c9e32aa0b68c64","unresolved":false,"context_lines":[{"line_number":1745,"context_line":"        server \u003d utils.find_resource("},{"line_number":1746,"context_line":"            compute_client.servers, parsed_args.server)"},{"line_number":1747,"context_line":"        server \u003d server.evacuate(host\u003dparsed_args.host,"},{"line_number":1748,"context_line":"                                 on_shared_storage\u003dparsed_args.shared_storage,"},{"line_number":1749,"context_line":"                                 password\u003dparsed_args.password)"},{"line_number":1750,"context_line":"        if parsed_args.wait:"},{"line_number":1751,"context_line":"            if utils.wait_for_status("}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_5a681a20","line":1748,"range":{"start_line":1748,"start_character":33,"end_line":1748,"end_character":78},"in_reply_to":"bfb3d3c7_ca667f2a","updated":"2019-05-21 20:31:55.000000000","message":"ah in that case ill go back to the other way i was playing with locally and only pass in the kwargs if tehy are valid\n\ne.g.\n\nkwargs \u003d {\u0027password\u0027: parsed_args.password}\nif ...\n    kwargs[\u0027host\u0027]\u003dparsed_args.host\nif ... \n    kwargs[\u0027on_shared_storage\u0027]\u003dparsed_args.shared_storage\n\nserver \u003d server.evacuate(**kwargs)","commit_id":"669721df00a542a0957924a2ebc653ca6fab4868"},{"author":{"_account_id":2463,"name":"Florian Haas","email":"florian.haas@cleura.com","username":"fghaas"},"change_message_id":"50842303eb6b284da5e55ae9aa8cdb512536e7b3","unresolved":false,"context_lines":[{"line_number":1680,"context_line":"This command is used to resurrect a server after the host it was on has failed."},{"line_number":1681,"context_line":"It can only be used if the compute service that manages the server is down."},{"line_number":1682,"context_line":"This command should only be used by an admin after they have confirmed that the"},{"line_number":1683,"context_line":"instance is not running on the faild host."},{"line_number":1684,"context_line":""},{"line_number":1685,"context_line":"If the server instance was created with a ephemeral root disk on non-shared"},{"line_number":1686,"context_line":"storage the server will be rebuilt using the original glance image preserving"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_9e797f30","line":1683,"updated":"2019-05-23 12:56:28.000000000","message":"Typo (\"faild\")","commit_id":"e60a585e30692dfadd7d264657626d768f1960f9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f2fd46802654ee61534469ffcdacf7e6634e8156","unresolved":false,"context_lines":[{"line_number":1680,"context_line":"This command is used to resurrect a server after the host it was on has failed."},{"line_number":1681,"context_line":"It can only be used if the compute service that manages the server is down."},{"line_number":1682,"context_line":"This command should only be used by an admin after they have confirmed that the"},{"line_number":1683,"context_line":"instance is not running on the faild host."},{"line_number":1684,"context_line":""},{"line_number":1685,"context_line":"If the server instance was created with a ephemeral root disk on non-shared"},{"line_number":1686,"context_line":"storage the server will be rebuilt using the original glance image preserving"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_64ef5cb0","line":1683,"in_reply_to":"bfb3d3c7_9e797f30","updated":"2019-05-23 14:29:35.000000000","message":"Done","commit_id":"e60a585e30692dfadd7d264657626d768f1960f9"},{"author":{"_account_id":2463,"name":"Florian Haas","email":"florian.haas@cleura.com","username":"fghaas"},"change_message_id":"50842303eb6b284da5e55ae9aa8cdb512536e7b3","unresolved":false,"context_lines":[{"line_number":1682,"context_line":"This command should only be used by an admin after they have confirmed that the"},{"line_number":1683,"context_line":"instance is not running on the faild host."},{"line_number":1684,"context_line":""},{"line_number":1685,"context_line":"If the server instance was created with a ephemeral root disk on non-shared"},{"line_number":1686,"context_line":"storage the server will be rebuilt using the original glance image preserving"},{"line_number":1687,"context_line":"the ports and any attached data volumes."},{"line_number":1688,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_1e934f51","line":1685,"updated":"2019-05-23 12:56:28.000000000","message":"Nit: should be \"an ephemeral root disk\"","commit_id":"e60a585e30692dfadd7d264657626d768f1960f9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f2fd46802654ee61534469ffcdacf7e6634e8156","unresolved":false,"context_lines":[{"line_number":1682,"context_line":"This command should only be used by an admin after they have confirmed that the"},{"line_number":1683,"context_line":"instance is not running on the faild host."},{"line_number":1684,"context_line":""},{"line_number":1685,"context_line":"If the server instance was created with a ephemeral root disk on non-shared"},{"line_number":1686,"context_line":"storage the server will be rebuilt using the original glance image preserving"},{"line_number":1687,"context_line":"the ports and any attached data volumes."},{"line_number":1688,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_c435e847","line":1685,"in_reply_to":"bfb3d3c7_1e934f51","updated":"2019-05-23 14:29:35.000000000","message":"Done","commit_id":"e60a585e30692dfadd7d264657626d768f1960f9"},{"author":{"_account_id":2463,"name":"Florian Haas","email":"florian.haas@cleura.com","username":"fghaas"},"change_message_id":"50842303eb6b284da5e55ae9aa8cdb512536e7b3","unresolved":false,"context_lines":[{"line_number":1686,"context_line":"storage the server will be rebuilt using the original glance image preserving"},{"line_number":1687,"context_line":"the ports and any attached data volumes."},{"line_number":1688,"context_line":""},{"line_number":1689,"context_line":"If the server uses a boot for volume or other root disk on shared storage the"},{"line_number":1690,"context_line":"root disk will be preserved and reused for the resurrected instnace on the new"},{"line_number":1691,"context_line":"host.\"\"\")"},{"line_number":1692,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_7ea36b9f","line":1689,"updated":"2019-05-23 12:56:28.000000000","message":"\"boot from volume\"?","commit_id":"e60a585e30692dfadd7d264657626d768f1960f9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f2fd46802654ee61534469ffcdacf7e6634e8156","unresolved":false,"context_lines":[{"line_number":1686,"context_line":"storage the server will be rebuilt using the original glance image preserving"},{"line_number":1687,"context_line":"the ports and any attached data volumes."},{"line_number":1688,"context_line":""},{"line_number":1689,"context_line":"If the server uses a boot for volume or other root disk on shared storage the"},{"line_number":1690,"context_line":"root disk will be preserved and reused for the resurrected instnace on the new"},{"line_number":1691,"context_line":"host.\"\"\")"},{"line_number":1692,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_a43a3431","line":1689,"in_reply_to":"bfb3d3c7_7ea36b9f","updated":"2019-05-23 14:29:35.000000000","message":"Done","commit_id":"e60a585e30692dfadd7d264657626d768f1960f9"},{"author":{"_account_id":2463,"name":"Florian Haas","email":"florian.haas@cleura.com","username":"fghaas"},"change_message_id":"50842303eb6b284da5e55ae9aa8cdb512536e7b3","unresolved":false,"context_lines":[{"line_number":1687,"context_line":"the ports and any attached data volumes."},{"line_number":1688,"context_line":""},{"line_number":1689,"context_line":"If the server uses a boot for volume or other root disk on shared storage the"},{"line_number":1690,"context_line":"root disk will be preserved and reused for the resurrected instnace on the new"},{"line_number":1691,"context_line":"host.\"\"\")"},{"line_number":1692,"context_line":""},{"line_number":1693,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_3eadf387","line":1690,"updated":"2019-05-23 12:56:28.000000000","message":"Typo (\"instnace\")","commit_id":"e60a585e30692dfadd7d264657626d768f1960f9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f2fd46802654ee61534469ffcdacf7e6634e8156","unresolved":false,"context_lines":[{"line_number":1687,"context_line":"the ports and any attached data volumes."},{"line_number":1688,"context_line":""},{"line_number":1689,"context_line":"If the server uses a boot for volume or other root disk on shared storage the"},{"line_number":1690,"context_line":"root disk will be preserved and reused for the resurrected instnace on the new"},{"line_number":1691,"context_line":"host.\"\"\")"},{"line_number":1692,"context_line":""},{"line_number":1693,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_843ff023","line":1690,"in_reply_to":"bfb3d3c7_3eadf387","updated":"2019-05-23 14:29:35.000000000","message":"Done","commit_id":"e60a585e30692dfadd7d264657626d768f1960f9"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"fe7b0a19c13e4d764af6909c0903ae567598c703","unresolved":false,"context_lines":[{"line_number":1705,"context_line":"        parser.add_argument("},{"line_number":1706,"context_line":"            \u0027--host\u0027, metavar\u003d\u0027\u003chost\u003e\u0027, default\u003dNone,"},{"line_number":1707,"context_line":"            help\u003d_(\"Set the preferred host on which to resurrect the server, \""},{"line_number":1708,"context_line":"                   \"note the host will be validated by the scheduler. \""},{"line_number":1709,"context_line":"                   \"This is only supported with --os-compute-api-version \""},{"line_number":1710,"context_line":"                   \"2.29 or greater\"),"},{"line_number":1711,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":7,"id":"bfb3d3c7_ca70580b","line":1708,"updated":"2019-05-28 13:12:42.000000000","message":"Micro-nit: I suggest splitting into two sentences: \n\n\u003e [...] on which to resurrect the server. Note that the host [...]\n\nActually the \"Note that\" could even be dropped, e.g.\n\n\u003e [...] on which to resurrect the server. The host [...]","commit_id":"54332d98017a4573d71b77c2a8eac7965b908191"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b90db56e203e3a36dcd62b8213bead480de52283","unresolved":false,"context_lines":[{"line_number":1717,"context_line":"            \u0027--shared-storage\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027shared_storage\u0027,"},{"line_number":1718,"context_line":"            help\u003d_(\"Indicate that the instance is on shared storage. \""},{"line_number":1719,"context_line":"                   \"This will be auto-calculated with \""},{"line_number":1720,"context_line":"                   \"--os-compute-api-version 2.13 and greater and should not \""},{"line_number":1721,"context_line":"                   \"be used with later micro versions\"),"},{"line_number":1722,"context_line":"        )"},{"line_number":1723,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f621f24_4a6ea395","line":1720,"range":{"start_line":1720,"start_character":45,"end_line":1720,"end_character":49},"updated":"2020-11-02 17:08:45.000000000","message":"2.14 and greater\n\n(2.13 is okay, 2.14 is not)","commit_id":"54332d98017a4573d71b77c2a8eac7965b908191"}],"openstackclient/tests/unit/compute/v2/test_server.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5eb75a79e52e78e938f97d663f8cde17e93d8292","unresolved":false,"context_lines":[{"line_number":2830,"context_line":"class TestServerRecreate(TestServer):"},{"line_number":2831,"context_line":""},{"line_number":2832,"context_line":"    def setUp(self):"},{"line_number":2833,"context_line":"        super().setUp()"},{"line_number":2834,"context_line":"        # Return value for utils.find_resource for image"},{"line_number":2835,"context_line":"        self.image \u003d image_fakes.FakeImage.create_one_image()"},{"line_number":2836,"context_line":"        self.images_mock.get.return_value \u003d self.image"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_3253783b","line":2833,"range":{"start_line":2833,"start_character":8,"end_line":2833,"end_character":23},"updated":"2019-03-15 16:11:58.000000000","message":"this is python3 only apparently\nwithout the backport from the futures module.\nill respin with the old form.","commit_id":"7511a144f6f7b4d5aabc5d8738976c5cda356640"}]}