)]}'
{"openstackclient/tests/functional/volume/v2/test_volume.py":[{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"ea48d1081db79bb14e9289c4ff85f741bbc4ef52","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        self.wait_for_status(\"volume\", volume_name, \"available\")"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        # Add cleanup before asserts in case delete of any volume/snapshot fail"},{"line_number":222,"context_line":"        self.addCleanup(self.openstack(\u0027volume delete \u0027"},{"line_number":223,"context_line":"                                       + volume_from_snap_name,"},{"line_number":224,"context_line":"                                       fail_ok\u003dTrue))"},{"line_number":225,"context_line":"        self.addCleanup(self.openstack(\u0027volume snapshot delete\u0027"},{"line_number":226,"context_line":"                                       + snapshot_name,"},{"line_number":227,"context_line":"                                       fail_ok\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":22,"id":"ffb9cba7_244a1527","line":224,"range":{"start_line":222,"start_character":0,"end_line":224,"end_character":53},"updated":"2019-04-22 20:50:23.000000000","message":"I think this should be:\n\nself.addCleanup(self.openstack, \u0027volume delete \u0027 + volume_from_snap_name, fail_ok\u003dTrue)\n\nWith how this is written, it looks like the self.openstack method is being invoked immediately instead of queued for later.","commit_id":"0479e3c7456bc2e8f9ffb62ebfa1271e95434f48"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d1b67d5c0308f3b070a5f09a5a8518b3e8baf52a","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        # Add cleanup before asserts in case delete of any volume/snapshot fail"},{"line_number":214,"context_line":"        self.addCleanup(self.openstack, \u0027volume delete \u0027"},{"line_number":215,"context_line":"                        + volume_from_snap_name,"},{"line_number":216,"context_line":"                        fail_ok\u003dTrue)"},{"line_number":217,"context_line":"        self.addCleanup(self.openstack, \u0027volume snapshot delete \u0027"},{"line_number":218,"context_line":"                        + snapshot_name,"},{"line_number":219,"context_line":"                        fail_ok\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":30,"id":"dfbec78f_f297a38f","line":216,"updated":"2019-05-09 01:08:28.000000000","message":"Do we really need this?\nL.258-271 handles deletions of volumes and snapshot.\n\nIf it is really needed, functions registered by addCleanup will be called in LIFO order [1], so I think L.220 should be registered first as it needs to be called last.\n\n[1] https://docs.python.org/3/library/unittest.html#unittest.TestCase.addCleanup","commit_id":"1f52c96f23b45a9ae72ea99b51550935bcf18cdc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d1b67d5c0308f3b070a5f09a5a8518b3e8baf52a","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        #  child volume before deleting the snapshot it is"},{"line_number":263,"context_line":"        #  dependent upon."},{"line_number":264,"context_line":"        child_delete_output \u003d self.openstack(\u0027volume delete \u0027"},{"line_number":265,"context_line":"                                             + volume_from_snap_name)"},{"line_number":266,"context_line":"        self.assertOutput(\u0027\u0027, child_delete_output)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        # Delete snapshot"}],"source_content_type":"text/x-python","patch_set":30,"id":"dfbec78f_72e97318","line":265,"updated":"2019-05-09 01:08:28.000000000","message":"Consider using wait_for_delete (as L.275 does)","commit_id":"1f52c96f23b45a9ae72ea99b51550935bcf18cdc"}]}