)]}'
{"openstackclient/compute/v2/server.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"623c63fa47b26bcd900f864a8c0f5fe498c90b6c","unresolved":false,"context_lines":[{"line_number":618,"context_line":"            help\u003d_(\u0027Hints for the scheduler (optional extension)\u0027),"},{"line_number":619,"context_line":"        )"},{"line_number":620,"context_line":"        parser.add_argument("},{"line_number":621,"context_line":"            \u0027--config-drive\u0027,"},{"line_number":622,"context_line":"            # TODO(mriedem): This should use action\u003d\u0027store_true\u0027 in a major"},{"line_number":623,"context_line":"            # version release so we can drop nargs/const/default."},{"line_number":624,"context_line":"            nargs\u003d\u0027?\u0027,  # 0 or 1 argument for this option for backward compat"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_832842e2","line":621,"updated":"2019-04-17 08:35:21.000000000","message":"Instead of modifying this option in a confusing way, how about just deprecating it and adding a new option named differently, like \"--create-config-drive\"? I\u0027d like that better than arguments getting possibly ignored because they are gobbled up unexpectedly by this nargs\u003d?.","commit_id":"b0e0d6fe54213147dd9089c388a87d0b9a7cd2ff"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"56bcf2c837f6c941ec186cb59133b368a7fee472","unresolved":false,"context_lines":[{"line_number":618,"context_line":"            help\u003d_(\u0027Hints for the scheduler (optional extension)\u0027),"},{"line_number":619,"context_line":"        )"},{"line_number":620,"context_line":"        parser.add_argument("},{"line_number":621,"context_line":"            \u0027--config-drive\u0027,"},{"line_number":622,"context_line":"            # TODO(mriedem): This should use action\u003d\u0027store_true\u0027 in a major"},{"line_number":623,"context_line":"            # version release so we can drop nargs/const/default."},{"line_number":624,"context_line":"            nargs\u003d\u0027?\u0027,  # 0 or 1 argument for this option for backward compat"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_219383fc","line":621,"in_reply_to":"3fce034c_832842e2","updated":"2019-04-17 13:28:07.000000000","message":"This is just temporary so I\u0027d like to avoid adding a new --create-config-drive option when what we really want long-term is --config-drive (like the nova CLI). As noted this can all go away in the next major version bump.","commit_id":"b0e0d6fe54213147dd9089c388a87d0b9a7cd2ff"}],"openstackclient/tests/unit/compute/v2/test_server.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"08a8994292400817559c50fbfbeec616b3d4f8ae","unresolved":false,"context_lines":[{"line_number":905,"context_line":"            \u0027--nic\u0027, \u0027auto\u0027,"},{"line_number":906,"context_line":"            # Test that --config-drive without an arg defaults to True"},{"line_number":907,"context_line":"            # FIXME(mriedem): This doesn\u0027t work and results in a parsing error"},{"line_number":908,"context_line":"            # \u0027--config-drive\u0027,"},{"line_number":909,"context_line":"            self.new_server.name,"},{"line_number":910,"context_line":"        ]"},{"line_number":911,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_de7fb3dd","line":908,"range":{"start_line":908,"start_character":0,"end_line":908,"end_character":31},"updated":"2019-05-01 14:37:38.000000000","message":"This fails because --config-drive is the last option and nargs consumes the following positional as the option argument.  This is why nargs is evil except when it is less evil than breaking a lot of things.  We\u0027ll only break a few things.\n\nMoving --config-drive to not be the last option will fix this test (plus changing the values below).","commit_id":"b0e0d6fe54213147dd9089c388a87d0b9a7cd2ff"}]}