)]}'
{"id":"openstack%2Fpython-openstackclient~653176","triplet_id":"openstack%2Fpython-openstackclient~master~Ibb7b6a2c84088b9cf68f101b3a3c035db5d047bc","project":"openstack/python-openstackclient","branch":"master","topic":"story/2005468","hashtags":[],"change_id":"Ibb7b6a2c84088b9cf68f101b3a3c035db5d047bc","subject":"WIP: Fix openstack server create --config-drive value","status":"ABANDONED","created":"2019-04-16 23:50:44.000000000","updated":"2019-08-20 21:41:55.000000000","total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4a378df218d59d202e3431370100fa16af36f5c3","_number":653176,"virtual_id_number":653176,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2019-04-17 08:35:21.000000000","_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"date":"2019-04-17 13:28:07.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"date":"2019-05-01 14:37:38.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":-1,"date":"2019-04-17 02:08:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-17 02:08:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-04-17 08:35:21.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2019-05-01 14:37:38.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"}],"messages":[{"id":"8a6bc5b15d91b7343b038d3d97dcdb99de44905e","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-16 23:50:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dc5da2b0b1274b760a224bf3489f289f062e3924","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-17 02:08:48.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstackclient-check-plugins http://logs.openstack.org/76/653176/1/check/openstackclient-check-plugins/4cebc68/ : SUCCESS in 6m 33s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/76/653176/1/check/osc-tox-py27-tips/06baff1/ : SUCCESS in 6m 52s\n- osc-tox-py35-tips http://logs.openstack.org/76/653176/1/check/osc-tox-py35-tips/4943cb8/ : SUCCESS in 7m 06s\n- openstack-tox-cover http://logs.openstack.org/76/653176/1/check/openstack-tox-cover/82f11e9/cover/ : SUCCESS in 5m 42s\n- openstack-tox-lower-constraints http://logs.openstack.org/76/653176/1/check/openstack-tox-lower-constraints/8c6480b/ : SUCCESS in 6m 00s\n- openstack-tox-pep8 http://logs.openstack.org/76/653176/1/check/openstack-tox-pep8/12c1510/ : SUCCESS in 5m 21s\n- openstack-tox-py27 http://logs.openstack.org/76/653176/1/check/openstack-tox-py27/b8e7b95/ : SUCCESS in 10m 16s\n- openstack-tox-py35 http://logs.openstack.org/76/653176/1/check/openstack-tox-py35/5934e2b/ : SUCCESS in 6m 02s\n- openstack-tox-py36 http://logs.openstack.org/76/653176/1/check/openstack-tox-py36/3cf24fa/ : SUCCESS in 6m 13s\n- openstack-tox-py37 http://logs.openstack.org/76/653176/1/check/openstack-tox-py37/6729ec1/ : SUCCESS in 7m 00s\n- openstack-tox-docs http://logs.openstack.org/76/653176/1/check/openstack-tox-docs/b2196fa/html/ : SUCCESS in 5m 46s\n- tempest-full http://logs.openstack.org/76/653176/1/check/tempest-full/6072593/ : SUCCESS in 1h 44m 11s\n- tempest-full-py3 http://logs.openstack.org/76/653176/1/check/tempest-full-py3/0feb799/ : SUCCESS in 1h 52m 13s\n- osc-functional-devstack http://logs.openstack.org/76/653176/1/check/osc-functional-devstack/d0330d7/ : FAILURE in 53m 04s\n- osc-functional-devstack-tips http://logs.openstack.org/76/653176/1/check/osc-functional-devstack-tips/71405d8/ : SUCCESS in 59m 46s","accounts_in_message":[],"_revision_number":1},{"id":"623c63fa47b26bcd900f864a8c0f5fe498c90b6c","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-04-17 08:35:21.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"56bcf2c837f6c941ec186cb59133b368a7fee472","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-17 13:28:07.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"08a8994292400817559c50fbfbeec616b3d4f8ae","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-05-01 14:37:38.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nThe test failure illustrates the fundamental problem with nargs \u0027?\u0027 with both options and positional args.\n\nI think we can probably release note that behaviour as it is still backward-compatible and only requires re-arranging the options to work around it.  There should not be any issues going to OSC 4 other than the expected not accepting an argument.","accounts_in_message":[],"_revision_number":1},{"id":"dcf50fc98907b8f3b1ec44f087c6297709d80524","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-08-20 21:41:55.000000000","message":"Abandoned\n\nGiven how latent this is I\u0027m just going to consider it low priority and abandon for now since I\u0027m not spending the time to work on it. Maybe someone else wants to take a crack at cleaning this up in a sane way.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b0e0d6fe54213147dd9089c388a87d0b9a7cd2ff","revisions":{"b0e0d6fe54213147dd9089c388a87d0b9a7cd2ff":{"kind":"REWORK","_number":1,"created":"2019-04-16 23:50:44.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/76/653176/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/76/653176/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/76/653176/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/76/653176/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/76/653176/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/76/653176/1"}}},"commit":{"parents":[{"commit":"cac699d0d93d204d019bdcf53f66360d9296f3cf","subject":"Merge \"Tweak network segment range fiunction tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cac699d0d93d204d019bdcf53f66360d9296f3cf"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-04-16 23:47:13.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-04-16 23:47:13.000000000","tz":-240},"subject":"WIP: Fix openstack server create --config-drive value","message":"WIP: Fix openstack server create --config-drive value\n\nThe --config-drive value should be a boolean. The API definitely\ndoesn\u0027t accept a volume ID, which was likely a mistake propagated\nfrom the python-novaclient server.create API docstring introduced\nway back in 2012:\n\n  https://review.openstack.org/#/c/3994/\n\nIdeally we could just change --config-drive to a non-string\nboolean value using action\u003d\u0027store_true\u0027 but that would break any\nexisting scripts providing an argument to that option.\n\nTo maintain backward compatibility this changes the option to\nuse nargs\u003d\u0027?\u0027 to support not specifying an argument with the\noption, and in that case means \u0027True\u0027, otherwise if not specified\nstill defaults to \u0027False\u0027.\n\nChange-Id: Ibb7b6a2c84088b9cf68f101b3a3c035db5d047bc\nStory: #2005468\nTask: #30547\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b0e0d6fe54213147dd9089c388a87d0b9a7cd2ff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b0e0d6fe54213147dd9089c388a87d0b9a7cd2ff"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
