)]}'
{"id":"openstack%2Fpython-openstackclient~658190","triplet_id":"openstack%2Fpython-openstackclient~master~If722b860be4010b91635c6d46f634da980e17152","project":"openstack/python-openstackclient","branch":"master","hashtags":[],"change_id":"If722b860be4010b91635c6d46f634da980e17152","subject":"Stop leaving temp files after unit test runs","status":"MERGED","created":"2019-05-09 19:12:52.000000000","updated":"2019-05-15 22:49:04.000000000","submitted":"2019-05-15 22:49:04.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"658190-1557960544612-88673ecb","meta_rev_id":"deaa6662b75e0268e29e78af84d0775b59cedf33","_number":658190,"virtual_id_number":658190,"owner":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-05-15 22:49:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-05-11 06:49:22.000000000","_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":2,"date":"2019-05-15 21:07:07.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":1,"date":"2019-05-15 21:07:07.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-11 06:49:22.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2019-05-15 21:07:07.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2019-05-15 22:49:04.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6ad5102973de7d628417a36635be05b41f5c6573","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2019-05-09 19:12:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"165fb024de7d5b74d25a83d1281a8bc21d9c96d9","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2019-05-09 19:13:41.000000000","message":"Patch Set 1:\n\nI\u0027m open to other suggestions, but this does solve the issue.","accounts_in_message":[],"_revision_number":1},{"id":"d219249c816dd32ce7b19fce303b0db029b4d1f2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-09 21:14:44.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstackclient-check-plugins http://logs.openstack.org/90/658190/1/check/openstackclient-check-plugins/7c6ba4f/ : SUCCESS in 4m 45s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/90/658190/1/check/osc-tox-py27-tips/5db43c9/ : SUCCESS in 5m 36s\n- osc-tox-py36-tips http://logs.openstack.org/90/658190/1/check/osc-tox-py36-tips/9b5531e/ : SUCCESS in 5m 22s\n- openstack-tox-cover http://logs.openstack.org/90/658190/1/check/openstack-tox-cover/4675c04/cover/ : SUCCESS in 5m 27s\n- openstack-tox-lower-constraints http://logs.openstack.org/90/658190/1/check/openstack-tox-lower-constraints/e489659/ : SUCCESS in 7m 37s\n- openstack-tox-pep8 http://logs.openstack.org/90/658190/1/check/openstack-tox-pep8/5e67e2d/ : FAILURE in 5m 07s\n- openstack-tox-py27 http://logs.openstack.org/90/658190/1/check/openstack-tox-py27/f62f9a8/ : SUCCESS in 4m 38s\n- openstack-tox-py36 http://logs.openstack.org/90/658190/1/check/openstack-tox-py36/4f13cd4/ : SUCCESS in 4m 49s\n- openstack-tox-py37 http://logs.openstack.org/90/658190/1/check/openstack-tox-py37/bd04a11/ : SUCCESS in 4m 47s\n- openstack-tox-docs http://logs.openstack.org/90/658190/1/check/openstack-tox-docs/4f93c69/html/ : SUCCESS in 5m 02s\n- tempest-full http://logs.openstack.org/90/658190/1/check/tempest-full/4317ba0/ : SUCCESS in 1h 55m 36s\n- tempest-full-py3 http://logs.openstack.org/90/658190/1/check/tempest-full-py3/3a75295/ : FAILURE in 1h 23m 16s\n- osc-functional-devstack http://logs.openstack.org/90/658190/1/check/osc-functional-devstack/4733e71/ : SUCCESS in 57m 43s\n- osc-functional-devstack-tips http://logs.openstack.org/90/658190/1/check/osc-functional-devstack-tips/ff17568/ : SUCCESS in 57m 06s","accounts_in_message":[],"_revision_number":1},{"id":"23b7453d75b7a485cde36e048be10a9a4bd144a3","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2019-05-10 00:46:55.000000000","message":"Patch Set 1:\n\nSeems bandit update is tripping up this repo now too","accounts_in_message":[],"_revision_number":1},{"id":"92e5154b292210b0db8775bcd9ae6aaf00ed562d","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2019-05-10 15:47:09.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"4fdf3d3f400d2fdbf2f980662a3ab5ed309694fe","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-10 17:40:23.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins http://logs.openstack.org/90/658190/2/check/openstackclient-check-plugins/e1ae377/ : SUCCESS in 4m 47s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/90/658190/2/check/osc-tox-py27-tips/16c8cda/ : SUCCESS in 5m 46s\n- osc-tox-py36-tips http://logs.openstack.org/90/658190/2/check/osc-tox-py36-tips/c9fb83b/ : SUCCESS in 5m 35s\n- openstack-tox-cover http://logs.openstack.org/90/658190/2/check/openstack-tox-cover/ec869cc/cover/ : SUCCESS in 6m 46s\n- openstack-tox-lower-constraints http://logs.openstack.org/90/658190/2/check/openstack-tox-lower-constraints/5777b95/ : SUCCESS in 7m 22s\n- openstack-tox-pep8 http://logs.openstack.org/90/658190/2/check/openstack-tox-pep8/18b50d5/ : SUCCESS in 4m 41s\n- openstack-tox-py27 http://logs.openstack.org/90/658190/2/check/openstack-tox-py27/9a7929c/ : SUCCESS in 4m 23s\n- openstack-tox-py36 http://logs.openstack.org/90/658190/2/check/openstack-tox-py36/27dcc0a/ : SUCCESS in 4m 35s\n- openstack-tox-py37 http://logs.openstack.org/90/658190/2/check/openstack-tox-py37/118d507/ : SUCCESS in 4m 52s\n- openstack-tox-docs http://logs.openstack.org/90/658190/2/check/openstack-tox-docs/7d8bfd6/html/ : SUCCESS in 5m 29s\n- tempest-full http://logs.openstack.org/90/658190/2/check/tempest-full/d97b0fc/ : SUCCESS in 1h 42m 56s\n- tempest-full-py3 http://logs.openstack.org/90/658190/2/check/tempest-full-py3/04cef0c/ : SUCCESS in 1h 36m 16s\n- osc-functional-devstack http://logs.openstack.org/90/658190/2/check/osc-functional-devstack/af4b1e4/ : SUCCESS in 53m 03s\n- osc-functional-devstack-tips http://logs.openstack.org/90/658190/2/check/osc-functional-devstack-tips/057788b/ : SUCCESS in 53m 02s","accounts_in_message":[],"_revision_number":2},{"id":"df7a27a087b4851c466d047c09d6bf7a97cf7798","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2019-05-11 06:49:22.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"b313318f0d871527fa80dfa1df114aebf63bf363","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-05-15 21:07:07.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nNice!  Thank you","accounts_in_message":[],"_revision_number":2},{"id":"ada8b490d1d25afb6b6deca204266a387502a9b2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-15 21:07:19.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"189ad6cf013915d01251543cbc40398b3cd1f557","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-15 22:49:04.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- osc-tox-py27-tips http://logs.openstack.org/90/658190/2/gate/osc-tox-py27-tips/713ce05/ : SUCCESS in 5m 42s\n- osc-tox-py36-tips http://logs.openstack.org/90/658190/2/gate/osc-tox-py36-tips/1f68ebc/ : SUCCESS in 5m 43s\n- openstack-tox-lower-constraints http://logs.openstack.org/90/658190/2/gate/openstack-tox-lower-constraints/5ff9913/ : SUCCESS in 5m 15s\n- openstack-tox-pep8 http://logs.openstack.org/90/658190/2/gate/openstack-tox-pep8/cb33ea2/ : SUCCESS in 5m 06s\n- openstack-tox-py27 http://logs.openstack.org/90/658190/2/gate/openstack-tox-py27/aff7a49/ : SUCCESS in 4m 32s\n- openstack-tox-py36 http://logs.openstack.org/90/658190/2/gate/openstack-tox-py36/90dff71/ : SUCCESS in 4m 43s\n- openstack-tox-py37 http://logs.openstack.org/90/658190/2/gate/openstack-tox-py37/258a8f9/ : SUCCESS in 4m 45s\n- openstack-tox-docs http://logs.openstack.org/90/658190/2/gate/openstack-tox-docs/a39cedd/html/ : SUCCESS in 5m 04s\n- tempest-full http://logs.openstack.org/90/658190/2/gate/tempest-full/02dd1b0/ : SUCCESS in 1h 36m 31s\n- tempest-full-py3 http://logs.openstack.org/90/658190/2/gate/tempest-full-py3/37831fb/ : SUCCESS in 1h 29m 33s\n- osc-functional-devstack http://logs.openstack.org/90/658190/2/gate/osc-functional-devstack/a3082a7/ : SUCCESS in 52m 01s","accounts_in_message":[],"_revision_number":2},{"id":"deaa6662b75e0268e29e78af84d0775b59cedf33","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-15 22:49:04.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4b91cd49658bd5a9224976ebd3a6f352d1eef5b0","revisions":{"187426bbde086fbc350029c1cd5ef1333351341c":{"kind":"REWORK","_number":1,"created":"2019-05-09 19:12:52.000000000","uploader":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"ref":"refs/changes/90/658190/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/90/658190/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/658190/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/658190/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/658190/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/90/658190/1"}}},"commit":{"parents":[{"commit":"ba66cdfcfac323ada3c2689bed001fc9c1a2869d","subject":"Merge \"Fix --limit option in image list sub-command\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ba66cdfcfac323ada3c2689bed001fc9c1a2869d"}]}],"author":{"name":"Brian Haley","email":"bhaley@redhat.com","date":"2019-05-09 19:08:54.000000000","tz":-240},"committer":{"name":"Brian Haley","email":"bhaley@redhat.com","date":"2019-05-09 19:08:54.000000000","tz":-240},"subject":"Stop leaving temp files after unit test runs","message":"Stop leaving temp files after unit test runs\n\ntest_shell.CLOUD_2 is using an absolute path for a temp\nfile, so leaves /tmp/test_log_file around after the unit\ntests are run.  Use a fixture instead so it\u0027s cleaned\nautomatically, which also removes the possibility of two\ntests using the same file and interfering with each other.\n\nChange-Id: If722b860be4010b91635c6d46f634da980e17152\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/187426bbde086fbc350029c1cd5ef1333351341c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/187426bbde086fbc350029c1cd5ef1333351341c"}]},"branch":"refs/heads/master"},"4b91cd49658bd5a9224976ebd3a6f352d1eef5b0":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-05-10 15:47:09.000000000","uploader":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"ref":"refs/changes/90/658190/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/90/658190/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/658190/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/658190/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/658190/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/90/658190/2"}}},"commit":{"parents":[{"commit":"1bc44fcdc6c96bbffdd70c57f6cb11b5c1278071","subject":"Merge \"document the --timing option\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/1bc44fcdc6c96bbffdd70c57f6cb11b5c1278071"}]}],"author":{"name":"Brian Haley","email":"bhaley@redhat.com","date":"2019-05-09 19:08:54.000000000","tz":-240},"committer":{"name":"Brian Haley","email":"haleyb.dev@gmail.com","date":"2019-05-10 15:47:09.000000000","tz":0},"subject":"Stop leaving temp files after unit test runs","message":"Stop leaving temp files after unit test runs\n\ntest_shell.CLOUD_2 is using an absolute path for a temp\nfile, so leaves /tmp/test_log_file around after the unit\ntests are run.  Use a fixture instead so it\u0027s cleaned\nautomatically, which also removes the possibility of two\ntests using the same file and interfering with each other.\n\nChange-Id: If722b860be4010b91635c6d46f634da980e17152\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4b91cd49658bd5a9224976ebd3a6f352d1eef5b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4b91cd49658bd5a9224976ebd3a6f352d1eef5b0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}