)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d079497bf2d36f56065a69e653e7cb8515a189a6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"WIP: Deprecate openstack server migrate --host option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Per the discussion at the Train Forum [1] this deprecates"},{"line_number":10,"context_line":"the problematic --host option on the server migrate command"},{"line_number":11,"context_line":"which, depending on the compute API version used, forcefully"},{"line_number":12,"context_line":"bypasses the scheduler and also does not allow you to live"},{"line_number":13,"context_line":"migrate a server and let the scheduler pick a host."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfb3d3c7_d98aa619","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":22},"updated":"2019-05-23 23:30:59.000000000","message":"live","commit_id":"68047a22397ec428e1c1a4772378492e6beb919a"}],"openstackclient/compute/v2/server.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"a1a913e3b487f97a1ec791f9269d4a6fe28f607e","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"            metavar\u003d\u0027\u003cserver\u003e\u0027,"},{"line_number":1407,"context_line":"            help\u003d_(\u0027Server (name or ID)\u0027),"},{"line_number":1408,"context_line":"        )"},{"line_number":1409,"context_line":"        # TODO(mriedem): Remove --live in 4.0."},{"line_number":1410,"context_line":"        parser.add_argument("},{"line_number":1411,"context_line":"            # Deprecated in favor of --live-migration + --host."},{"line_number":1412,"context_line":"            \u0027--live\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_5842dbac","line":1409,"updated":"2019-05-16 04:14:52.000000000","message":"We usually have said next major version but at least 6 months before removing stuff, so this would not come out in 4.0.  I really do not have a feel for how much of an impact that would have on users to take it out in 4.0, I am open to thoughts here...","commit_id":"68047a22397ec428e1c1a4772378492e6beb919a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d079497bf2d36f56065a69e653e7cb8515a189a6","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"            metavar\u003d\u0027\u003cserver\u003e\u0027,"},{"line_number":1407,"context_line":"            help\u003d_(\u0027Server (name or ID)\u0027),"},{"line_number":1408,"context_line":"        )"},{"line_number":1409,"context_line":"        # TODO(mriedem): Remove --live in 4.0."},{"line_number":1410,"context_line":"        parser.add_argument("},{"line_number":1411,"context_line":"            # Deprecated in favor of --live-migration + --host."},{"line_number":1412,"context_line":"            \u0027--live\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_b9cfb2ae","line":1409,"in_reply_to":"bfb3d3c7_28268bb9","updated":"2019-05-23 23:30:59.000000000","message":"Done","commit_id":"68047a22397ec428e1c1a4772378492e6beb919a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"07f70af837e536cba69122f292685a8600024b01","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"            metavar\u003d\u0027\u003cserver\u003e\u0027,"},{"line_number":1407,"context_line":"            help\u003d_(\u0027Server (name or ID)\u0027),"},{"line_number":1408,"context_line":"        )"},{"line_number":1409,"context_line":"        # TODO(mriedem): Remove --live in 4.0."},{"line_number":1410,"context_line":"        parser.add_argument("},{"line_number":1411,"context_line":"            # Deprecated in favor of --live-migration + --host."},{"line_number":1412,"context_line":"            \u0027--live\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_20280095","line":1409,"in_reply_to":"dfbec78f_5842dbac","updated":"2019-05-16 17:03:06.000000000","message":"\u003e We usually have said next major version but at least 6 months\n \u003e before removing stuff, so this would not come out in 4.0.  I really\n \u003e do not have a feel for how much of an impact that would have on\n \u003e users to take it out in 4.0, I am open to thoughts here...\n\nOK so how about \"next major version bump after the Train release\"? I guess I didn\u0027t think about it but yeah we have the same policy in novaclient, full server side release boundary before removing deprecated things.","commit_id":"68047a22397ec428e1c1a4772378492e6beb919a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d565250c7b0f0a566abf488fcbdc7d007193fdbd","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"            metavar\u003d\u0027\u003cserver\u003e\u0027,"},{"line_number":1407,"context_line":"            help\u003d_(\u0027Server (name or ID)\u0027),"},{"line_number":1408,"context_line":"        )"},{"line_number":1409,"context_line":"        # TODO(mriedem): Remove --live in 4.0."},{"line_number":1410,"context_line":"        parser.add_argument("},{"line_number":1411,"context_line":"            # Deprecated in favor of --live-migration + --host."},{"line_number":1412,"context_line":"            \u0027--live\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_ec9ae85f","line":1409,"in_reply_to":"dfbec78f_5842dbac","updated":"2019-05-16 13:00:49.000000000","message":"I brought this up on the mailing list but, with 4.0 being a major version (meaning breaking changes are a thing), couldn\u0027t we just change the behavior of the \u0027--live\u0027 flag altogether and make it a boolean? That seems a heck of a lot cleaner than \u0027server migrate --live-migration\u0027 (\u0027-migration\u0027 is wholly unnecessary)","commit_id":"68047a22397ec428e1c1a4772378492e6beb919a"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"b503d5d5fc6c2e696459419927e57cfccfb2f999","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"            metavar\u003d\u0027\u003cserver\u003e\u0027,"},{"line_number":1407,"context_line":"            help\u003d_(\u0027Server (name or ID)\u0027),"},{"line_number":1408,"context_line":"        )"},{"line_number":1409,"context_line":"        # TODO(mriedem): Remove --live in 4.0."},{"line_number":1410,"context_line":"        parser.add_argument("},{"line_number":1411,"context_line":"            # Deprecated in favor of --live-migration + --host."},{"line_number":1412,"context_line":"            \u0027--live\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_28268bb9","line":1409,"in_reply_to":"dfbec78f_8039acf2","updated":"2019-05-16 17:52:52.000000000","message":"What I liked about using --live-migrate was that it is completely backward-compatible and --live can just fade away in time.  --live is the better name though.\n\nSo how about this:  deprecate --live and add --live-migrate (basically what you have here) now, down the road (osc5 or whenever) we can change --live to be an alias for --live-migrate.\n\nI don\u0027t expect major releases to be so rare in the future.  Not every cycle but much sooner than 2.5 years.","commit_id":"68047a22397ec428e1c1a4772378492e6beb919a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"07f70af837e536cba69122f292685a8600024b01","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"            metavar\u003d\u0027\u003cserver\u003e\u0027,"},{"line_number":1407,"context_line":"            help\u003d_(\u0027Server (name or ID)\u0027),"},{"line_number":1408,"context_line":"        )"},{"line_number":1409,"context_line":"        # TODO(mriedem): Remove --live in 4.0."},{"line_number":1410,"context_line":"        parser.add_argument("},{"line_number":1411,"context_line":"            # Deprecated in favor of --live-migration + --host."},{"line_number":1412,"context_line":"            \u0027--live\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_8039acf2","line":1409,"in_reply_to":"dfbec78f_c7a9ff8f","updated":"2019-05-16 17:03:06.000000000","message":"I was wondering if this exists as an option for backports, however, backporting something that (1) adds new options, even if they aren\u0027t required and (2) deprecates options is generally a no-go on stable branches. That\u0027s part of the reason I wanted to get something out pre-4.0 major change, which at a minimum is this, and it has the deprecation signaling.\n\nThis could be potentially split into (1) adding new options for the better usage which is maybe backportable as a bug fix and then (2) leave the deprecation of --live on master for the 3.x cut before 4.0, but it\u0027s not a huge deal to me. But I think we should get the fix and deprecation out before the 4.0 release because I (a) don\u0027t want to hold this longer waiting for the major release and (b) don\u0027t want to make people upgrade all of their scripts for 4.0 changes just to get this fix.","commit_id":"68047a22397ec428e1c1a4772378492e6beb919a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cfb6e31fe5f54035cfc0380f2adbfd3fb3748775","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"            metavar\u003d\u0027\u003cserver\u003e\u0027,"},{"line_number":1407,"context_line":"            help\u003d_(\u0027Server (name or ID)\u0027),"},{"line_number":1408,"context_line":"        )"},{"line_number":1409,"context_line":"        # TODO(mriedem): Remove --live in 4.0."},{"line_number":1410,"context_line":"        parser.add_argument("},{"line_number":1411,"context_line":"            # Deprecated in favor of --live-migration + --host."},{"line_number":1412,"context_line":"            \u0027--live\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_c7a9ff8f","line":1409,"in_reply_to":"dfbec78f_ec0f4885","updated":"2019-05-16 13:40:50.000000000","message":"Given that this has been broken for a very long time now and that we have an alternative (via python-novaclient) I don\u0027t _personally_ think this is a big deal, but that\u0027s just me :)","commit_id":"68047a22397ec428e1c1a4772378492e6beb919a"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6c77296c6e99053399165deb4834b268a7fcbc0f","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"            metavar\u003d\u0027\u003cserver\u003e\u0027,"},{"line_number":1407,"context_line":"            help\u003d_(\u0027Server (name or ID)\u0027),"},{"line_number":1408,"context_line":"        )"},{"line_number":1409,"context_line":"        # TODO(mriedem): Remove --live in 4.0."},{"line_number":1410,"context_line":"        parser.add_argument("},{"line_number":1411,"context_line":"            # Deprecated in favor of --live-migration + --host."},{"line_number":1412,"context_line":"            \u0027--live\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_ec0f4885","line":1409,"in_reply_to":"dfbec78f_ec9ae85f","updated":"2019-05-16 13:09:50.000000000","message":"We could do that, it would mean holding this entire change for a while longer.  Normally there would have needed to be a deprecation period warning of the change, again I am unsure of the impact on the user community of an abrupt change here.","commit_id":"68047a22397ec428e1c1a4772378492e6beb919a"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"a1a913e3b487f97a1ec791f9269d4a6fe28f607e","unresolved":false,"context_lines":[{"line_number":1416,"context_line":"        # TODO(mriedem): Do we need to put --live and --live-migration in"},{"line_number":1417,"context_line":"        # a mutually exclusive group? Or should we just manually check if both"},{"line_number":1418,"context_line":"        # are specified and fail?"},{"line_number":1419,"context_line":"        parser.add_argument("},{"line_number":1420,"context_line":"            \u0027--live-migration\u0027,"},{"line_number":1421,"context_line":"            dest\u003d\u0027live_migration\u0027,"},{"line_number":1422,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_f8df0f0a","line":1419,"updated":"2019-05-16 04:14:52.000000000","message":"I usually use the mutex group unless that doesn\u0027t provide a useful error for the user for some reason.  In this case though you would have either --live or --live-migration + --host and I\u0027m not sure how to do that via argparse.","commit_id":"68047a22397ec428e1c1a4772378492e6beb919a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"07f70af837e536cba69122f292685a8600024b01","unresolved":false,"context_lines":[{"line_number":1416,"context_line":"        # TODO(mriedem): Do we need to put --live and --live-migration in"},{"line_number":1417,"context_line":"        # a mutually exclusive group? Or should we just manually check if both"},{"line_number":1418,"context_line":"        # are specified and fail?"},{"line_number":1419,"context_line":"        parser.add_argument("},{"line_number":1420,"context_line":"            \u0027--live-migration\u0027,"},{"line_number":1421,"context_line":"            dest\u003d\u0027live_migration\u0027,"},{"line_number":1422,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_e3043217","line":1419,"in_reply_to":"dfbec78f_f8df0f0a","updated":"2019-05-16 17:03:06.000000000","message":"I would like to avoid lumping --host in with --live-migration because we\u0027re going to want to build on this to make --host work for cold migration sans --live-migration as well for the 2.56 microversion. So I\u0027ll not try a mutex group.","commit_id":"68047a22397ec428e1c1a4772378492e6beb919a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"71cd758dcea49fd43cc2a87ea3637505e3ae3ee6","unresolved":false,"context_lines":[{"line_number":1482,"context_line":"            parsed_args.server,"},{"line_number":1483,"context_line":"        )"},{"line_number":1484,"context_line":"        # Check for live migration."},{"line_number":1485,"context_line":"        if parsed_args.live or parsed_args.live_migration:"},{"line_number":1486,"context_line":"            kwargs \u003d {"},{"line_number":1487,"context_line":"                \u0027block_migration\u0027: parsed_args.block_migration"},{"line_number":1488,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_0f53bb18","line":1485,"updated":"2019-05-15 22:14:49.000000000","message":"Per the TODO above, do we fail if both are specified? Or do we just process --live-migration over --live if both are specified? Seems we should be straight-forward and fail if both are specified.","commit_id":"68047a22397ec428e1c1a4772378492e6beb919a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d079497bf2d36f56065a69e653e7cb8515a189a6","unresolved":false,"context_lines":[{"line_number":1482,"context_line":"            parsed_args.server,"},{"line_number":1483,"context_line":"        )"},{"line_number":1484,"context_line":"        # Check for live migration."},{"line_number":1485,"context_line":"        if parsed_args.live or parsed_args.live_migration:"},{"line_number":1486,"context_line":"            kwargs \u003d {"},{"line_number":1487,"context_line":"                \u0027block_migration\u0027: parsed_args.block_migration"},{"line_number":1488,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_3950a2d4","line":1485,"in_reply_to":"bfb3d3c7_88b7773b","updated":"2019-05-23 23:30:59.000000000","message":"\u003e We usually remove deprecated options from the online help and mark them deprecated in the docs...with autodoc that isn\u0027t going to work out that way anymore...yeah, we\u0027ll need a note in the help\n\nOK just to be clear I should remove help\u003dargparse.SUPPRESS from the --live option so the help for that option shows up in both the docs and shell (is that what you\u0027re calling \"online help\"?), but make sure there is a deprecation note in the help. I had originally done that but then just suppressed the help on the --live option, I think I had seen that used somewhere else for a deprecated option...oh yeah here:\n\nhttps://github.com/openstack/python-openstackclient/blob/3.18.0/openstackclient/volume/v2/volume_transfer_request.py#L45\n\nBut maybe that\u0027s different because it\u0027s not using autodoc:\n\nhttps://github.com/openstack/python-openstackclient/blob/3.18.0/doc/source/cli/command-objects/volume-transfer-request.rst#volume-transfer-request-accept\n\n\u003e I don\u0027t think I have a strong feeling either way (priority vs fail) but in the deprecated stuff I\u0027ve been ripping out the last couple of days we had done the priority thing when renaming options.\n\nOK I\u0027ll follow suit and allow both but take --live-migration over --live if both are specified.","commit_id":"68047a22397ec428e1c1a4772378492e6beb919a"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"a1a913e3b487f97a1ec791f9269d4a6fe28f607e","unresolved":false,"context_lines":[{"line_number":1482,"context_line":"            parsed_args.server,"},{"line_number":1483,"context_line":"        )"},{"line_number":1484,"context_line":"        # Check for live migration."},{"line_number":1485,"context_line":"        if parsed_args.live or parsed_args.live_migration:"},{"line_number":1486,"context_line":"            kwargs \u003d {"},{"line_number":1487,"context_line":"                \u0027block_migration\u0027: parsed_args.block_migration"},{"line_number":1488,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_98f7f38b","line":1485,"in_reply_to":"dfbec78f_0f53bb18","updated":"2019-05-16 04:14:52.000000000","message":"Without the mutex group and when both options are present the \u0027new way\u0027 should have priority.","commit_id":"68047a22397ec428e1c1a4772378492e6beb919a"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"b503d5d5fc6c2e696459419927e57cfccfb2f999","unresolved":false,"context_lines":[{"line_number":1482,"context_line":"            parsed_args.server,"},{"line_number":1483,"context_line":"        )"},{"line_number":1484,"context_line":"        # Check for live migration."},{"line_number":1485,"context_line":"        if parsed_args.live or parsed_args.live_migration:"},{"line_number":1486,"context_line":"            kwargs \u003d {"},{"line_number":1487,"context_line":"                \u0027block_migration\u0027: parsed_args.block_migration"},{"line_number":1488,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_88b7773b","line":1485,"in_reply_to":"dfbec78f_602278bb","updated":"2019-05-16 17:52:52.000000000","message":"Deprecating --live should mean there is a warning any time it is used like you have below, except --host being present would otherwise ignore --live aside from the warning.  We usually remove deprecated options from the online help and mark them deprecated in the docs...with autodoc that isn\u0027t going to work out that way anymore...yeah, we\u0027ll need a note in the help\n\nI don\u0027t think I have a strong feeling either way (priority vs fail) but in the deprecated stuff I\u0027ve been ripping out the last couple of days we had done the priority thing when renaming options.","commit_id":"68047a22397ec428e1c1a4772378492e6beb919a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"07f70af837e536cba69122f292685a8600024b01","unresolved":false,"context_lines":[{"line_number":1482,"context_line":"            parsed_args.server,"},{"line_number":1483,"context_line":"        )"},{"line_number":1484,"context_line":"        # Check for live migration."},{"line_number":1485,"context_line":"        if parsed_args.live or parsed_args.live_migration:"},{"line_number":1486,"context_line":"            kwargs \u003d {"},{"line_number":1487,"context_line":"                \u0027block_migration\u0027: parsed_args.block_migration"},{"line_number":1488,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_602278bb","line":1485,"in_reply_to":"dfbec78f_98f7f38b","updated":"2019-05-16 17:03:06.000000000","message":"OK I can do that - and no failure? If not a failure if both are used, should I say something in the help for --live-migration that it takes priority over --live? I\u0027d just like to avoid ambiguity.","commit_id":"68047a22397ec428e1c1a4772378492e6beb919a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"71cd758dcea49fd43cc2a87ea3637505e3ae3ee6","unresolved":false,"context_lines":[{"line_number":1492,"context_line":"            # deprecated option is used and if so emit a warning."},{"line_number":1493,"context_line":"            if parsed_args.live:"},{"line_number":1494,"context_line":"                self.log.warning(_("},{"line_number":1495,"context_line":"                    \u0027The --live option has been deprecated. Please use the\u0027"},{"line_number":1496,"context_line":"                    \u0027--live-migration option instead.\u0027))"},{"line_number":1497,"context_line":"                kwargs[\u0027host\u0027] \u003d parsed_args.live"},{"line_number":1498,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_8f3ecbb5","line":1495,"range":{"start_line":1495,"start_character":74,"end_line":1495,"end_character":75},"updated":"2019-05-15 22:14:49.000000000","message":"need a space here","commit_id":"68047a22397ec428e1c1a4772378492e6beb919a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d079497bf2d36f56065a69e653e7cb8515a189a6","unresolved":false,"context_lines":[{"line_number":1492,"context_line":"            # deprecated option is used and if so emit a warning."},{"line_number":1493,"context_line":"            if parsed_args.live:"},{"line_number":1494,"context_line":"                self.log.warning(_("},{"line_number":1495,"context_line":"                    \u0027The --live option has been deprecated. Please use the\u0027"},{"line_number":1496,"context_line":"                    \u0027--live-migration option instead.\u0027))"},{"line_number":1497,"context_line":"                kwargs[\u0027host\u0027] \u003d parsed_args.live"},{"line_number":1498,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_59d0f61f","line":1495,"range":{"start_line":1495,"start_character":74,"end_line":1495,"end_character":75},"in_reply_to":"dfbec78f_8f3ecbb5","updated":"2019-05-23 23:30:59.000000000","message":"Done","commit_id":"68047a22397ec428e1c1a4772378492e6beb919a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"71cd758dcea49fd43cc2a87ea3637505e3ae3ee6","unresolved":false,"context_lines":[{"line_number":1507,"context_line":"                        api_versions.APIVersion(\u00272.30\u0027)):"},{"line_number":1508,"context_line":"                    raise exceptions.CommandError("},{"line_number":1509,"context_line":"                        \u0027--os-compute-api-version 2.30 or greater is required \u0027"},{"line_number":1510,"context_line":"                        \u0027when using --live-migration and --host\u0027)"},{"line_number":1511,"context_line":"                # The host parameter is required in the API even if None."},{"line_number":1512,"context_line":"                kwargs[\u0027host\u0027] \u003d parsed_args.host"},{"line_number":1513,"context_line":"            if compute_client.api_version \u003c api_versions.APIVersion(\u00272.25\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_0f7c1b81","line":1510,"range":{"start_line":1510,"start_character":36,"end_line":1510,"end_character":57},"updated":"2019-05-15 22:14:49.000000000","message":"could probably nix this since right now you can\u0027t use --host without doing a live migration","commit_id":"68047a22397ec428e1c1a4772378492e6beb919a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d079497bf2d36f56065a69e653e7cb8515a189a6","unresolved":false,"context_lines":[{"line_number":1507,"context_line":"                        api_versions.APIVersion(\u00272.30\u0027)):"},{"line_number":1508,"context_line":"                    raise exceptions.CommandError("},{"line_number":1509,"context_line":"                        \u0027--os-compute-api-version 2.30 or greater is required \u0027"},{"line_number":1510,"context_line":"                        \u0027when using --live-migration and --host\u0027)"},{"line_number":1511,"context_line":"                # The host parameter is required in the API even if None."},{"line_number":1512,"context_line":"                kwargs[\u0027host\u0027] \u003d parsed_args.host"},{"line_number":1513,"context_line":"            if compute_client.api_version \u003c api_versions.APIVersion(\u00272.25\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_19ca7e6c","line":1510,"range":{"start_line":1510,"start_character":36,"end_line":1510,"end_character":57},"in_reply_to":"dfbec78f_0f7c1b81","updated":"2019-05-23 23:30:59.000000000","message":"Done","commit_id":"68047a22397ec428e1c1a4772378492e6beb919a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6ab49ccb4c6bdccc9bed17f8fbb9cd87b853b931","unresolved":false,"context_lines":[{"line_number":1520,"context_line":"                # The host parameter is required in the API even if None."},{"line_number":1521,"context_line":"                kwargs[\u0027host\u0027] \u003d parsed_args.host"},{"line_number":1522,"context_line":"            else:"},{"line_number":1523,"context_line":"                # TODO(mriedem): What do we do if --host was specified without"},{"line_number":1524,"context_line":"                # --live-migration? Fail like in the cold migrate case?"},{"line_number":1525,"context_line":"                kwargs[\u0027host\u0027] \u003d parsed_args.live"},{"line_number":1526,"context_line":""},{"line_number":1527,"context_line":"            if compute_client.api_version \u003c api_versions.APIVersion(\u00272.25\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_7984dab1","line":1524,"range":{"start_line":1523,"start_character":16,"end_line":1524,"end_character":71},"updated":"2019-05-23 23:31:32.000000000","message":"This is the last thing I\u0027m not sure about. Seems we should fail if --host is used with --live but not --live-migration.","commit_id":"2fd01cc5dc371bb0ee174f45b2004b1bd1bda99c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d4a897a91bfb703826508e6826cb4226d0e987b0","unresolved":false,"context_lines":[{"line_number":1520,"context_line":"                # The host parameter is required in the API even if None."},{"line_number":1521,"context_line":"                kwargs[\u0027host\u0027] \u003d parsed_args.host"},{"line_number":1522,"context_line":"            else:"},{"line_number":1523,"context_line":"                # TODO(mriedem): What do we do if --host was specified without"},{"line_number":1524,"context_line":"                # --live-migration? Fail like in the cold migrate case?"},{"line_number":1525,"context_line":"                kwargs[\u0027host\u0027] \u003d parsed_args.live"},{"line_number":1526,"context_line":""},{"line_number":1527,"context_line":"            if compute_client.api_version \u003c api_versions.APIVersion(\u00272.25\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_9441530e","line":1524,"range":{"start_line":1523,"start_character":16,"end_line":1524,"end_character":71},"in_reply_to":"bfb3d3c7_7984dab1","updated":"2019-05-24 00:08:46.000000000","message":"Should --live and --host be in a mutex group?","commit_id":"2fd01cc5dc371bb0ee174f45b2004b1bd1bda99c"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"61dc8241060815ae71d4f8573e72b4daed6a419c","unresolved":false,"context_lines":[{"line_number":1520,"context_line":"                # The host parameter is required in the API even if None."},{"line_number":1521,"context_line":"                kwargs[\u0027host\u0027] \u003d parsed_args.host"},{"line_number":1522,"context_line":"            else:"},{"line_number":1523,"context_line":"                # TODO(mriedem): What do we do if --host was specified without"},{"line_number":1524,"context_line":"                # --live-migration? Fail like in the cold migrate case?"},{"line_number":1525,"context_line":"                kwargs[\u0027host\u0027] \u003d parsed_args.live"},{"line_number":1526,"context_line":""},{"line_number":1527,"context_line":"            if compute_client.api_version \u003c api_versions.APIVersion(\u00272.25\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_b232605d","line":1524,"range":{"start_line":1523,"start_character":16,"end_line":1524,"end_character":71},"in_reply_to":"bfb3d3c7_9441530e","updated":"2019-05-24 12:52:32.000000000","message":"I would probably use the mutex group because that will show up in the help and docs as exclusive; usually the tradeoff is with the error message you get but you have the chance here to handle that in the deprecation warning if you think more explanation is warranted.","commit_id":"2fd01cc5dc371bb0ee174f45b2004b1bd1bda99c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f4cb8dea58f5d51036c8ec788b96abb537929baf","unresolved":false,"context_lines":[{"line_number":1520,"context_line":"                # The host parameter is required in the API even if None."},{"line_number":1521,"context_line":"                kwargs[\u0027host\u0027] \u003d parsed_args.host"},{"line_number":1522,"context_line":"            else:"},{"line_number":1523,"context_line":"                # TODO(mriedem): What do we do if --host was specified without"},{"line_number":1524,"context_line":"                # --live-migration? Fail like in the cold migrate case?"},{"line_number":1525,"context_line":"                kwargs[\u0027host\u0027] \u003d parsed_args.live"},{"line_number":1526,"context_line":""},{"line_number":1527,"context_line":"            if compute_client.api_version \u003c api_versions.APIVersion(\u00272.25\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_ff642024","line":1524,"range":{"start_line":1523,"start_character":16,"end_line":1524,"end_character":71},"in_reply_to":"bfb3d3c7_b232605d","updated":"2019-05-24 14:16:39.000000000","message":"And the mutex group won\u0027t cause problems with eventually supporting --host without cold migrate, right? It just means you can\u0027t use both --live and --host, but I can use --host without --live-migration to do a cold migration with a target host (when we add support for 2.56).","commit_id":"2fd01cc5dc371bb0ee174f45b2004b1bd1bda99c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fc3f9a8d95cad33bbdf176c10a230826c603b86e","unresolved":false,"context_lines":[{"line_number":1522,"context_line":"                # The host parameter is required in the API even if None."},{"line_number":1523,"context_line":"                kwargs[\u0027host\u0027] \u003d parsed_args.host"},{"line_number":1524,"context_line":"            else:"},{"line_number":1525,"context_line":"                # TODO(mriedem): What do we do if --host was specified without"},{"line_number":1526,"context_line":"                # --live-migration? Fail like in the cold migrate case? Should"},{"line_number":1527,"context_line":"                # --host and --live be in a mutex group?"},{"line_number":1528,"context_line":"                kwargs[\u0027host\u0027] \u003d parsed_args.live"},{"line_number":1529,"context_line":""},{"line_number":1530,"context_line":"            if compute_client.api_version \u003c api_versions.APIVersion(\u00272.25\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_82dcabe4","line":1527,"range":{"start_line":1525,"start_character":16,"end_line":1527,"end_character":56},"updated":"2019-05-24 15:01:35.000000000","message":"Oops need to remove this.","commit_id":"b8312a6782d8411819b4b3b5f6896c340d33feaf"}]}