)]}'
{"openstackclient/compute/v2/server.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5243098f2380c73549f64f1072435948502504e1","unresolved":false,"context_lines":[{"line_number":1518,"context_line":"            action\u003d\"store_true\","},{"line_number":1519,"context_line":"            help\u003d_(\u0027Restore server migrate before resize\u0027),"},{"line_number":1520,"context_line":"        )"},{"line_number":1521,"context_line":"        # NOTE(stephenfin): \u0027--wait\u0027 isn\u0027t actually applicable for the revert"},{"line_number":1522,"context_line":"        # or confirm actions but we\u0027re being consistent with \u0027server resize\u0027"},{"line_number":1523,"context_line":"        parser.add_argument("},{"line_number":1524,"context_line":"            \u0027--wait\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_be3a1bc9","line":1521,"updated":"2019-06-10 18:39:01.000000000","message":"It could be - the compute API casts to the compute to complete the confirm/revert operation. The tricky thing is if the instance was stopped when the cold migration started, it should be stopped when the confirm/revert finishes. But \"openstack server resize --wait\" isn\u0027t used with --confirm or --revert either so I wouldn\u0027t expect it to be used for those here. Anyway, your note is actually just confusing to me so I\u0027d drop it.","commit_id":"dd97e0c26da3007c9c26dd67adb1a45391dbdbc0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5933dcbdfca0cda1ef74342bc8891de8868ec913","unresolved":false,"context_lines":[{"line_number":1518,"context_line":"            action\u003d\"store_true\","},{"line_number":1519,"context_line":"            help\u003d_(\u0027Restore server migrate before resize\u0027),"},{"line_number":1520,"context_line":"        )"},{"line_number":1521,"context_line":"        # NOTE(stephenfin): \u0027--wait\u0027 isn\u0027t actually applicable for the revert"},{"line_number":1522,"context_line":"        # or confirm actions but we\u0027re being consistent with \u0027server resize\u0027"},{"line_number":1523,"context_line":"        parser.add_argument("},{"line_number":1524,"context_line":"            \u0027--wait\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_d081bbc4","line":1521,"in_reply_to":"9fb8cfa7_be3a1bc9","updated":"2019-06-13 16:16:33.000000000","message":"Done","commit_id":"dd97e0c26da3007c9c26dd67adb1a45391dbdbc0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5243098f2380c73549f64f1072435948502504e1","unresolved":false,"context_lines":[{"line_number":1611,"context_line":"            ):"},{"line_number":1612,"context_line":"                self.app.stdout.write(_(\u0027Complete\\n\u0027))"},{"line_number":1613,"context_line":"            else:"},{"line_number":1614,"context_line":"                LOG.error(_(\u0027Error migrating server: %s\u0027), server.id)"},{"line_number":1615,"context_line":"                self.app.stdout.write(_(\u0027Error migrating server\\n\u0027))"},{"line_number":1616,"context_line":"                raise SystemExit"},{"line_number":1617,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_5e33dff6","line":1614,"updated":"2019-06-10 18:39:01.000000000","message":"This is unrelated.","commit_id":"dd97e0c26da3007c9c26dd67adb1a45391dbdbc0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5933dcbdfca0cda1ef74342bc8891de8868ec913","unresolved":false,"context_lines":[{"line_number":1611,"context_line":"            ):"},{"line_number":1612,"context_line":"                self.app.stdout.write(_(\u0027Complete\\n\u0027))"},{"line_number":1613,"context_line":"            else:"},{"line_number":1614,"context_line":"                LOG.error(_(\u0027Error migrating server: %s\u0027), server.id)"},{"line_number":1615,"context_line":"                self.app.stdout.write(_(\u0027Error migrating server\\n\u0027))"},{"line_number":1616,"context_line":"                raise SystemExit"},{"line_number":1617,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_3068571b","line":1614,"in_reply_to":"9fb8cfa7_5e33dff6","updated":"2019-06-13 16:16:33.000000000","message":"Done","commit_id":"dd97e0c26da3007c9c26dd67adb1a45391dbdbc0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5243098f2380c73549f64f1072435948502504e1","unresolved":false,"context_lines":[{"line_number":2053,"context_line":"    _description \u003d _(\"\"\"Scale server to a new flavor."},{"line_number":2054,"context_line":""},{"line_number":2055,"context_line":"A resize operation is implemented by creating a new server and copying the"},{"line_number":2056,"context_line":"contents of the original disk into a new one. It is also a two-step process for"},{"line_number":2057,"context_line":"the user: the first is to perform the resize, the second is to either confirm"},{"line_number":2058,"context_line":"(verify) success and release the old server, or to declare a revert to release"},{"line_number":2059,"context_line":"the new server and restart the old one.\"\"\")"},{"line_number":2060,"context_line":""},{"line_number":2061,"context_line":"    def get_parser(self, prog_name):"},{"line_number":2062,"context_line":"        parser \u003d super(ResizeServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_be68dbb8","line":2059,"range":{"start_line":2056,"start_character":46,"end_line":2059,"end_character":39},"updated":"2019-06-10 18:39:01.000000000","message":"Why not include something like this in the \"server migrate\" description as well?","commit_id":"dd97e0c26da3007c9c26dd67adb1a45391dbdbc0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5933dcbdfca0cda1ef74342bc8891de8868ec913","unresolved":false,"context_lines":[{"line_number":2053,"context_line":"    _description \u003d _(\"\"\"Scale server to a new flavor."},{"line_number":2054,"context_line":""},{"line_number":2055,"context_line":"A resize operation is implemented by creating a new server and copying the"},{"line_number":2056,"context_line":"contents of the original disk into a new one. It is also a two-step process for"},{"line_number":2057,"context_line":"the user: the first is to perform the resize, the second is to either confirm"},{"line_number":2058,"context_line":"(verify) success and release the old server, or to declare a revert to release"},{"line_number":2059,"context_line":"the new server and restart the old one.\"\"\")"},{"line_number":2060,"context_line":""},{"line_number":2061,"context_line":"    def get_parser(self, prog_name):"},{"line_number":2062,"context_line":"        parser \u003d super(ResizeServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_d05a1b81","line":2059,"range":{"start_line":2056,"start_character":46,"end_line":2059,"end_character":39},"in_reply_to":"9fb8cfa7_be68dbb8","updated":"2019-06-13 16:16:33.000000000","message":"Good call. Done.","commit_id":"dd97e0c26da3007c9c26dd67adb1a45391dbdbc0"}]}
