)]}'
{"id":"openstack%2Fpython-openstackclient~668255","triplet_id":"openstack%2Fpython-openstackclient~master~I312c971346c7ded93f6fcaa515098554b8580295","project":"openstack/python-openstackclient","branch":"master","topic":"lookup-one-by-one-bfv","hashtags":[],"change_id":"I312c971346c7ded93f6fcaa515098554b8580295","subject":"Fix BFV server list handling with --name-lookup-one-by-one","status":"MERGED","created":"2019-06-28 21:53:56.000000000","updated":"2019-07-22 13:23:51.000000000","submitted":"2019-07-19 17:27:59.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"668255-1563557279422-4e3e88c1","meta_rev_id":"4f7515ad139b11f9545b92e38ec6d40906f9f085","_number":668255,"virtual_id_number":668255,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-07-19 17:27:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2019-06-29 00:43:49.000000000","_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"recommended":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-03 19:43:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-07-02 19:43:02.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2019-07-19 15:39:59.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-03 19:43:41.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-07-19 15:39:59.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2019-07-19 17:27:59.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"db963ab97d422cb33e8aee648143cb940c2755e2","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-06-28 21:53:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f0d0f9eb0f77a41275a26e1cc15716f433a9c3a6","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-06-28 22:06:45.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"fc52ddb39d8d38387a47959fe75622087160c79e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-29 00:20:08.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstackclient-check-plugins http://logs.openstack.org/55/668255/2/check/openstackclient-check-plugins/6bb6b06/ : SUCCESS in 3m 33s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/55/668255/2/check/osc-tox-py27-tips/de16df5/ : SUCCESS in 4m 09s\n- osc-tox-py36-tips http://logs.openstack.org/55/668255/2/check/osc-tox-py36-tips/3d43b9d/ : SUCCESS in 4m 27s\n- openstack-tox-cover http://logs.openstack.org/55/668255/2/check/openstack-tox-cover/79afae6/cover/ : SUCCESS in 4m 01s\n- openstack-tox-lower-constraints http://logs.openstack.org/55/668255/2/check/openstack-tox-lower-constraints/0a969d5/ : SUCCESS in 4m 05s\n- openstack-tox-pep8 http://logs.openstack.org/55/668255/2/check/openstack-tox-pep8/00037d3/ : SUCCESS in 3m 35s\n- openstack-tox-py27 http://logs.openstack.org/55/668255/2/check/openstack-tox-py27/8362f7e/ : SUCCESS in 3m 06s\n- openstack-tox-py36 http://logs.openstack.org/55/668255/2/check/openstack-tox-py36/d8fced6/ : SUCCESS in 3m 11s\n- openstack-tox-py37 http://logs.openstack.org/55/668255/2/check/openstack-tox-py37/e9ca1f9/ : SUCCESS in 3m 47s\n- openstack-tox-docs http://logs.openstack.org/55/668255/2/check/openstack-tox-docs/f6b06d9/html/ : SUCCESS in 3m 37s\n- tempest-full http://logs.openstack.org/55/668255/2/check/tempest-full/b83b769/ : TIMED_OUT in 2h 07m 40s\n- tempest-full-py3 http://logs.openstack.org/55/668255/2/check/tempest-full-py3/b268fdf/ : SUCCESS in 1h 41m 03s\n- osc-functional-devstack http://logs.openstack.org/55/668255/2/check/osc-functional-devstack/249dd8d/ : SUCCESS in 1h 06m 47s\n- osc-functional-devstack-tips http://logs.openstack.org/55/668255/2/check/osc-functional-devstack-tips/c22839c/ : SUCCESS in 1h 02m 30s","accounts_in_message":[],"_revision_number":2},{"id":"081a625d2c9a3ec3dc36d973ed560613b94cb8ad","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-06-29 00:43:49.000000000","message":"Patch Set 2:\n\nrecheck TIMED_OUT","accounts_in_message":[],"_revision_number":2},{"id":"9ae506a599d122143202d8a0fa16525371179b1c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-29 02:26:45.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins http://logs.openstack.org/55/668255/2/check/openstackclient-check-plugins/d453c8f/ : SUCCESS in 4m 10s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/55/668255/2/check/osc-tox-py27-tips/a4286ff/ : SUCCESS in 4m 11s\n- osc-tox-py36-tips http://logs.openstack.org/55/668255/2/check/osc-tox-py36-tips/9236899/ : SUCCESS in 3m 53s\n- openstack-tox-cover http://logs.openstack.org/55/668255/2/check/openstack-tox-cover/5172802/cover/ : SUCCESS in 4m 14s\n- openstack-tox-lower-constraints http://logs.openstack.org/55/668255/2/check/openstack-tox-lower-constraints/8b0a9a1/ : SUCCESS in 4m 05s\n- openstack-tox-pep8 http://logs.openstack.org/55/668255/2/check/openstack-tox-pep8/092ee55/ : SUCCESS in 3m 29s\n- openstack-tox-py27 http://logs.openstack.org/55/668255/2/check/openstack-tox-py27/e528b2d/ : SUCCESS in 3m 16s\n- openstack-tox-py36 http://logs.openstack.org/55/668255/2/check/openstack-tox-py36/489c419/ : SUCCESS in 3m 30s\n- openstack-tox-py37 http://logs.openstack.org/55/668255/2/check/openstack-tox-py37/3abfc20/ : SUCCESS in 3m 24s\n- openstack-tox-docs http://logs.openstack.org/55/668255/2/check/openstack-tox-docs/c04daca/html/ : SUCCESS in 3m 38s\n- tempest-full http://logs.openstack.org/55/668255/2/check/tempest-full/e8a8d0c/ : SUCCESS in 1h 37m 46s\n- tempest-full-py3 http://logs.openstack.org/55/668255/2/check/tempest-full-py3/c0ac608/ : SUCCESS in 1h 34m 15s\n- osc-functional-devstack http://logs.openstack.org/55/668255/2/check/osc-functional-devstack/284fc94/ : SUCCESS in 53m 47s\n- osc-functional-devstack-tips http://logs.openstack.org/55/668255/2/check/osc-functional-devstack-tips/7bb136b/ : SUCCESS in 55m 29s","accounts_in_message":[],"_revision_number":2},{"id":"0f8c37311b6514857273ccff8f6421c50b28ced9","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-07-02 19:43:02.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"5b252b989821deb9e020c4d8f15b93410da9ee4f","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-03 19:43:41.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)\n\nGood catch, easy fix, and removing the fix makes the tests fail so that all looks good.","accounts_in_message":[],"_revision_number":2},{"id":"ec5bd03d5164af168fbd863c6946ca4d61be9532","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-07-19 15:39:59.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"c239428b2442e0deae92c609a0ccf7da1af5b641","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-19 15:40:11.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"043016c3010e59aced3793be18e3861a0a247041","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-19 17:27:59.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- osc-tox-py27-tips http://logs.openstack.org/55/668255/2/gate/osc-tox-py27-tips/5c70e27/ : SUCCESS in 6m 35s\n- osc-tox-py36-tips http://logs.openstack.org/55/668255/2/gate/osc-tox-py36-tips/c6e70b4/ : SUCCESS in 5m 11s\n- openstack-tox-lower-constraints http://logs.openstack.org/55/668255/2/gate/openstack-tox-lower-constraints/80c8a3b/ : SUCCESS in 4m 51s\n- openstack-tox-pep8 http://logs.openstack.org/55/668255/2/gate/openstack-tox-pep8/76524eb/ : SUCCESS in 5m 23s\n- openstack-tox-py27 http://logs.openstack.org/55/668255/2/gate/openstack-tox-py27/a35e1c7/ : SUCCESS in 5m 50s\n- openstack-tox-py36 http://logs.openstack.org/55/668255/2/gate/openstack-tox-py36/ab4c294/ : SUCCESS in 3m 44s\n- openstack-tox-py37 http://logs.openstack.org/55/668255/2/gate/openstack-tox-py37/c01b2e6/ : SUCCESS in 5m 37s\n- openstack-tox-docs http://logs.openstack.org/55/668255/2/gate/openstack-tox-docs/8d02720/html/ : SUCCESS in 6m 28s\n- tempest-full http://logs.openstack.org/55/668255/2/gate/tempest-full/06d1f27/ : SUCCESS in 1h 39m 51s\n- tempest-full-py3 http://logs.openstack.org/55/668255/2/gate/tempest-full-py3/542931a/ : SUCCESS in 1h 19m 12s\n- osc-functional-devstack http://logs.openstack.org/55/668255/2/gate/osc-functional-devstack/a5ab230/ : SUCCESS in 52m 40s","accounts_in_message":[],"_revision_number":2},{"id":"a96bc19669caf86d5f9acde0d06a58af31bb8a75","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-19 17:27:59.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"a0f77bca86aaa1d9c5734814411e34e705abc71c","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-22 13:23:51.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit 83359fbe4fd7e5850abd45a467bf197c284519b1","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"bfc34e11b3437506508b3e120accc0e212268ac6","revisions":{"6671c04bcef1da714b378f20cfacc296589a7d1d":{"kind":"REWORK","_number":1,"created":"2019-06-28 21:53:56.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/55/668255/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/55/668255/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/668255/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/668255/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/668255/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/55/668255/1"}}},"commit":{"parents":[{"commit":"eada2db332caa3dc042650437a1536e589505c2b","subject":"Merge \"Use cliff formattable columns in identity commands\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/eada2db332caa3dc042650437a1536e589505c2b"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2019-06-28 18:17:10.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2019-06-28 21:52:03.000000000","tz":0},"subject":"Fix BFV server list handling with --name-lookup-one-by-one","message":"Fix BFV server list handling with --name-lookup-one-by-one\n\nWhen the --name-lookup-one-by-one option passed to the \u0027server list\u0027\ncommand, the image and flavor names will be looked up for each\nserver being listed instead of fetching all image/flavor names.\n\nThe current code assumes all servers have an image attribute, but\nservers booted from volumes have no image, so the following error is\nraised when listing BFV servers with --name-lookup-one-by-one:\n\n  AttributeError: (\u0027unicode\u0027|\u0027str\u0027) object has no attribute \u0027get\u0027\n\nThe error occurs when the code attempts server.image.get(\u0027id\u0027).\n\nThis fixes the --name-lookup-one-by-one code not to assume an image\nfor a server. The unit tests for \u0027server list\u0027 have also been\nrobustified to feature one BFV server to enhance our test coverage.\n\nStory: #2006063\nTask: #34777\n\nChange-Id: I312c971346c7ded93f6fcaa515098554b8580295\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/6671c04bcef1da714b378f20cfacc296589a7d1d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/6671c04bcef1da714b378f20cfacc296589a7d1d"}]},"branch":"refs/heads/master"},"bfc34e11b3437506508b3e120accc0e212268ac6":{"kind":"REWORK","_number":2,"created":"2019-06-28 22:06:45.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/55/668255/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/55/668255/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/668255/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/668255/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/668255/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/55/668255/2"}}},"commit":{"parents":[{"commit":"eada2db332caa3dc042650437a1536e589505c2b","subject":"Merge \"Use cliff formattable columns in identity commands\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/eada2db332caa3dc042650437a1536e589505c2b"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2019-06-28 18:17:10.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2019-06-28 22:06:39.000000000","tz":0},"subject":"Fix BFV server list handling with --name-lookup-one-by-one","message":"Fix BFV server list handling with --name-lookup-one-by-one\n\nWhen the --name-lookup-one-by-one option passed to the \u0027server list\u0027\ncommand, the image and flavor names will be looked up for each\nserver being listed instead of fetching all image/flavor names.\n\nThe current code assumes all servers have an image attribute, but\nservers booted from volumes have no image, so the following error is\nraised when listing BFV servers with --name-lookup-one-by-one:\n\n  AttributeError: (\u0027unicode\u0027|\u0027str\u0027) object has no attribute \u0027get\u0027\n\nThe error occurs when the code attempts server.image.get(\u0027id\u0027).\n\nThis fixes the --name-lookup-one-by-one code not to assume an image\nfor a server. The unit tests for \u0027server list\u0027 have also been\nrobustified to feature one BFV server to enhance our test coverage.\n\nStory: #2006063\nTask: #34777\n\nChange-Id: I312c971346c7ded93f6fcaa515098554b8580295\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bfc34e11b3437506508b3e120accc0e212268ac6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bfc34e11b3437506508b3e120accc0e212268ac6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}