)]}'
{"id":"openstack%2Fpython-openstackclient~672577","triplet_id":"openstack%2Fpython-openstackclient~master~I868e0868e8eb17e7e34eef3d2d58dceedd29c2b0","project":"openstack/python-openstackclient","branch":"master","topic":"story/2005349","hashtags":[],"change_id":"I868e0868e8eb17e7e34eef3d2d58dceedd29c2b0","subject":"Fix compute service set handling for 2.53+","status":"MERGED","created":"2019-07-24 18:44:01.000000000","updated":"2019-09-20 14:10:04.000000000","submitted":"2019-08-20 17:53:33.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"672577-1566323613494-3b288848","meta_rev_id":"83b404c279a6d5898461a0c06daf070c6895fb3c","_number":672577,"virtual_id_number":672577,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-08-20 17:53:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-08-09 16:01:07.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2019-08-20 16:07:51.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-20 16:07:51.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2019-08-20 17:53:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e42aac8c9a1a4363a741e15cfdcbc4f0c164b3bf","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-24 18:44:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e5db3eb795711504c3c1b32226b3caff5b0fa319","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-24 18:47:30.000000000","message":"Patch Set 1: Workflow-1\n\nI want to test this in devstack before starting on unit tests.","accounts_in_message":[],"_revision_number":1},{"id":"d5474d6ebb8bd426283e0e18643336c66476a146","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-24 18:51:57.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"66816c4fbca50067a7b7ec4c496dc0cf955d3e49","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-24 20:48:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins http://logs.openstack.org/77/672577/1/check/openstackclient-check-plugins/f3f907d/ : SUCCESS in 5m 15s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/77/672577/1/check/osc-tox-py27-tips/b0cd1c8/ : SUCCESS in 4m 57s\n- osc-tox-py36-tips http://logs.openstack.org/77/672577/1/check/osc-tox-py36-tips/dbafdc5/ : SUCCESS in 6m 48s\n- openstack-tox-cover http://logs.openstack.org/77/672577/1/check/openstack-tox-cover/7cf6ae7/cover/ : SUCCESS in 5m 12s\n- openstack-tox-lower-constraints http://logs.openstack.org/77/672577/1/check/openstack-tox-lower-constraints/ed7acb3/ : SUCCESS in 4m 03s\n- openstack-tox-pep8 http://logs.openstack.org/77/672577/1/check/openstack-tox-pep8/a0f66ed/ : SUCCESS in 4m 11s\n- openstack-tox-py27 http://logs.openstack.org/77/672577/1/check/openstack-tox-py27/4a52801/ : SUCCESS in 5m 02s\n- openstack-tox-py36 http://logs.openstack.org/77/672577/1/check/openstack-tox-py36/52a9090/ : SUCCESS in 4m 29s\n- openstack-tox-py37 http://logs.openstack.org/77/672577/1/check/openstack-tox-py37/8ec1ace/ : SUCCESS in 5m 08s\n- openstack-tox-docs http://logs.openstack.org/77/672577/1/check/openstack-tox-docs/80e0cac/html/ : SUCCESS in 5m 02s\n- build-openstack-releasenotes http://logs.openstack.org/77/672577/1/check/build-openstack-releasenotes/0f59806/html/ : SUCCESS in 4m 47s\n- tempest-full http://logs.openstack.org/77/672577/1/check/tempest-full/a589c5f/ : SUCCESS in 1h 55m 31s\n- tempest-full-py3 http://logs.openstack.org/77/672577/1/check/tempest-full-py3/483757a/ : SUCCESS in 1h 32m 35s\n- osc-functional-devstack http://logs.openstack.org/77/672577/1/check/osc-functional-devstack/a6df5f2/ : SUCCESS in 49m 13s\n- osc-functional-devstack-tips http://logs.openstack.org/77/672577/1/check/osc-functional-devstack-tips/34fa396/ : SUCCESS in 59m 34s","accounts_in_message":[],"_revision_number":1},{"id":"417d0fa152409a42bcd317b1c2805984afe2d5f0","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 15:56:14.000000000","message":"Patch Set 1:\n\nWithout this patch trying to disable and force down a compute service with 2.53 clearly fails:\n\n$ openstack --os-compute-api-version 2.53 compute service set --disable --down devstack nova-compute\nFailed to set service status to disabled\nFailed to set service state to down\nCompute service nova-compute of host devstack failed to set.","accounts_in_message":[],"_revision_number":1},{"id":"fd8b4c637b1fc8e8344db35ad8a787a1835e9557","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 16:20:38.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nOK with a couple of fixes I got it working:\n\nstack@devstack:~/python-openstackclient$ openstack --os-compute-api-version 2.53 compute service set --disable --down devstack nova-compute\nstack@devstack:~/python-openstackclient$ openstack --os-compute-api-version 2.53 compute service list --service nova-compute\n+--------------------------------------+--------------+----------+------+----------+-------+----------------------------+\n| ID                                   | Binary       | Host     | Zone | Status   | State | Updated At                 |\n+--------------------------------------+--------------+----------+------+----------+-------+----------------------------+\n| 3b3ad7c3-5524-4d6c-b2a1-2e1aeab5c0ef | nova-compute | devstack | nova | disabled | down  | 2019-07-25T16:20:16.000000 |\n+--------------------------------------+--------------+----------+------+----------+-------+----------------------------+","accounts_in_message":[],"_revision_number":1},{"id":"faf08d240bc7decc639a25a037a71fef2ebdaf8a","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 16:21:58.000000000","message":"Patch Set 1:\n\nWith --disable-reason:\n\nstack@devstack:~/python-openstackclient$ openstack --os-compute-api-version 2.53 compute service set --disable --disable-reason \u0027testing\u0027 devstack nova-compute\nstack@devstack:~/python-openstackclient$ openstack --os-compute-api-version 2.53 compute service list --long --service nova-compute\n+--------------------------------------+--------------+----------+------+----------+-------+----------------------------+-----------------+\n| ID                                   | Binary       | Host     | Zone | Status   | State | Updated At                 | Disabled Reason |\n+--------------------------------------+--------------+----------+------+----------+-------+----------------------------+-----------------+\n| 3b3ad7c3-5524-4d6c-b2a1-2e1aeab5c0ef | nova-compute | devstack | nova | disabled | down  | 2019-07-25T16:21:26.000000 | testing         |\n+--------------------------------------+--------------+----------+------+----------+-------+----------------------------+-----------------+","accounts_in_message":[],"_revision_number":1},{"id":"b2ba7e17eea182a2e3e8e226b14f20c111eec281","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 16:22:24.000000000","message":"Patch Set 1:\n\nstack@devstack:~/python-openstackclient$ openstack --os-compute-api-version 2.53 compute service set --enable --up devstack nova-compute\nstack@devstack:~/python-openstackclient$ openstack --os-compute-api-version 2.53 compute service list --long --service nova-compute\n+--------------------------------------+--------------+----------+------+---------+-------+----------------------------+-----------------+\n| ID                                   | Binary       | Host     | Zone | Status  | State | Updated At                 | Disabled Reason |\n+--------------------------------------+--------------+----------+------+---------+-------+----------------------------+-----------------+\n| 3b3ad7c3-5524-4d6c-b2a1-2e1aeab5c0ef | nova-compute | devstack | nova | enabled | up    | 2019-07-25T16:22:12.000000 | None            |\n+--------------------------------------+--------------+----------+------+---------+-------+----------------------------+-----------------+","accounts_in_message":[],"_revision_number":1},{"id":"648a40c217470f4923cb3988334e44df47341543","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 18:15:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"881ea7efd1e59a2f92b3ebbf1791c48365313359","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-25 20:00:46.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins http://logs.openstack.org/77/672577/2/check/openstackclient-check-plugins/4bb85e6/ : SUCCESS in 5m 49s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/77/672577/2/check/osc-tox-py27-tips/7547a0a/ : SUCCESS in 5m 08s\n- osc-tox-py36-tips http://logs.openstack.org/77/672577/2/check/osc-tox-py36-tips/a74c712/ : SUCCESS in 4m 40s\n- openstack-tox-cover http://logs.openstack.org/77/672577/2/check/openstack-tox-cover/ea6a4a9/cover/ : SUCCESS in 4m 29s\n- openstack-tox-lower-constraints http://logs.openstack.org/77/672577/2/check/openstack-tox-lower-constraints/cbd6d15/ : SUCCESS in 5m 03s\n- openstack-tox-pep8 http://logs.openstack.org/77/672577/2/check/openstack-tox-pep8/330e497/ : SUCCESS in 5m 21s\n- openstack-tox-py27 http://logs.openstack.org/77/672577/2/check/openstack-tox-py27/61c2980/ : SUCCESS in 4m 04s\n- openstack-tox-py36 http://logs.openstack.org/77/672577/2/check/openstack-tox-py36/ff72191/ : SUCCESS in 4m 52s\n- openstack-tox-py37 http://logs.openstack.org/77/672577/2/check/openstack-tox-py37/3535d51/ : SUCCESS in 3m 52s\n- openstack-tox-docs http://logs.openstack.org/77/672577/2/check/openstack-tox-docs/3274460/html/ : SUCCESS in 5m 19s\n- build-openstack-releasenotes http://logs.openstack.org/77/672577/2/check/build-openstack-releasenotes/751dcc0/html/ : SUCCESS in 5m 03s\n- tempest-full http://logs.openstack.org/77/672577/2/check/tempest-full/0ba711f/ : SUCCESS in 1h 39m 06s\n- tempest-full-py3 http://logs.openstack.org/77/672577/2/check/tempest-full-py3/9c30f82/ : SUCCESS in 1h 32m 45s\n- osc-functional-devstack http://logs.openstack.org/77/672577/2/check/osc-functional-devstack/3718840/ : SUCCESS in 1h 11m 45s\n- osc-functional-devstack-tips http://logs.openstack.org/77/672577/2/check/osc-functional-devstack-tips/367106b/ : SUCCESS in 1h 00m 17s","accounts_in_message":[],"_revision_number":2},{"id":"22e576375a03a5600e4064a39713cb40b95fa57c","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-08-01 16:56:05.000000000","message":"Patch Set 2: Code-Review+2\n\nThanks Matt.  I think we should have a bit more explanation of _what_ changes in the release note.\n\nAlso now is the time for argument changes and/or deprecation.  I want to get osc4 released before we freeze.","accounts_in_message":[],"_revision_number":2},{"id":"457cdbcb5f2abf7ff25608cad006f79ab4475ad5","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-08-02 13:39:36.000000000","message":"Patch Set 2:\n\n\u003e I think we should have a bit more explanation of _what_ changes in the release note.\n\nI thought about that but I\u0027m not sure what to say that would not cause confusion. This just makes the command work as-is but with 2.53+ where the PUT /os-services/{service_id} API requires a service UUID rather than the host/binary to identify the service. The end user of the CLI probably doesn\u0027t really care about that though, right? The CLI requires you provide a host and binary and this is just doing the massaging under the covers based on the microversion being used.\n\nA bit more detail would make more sense to me when the --id option is added, but that\u0027s a minor feature change which I think can wait for after the major release to 4.0.","accounts_in_message":[],"_revision_number":2},{"id":"44dd4104bb0997e169c92661b129a71948172c72","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-08-09 16:00:19.000000000","message":"Patch Set 3: Published edit on patch set 2.","accounts_in_message":[],"_revision_number":3},{"id":"b776c819c83045e4876f8c39aa2c031b1a6a9e12","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-08-09 16:01:07.000000000","message":"Patch Set 3: Code-Review+2\n\n\u003e I thought about that but I\u0027m not sure what to say that would not cause confusion.\n\nOK.\n\nI did edit the release note for consistency.","accounts_in_message":[],"_revision_number":3},{"id":"a36e17feb96e5b7003a16df484dcdc8f847d73f8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 17:53:51.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://logs.opendev.org/77/672577/3/check/openstackclient-check-plugins/959723d/ : SUCCESS in 6m 07s (non-voting)\n- osc-tox-py27-tips https://logs.opendev.org/77/672577/3/check/osc-tox-py27-tips/d13b196/ : SUCCESS in 5m 31s\n- osc-tox-py36-tips https://logs.opendev.org/77/672577/3/check/osc-tox-py36-tips/cbebe13/ : SUCCESS in 4m 20s\n- openstack-tox-cover https://logs.opendev.org/77/672577/3/check/openstack-tox-cover/e0bc326/cover/ : SUCCESS in 5m 12s\n- openstack-tox-lower-constraints https://logs.opendev.org/77/672577/3/check/openstack-tox-lower-constraints/c3dba09/ : SUCCESS in 4m 44s\n- openstack-tox-pep8 https://logs.opendev.org/77/672577/3/check/openstack-tox-pep8/2a07e7d/ : SUCCESS in 4m 14s\n- openstack-tox-py27 https://logs.opendev.org/77/672577/3/check/openstack-tox-py27/3250048/ : SUCCESS in 5m 59s\n- openstack-tox-py36 https://logs.opendev.org/77/672577/3/check/openstack-tox-py36/4ed4004/ : SUCCESS in 3m 23s\n- openstack-tox-py37 https://logs.opendev.org/77/672577/3/check/openstack-tox-py37/8cd92f4/ : SUCCESS in 5m 12s\n- openstack-tox-docs https://logs.opendev.org/77/672577/3/check/openstack-tox-docs/c9e1bdf/html/ : SUCCESS in 4m 31s\n- build-openstack-releasenotes https://logs.opendev.org/77/672577/3/check/build-openstack-releasenotes/0d0345b/html/ : SUCCESS in 4m 23s\n- tempest-full https://logs.opendev.org/77/672577/3/check/tempest-full/822dad2/ : SUCCESS in 1h 44m 53s\n- tempest-full-py3 https://logs.opendev.org/77/672577/3/check/tempest-full-py3/6456e00/ : SUCCESS in 1h 34m 29s\n- osc-functional-devstack https://logs.opendev.org/77/672577/3/check/osc-functional-devstack/9250ce4/ : SUCCESS in 54m 01s\n- osc-functional-devstack-tips https://logs.opendev.org/77/672577/3/check/osc-functional-devstack-tips/aeb322f/ : SUCCESS in 56m 42s","accounts_in_message":[],"_revision_number":3},{"id":"c0b67f46e1f2fd265e29f51d5b291d6640749965","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-08-20 16:07:51.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"d100a3450ec991b2cfb65c7e1e282c31ee42fdac","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-20 16:08:03.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"570424ef20117ceb5fa49d7c4e425b65156cdef3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-20 17:53:30.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- osc-tox-py27-tips https://zuul.opendev.org/t/openstack/build/e860aa655dcb4885b567b83fdb0eed30 : SUCCESS in 5m 30s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/5b464e4ec0014e3ba0a32fc3d521029b : SUCCESS in 6m 41s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4539c9c5078d4921af4d92c06824055b : SUCCESS in 4m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a441742ca6f74529a0967cdab60cf71b : SUCCESS in 6m 40s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/e82bfe4a802a4ba1937b53ae72455525 : SUCCESS in 3m 42s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/62af87709bc84c56b63faf426b0cb2d7 : SUCCESS in 4m 57s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/90c81aa122be411bb8136b5df2e269d7 : SUCCESS in 4m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f8f7f06398cc4df2918e2f22cc94a4cf : SUCCESS in 6m 07s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b663ae8b853945fd9ce69c3a2a50bad8 : SUCCESS in 5m 19s\n- tempest-full https://zuul.opendev.org/t/openstack/build/296634f982614194a6d2fb340f355861 : SUCCESS in 1h 35m 10s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/1abb47649fa248239bf743f8f1799e79 : SUCCESS in 1h 42m 43s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/b3461e5c1e7f4c10bd78c28c0be2f631 : SUCCESS in 1h 00m 19s","accounts_in_message":[],"_revision_number":3},{"id":"fcb90ce225bae49e9a2124ce60dd70a0afd38a35","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-20 17:53:33.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"b6432d16c135b3b53a80d5630aef724ddfc3f0e7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-20 17:55:57.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a23f8ee008794771a90e3587c4041a31 : SUCCESS in 1m 55s","accounts_in_message":[],"_revision_number":3},{"id":"05849cba406b3ac1faa4f53b53749a181b1250d5","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-09-20 14:10:04.000000000","message":"Patch Set 3: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit 100d34c54ecdfedf6fb40a2686e1aae1f54df97e","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"4bd53dc1090fda86f6ce25b76a079e250c9206d8","revisions":{"c4b7b43d0815600a5192a4fed579deb7040da618":{"kind":"REWORK","_number":1,"created":"2019-07-24 18:44:01.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/77/672577/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/77/672577/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/672577/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/672577/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/672577/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/77/672577/1"}}},"commit":{"parents":[{"commit":"b52a831f6b92daaba100e09299ec967679adf308","subject":"Mention compute service set --up|--down requires 2.11 or greater","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b52a831f6b92daaba100e09299ec967679adf308"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-24 18:39:07.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-24 18:39:07.000000000","tz":-240},"subject":"WIP: Fix compute service set handling for 2.53+","message":"WIP: Fix compute service set handling for 2.53+\n\nTODO: needs tests for the 2.53 cases:\n  - enable\n  - disable\n  - disabled reason\n  - up\n  - down\n\nWith compute API microversion 2.53 there is a single\nPUT /os-services/{service_id} API which takes the service\nid as a UUID. Since the openstack compute service set\ncommand only takes --host and --service (binary) to identify\nthe service, this change checks if 2.53 or greater is being\nused and if so, looks up the service by host and binary and\ncalls the appropriate methods in novaclient.\n\nIf the command cannot uniquely identify a compute service\nwith the given host and binary, an error is raised. A future\nchange could add an --id option to be used with 2.53+ to\npass the service id (as UUID) directly to avoid the host/binary\nfiltering.\n\nChange-Id: I868e0868e8eb17e7e34eef3d2d58dceedd29c2b0\nStory: 2005349\nTask: 30302\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c4b7b43d0815600a5192a4fed579deb7040da618"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c4b7b43d0815600a5192a4fed579deb7040da618"}]},"branch":"refs/heads/master"},"6f989492beb9793b797ca0b24285fcf9bfa8a678":{"kind":"REWORK","_number":2,"created":"2019-07-25 18:15:56.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/77/672577/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/77/672577/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/672577/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/672577/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/672577/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/77/672577/2"}}},"commit":{"parents":[{"commit":"b52a831f6b92daaba100e09299ec967679adf308","subject":"Mention compute service set --up|--down requires 2.11 or greater","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b52a831f6b92daaba100e09299ec967679adf308"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-24 18:39:07.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-25 18:15:05.000000000","tz":-240},"subject":"Fix compute service set handling for 2.53+","message":"Fix compute service set handling for 2.53+\n\nWith compute API microversion 2.53 there is a single\nPUT /os-services/{service_id} API which takes the service\nid as a UUID. Since the openstack compute service set\ncommand only takes --host and --service (binary) to identify\nthe service, this change checks if 2.53 or greater is being\nused and if so, looks up the service by host and binary and\ncalls the appropriate methods in novaclient.\n\nIf the command cannot uniquely identify a compute service\nwith the given host and binary, an error is raised. A future\nchange could add an --id option to be used with 2.53+ to\npass the service id (as UUID) directly to avoid the host/binary\nfiltering.\n\nChange-Id: I868e0868e8eb17e7e34eef3d2d58dceedd29c2b0\nStory: 2005349\nTask: 30302\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/6f989492beb9793b797ca0b24285fcf9bfa8a678"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/6f989492beb9793b797ca0b24285fcf9bfa8a678"}]},"branch":"refs/heads/master"},"4bd53dc1090fda86f6ce25b76a079e250c9206d8":{"kind":"REWORK","_number":3,"created":"2019-08-09 16:00:19.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/77/672577/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/77/672577/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/672577/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/672577/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/672577/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/77/672577/3"}}},"commit":{"parents":[{"commit":"b52a831f6b92daaba100e09299ec967679adf308","subject":"Mention compute service set --up|--down requires 2.11 or greater","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b52a831f6b92daaba100e09299ec967679adf308"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-24 18:39:07.000000000","tz":-240},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2019-08-09 16:00:13.000000000","tz":0},"subject":"Fix compute service set handling for 2.53+","message":"Fix compute service set handling for 2.53+\n\nWith compute API microversion 2.53 there is a single\nPUT /os-services/{service_id} API which takes the service\nid as a UUID. Since the openstack compute service set\ncommand only takes --host and --service (binary) to identify\nthe service, this change checks if 2.53 or greater is being\nused and if so, looks up the service by host and binary and\ncalls the appropriate methods in novaclient.\n\nIf the command cannot uniquely identify a compute service\nwith the given host and binary, an error is raised. A future\nchange could add an --id option to be used with 2.53+ to\npass the service id (as UUID) directly to avoid the host/binary\nfiltering.\n\nChange-Id: I868e0868e8eb17e7e34eef3d2d58dceedd29c2b0\nStory: 2005349\nTask: 30302\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4bd53dc1090fda86f6ce25b76a079e250c9206d8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4bd53dc1090fda86f6ce25b76a079e250c9206d8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}