)]}'
{"openstackclient/compute/v2/server.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c77c05c40dca8a525c2fe956a535fe40fa94df5c","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                   \u0027volume.\u0027),"},{"line_number":505,"context_line":"        )"},{"line_number":506,"context_line":"        parser.add_argument("},{"line_number":507,"context_line":"            \u0027--boot-from-volume\u0027,"},{"line_number":508,"context_line":"            metavar\u003d\u0027\u003cvolume-size\u003e\u0027,"},{"line_number":509,"context_line":"            type\u003dint,"},{"line_number":510,"context_line":"            help\u003d_(\u0027When used in conjunction with the ``--image`` or \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_77fca871","line":507,"updated":"2019-08-01 19:44:09.000000000","message":"This should come after --flavor in the argument list since this is optional but --flavor is required. The required args are shown first.","commit_id":"ee056889326712cd408d94cc099ee7d8e074f63f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fb77950d7a39d16c374df3936476d653bc3824ad","unresolved":false,"context_lines":[{"line_number":756,"context_line":"        flavor \u003d utils.find_resource(compute_client.flavors,"},{"line_number":757,"context_line":"                                     parsed_args.flavor)"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"        boot_args \u003d [parsed_args.server_name, image, flavor]"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"        files \u003d {}"},{"line_number":762,"context_line":"        for f in parsed_args.file:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_424be829","line":759,"range":{"start_line":759,"start_character":46,"end_line":759,"end_character":51},"updated":"2019-08-01 20:19:11.000000000","message":"Might need to nix this when using --boot-from-volume:\n\n$ openstack server create --image cirros-0.4.0-x86_64-disk --boot-from-volume 1 --flavor m1.tiny --wait test-bfv-1\nBlock Device Mapping is Invalid: Boot sequence for the instance and image/block device mapping combination is not valid. (HTTP 400) (Request-ID: req-ca2e9c0a-446f-4172-aa89-126c78360c91)","commit_id":"ee056889326712cd408d94cc099ee7d8e074f63f"}],"openstackclient/tests/functional/compute/v2/test_server.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"92d30f502ab74472d4c303cd14b81bcaf3dc0d83","unresolved":false,"context_lines":[{"line_number":738,"context_line":"        # Since the server is volume-backed the GET /servers/{server_id}"},{"line_number":739,"context_line":"        # response with have image\u003d\u0027\u0027 so there will be no \"image\" field in"},{"line_number":740,"context_line":"        # the output."},{"line_number":741,"context_line":"        self.assertNotIn(\u0027image\u0027, cmd_output)"},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        # check the volume that attached on server"},{"line_number":744,"context_line":"        cmd_output \u003d json.loads(self.openstack("}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_a7050048","line":741,"updated":"2019-08-02 14:24:05.000000000","message":"Apparently this is wrong, but the code here confused me if image is the empty string:\n\nhttps://github.com/openstack/python-openstackclient/blob/3.19.0/openstackclient/compute/v2/server.py#L143\n\nBut I guess I just need to handle the empty string for the image.","commit_id":"e4703f8a82b26f0cf4861ac95973ee3595006ffe"}]}
