)]}'
{"id":"openstack%2Fpython-openstackclient~679490","triplet_id":"openstack%2Fpython-openstackclient~master~I99a6d192749a4ac76777f72be8118261c0521cb0","project":"openstack/python-openstackclient","branch":"master","topic":"net-location","hashtags":[],"change_id":"I99a6d192749a4ac76777f72be8118261c0521cb0","subject":"Format location columns in network commands","status":"MERGED","created":"2019-08-30 17:54:45.000000000","updated":"2020-06-17 10:07:12.000000000","submitted":"2019-09-09 15:48:24.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"679490-1568044104823-079b87d1","meta_rev_id":"3364f4f4f78fe4db56f864178c1635fe26403787","_number":679490,"virtual_id_number":679490,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-09-09 15:48:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-09-09 14:07:08.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":-1,"date":"2019-09-02 12:38:39.000000000","permitted_voting_range":{"min":-1,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":2,"date":"2019-08-31 05:17:50.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-09-09 14:07:08.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-31 05:17:50.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2019-09-02 12:38:39.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2019-09-09 15:48:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"080c5c960debd52b72ae29958505bbcfde6ef51f","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-08-30 17:54:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4c41a8d8dbde07b7fe3b4cf9c7e166c70a290c39","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-30 19:54:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/2194565950fc481a9274474e0393b42b : SUCCESS in 5m 54s (non-voting)\n- osc-tox-py27-tips https://zuul.opendev.org/t/openstack/build/4a4975d5588a410e90916bacf09d8728 : SUCCESS in 5m 49s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/67f9f117bbbd48238d3a4354ab51b795 : SUCCESS in 4m 52s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/764efb87e687445caa09c7cd340271ef : SUCCESS in 5m 49s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9a4e5138c69b4cc6b48b6f787b9730dd : SUCCESS in 5m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a32fc272b8c34c00a32f052140ff5a1d : SUCCESS in 5m 07s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/f3baea938b784699a2cf2fbabc7a471f : SUCCESS in 3m 45s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/cfa7b892950147e0a8c9ec44096e7dfa : SUCCESS in 3m 50s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/fac86dab5e3e4737b7a3e2437ff56ad5 : SUCCESS in 4m 29s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/51cf24d4729e4cdabdb146fe2750e81b : SUCCESS in 5m 30s\n- tempest-full https://zuul.opendev.org/t/openstack/build/4d74a14b147e4997b498eac77f27f8ac : SUCCESS in 1h 45m 33s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/65eea3033f3f42f7bf9cc8193b942788 : SUCCESS in 1h 36m 47s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/dfe39dc29ccc48d4a1547677f2bac3c9 : SUCCESS in 1h 00m 08s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/22e89ad918d2449f949f8b529e56dd8c : SUCCESS in 1h 00m 31s","accounts_in_message":[],"_revision_number":1},{"id":"0badc18b557c889eb1a222ef185624a55eab483b","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2019-08-31 05:17:50.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"06defa3b7abe1e2e11b9597cfa9fd53a2f6e703e","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-09-02 12:38:39.000000000","message":"Patch Set 1: Code-Review-1\n\nThe same comment from the osc-lib patch applies, having\n\nzone\u003d\u0027None\u0027\n\nin the location column when there really is zone\u003dNone in the data is at least confusing or even wrong, IMO it would be better to not output fields with value\u003dNone at all. Also seeing \"cloud\u003d\u0027\u0027\" when using env vars set by openrc doesn\u0027t seem rather helpful either.\n\nI\u0027m also still convinced that the whole location column shouldn\u0027t be output at all in OSC, but I seem to be at a minority in that regard.","accounts_in_message":[],"_revision_number":1},{"id":"7b593d7e7282af91adc3c90e0e20b3c03b8970ac","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-09-02 14:49:33.000000000","message":"Patch Set 1:\n\nThis is not the first time we have considered what to return for None (the Python literal) in prettytable output.  I\u0027ve never been happy with it either...\n\nI agree that returning \u0027None\u0027 for None is wrong.  https://review.opendev.org/679660 proposes a solution to that, namely returning nothing at all but leaving the key in the output:\n\n {\u0027key1\u0027: None, \u0027key2\u0027: \u0027x\u0027}\n\nbecomes\n\n key1\u003d, key2\u003d\u0027x\u0027","accounts_in_message":[],"_revision_number":1},{"id":"921ffbc70b403364165eebe21dd67a98f8a24fb7","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-09-09 14:07:08.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nI am going to merge this as it fixes the existing behaviour when formatting None, we can discuss Location filtering separately.","accounts_in_message":[],"_revision_number":1},{"id":"5557c83ec1763b8ec7abd6f79608cbd83ceab4fc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-09 14:07:20.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"38feb689476eb46d9069d18fdc5c455616972bd6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-09 15:48:24.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- osc-tox-py27-tips https://zuul.opendev.org/t/openstack/build/cfe77daccbcb457386e28ea333b5e92a : SUCCESS in 4m 29s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/5de3aeb391054c15b7c02ce4171c152a : SUCCESS in 4m 23s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c80f437677b849c1a9c35f2af7516dab : SUCCESS in 5m 44s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3beaa7c4133c400caa9ec2a8c8a73d42 : SUCCESS in 3m 55s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/cedb480a4407402891894d3a467c9fdd : SUCCESS in 3m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/53113ebc8a314074b81b143f7981b561 : SUCCESS in 4m 08s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/7cbb6b308fba4ace8b4e4d929334d5e1 : SUCCESS in 4m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/95d2c1f016ae43d5a94f84cff1d60eed : SUCCESS in 5m 00s\n- tempest-full https://zuul.opendev.org/t/openstack/build/fb40677b3cc24eaeb36d13928fdbfbfa : SUCCESS in 1h 35m 22s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/1c8fa28fcdd64f60bfde83d3162e0982 : SUCCESS in 1h 29m 18s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/0e7e62203c354380bddb2e3001d154df : SUCCESS in 53m 10s","accounts_in_message":[],"_revision_number":1},{"id":"728c5daef4605705d43a400ac27d572c350c11e5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-09 15:48:24.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"246fe874f5836ef569f897f6bc28511e3e755645","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-09 15:49:35.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f112b6a982474110a816f1efdbc63c00 : SUCCESS in 51s","accounts_in_message":[],"_revision_number":1},{"id":"591d9708d3d60bedda0165147b39b6f93425fc3e","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-06-17 10:07:12.000000000","message":"Created a revert of this change as I5f59959ba8a01aba49e29f4cb007397467344e58","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6ee7b8d138e07bfc37c5cd887f7afa49cdabb02f","revisions":{"6ee7b8d138e07bfc37c5cd887f7afa49cdabb02f":{"kind":"REWORK","_number":1,"created":"2019-08-30 17:54:45.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/90/679490/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/90/679490/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/679490/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/679490/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/679490/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/90/679490/1"}}},"commit":{"parents":[{"commit":"eed615e7d0fb0935ddde0565bf93174549f2456a","subject":"Merge \"Remove token_endpoint auth type\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/eed615e7d0fb0935ddde0565bf93174549f2456a"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2019-08-30 17:53:15.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2019-08-30 17:53:18.000000000","tz":-300},"subject":"Format location columns in network commands","message":"Format location columns in network commands\n\nThese return a Munch from the SDK, which can be handled exactly\nlike a dict so do that.\n\nNote that the location column has a nested project dict in the\nreturn value, this is addressed separately in osc_lib.format_columns\nin https://review.opendev.org/#/c/679474/.\n\nChange-Id: I99a6d192749a4ac76777f72be8118261c0521cb0\nSigned-off-by: Dean Troyer \u003cdtroyer@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/6ee7b8d138e07bfc37c5cd887f7afa49cdabb02f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/6ee7b8d138e07bfc37c5cd887f7afa49cdabb02f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}