)]}'
{"openstackclient/network/v2/subnet.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d55910e67b441b19b8a5eb0112df9d29a1fd4a0a","unresolved":false,"context_lines":[{"line_number":581,"context_line":"        dns_publish_fixed_ip_group.add_argument("},{"line_number":582,"context_line":"            \u0027--no-dns-publish-fixed-ip\u0027,"},{"line_number":583,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":584,"context_line":"            help\u003d_(\"Disable publishing fixed IPs in DNS (default)\")"},{"line_number":585,"context_line":"        )"},{"line_number":586,"context_line":"        parser.add_argument("},{"line_number":587,"context_line":"            \u0027--gateway\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_88aa5e81","line":584,"range":{"start_line":584,"start_character":55,"end_line":584,"end_character":65},"updated":"2019-09-03 20:34:10.000000000","message":"Since this is the \"set\" code, there is no default, so this can be removed.","commit_id":"bb1009c734a3310a969e22ce006b5d966ad462a9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"51c6ca679fa50df59ac5bf79a3ef9e8dc0782cc9","unresolved":false,"context_lines":[{"line_number":581,"context_line":"        dns_publish_fixed_ip_group.add_argument("},{"line_number":582,"context_line":"            \u0027--no-dns-publish-fixed-ip\u0027,"},{"line_number":583,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":584,"context_line":"            help\u003d_(\"Disable publishing fixed IPs in DNS (default)\")"},{"line_number":585,"context_line":"        )"},{"line_number":586,"context_line":"        parser.add_argument("},{"line_number":587,"context_line":"            \u0027--gateway\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_74db9a1a","line":584,"range":{"start_line":584,"start_character":55,"end_line":584,"end_character":65},"in_reply_to":"7faddb67_88aa5e81","updated":"2019-09-11 08:34:00.000000000","message":"Good catch, that\u0027s what you get from c\u0026p, fixed.","commit_id":"bb1009c734a3310a969e22ce006b5d966ad462a9"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"38bd850447221618f1c9be317e0a87c694ef034f","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    if parsed_args.dns_publish_fixed_ip:"},{"line_number":233,"context_line":"        attrs[\u0027dns_publish_fixed_ip\u0027] \u003d True"},{"line_number":234,"context_line":"    if parsed_args.no_dns_publish_fixed_ip:"},{"line_number":235,"context_line":"        attrs[\u0027dns_publish_fixed_ip\u0027] \u003d False"},{"line_number":236,"context_line":"    if (\u0027dns_nameservers\u0027 in parsed_args and"},{"line_number":237,"context_line":"       parsed_args.dns_nameservers is not None):"},{"line_number":238,"context_line":"        attrs[\u0027dns_nameservers\u0027] \u003d parsed_args.dns_nameservers"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_60df2067","line":235,"updated":"2020-01-02 14:23:14.000000000","message":"It\u0027s possible to refactor this line, I think. Actually it\u0027s not possible to use these two options in the same time. So you can check only one of these option.","commit_id":"b4e9b225b4435a7a3598b70617c1e6eb73613fa0"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"d3e80a433f4b605c87412833cc9f2785766225f2","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    if parsed_args.dns_publish_fixed_ip:"},{"line_number":233,"context_line":"        attrs[\u0027dns_publish_fixed_ip\u0027] \u003d True"},{"line_number":234,"context_line":"    if parsed_args.no_dns_publish_fixed_ip:"},{"line_number":235,"context_line":"        attrs[\u0027dns_publish_fixed_ip\u0027] \u003d False"},{"line_number":236,"context_line":"    if (\u0027dns_nameservers\u0027 in parsed_args and"},{"line_number":237,"context_line":"       parsed_args.dns_nameservers is not None):"},{"line_number":238,"context_line":"        attrs[\u0027dns_nameservers\u0027] \u003d parsed_args.dns_nameservers"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_1535d343","line":235,"in_reply_to":"3fa7e38b_602720ca","updated":"2020-01-13 17:25:33.000000000","message":"Frickler is right.  Some REST API\u0027s are fussy about attributes being present or not so we just do it this way everywhere to be consistent.\n\nIt is possible we will let the SDK handle this sort of thing in the future...","commit_id":"b4e9b225b4435a7a3598b70617c1e6eb73613fa0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7922059c476d8f5e9276d1c47862b59abbe72e39","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    if parsed_args.dns_publish_fixed_ip:"},{"line_number":233,"context_line":"        attrs[\u0027dns_publish_fixed_ip\u0027] \u003d True"},{"line_number":234,"context_line":"    if parsed_args.no_dns_publish_fixed_ip:"},{"line_number":235,"context_line":"        attrs[\u0027dns_publish_fixed_ip\u0027] \u003d False"},{"line_number":236,"context_line":"    if (\u0027dns_nameservers\u0027 in parsed_args and"},{"line_number":237,"context_line":"       parsed_args.dns_nameservers is not None):"},{"line_number":238,"context_line":"        attrs[\u0027dns_nameservers\u0027] \u003d parsed_args.dns_nameservers"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_602720ca","line":235,"in_reply_to":"3fa7e38b_60df2067","updated":"2020-01-02 15:08:02.000000000","message":"Not sure what you want to say here. If neither option is set, the attribute must not be set at all, as it requires a specific neutron extension to be available and that may not be the case for every deployment. This is similar to how the \"enable_dhcp\" option is dealt with above.","commit_id":"b4e9b225b4435a7a3598b70617c1e6eb73613fa0"}]}