)]}'
{"id":"openstack%2Fpython-openstackclient~689876","triplet_id":"openstack%2Fpython-openstackclient~master~Id9be39971110fd2eb4519a0582c9bf2514cdcacd","project":"openstack/python-openstackclient","branch":"master","topic":"story/1735016","hashtags":[],"change_id":"Id9be39971110fd2eb4519a0582c9bf2514cdcacd","subject":"Fix plugin autodoc generation","status":"MERGED","created":"2019-10-21 21:18:35.000000000","updated":"2019-10-22 21:16:43.000000000","submitted":"2019-10-22 21:16:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"689876-1571779003652-fe29816b","meta_rev_id":"dc312dacfa3c457d282d1cf605f2835c9c9d78ba","_number":689876,"virtual_id_number":689876,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-22 21:16:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2019-10-21 22:50:16.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"recommended":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":1,"date":"2019-10-22 16:12:50.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-10-21 22:15:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-10-22 19:24:43.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":2,"date":"2019-10-21 21:44:16.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2019-10-22 19:24:43.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-21 21:44:16.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2019-10-21 22:15:44.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-10-22 16:12:50.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"},{"updated":"2019-10-22 19:24:43.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2019-10-22 21:16:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8219516c0cad737872f675f9d7f94e37d58aa687","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-10-21 21:18:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7ec8a700d97d97072575b64446dbebd25ed09ebc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-21 21:31:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/72559e68c8ca4c4aa52916ce05929c27 : SUCCESS in 4m 45s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/95c16837f4c74f059fcc897eb8e93cf5 : SUCCESS in 4m 39s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9b229f2c58364721a0140c43e8e9f921 : SUCCESS in 5m 39s\n- requirements-check https://zuul.opendev.org/t/openstack/build/f5d0f443cbab4bf0aa8c34b00f1bf7fd : SUCCESS in 2m 11s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/65087c25893a47fbb0cbcc95c0853291 : SUCCESS in 5m 13s","accounts_in_message":[],"_revision_number":1},{"id":"eb5dcf42867a93ac0561e4cc1eb82aee87f90122","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-10-21 21:35:52.000000000","message":"Patch Set 1:\n\nRendered: https://8728c3420492afd1b41a-06fd4184f2cef7745958cc2583c9060a.ssl.cf5.rackcdn.com/689876/1/check/openstack-tox-docs/9b229f2/docs/cli/plugin-commands.html\n\nThis is an improvement in that cli/plugin-commands.html now has actual content. But we\u0027re far from done; that content is non-pretty. Things that stand out at a glance:\n- There\u0027s now a bullet list at the top of the page (generated by ``.. list-plugins:: openstack.cli.extension``) which seems to overlap with the list of plugins on the page; but in a different order (since it seems to be sorted by API_NAME rather than project name) and with some weirdnesses (like: \u0027metric\u0027 shows up twice; and several plugins don\u0027t have descriptions -- guessing these would be remedied within the plugin projects themselves).\n- The page is huge. We should consider splitting it into its constituent projects and make this page just a TOC.\n- Only the command summaries are shown. This might be okay if there was also a link to the plugin\u0027s own docs; but why not just include the whole doc here, since we have it on hand?","accounts_in_message":[],"_revision_number":1},{"id":"eb4cfd47eba8389dcedb62d679e13750e80e8da3","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-10-21 21:40:20.000000000","message":"Patch Set 1:\n\nOh, also: Does this mean we can take these deps out of test-requirements.txt? I\u0027ll propose a patch to do that and see what breaks...\n\n... https://review.opendev.org/689881","accounts_in_message":[],"_revision_number":1},{"id":"a833157dcc46327565f28ff30edf6870259f1089","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2019-10-21 21:44:16.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3a7a8015a8c8a4994a2e90386687f4834a3c30c5","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-10-21 22:12:21.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1e856111a0300c18742fdcac9e65937d392a34c8","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-10-21 22:13:07.000000000","message":"Patch Set 1: -Code-Review\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cb824c0524f441fe7decf9930772f0b6cb6c9aaf","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-10-21 22:14:13.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2b4f1a9081a86380013185f5c26aa97f8c67bf7a","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-10-21 22:15:44.000000000","message":"Patch Set 1: Code-Review+1\n\nOK yeah this is better than the busted docs and there is a patch in the pipeline to cleanup test-requirements.txt so lgtm.","accounts_in_message":[],"_revision_number":1},{"id":"e6e1e5669ba0bd8235344b74252abb0268fa2172","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-10-21 22:50:16.000000000","message":"Patch Set 1:\n\n\u003e There\u0027s now a bullet list at the top of the page\n\nRemoved as part of [1].\n\n\u003e The page is huge. We should consider splitting it into its constituent projects and make this page just a TOC.\n\nDone via [1].\n\n\u003e Only the command summaries are shown. This might be okay if there was also a link to the plugin\u0027s own docs; but why not just include the whole doc here, since we have it on hand?\n\nDone via [2].\n\n[1] https://review.opendev.org/#/c/689886/\n[2] https://review.opendev.org/#/c/689892/","accounts_in_message":[],"_revision_number":1},{"id":"9910e0be5e1c4b90886a44a63f5ed0390a1a4c45","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2019-10-22 16:12:50.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM, thanks!","accounts_in_message":[],"_revision_number":1},{"id":"78c897aefcd9d195a2cf2a237a17208f8b1d548c","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-10-22 19:24:43.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nUltimately this belongs in the openstackclient repo, all of the plugin-related stuff is meant to be there.  Granted that is a really old plan and at this pace I\u0027ll retire, so it should be somehwere...","accounts_in_message":[],"_revision_number":1},{"id":"26d36484c67b0016d443f0398acd31230ba8a00a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-22 19:24:58.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"dbb4222ee689d6badcff22016e3733785d9dbc18","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-22 21:16:43.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"4cc7118fb09c1e9eb55635ef5eae88119fc099f4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-22 21:16:43.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3572abb5690a4d629ced37de10ee412d : SUCCESS in 6m 05s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/21b745a943e54f3e94ce43934f2799d4 : SUCCESS in 6m 07s\n- requirements-check https://zuul.opendev.org/t/openstack/build/4ea99b7fb3e2469885a36e23222e7980 : SUCCESS in 3m 58s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c3285d1f1f8c4cfaa64da6d44f3c4c98 : SUCCESS in 6m 58s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"cf1006bf0ef67a693357ba3913962037aaf6c3d5","revisions":{"cf1006bf0ef67a693357ba3913962037aaf6c3d5":{"kind":"REWORK","_number":1,"created":"2019-10-21 21:18:35.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/76/689876/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/76/689876/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/76/689876/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/76/689876/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/76/689876/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/76/689876/1"}}},"commit":{"parents":[{"commit":"154df0d069cdf8a10678b9f6d1b715350847fe96","subject":"Update master for stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/154df0d069cdf8a10678b9f6d1b715350847fe96"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-10-21 21:09:10.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-10-21 21:10:56.000000000","tz":-300},"subject":"Fix plugin autodoc generation","message":"Fix plugin autodoc generation\n\nDocumentation for plugins wasn\u0027t being generated because the plugin\nprojects weren\u0027t being installed in the docs environment. Add them to\ndoc/requirements.txt to make this work.\n\nChange-Id: Id9be39971110fd2eb4519a0582c9bf2514cdcacd\nStory: #1735016\nTask: #13825\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cf1006bf0ef67a693357ba3913962037aaf6c3d5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cf1006bf0ef67a693357ba3913962037aaf6c3d5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}