)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"64c896145371341584b33764dd85dae735c19f6b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"WIP:Fix openstack server list --deleted --marker option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch removes using the \"name\" option for a marker. find_resource()"},{"line_number":10,"context_line":"that is being called does not correctly handle using the marker"},{"line_number":11,"context_line":"as the \"name\" or \"id\" in the search. Even passing in \"deleted\u003dTrue\""},{"line_number":12,"context_line":"it does not find the server correctly. One simple way to fix this is"},{"line_number":13,"context_line":"force the marker to only be an ID, which is how the nova client"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_8bf703d5","line":10,"updated":"2019-10-24 19:55:10.000000000","message":"Sure it does, as long as the marker server is not deleted. You should probably explain the use case and recreate scenario a bit more here in the commit message for context.","commit_id":"482b00936eac3d89eb44ce4c048f9c92a731b79c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"77fc49f16c7049b70162f18320d6a2a2cf564d5b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     KeithMnemonic \u003ckeith.berger@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-12-13 15:04:39 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP:Fix openstack server list --deleted --marker option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch removes using the \"name\" option for a marker when"},{"line_number":10,"context_line":"--deleted is also used. The find_resource() function"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_b04c0676","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":4},"updated":"2019-12-16 15:56:14.000000000","message":"You should also remove this when this is no longer a WIP.","commit_id":"dd1eac6465a7fe76636adf2f1377ef6e31eedbc8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae4c11d2d63f5fa59890e83890bb5e92c71af82e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"as the \"name\" in the search when also using deleted\u003dTrue."},{"line_number":13,"context_line":"One simple way to fix this is force the marker to only be an ID"},{"line_number":14,"context_line":"when --deleted is used. This is how the nova client works."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"story: 2006761"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib878982b1d469212ca3483dcfaf407a8e1d2b417"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3fa7e38b_bdc60f9c","line":15,"updated":"2019-12-17 15:11:56.000000000","message":"A little more context here for other reviewers.\n\nUsing the --deleted option is available to users with the admin role by default. If you\u0027re an admin listing --deleted servers with a marker by name, find_resource() is going to fail to find it since it doesn\u0027t apply the --deleted filter to find_resource(). The find_resource() function is trying to find the marker server by name if it\u0027s not found by id, and to find it by name it\u0027s listing servers with the given marker as the name, but not applying the --deleted filter so it doesn\u0027t get back any results.\n\nIn the story I suggested modifying find_resource to include the deleted query param when it\u0027s specified on the command line but Keith said that didn\u0027t work because it still results in something like this:\n\nhttp://192.168.1.123/compute/v2.1/servers?deleted\u003dTrue\u0026name\u003d4cecd49f-bc25-4a7e-826e-4aea6f9267d9\n\nIt seems like there are bugs in find_resource() but I haven\u0027t dug into the details there.\n\nI think restricting the marker to be the server ID when listing deleted servers is probably OK since if you\u0027re using --deleted you\u0027re an admin and you could be listing across all projects and if you\u0027re filtering by a server across all projects anyway (not that you have to, I\u0027m just saying if you are), or even showing a server in another project, you have to do it by id rather than name because find_resource() won\u0027t find the server in another project by name, only ID.","commit_id":"8513fc2074e261cebb79c86d62616fbbf95f3a00"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae4c11d2d63f5fa59890e83890bb5e92c71af82e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"One simple way to fix this is force the marker to only be an ID"},{"line_number":14,"context_line":"when --deleted is used. This is how the nova client works."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"story: 2006761"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib878982b1d469212ca3483dcfaf407a8e1d2b417"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3fa7e38b_7d6417e7","line":16,"updated":"2019-12-17 15:11:56.000000000","message":"Should also have:\n\nTask: 37258\n\nOn the line below the story.","commit_id":"8513fc2074e261cebb79c86d62616fbbf95f3a00"}],"openstackclient/compute/v2/server.py":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0a87a924d8a9f18b600b918847a0c6f9d8b14f70","unresolved":false,"context_lines":[{"line_number":1410,"context_line":"            )"},{"line_number":1411,"context_line":"            mixed_case_fields \u003d []"},{"line_number":1412,"context_line":""},{"line_number":1413,"context_line":"        marker_id \u003d None"},{"line_number":1414,"context_line":"        if parsed_args.marker:"},{"line_number":1415,"context_line":""},{"line_number":1416,"context_line":"        data \u003d compute_client.servers.list(search_opts\u003dsearch_opts,"},{"line_number":1417,"context_line":"                                           marker\u003dparsed_args.marker,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_05dc6216","line":1414,"range":{"start_line":1413,"start_character":8,"end_line":1414,"end_character":30},"updated":"2019-10-24 19:10:15.000000000","message":"may want to get rid of these two lines while you are at it","commit_id":"482b00936eac3d89eb44ce4c048f9c92a731b79c"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0a87a924d8a9f18b600b918847a0c6f9d8b14f70","unresolved":false,"context_lines":[{"line_number":1415,"context_line":""},{"line_number":1416,"context_line":"        data \u003d compute_client.servers.list(search_opts\u003dsearch_opts,"},{"line_number":1417,"context_line":"                                           marker\u003dparsed_args.marker,"},{"line_number":1418,"context_line":"                                           limit\u003dparsed_args.limit)"},{"line_number":1419,"context_line":""},{"line_number":1420,"context_line":"        images \u003d {}"},{"line_number":1421,"context_line":"        flavors \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_65a51647","line":1418,"updated":"2019-10-24 19:10:15.000000000","message":"I think this is the right thing to do. We don\u0027t need to lookup the marker. There\u0027s nothing to gain, from usability POV, for looking up the marker. Nova API doesn\u0027t support fetching a *deleted* server.\n\nhttps://github.com/openstack/osc-lib/blob/1.14.1/osc_lib/utils/__init__.py#L196\n\nOr yet, btw, it also have other problems, like passing in kwargs into manager.get() and silently eat the exception. :-)\n\nhttps://github.com/openstack/osc-lib/blob/1.14.1/osc_lib/utils/__init__.py#L204\n\nFinally utils.find_resource() will trying to do server.list() under the hood and do a lookup by name.\n\nhttps://github.com/openstack/osc-lib/blob/1.14.1/osc_lib/utils/__init__.py#L236\n\nWhich will inevitably hit the NotFound exception if the given marker is the server ID.\n\nhttps://github.com/openstack/osc-lib/blob/1.14.1/osc_lib/utils/__init__.py#L248\n\nCase 5 is pretty much dead (and buggy btw) code.\n\nhttps://github.com/openstack/osc-lib/blob/1.14.1/osc_lib/utils/__init__.py#L277\n\nSo there\u0027s really no point of going through all that pain if marker is specify. We can just do the listing directly.","commit_id":"482b00936eac3d89eb44ce4c048f9c92a731b79c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0c232df0ad564d71fdea998b6bde41d96924e757","unresolved":false,"context_lines":[{"line_number":1415,"context_line":""},{"line_number":1416,"context_line":"        data \u003d compute_client.servers.list(search_opts\u003dsearch_opts,"},{"line_number":1417,"context_line":"                                           marker\u003dparsed_args.marker,"},{"line_number":1418,"context_line":"                                           limit\u003dparsed_args.limit)"},{"line_number":1419,"context_line":""},{"line_number":1420,"context_line":"        images \u003d {}"},{"line_number":1421,"context_line":"        flavors \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_eb5b17f3","line":1418,"in_reply_to":"3fa7e38b_65a51647","updated":"2019-10-24 19:54:22.000000000","message":"If you remove the ability to specify a marker server by name or id, the docs on the --marker option need to be updated because right now it says you can specify a name or id, and we know that name doesn\u0027t work if the marker server is deleted. That kind of behavioral change would also require a release note.","commit_id":"482b00936eac3d89eb44ce4c048f9c92a731b79c"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"225000be59ee4561e07c3f936ce2ceea4b161762","unresolved":false,"context_lines":[{"line_number":1415,"context_line":""},{"line_number":1416,"context_line":"        data \u003d compute_client.servers.list(search_opts\u003dsearch_opts,"},{"line_number":1417,"context_line":"                                           marker\u003dparsed_args.marker,"},{"line_number":1418,"context_line":"                                           limit\u003dparsed_args.limit)"},{"line_number":1419,"context_line":""},{"line_number":1420,"context_line":"        images \u003d {}"},{"line_number":1421,"context_line":"        flavors \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_11bee0d3","line":1418,"in_reply_to":"3fa7e38b_eb5b17f3","updated":"2019-10-24 21:10:32.000000000","message":"Maybe we can enhance python-novaclient to enable fetching deleted server?\n\nhttps://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L848","commit_id":"482b00936eac3d89eb44ce4c048f9c92a731b79c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8983895a34e09a4b9f0cdee424082c46c8492549","unresolved":false,"context_lines":[{"line_number":1242,"context_line":"            default\u003dNone,"},{"line_number":1243,"context_line":"            help\u003d_(\u0027The last server of the previous page. Display \u0027"},{"line_number":1244,"context_line":"                   \u0027list of servers after marker. Display all servers if not \u0027"},{"line_number":1245,"context_line":"                   \u0027specified. The marker can be an ID. A name can be used \u0027"},{"line_number":1246,"context_line":"                   \u0027when not also using --deleted\u0027),"},{"line_number":1247,"context_line":"        )"},{"line_number":1248,"context_line":"        parser.add_argument("},{"line_number":1249,"context_line":"            \u0027--limit\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_2a050916","line":1246,"range":{"start_line":1245,"start_character":31,"end_line":1246,"end_character":50},"updated":"2019-12-16 15:12:36.000000000","message":"I would re-word this to avoid the negative:\n\n\"When used with the ``--deleted`` option, the marker can only be an ID, otherwise it can be a name or ID.\"","commit_id":"dd1eac6465a7fe76636adf2f1377ef6e31eedbc8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae4c11d2d63f5fa59890e83890bb5e92c71af82e","unresolved":false,"context_lines":[{"line_number":1242,"context_line":"            default\u003dNone,"},{"line_number":1243,"context_line":"            help\u003d_(\u0027The last server of the previous page. Display \u0027"},{"line_number":1244,"context_line":"                   \u0027list of servers after marker. Display all servers if not \u0027"},{"line_number":1245,"context_line":"                   \u0027specified. When using with --deleted, the marker must be \u0027"},{"line_number":1246,"context_line":"                   \u0027an ID. Otherwise, a Name or ID can be used\u0027),"},{"line_number":1247,"context_line":"        )"},{"line_number":1248,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_dd598bfd","line":1245,"range":{"start_line":1245,"start_character":31,"end_line":1245,"end_character":56},"updated":"2019-12-17 15:11:56.000000000","message":"When used with the ``--deleted`` option...\n\n--\n\nFormat the option so it renders in docs properly:\n\nhttps://3fdd3adccbbbca8893fe-55e7a9d33a731efe4f7611907a31a4a1.ssl.cf1.rackcdn.com/691045/7/check/openstack-tox-docs/0382ad9/docs/cli/command-objects/server.html#server-list\n\nOtherwise it looks like a single dash: -deleted","commit_id":"8513fc2074e261cebb79c86d62616fbbf95f3a00"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae4c11d2d63f5fa59890e83890bb5e92c71af82e","unresolved":false,"context_lines":[{"line_number":1243,"context_line":"            help\u003d_(\u0027The last server of the previous page. Display \u0027"},{"line_number":1244,"context_line":"                   \u0027list of servers after marker. Display all servers if not \u0027"},{"line_number":1245,"context_line":"                   \u0027specified. When using with --deleted, the marker must be \u0027"},{"line_number":1246,"context_line":"                   \u0027an ID. Otherwise, a Name or ID can be used\u0027),"},{"line_number":1247,"context_line":"        )"},{"line_number":1248,"context_line":"        parser.add_argument("},{"line_number":1249,"context_line":"            \u0027--limit\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_9d6b1385","line":1246,"range":{"start_line":1246,"start_character":40,"end_line":1246,"end_character":44},"updated":"2019-12-17 15:11:56.000000000","message":"name","commit_id":"8513fc2074e261cebb79c86d62616fbbf95f3a00"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae4c11d2d63f5fa59890e83890bb5e92c71af82e","unresolved":false,"context_lines":[{"line_number":1243,"context_line":"            help\u003d_(\u0027The last server of the previous page. Display \u0027"},{"line_number":1244,"context_line":"                   \u0027list of servers after marker. Display all servers if not \u0027"},{"line_number":1245,"context_line":"                   \u0027specified. When using with --deleted, the marker must be \u0027"},{"line_number":1246,"context_line":"                   \u0027an ID. Otherwise, a Name or ID can be used\u0027),"},{"line_number":1247,"context_line":"        )"},{"line_number":1248,"context_line":"        parser.add_argument("},{"line_number":1249,"context_line":"            \u0027--limit\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_3dfd3fb2","line":1246,"range":{"start_line":1246,"start_character":25,"end_line":1246,"end_character":26},"updated":"2019-12-17 15:11:56.000000000","message":"nit: not really sure \"Otherwise\" needs to start a separate sentence here. Why not just:\n\n\"When used with the ``--deleted`` option the marker must be an ID otherwise a name or ID can be used.\"","commit_id":"8513fc2074e261cebb79c86d62616fbbf95f3a00"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae4c11d2d63f5fa59890e83890bb5e92c71af82e","unresolved":false,"context_lines":[{"line_number":1243,"context_line":"            help\u003d_(\u0027The last server of the previous page. Display \u0027"},{"line_number":1244,"context_line":"                   \u0027list of servers after marker. Display all servers if not \u0027"},{"line_number":1245,"context_line":"                   \u0027specified. When using with --deleted, the marker must be \u0027"},{"line_number":1246,"context_line":"                   \u0027an ID. Otherwise, a Name or ID can be used\u0027),"},{"line_number":1247,"context_line":"        )"},{"line_number":1248,"context_line":"        parser.add_argument("},{"line_number":1249,"context_line":"            \u0027--limit\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_5d659bae","line":1246,"range":{"start_line":1246,"start_character":58,"end_line":1246,"end_character":62},"updated":"2019-12-17 15:11:56.000000000","message":"used.","commit_id":"8513fc2074e261cebb79c86d62616fbbf95f3a00"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae4c11d2d63f5fa59890e83890bb5e92c71af82e","unresolved":false,"context_lines":[{"line_number":1452,"context_line":""},{"line_number":1453,"context_line":"        marker_id \u003d None"},{"line_number":1454,"context_line":""},{"line_number":1455,"context_line":"        if parsed_args.marker and not parsed_args.deleted:"},{"line_number":1456,"context_line":"            marker_id \u003d utils.find_resource(compute_client.servers,"},{"line_number":1457,"context_line":"                                            parsed_args.marker).id"},{"line_number":1458,"context_line":"        elif parsed_args.marker and parsed_args.deleted:"},{"line_number":1459,"context_line":"            marker_id \u003d parsed_args.marker"},{"line_number":1460,"context_line":""},{"line_number":1461,"context_line":"        data \u003d compute_client.servers.list(search_opts\u003dsearch_opts,"},{"line_number":1462,"context_line":"                                           marker\u003dmarker_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_dddc2b47","line":1459,"range":{"start_line":1455,"start_character":8,"end_line":1459,"end_character":42},"updated":"2019-12-17 15:11:56.000000000","message":"First, we should probably have a code comment here to remind someone looking at this that when a marker is specified with --deleted the marker must be an id because find_resource will not find the deleted server marker by name.\n\nSecond, I think the logic could be cleaned up a bit:\n\nif parsed_args.marker:\n    # put your comment here about the logic\n    if parsed_args.deleted:\n        marker_id \u003d parsed_args.marker\n    else:\n        marker_id \u003d utils.find_resource(...)","commit_id":"8513fc2074e261cebb79c86d62616fbbf95f3a00"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6b45934a2a238d0a2ac7f54c0ccc6eea5dc9b4e2","unresolved":false,"context_lines":[{"line_number":1242,"context_line":"            default\u003dNone,"},{"line_number":1243,"context_line":"            help\u003d_(\u0027The last server of the previous page. Display \u0027"},{"line_number":1244,"context_line":"                   \u0027list of servers after marker. Display all servers if not \u0027"},{"line_number":1245,"context_line":"                   \u0027specified. When used with \"--deleted\", the marker must be \u0027"},{"line_number":1246,"context_line":"                   \u0027an ID, otherwise a name or ID can be used\u0027),"},{"line_number":1247,"context_line":"        )"},{"line_number":1248,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_7ea64a10","line":1245,"range":{"start_line":1245,"start_character":46,"end_line":1245,"end_character":57},"updated":"2019-12-17 20:01:41.000000000","message":"Not double quotes, double back-ticks:\n\n``--deleted``\n\nBecause this renders like \"-deleted\" in the docs.","commit_id":"fccd54bed55e144c8840de202eaea5ffb34f015a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6b45934a2a238d0a2ac7f54c0ccc6eea5dc9b4e2","unresolved":false,"context_lines":[{"line_number":1243,"context_line":"            help\u003d_(\u0027The last server of the previous page. Display \u0027"},{"line_number":1244,"context_line":"                   \u0027list of servers after marker. Display all servers if not \u0027"},{"line_number":1245,"context_line":"                   \u0027specified. When used with \"--deleted\", the marker must be \u0027"},{"line_number":1246,"context_line":"                   \u0027an ID, otherwise a name or ID can be used\u0027),"},{"line_number":1247,"context_line":"        )"},{"line_number":1248,"context_line":"        parser.add_argument("},{"line_number":1249,"context_line":"            \u0027--limit\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_3eb0d240","line":1246,"range":{"start_line":1246,"start_character":57,"end_line":1246,"end_character":61},"updated":"2019-12-17 20:01:41.000000000","message":"used. (end the sentence with a period since there are multiple sentences)","commit_id":"fccd54bed55e144c8840de202eaea5ffb34f015a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5182b6e56d48a7ed30a37d766a82a1a211ae1376","unresolved":false,"context_lines":[{"line_number":1455,"context_line":"        if parsed_args.marker:"},{"line_number":1456,"context_line":"            # Check if both \"--marker\" and \"--deleted\" are used."},{"line_number":1457,"context_line":"            # In that scenario a lookup is not needed as the marker"},{"line_number":1458,"context_line":"            # needs to be an ID."},{"line_number":1459,"context_line":"            if parsed_args.deleted:"},{"line_number":1460,"context_line":"                marker_id \u003d parsed_args.marker"},{"line_number":1461,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_3e89b26e","line":1458,"range":{"start_line":1458,"start_character":31,"end_line":1458,"end_character":32},"updated":"2019-12-17 20:03:18.000000000","message":"nit: \"because find_resource does not handle deleted resources.\"","commit_id":"4acbe782668751a3edc815399fce8a93fe9e7f1f"}],"openstackclient/tests/functional/compute/v2/test_server.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae4c11d2d63f5fa59890e83890bb5e92c71af82e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            \u0027server list -f json --marker \u0027 + id2"},{"line_number":79,"context_line":"        ))"},{"line_number":80,"context_line":"        col_name \u003d [x[\"Name\"] for x in cmd_output]"},{"line_number":81,"context_line":"        self.assertIn(name1, col_name)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # Test list --marker with Name"},{"line_number":84,"context_line":"        cmd_output \u003d json.loads(self.openstack("}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_1da163a9","line":81,"updated":"2019-12-17 15:11:56.000000000","message":"This looks a bit weird to me, but I always have to go back and remember that the marker is the ID of the last-seen item in the list so it won\u0027t be returned in the next result set, so you\u0027re using id2 as the marker so checking that server1 is in the result.","commit_id":"8513fc2074e261cebb79c86d62616fbbf95f3a00"}],"releasenotes/notes/bug-2006761-9041d1b25e845cfb.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae4c11d2d63f5fa59890e83890bb5e92c71af82e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes the \"No server with a name or ID of \u0027id\u0027 exits\" when running"},{"line_number":5,"context_line":"    openstack server list --deleted --marker. This fix removes using"},{"line_number":6,"context_line":"    a name when both --deleted and --marker are used. In this scenario"},{"line_number":7,"context_line":"    an ID must be supplied."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_5d96fb4b","line":4,"range":{"start_line":4,"start_character":51,"end_line":4,"end_character":56},"updated":"2019-12-17 15:11:56.000000000","message":"exists","commit_id":"8513fc2074e261cebb79c86d62616fbbf95f3a00"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae4c11d2d63f5fa59890e83890bb5e92c71af82e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes the \"No server with a name or ID of \u0027id\u0027 exits\" when running"},{"line_number":5,"context_line":"    openstack server list --deleted --marker. This fix removes using"},{"line_number":6,"context_line":"    a name when both --deleted and --marker are used. In this scenario"},{"line_number":7,"context_line":"    an ID must be supplied."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_bd7e0f19","line":5,"updated":"2019-12-17 15:11:56.000000000","message":"Put the command in `` ... `` formatting so it renders the options properly.","commit_id":"8513fc2074e261cebb79c86d62616fbbf95f3a00"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae4c11d2d63f5fa59890e83890bb5e92c71af82e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes the \"No server with a name or ID of \u0027id\u0027 exits\" when running"},{"line_number":5,"context_line":"    openstack server list --deleted --marker. This fix removes using"},{"line_number":6,"context_line":"    a name when both --deleted and --marker are used. In this scenario"},{"line_number":7,"context_line":"    an ID must be supplied."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_dde66be8","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":13},"updated":"2019-12-17 15:11:56.000000000","message":"Remove \u0027openstack\u0027 from the command list example here.","commit_id":"8513fc2074e261cebb79c86d62616fbbf95f3a00"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae4c11d2d63f5fa59890e83890bb5e92c71af82e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes the \"No server with a name or ID of \u0027id\u0027 exits\" when running"},{"line_number":5,"context_line":"    openstack server list --deleted --marker. This fix removes using"},{"line_number":6,"context_line":"    a name when both --deleted and --marker are used. In this scenario"},{"line_number":7,"context_line":"    an ID must be supplied."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_3d721f4c","line":5,"range":{"start_line":5,"start_character":46,"end_line":5,"end_character":50},"updated":"2019-12-17 15:11:56.000000000","message":"nit: s/This/The/ - the release notes are read in aggregate so don\u0027t write this like a commit message because the reader won\u0027t have context.","commit_id":"8513fc2074e261cebb79c86d62616fbbf95f3a00"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae4c11d2d63f5fa59890e83890bb5e92c71af82e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes the \"No server with a name or ID of \u0027id\u0027 exits\" when running"},{"line_number":5,"context_line":"    openstack server list --deleted --marker. This fix removes using"},{"line_number":6,"context_line":"    a name when both --deleted and --marker are used. In this scenario"},{"line_number":7,"context_line":"    an ID must be supplied."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_bd936f4e","line":6,"range":{"start_line":6,"start_character":21,"end_line":6,"end_character":30},"updated":"2019-12-17 15:11:56.000000000","message":"``--deleted``","commit_id":"8513fc2074e261cebb79c86d62616fbbf95f3a00"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae4c11d2d63f5fa59890e83890bb5e92c71af82e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes the \"No server with a name or ID of \u0027id\u0027 exits\" when running"},{"line_number":5,"context_line":"    openstack server list --deleted --marker. This fix removes using"},{"line_number":6,"context_line":"    a name when both --deleted and --marker are used. In this scenario"},{"line_number":7,"context_line":"    an ID must be supplied."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_dd98ab6a","line":6,"range":{"start_line":6,"start_character":35,"end_line":6,"end_character":43},"updated":"2019-12-17 15:11:56.000000000","message":"``--marker``","commit_id":"8513fc2074e261cebb79c86d62616fbbf95f3a00"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae4c11d2d63f5fa59890e83890bb5e92c71af82e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes the \"No server with a name or ID of \u0027id\u0027 exits\" when running"},{"line_number":5,"context_line":"    openstack server list --deleted --marker. This fix removes using"},{"line_number":6,"context_line":"    a name when both --deleted and --marker are used. In this scenario"},{"line_number":7,"context_line":"    an ID must be supplied."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_1d8f2323","line":6,"range":{"start_line":6,"start_character":6,"end_line":6,"end_character":10},"updated":"2019-12-17 15:11:56.000000000","message":"name for the marker","commit_id":"8513fc2074e261cebb79c86d62616fbbf95f3a00"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae4c11d2d63f5fa59890e83890bb5e92c71af82e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Fixes the \"No server with a name or ID of \u0027id\u0027 exits\" when running"},{"line_number":5,"context_line":"    openstack server list --deleted --marker. This fix removes using"},{"line_number":6,"context_line":"    a name when both --deleted and --marker are used. In this scenario"},{"line_number":7,"context_line":"    an ID must be supplied."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_9d9a335e","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":26},"updated":"2019-12-17 15:11:56.000000000","message":"supplied for the marker.","commit_id":"8513fc2074e261cebb79c86d62616fbbf95f3a00"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae4c11d2d63f5fa59890e83890bb5e92c71af82e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3fa7e38b_1ddde312","line":8,"updated":"2019-12-17 15:11:56.000000000","message":"I think Dean usually wants something like this in the release notes as well for reference on its own line at the end (see others for examples):\n\n[Story `2006761 \u003chttps://storyboard.openstack.org/#!/story/2006761\u003e`_]\n\nSee https://bbdcc04aac9c92500632-b8f5baac1536449624f55cad0c5791e8.ssl.cf5.rackcdn.com/691045/7/check/build-openstack-releasenotes/dfd1aa4/docs/unreleased.html#relnotes-4-0-0-bug-fixes for examples.","commit_id":"8513fc2074e261cebb79c86d62616fbbf95f3a00"}]}