)]}'
{"id":"openstack%2Fpython-openstackclient~691865","triplet_id":"openstack%2Fpython-openstackclient~master~I5658e3df5af1100e139623505d0375588edae63c","project":"openstack/python-openstackclient","branch":"master","topic":"tech-debt","hashtags":[],"change_id":"I5658e3df5af1100e139623505d0375588edae63c","subject":"Remove redundant OpenStackShell.prepare_to_run_command","status":"MERGED","created":"2019-10-29 13:57:34.000000000","updated":"2020-01-13 19:31:21.000000000","submitted":"2020-01-13 19:27:52.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"691865-1578943672918-bbef5f2b","meta_rev_id":"9a8dc1ed5c5a154b7082a01fc10ab7f9008471be","_number":691865,"virtual_id_number":691865,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-01-13 19:27:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"recommended":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-12-02 11:58:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},{"value":2,"date":"2020-01-13 17:26:10.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2019-11-29 14:52:50.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},{"value":1,"date":"2020-01-13 17:26:10.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-29 14:52:50.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2019-12-02 11:58:27.000000000","updated_by":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"reviewer":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"state":"REVIEWER"},{"updated":"2020-01-13 17:26:10.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2020-01-13 19:27:52.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a33b7023b8b149826ba7f0b20934fc692cad3f87","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-10-29 13:57:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"52129251f2e8b8beb9e2c1fab0984eeeda63928b","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-10-29 13:59:07.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f53c790c6ebc1679fa719708902cc44c74fe0258","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-29 16:13:32.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/f151565a81d04f10867c4e8e54e4ceb6 : SUCCESS in 5m 20s (non-voting)\n- osc-tox-py27-tips https://zuul.opendev.org/t/openstack/build/c677135d18d741c49f64a61b206c82a4 : SUCCESS in 4m 18s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/9a323f5933b540cc8fd50870ddefeb4f : SUCCESS in 4m 39s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/081e5fdfe5f94d15b05b49daffe8e692 : SUCCESS in 5m 41s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b977453ac3e847f598a884daf2984ea9 : SUCCESS in 3m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/221f65105a1947418d41224326671bd3 : SUCCESS in 4m 04s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/7cdca6908b344f3da13f0fdc00be1460 : SUCCESS in 3m 59s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/562c4c5e096d4b9bb23ec0d345541d72 : SUCCESS in 3m 28s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/a480599c6ed845048f5a83024b514cd2 : SUCCESS in 3m 39s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/962f8028976c46ddab61fddefda8577c : SUCCESS in 5m 08s\n- tempest-full https://zuul.opendev.org/t/openstack/build/8a4143391d614d4680eda6ae65f8e25b : FAILURE in 1h 25m 42s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/a6e2b0bc44ea44cea0b098d25edd63fc : SUCCESS in 1h 12m 00s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/b54f48c0e8fc4ae1be797dcc75252b0f : FAILURE in 28m 58s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/019a3a933f404e48b9fcf390b0b96bf5 : FAILURE in 28m 41s","accounts_in_message":[],"_revision_number":1},{"id":"4d3806cce053864b5e6a0ef104cf286b9e10d4a9","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-10-29 16:22:39.000000000","message":"Patch Set 1:\n\nWell... that\u0027s a weird failure.","accounts_in_message":[],"_revision_number":1},{"id":"8fecc5df6929b5e516c634e8b72bec1ec52d95d2","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-10-31 16:53:30.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"c12bedddcd883e9197d58bf7bdfd3842abd2337d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-31 18:26:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/70cdc5d85229465fbcc4176d8bde279a : SUCCESS in 4m 38s (non-voting)\n- osc-tox-py27-tips https://zuul.opendev.org/t/openstack/build/957974d921d948f3ad0848839555ee9c : SUCCESS in 4m 08s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/e99e6943628b4b56bed7930bbd46e7e2 : SUCCESS in 4m 26s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d762380850154b2eac312f31de786209 : SUCCESS in 4m 13s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/787cc3cb4cb244f78f8cdb9425a678de : SUCCESS in 4m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ccc9c590640446329b3484e1e60b3c5b : SUCCESS in 3m 40s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/0e147eceb9c2442297f8a80f551abe25 : SUCCESS in 3m 55s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a7b944e4ba4d40579a1cd9c434067334 : SUCCESS in 3m 15s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/c84b107e82b8452b9a656ba37caf9f2f : SUCCESS in 3m 35s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5b0191ce908d49879ba63d90f5cf9831 : SUCCESS in 5m 15s\n- tempest-full https://zuul.opendev.org/t/openstack/build/c4bcb2ca3ab94176aaf9807f6cd2981b : SUCCESS in 1h 30m 40s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/e28c014e65fc48a4a0e0daf6e4f933fa : SUCCESS in 1h 17m 18s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/b89482c4afca44229e63e8ab70456046 : SUCCESS in 55m 45s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/ddadf1a7d20040ccb1ceff71622662c5 : SUCCESS in 1h 01m 47s","accounts_in_message":[],"_revision_number":2},{"id":"5ba3f936de6b7fde58d34927840ee513566fe5af","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-11-29 14:52:50.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"9f9fe79a59c7b46daf1ae8d9841a90323f96c27a","author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"date":"2019-12-02 11:58:27.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"458290bd10cd741dbc627b659b65b99ce54c5b8c","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2020-01-13 17:26:10.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"6978b54b7f3dd598e7f88c0fa0a2f7fe96307e01","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-13 17:26:26.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"3818191b1ed25ee3025f877dd629cf2f5a46fa0f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-13 19:27:52.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/01a9dea334da4859bffdcfa39a69deb1 : SUCCESS in 5m 32s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/be030b9f635049839f8bdcaf5e430f36 : SUCCESS in 5m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5e1f47f3f1e1432ea2c15348d5041bf2 : SUCCESS in 3m 20s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d76b77a0a2674ad3989fcd75a73c9f75 : SUCCESS in 3m 43s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/1bd406ff58234dfb8471514ef471d349 : SUCCESS in 4m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/02ec46fc8563463987b6c16c8d8a9563 : SUCCESS in 6m 01s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/cf1835febc464201acca9c4a69fda353 : SUCCESS in 1h 26m 23s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/876aec1187f14bfcb0fb1c3fd59694d1 : SUCCESS in 46m 22s","accounts_in_message":[],"_revision_number":2},{"id":"734657399f8652f6862a2907e62b9d47c6a1bea2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-13 19:27:52.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"5ce4ef08ebda03bccd370bec14cade65e111bb66","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-13 19:31:21.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/09921504e3074f5b98b0338d83b7a0d2 : SUCCESS in 1m 20s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"40f74816c11c2d46eb0595795ef3611c18920482","revisions":{"fc1edc68378aee572e6538ec55908fff02ca5d8e":{"kind":"REWORK","_number":1,"created":"2019-10-29 13:57:34.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/65/691865/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/65/691865/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/691865/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/691865/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/691865/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/65/691865/1"}}},"commit":{"parents":[{"commit":"45af14ca72b44c03f14189ac61a29253faf03bd7","subject":"Merge \"Doc: launchpad \u003d\u003e storyboard\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/45af14ca72b44c03f14189ac61a29253faf03bd7"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-10-29 13:55:51.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-10-29 13:55:51.000000000","tz":-300},"subject":"Remove redundant OpenStackShell.prepare_to_run_command","message":"Remove redundant OpenStackShell.prepare_to_run_command\n\nosc-lib\u0027s OpenStackShell.prepare_to_run_command has been a superset of\npython-openstackclient\u0027s since at least osc-lib 1.4.0. We require 1.14.0\nnow, so the redundant override can be removed.\n\nChange-Id: I5658e3df5af1100e139623505d0375588edae63c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/fc1edc68378aee572e6538ec55908fff02ca5d8e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/fc1edc68378aee572e6538ec55908fff02ca5d8e"}]},"branch":"refs/heads/master"},"40f74816c11c2d46eb0595795ef3611c18920482":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-10-31 16:53:30.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/65/691865/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/65/691865/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/691865/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/691865/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/691865/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/65/691865/2"}}},"commit":{"parents":[{"commit":"f1d742f32adeb662a3fdf8fa3ef3bc391e71ed81","subject":"Fix functional tests for py3","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f1d742f32adeb662a3fdf8fa3ef3bc391e71ed81"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-10-29 13:55:51.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-10-31 16:53:30.000000000","tz":0},"subject":"Remove redundant OpenStackShell.prepare_to_run_command","message":"Remove redundant OpenStackShell.prepare_to_run_command\n\nosc-lib\u0027s OpenStackShell.prepare_to_run_command has been a superset of\npython-openstackclient\u0027s since at least osc-lib 1.4.0. We require 1.14.0\nnow, so the redundant override can be removed.\n\nChange-Id: I5658e3df5af1100e139623505d0375588edae63c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/40f74816c11c2d46eb0595795ef3611c18920482"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/40f74816c11c2d46eb0595795ef3611c18920482"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}