)]}'
{"openstackclient/tests/functional/compute/v2/test_keypair.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2ad25c8a3b841aa980469c519af341484aa5b104","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        1) Create keypair with private key file"},{"line_number":109,"context_line":"        2) Delete keypair"},{"line_number":110,"context_line":"        \"\"\""},{"line_number":111,"context_line":"        with tempfile.NamedTemporaryFile(mode\u003d\u0027w+\u0027) as f:"},{"line_number":112,"context_line":"            cmd_output \u003d json.loads(self.openstack("},{"line_number":113,"context_line":"                \u0027keypair create -f json --private-key %s tmpkey\u0027 % f.name,"},{"line_number":114,"context_line":"            ))"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_08b5fc7d","line":111,"range":{"start_line":111,"start_character":46,"end_line":111,"end_character":50},"updated":"2019-10-31 15:50:54.000000000","message":"note to reviewers: this could probably be a \u0027r\u0027, but the default is \u0027w+b\u0027 and I was going for the minimal delta from what existed beforehand.","commit_id":"f1d742f32adeb662a3fdf8fa3ef3bc391e71ed81"}],"openstackclient/tests/functional/identity/v2/common.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"eea7b44007b43a168af7b1973dedcabae0967bfd","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            # TODO(dtroyer): Actually determine if Identity v2 admin is"},{"line_number":64,"context_line":"            #                enabled in the target cloud.  Tuens out OSC"},{"line_number":65,"context_line":"            #                doesn\u0027t make this easy as it should (yet)."},{"line_number":66,"context_line":"            raise unittest.case.SkipTest(\u0027No Identity v2 admin endpoint?\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @classmethod"},{"line_number":69,"context_line":"    def tearDownClass(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_abdb8dea","line":66,"range":{"start_line":66,"start_character":12,"end_line":66,"end_character":40},"updated":"2019-10-30 23:52:06.000000000","message":"We could also just use \"self.skipTest()\" without the raise. there\u0027s a testtools method for skipping tests ...","commit_id":"62ac2fa3067d7e09b7695f8a4d588829d5db3b22"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"558ca6f6774e677371d7d1965edc98424c798911","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            # TODO(dtroyer): Actually determine if Identity v2 admin is"},{"line_number":64,"context_line":"            #                enabled in the target cloud.  Tuens out OSC"},{"line_number":65,"context_line":"            #                doesn\u0027t make this easy as it should (yet)."},{"line_number":66,"context_line":"            raise unittest.case.SkipTest(\u0027No Identity v2 admin endpoint?\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @classmethod"},{"line_number":69,"context_line":"    def tearDownClass(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_6ba8351f","line":66,"range":{"start_line":66,"start_character":12,"end_line":66,"end_character":40},"in_reply_to":"3fa7e38b_abdb8dea","updated":"2019-10-31 00:18:19.000000000","message":"There\u0027s no \"self\" here in this classmethod. But even if there were, that does the same thing, which is raise the exception. And the weird thing is that the code that special cases the exception is looking for the wrong one (from unittest rather than unittest2) in py3 :(","commit_id":"62ac2fa3067d7e09b7695f8a4d588829d5db3b22"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"eceb868303b99ec906b79b6d61a10976ac3b98a3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            # TODO(dtroyer): Actually determine if Identity v2 admin is"},{"line_number":64,"context_line":"            #                enabled in the target cloud.  Tuens out OSC"},{"line_number":65,"context_line":"            #                doesn\u0027t make this easy as it should (yet)."},{"line_number":66,"context_line":"            raise unittest.case.SkipTest(\u0027No Identity v2 admin endpoint?\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @classmethod"},{"line_number":69,"context_line":"    def tearDownClass(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_92ed99f1","line":66,"range":{"start_line":66,"start_character":27,"end_line":66,"end_character":31},"updated":"2019-10-31 13:42:29.000000000","message":"Why is \u0027case\u0027 needed?\n\nhttps://docs.python.org/3.6/library/unittest.html#unittest.SkipTest\n\nhttps://docs.python.org/2.7/library/unittest.html#unittest.SkipTest","commit_id":"f1d742f32adeb662a3fdf8fa3ef3bc391e71ed81"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"e452d1aff2a5aacf9343ae4ef1c83c127f57440b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            # TODO(dtroyer): Actually determine if Identity v2 admin is"},{"line_number":64,"context_line":"            #                enabled in the target cloud.  Tuens out OSC"},{"line_number":65,"context_line":"            #                doesn\u0027t make this easy as it should (yet)."},{"line_number":66,"context_line":"            raise unittest.case.SkipTest(\u0027No Identity v2 admin endpoint?\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @classmethod"},{"line_number":69,"context_line":"    def tearDownClass(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_92a83920","line":66,"range":{"start_line":66,"start_character":27,"end_line":66,"end_character":31},"in_reply_to":"3fa7e38b_92ed99f1","updated":"2019-10-31 13:58:28.000000000","message":"Probably isn\u0027t. But this whole thing shouldn\u0027t be needed. There\u0027s a weird thing happening here where testtools tries to load up unittest/unittest2 but prefers the latter, so TestCase.SkipTest is resolving to the unittest2 incarnation; but for some reason when running this test suite, we end up in a code path that checks for the unittest one :(\n\nAnyway, I used unittest.case.SkipTest because that was the exact symbol showing up in pdb and there was enough weirdness going on that I didn\u0027t want to take any chances.","commit_id":"f1d742f32adeb662a3fdf8fa3ef3bc391e71ed81"}]}