)]}'
{"id":"openstack%2Fpython-openstackclient~693073","triplet_id":"openstack%2Fpython-openstackclient~master~I0d7432f13642fbccd5ca79da9c76adfcbabb5fa9","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1851391","hashtags":[],"change_id":"I0d7432f13642fbccd5ca79da9c76adfcbabb5fa9","subject":"Refactor AggregateTests","status":"MERGED","created":"2019-11-05 19:37:10.000000000","updated":"2019-11-06 06:00:56.000000000","submitted":"2019-11-06 05:59:24.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"693073-1573019964446-91d4b73c","meta_rev_id":"39de58012d2d7224dd6e4bf5ca235966b63f13f2","_number":693073,"virtual_id_number":693073,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-11-06 05:59:24.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2019-11-06 02:52:15.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-11-06 01:02:42.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-11-06 01:02:42.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-06 01:02:42.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2019-11-06 05:59:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"49c3648ddb6ad8d3ab7c3fa23232d6c1ec4df6a9","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-11-05 19:37:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"caaa6ed23c3a296b6c74476b31df8e09920318dc","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-11-05 20:58:05.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nI added the wait_for_status() attempting to force serialization here, we had a bunch of tests that were racy when running in parallel due to overuse of classmethods, I didn\u0027t know if aggregate create was synchronous, so thanks.","accounts_in_message":[],"_revision_number":1},{"id":"2aa7c3f81784e768de3857c50b8e181b88e1a56a","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-11-05 21:02:02.000000000","message":"Patch Set 1:\n\n\u003e I didn\u0027t know if aggregate create was synchronous, so thanks.\n\nOh, hell, I was pretty much just assuming. Since the `aggregate create` command returns an ID, I would very much expect that to mean it really created the aggregate and that it has that ID. It also wouldn\u0027t make a lot of sense for a small CRUD operation like this to be asynchronous.\n\n[Later] The POST /os-aggregates API returns 200 rather than 202, which confirms it\u0027s synchronous. Phew.","accounts_in_message":[],"_revision_number":1},{"id":"a9b6e913c7452bec4fe9f892eb52f7eb18dbc36d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-05 21:21:43.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/3afd0736716e4f8e82ac7ab41c44bd3f : SUCCESS in 6m 04s (non-voting)\n- osc-tox-py27-tips https://zuul.opendev.org/t/openstack/build/3672faf0de7b41bfbad2eac1743d3f8f : SUCCESS in 6m 07s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/8911df2c62364076865a5a2ad40f169a : SUCCESS in 6m 25s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/42c244b0034040fb87e04bdcb518cbf2 : SUCCESS in 5m 41s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/37e610e4bafb43a0a6a89c7b831b0a63 : SUCCESS in 5m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3807419720ba4b0d88ba7e3419615c66 : FAILURE in 5m 11s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/7abfe0c0044547848779bc3a02c28834 : SUCCESS in 4m 31s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/30135483bebd4815aa40649e00c52fa7 : SUCCESS in 4m 19s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/dcdbfe800588421096df993e6f77387a : SUCCESS in 4m 55s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bc84dad7bfcf43fd98c79312a0112628 : SUCCESS in 6m 07s\n- tempest-full https://zuul.opendev.org/t/openstack/build/6907f203b92e47ff8d4a9d968e8426ca : SUCCESS in 1h 29m 22s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/7621916021e74238a36dfd5ef72d5e57 : SUCCESS in 1h 24m 49s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/26b9757a32294136a706074c17563c95 : SUCCESS in 54m 56s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/b8c608c900fb4ad2bc0f2e90a3fce0c3 : SUCCESS in 56m 47s","accounts_in_message":[],"_revision_number":1},{"id":"cf8380f6354d9b35c3b4adf9b06106ce8bee5849","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-11-05 21:32:03.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"01fb3e24e0824be55e049f7c3f6cb8094803da1e","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-11-05 21:32:17.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"f0c1ca6e55e124c4061fd4f45ed84072430e3f59","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-11-05 21:32:27.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"42c92a6c9f24c7bbf204ae9aeda2cad4e2e12273","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-05 23:16:30.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/1ecb9ac1996a4f62872ae5f1e2be1675 : SUCCESS in 4m 21s (non-voting)\n- osc-tox-py27-tips https://zuul.opendev.org/t/openstack/build/bd11991c5ce541bb8666545e08b32757 : SUCCESS in 4m 04s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/d891610ef932455b8dbd31326d1a564c : SUCCESS in 4m 07s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9231d53b5f984b85a3f1629adecc2175 : SUCCESS in 4m 18s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5a82589ca62c4a8b9cace0138395cf22 : SUCCESS in 3m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fa4671d5607941458a0fa706d5a347c9 : SUCCESS in 4m 04s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/2b6f43f3f9b1438283badc170233d6ef : SUCCESS in 4m 03s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/585a3197458643738d56f4bb14ec18f1 : SUCCESS in 3m 04s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/1679e3ab1da74597ad6d88850cb4854e : SUCCESS in 3m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4066963bc1954f48a0f0b186f9619e4f : SUCCESS in 5m 07s\n- tempest-full https://zuul.opendev.org/t/openstack/build/b48696b1adce4a7f8ea0790095fa535b : SUCCESS in 1h 38m 38s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/1efb50bae6e1457897c6e29dd7847ea0 : SUCCESS in 1h 31m 07s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/5924635db8ea4478977748c858bda0f9 : SUCCESS in 55m 47s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/ea79b06281f44887b8882910962076df : SUCCESS in 52m 29s","accounts_in_message":[],"_revision_number":2},{"id":"a244795d6764b246522b77d326867dd1cc55ed7f","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-11-06 01:02:42.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"2a1dc22ab9b41b9963e37bb6b5ed00562ca76a00","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-06 01:02:54.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"5614d1c182fd7ae84b2519e4aa8f22c78b69d460","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-06 02:37:27.000000000","message":"Patch Set 2: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- osc-tox-py27-tips https://zuul.opendev.org/t/openstack/build/ceaac703cc644b6eb369a6fe15c8fa35 : SUCCESS in 4m 01s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/ba7c7d2f65d441f6a06c8ece9b43f826 : SUCCESS in 3m 37s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/81aabb3c8c744324b8199394dd1c388f : SUCCESS in 2m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bf6fdefd1ee64f838c53e27d8e185dc8 : SUCCESS in 2m 53s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/28d4c7ece7d340059d10910c961ad0ae : SUCCESS in 2m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b25078c2eeae4ce7857ab2470cc230c7 : SUCCESS in 3m 13s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/05decb8e06c54467b99b1e4fc44582a3 : SUCCESS in 3m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5f55bfa5a08346f38fc4101bdeda25ef : SUCCESS in 4m 37s\n- tempest-full https://zuul.opendev.org/t/openstack/build/a623ed0fab5a4ca7acb4d05f0549f1e1 : SUCCESS in 1h 32m 46s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/9d4addff261b4acf9491b12bfb139bf5 : SUCCESS in 1h 17m 17s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/8353d6c16df34f3d9e59b33b2cdfe888 : FAILURE in 59m 10s","accounts_in_message":[],"_revision_number":2},{"id":"62e97e7211cb0c1254d22fdef8b1ee5a5e2994c2","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-11-06 02:52:15.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"6b32d5988408d7dfb4bb69d8ca5eb8b1ea5b8726","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-06 04:26:26.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/7f0e36ff7ed6411caa22d097e9e8f649 : SUCCESS in 3m 47s (non-voting)\n- osc-tox-py27-tips https://zuul.opendev.org/t/openstack/build/0b6149b7995b4da694a8e87d3990e489 : SUCCESS in 4m 56s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/e63fed6538e840b1bd5969e69315ec39 : SUCCESS in 4m 15s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/44e6ec33fa4d40ceab993446beb5da03 : SUCCESS in 3m 44s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ae0195c6d95146adb6d2565da9aec37d : SUCCESS in 4m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/08cd7497b4e74c45a29de36872e8a1f6 : SUCCESS in 4m 45s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/f85862f0737a4aa599136570b399e3d3 : SUCCESS in 2m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4f33fd35d37c43dc88a164263f8c54f1 : SUCCESS in 3m 07s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/6a6e182546df42e983f10247cd5e0a51 : SUCCESS in 3m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b92601cc23e34ece8b6d3b4a1a749bf5 : SUCCESS in 4m 47s\n- tempest-full https://zuul.opendev.org/t/openstack/build/e1236f035d884ee484c6966445c5a27a : SUCCESS in 1h 28m 49s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/7b6842dd87f54a2a830c1019a5deb4eb : SUCCESS in 1h 15m 14s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/d53eca1093e14923b7c492b5ab100b03 : SUCCESS in 47m 33s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/30d9a396c3ad420bb643a634a30f6d76 : SUCCESS in 47m 43s","accounts_in_message":[],"_revision_number":2},{"id":"2d4c8b5c99126f52669074a4675dcd3aa249083d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-06 04:26:37.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"1a89b224bba8d600aa97729ab3ac21e4923b315a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-06 05:59:24.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"d4742b0c08ccc153b94be38821232928240c7d44","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-06 05:59:24.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- osc-tox-py27-tips https://zuul.opendev.org/t/openstack/build/8d359ab8b7d24b48ad4b2f37e37d1504 : SUCCESS in 4m 19s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/824c6e5220df47e38fa4e4c72bbf33a8 : SUCCESS in 4m 09s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/31f2c7412636416ab9ff5a604c146d0d : SUCCESS in 4m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8517ab6cea874935af406339b6d4fe75 : SUCCESS in 3m 24s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/c1df5ad36e6246769a2e51435600161c : SUCCESS in 2m 54s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/29f8909554954f0c828ae4ed41a23d2d : SUCCESS in 3m 15s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/2dcfbc523c5e4ae3b05220c3d8617134 : SUCCESS in 3m 06s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cae4deda2ae04cb58eb27bb23eae7983 : SUCCESS in 4m 46s\n- tempest-full https://zuul.opendev.org/t/openstack/build/9576c5105cf842698f4bc06c565ac600 : SUCCESS in 1h 25m 30s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/77c2eb603f6748a4bd6c8de9d99a5dd7 : SUCCESS in 1h 27m 20s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/96a5afca18c44291a85e14ffdcd263ee : SUCCESS in 48m 46s","accounts_in_message":[],"_revision_number":2},{"id":"cf6f0084ef1cd8962ea619ba1282f9376268a2e8","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-06 06:00:56.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/eb8e67711ae44c0b8f7dfdf35808dadc : SUCCESS in 1m 14s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3b409e4d0e136380042a59a421ec4c4dc5b95c18","revisions":{"df2f7a912ffc0e295c0808879b209fff39216cb9":{"kind":"REWORK","_number":1,"created":"2019-11-05 19:37:10.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/73/693073/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/73/693073/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/73/693073/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/73/693073/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/73/693073/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/73/693073/1"}}},"commit":{"parents":[{"commit":"d17a1c8039807cdac29e77eb5f0724d181bdd831","subject":"Merge \"neutron: autogenerate docs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d17a1c8039807cdac29e77eb5f0724d181bdd831"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-11-05 19:26:19.000000000","tz":-360},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-11-05 19:26:19.000000000","tz":-360},"subject":"Refactor AggregateTests","message":"Refactor AggregateTests\n\nWhile investigating the referenced story/bug I noticed that\nwait_for_status in\nopenstackclient.tests.functional.compute.v2.test_aggregate.AggregateTests\nwas doing a lot more than it should ever need to (it probably got copied\nin from somewhere). The two places calling it only need to a) check the\noutput of `openstack aggregate show`, and b) try once -- since they just\ngot done creating the aggregate synchronously, there should never be a\nneed to delay/retry. So this commit removes the helper method and just\ninlines the check.\n\nAt the same time, the addCleanup(aggregate delete) directives are moved\nabove their respective creates. This is a defensive best practice which\nmakes sure cleanup happens even if something fails very soon after the\nactual back-end create (as was in fact the case with the referenced\nbug/story).\n\nIt is unknown whether this will impact the referenced bug.\n\nChange-Id: I0d7432f13642fbccd5ca79da9c76adfcbabb5fa9\nStory: 2006811\nRelated-Bug: #1851391\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/df2f7a912ffc0e295c0808879b209fff39216cb9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/df2f7a912ffc0e295c0808879b209fff39216cb9"}]},"branch":"refs/heads/master"},"3b409e4d0e136380042a59a421ec4c4dc5b95c18":{"kind":"REWORK","_number":2,"created":"2019-11-05 21:32:17.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/73/693073/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/73/693073/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/73/693073/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/73/693073/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/73/693073/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/73/693073/2"}}},"commit":{"parents":[{"commit":"d17a1c8039807cdac29e77eb5f0724d181bdd831","subject":"Merge \"neutron: autogenerate docs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d17a1c8039807cdac29e77eb5f0724d181bdd831"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-11-05 19:26:19.000000000","tz":-360},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-11-05 21:32:15.000000000","tz":0},"subject":"Refactor AggregateTests","message":"Refactor AggregateTests\n\nWhile investigating the referenced story/bug I noticed that\nwait_for_status in\nopenstackclient.tests.functional.compute.v2.test_aggregate.AggregateTests\nwas doing a lot more than it should ever need to (it probably got copied\nin from somewhere). The two places calling it only need to a) check the\noutput of `openstack aggregate show`, and b) try once -- since they just\ngot done creating the aggregate synchronously, there should never be a\nneed to delay/retry. So this commit removes the helper method and just\ninlines the check.\n\nAt the same time, the addCleanup(aggregate delete) directives are moved\nabove their respective creates. This is a defensive best practice which\nmakes sure cleanup happens even if something fails very soon after the\nactual back-end create (as was in fact the case with the referenced\nbug/story).\n\nIt is unknown whether this will impact the referenced bug.\n\nChange-Id: I0d7432f13642fbccd5ca79da9c76adfcbabb5fa9\nStory: 2006811\nRelated-Bug: #1851391\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3b409e4d0e136380042a59a421ec4c4dc5b95c18"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3b409e4d0e136380042a59a421ec4c4dc5b95c18"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}