)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"16c565f34ce33036b53c4681fe907c254a32aae6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Daniel Bengtsson \u003cdbengt@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-11-15 10:06:35 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Stop configuring install_command in tox."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, we are overriding \u0027install_command\u0027 to use \u0027pip\u0027. This is"},{"line_number":10,"context_line":"considered poor behavior and \u0027python -m pip\u0027 should be used instead:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"https://snarky.ca/why-you-should-use-python-m-pip/"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It turns out that this is the the default value provided by tox:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"https://tox.readthedocs.io/en/latest/config.html#conf-install_command"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"So we can remove the line and simply use the default value."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I410173d5fdcd8c592d98eed2f48b98e06299e8b3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_3d5c0a18","line":18,"range":{"start_line":7,"start_character":0,"end_line":18,"end_character":59},"updated":"2019-11-15 09:29:31.000000000","message":"You not stop only to configure `install_command` you also introduce `python -m pip` in some target, so can you also reflect these changes in your message please.","commit_id":"be2b69b927f776cc592a5563658623db8aa6cbfe"}],"tox.ini":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"da3173efb896af9262f0d3f58d8f299b4fdb16eb","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"[testenv]"},{"line_number":11,"context_line":"usedevelop \u003d True"},{"line_number":12,"context_line":"basepython \u003d python3"},{"line_number":13,"context_line":"install_command \u003d pip install {opts} {packages}"},{"line_number":14,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":15,"context_line":"         OS_STDOUT_CAPTURE\u003d1"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_787554c8","side":"PARENT","line":12,"updated":"2020-01-08 20:18:48.000000000","message":"I don\u0027t think we want to remove basepython just yet. Still a lot of folks using systems with py2 as the default python, so we should keep this to make sure tox knows to use python3 instead.","commit_id":"2c676b60b15b615e7a1e1c4255b4461f0f2a09a6"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"e0ac58d6fd4eea236d9a6bd9aa160c26694ee31f","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"[testenv]"},{"line_number":11,"context_line":"usedevelop \u003d True"},{"line_number":12,"context_line":"basepython \u003d python3"},{"line_number":13,"context_line":"install_command \u003d pip install {opts} {packages}"},{"line_number":14,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":15,"context_line":"         OS_STDOUT_CAPTURE\u003d1"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_d4c44810","side":"PARENT","line":12,"in_reply_to":"3fa7e38b_787554c8","updated":"2020-01-09 13:19:38.000000000","message":"We are now in phase 2 [1] so I think we can go ahead with setup the `basepython` to python3, but maybe I missing something related to the project\u0027s context.\n\n[1] https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html","commit_id":"2c676b60b15b615e7a1e1c4255b4461f0f2a09a6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"764bf47718128a39ca24b852777c036e280ba96f","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[testenv:fast8]"},{"line_number":24,"context_line":"# Use same environment directory as pep8 env to save space and install time"},{"line_number":25,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":26,"context_line":"envdir \u003d {toxworkdir}/pep8"},{"line_number":27,"context_line":"commands \u003d"},{"line_number":28,"context_line":"  {toxinidir}/tools/fast8.sh"}],"source_content_type":"text/x-properties","patch_set":8,"id":"3fa7e38b_b8f6efd4","line":25,"updated":"2020-02-05 15:01:02.000000000","message":"Do we need this? I think \u0027envdir\" in the next line handles it.","commit_id":"c702e31c669b89d8e55c9fa97b50932473a57276"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b4c83bbd093a76752784b2794df26b8cef2cd7b","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[testenv:fast8]"},{"line_number":24,"context_line":"# Use same environment directory as pep8 env to save space and install time"},{"line_number":25,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":26,"context_line":"envdir \u003d {toxworkdir}/pep8"},{"line_number":27,"context_line":"commands \u003d"},{"line_number":28,"context_line":"  {toxinidir}/tools/fast8.sh"}],"source_content_type":"text/x-properties","patch_set":10,"id":"3fa7e38b_dbbfbec8","line":25,"updated":"2020-02-12 04:46:18.000000000","message":"This is unnecessary.\n\"envdir\" in the next line handle it.","commit_id":"00faeb608b70639180deb93e39247e0c59b4d8b9"}]}