)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4739622301979c87dbb0e2647bba393f6b26bc8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9b9eeb25_2f3dbf8a","updated":"2024-09-17 08:52:25.000000000","message":"really old patch, thanks for finding it","commit_id":"b0936c5b3031a0abe50dcf004666e2f58909aa82"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6eeca2cb2ed914a4b273d13300b2a72af59fd937","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6dfc2c99_e4d32c9e","updated":"2024-09-13 16:27:00.000000000","message":"recheck","commit_id":"b0936c5b3031a0abe50dcf004666e2f58909aa82"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8e16cbe933f157bb4d22763edf4bbd5b4cf7d02b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f562395d_44d0ab44","updated":"2024-09-13 16:21:47.000000000","message":"recheck","commit_id":"b0936c5b3031a0abe50dcf004666e2f58909aa82"}],"openstackclient/network/v2/floating_ip.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"bd8cbcd82ed6935d8f91c28efcbb5816c00337a4","unresolved":false,"context_lines":[{"line_number":369,"context_line":"                        formatters\u003d{},"},{"line_number":370,"context_line":"                    ) for s in data))"},{"line_number":371,"context_line":"        except sdk_exceptions.NotFoundException:"},{"line_number":372,"context_line":"            pass"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def take_action_compute(self, client, parsed_args):"},{"line_number":375,"context_line":"        columns \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_95db031f","line":372,"range":{"start_line":372,"start_character":12,"end_line":372,"end_character":16},"updated":"2020-01-13 17:00:41.000000000","message":"Do we not need to return at least a 2-tuple here?  It\u0027s been long enough I don\u0027t recall what cliff will do...will check...","commit_id":"0845720d26bc77189e997d7b75a15898afb40357"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"3b619d912042e96df21a10f0b1c374c3d1cd1098","unresolved":false,"context_lines":[{"line_number":369,"context_line":"                        formatters\u003d{},"},{"line_number":370,"context_line":"                    ) for s in data))"},{"line_number":371,"context_line":"        except sdk_exceptions.NotFoundException:"},{"line_number":372,"context_line":"            pass"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def take_action_compute(self, client, parsed_args):"},{"line_number":375,"context_line":"        columns \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_c198ca6b","line":372,"range":{"start_line":372,"start_character":12,"end_line":372,"end_character":16},"in_reply_to":"3fa7e38b_650c9293","updated":"2020-02-25 16:59:04.000000000","message":"So the desire is that if you request something that is undefined because of an operator choice you get a null return set back instead of an error.  For example, in a TripleO deployment there is no such thing as floating IPs on the undercloud.  If you do an `openstack flosting ip list` you get \"NotFoundException: NotFoundException: Unknown error\" which is misleading.  I would rather there be no error at all and a return code of 0, indicating the null set.","commit_id":"0845720d26bc77189e997d7b75a15898afb40357"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"524852bf243fe0ebcfb2dbb15a1181a6c886f7de","unresolved":false,"context_lines":[{"line_number":369,"context_line":"                        formatters\u003d{},"},{"line_number":370,"context_line":"                    ) for s in data))"},{"line_number":371,"context_line":"        except sdk_exceptions.NotFoundException:"},{"line_number":372,"context_line":"            pass"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def take_action_compute(self, client, parsed_args):"},{"line_number":375,"context_line":"        columns \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_650c9293","line":372,"range":{"start_line":372,"start_character":12,"end_line":372,"end_character":16},"in_reply_to":"3fa7e38b_95db031f","updated":"2020-01-14 02:50:03.000000000","message":"It looks like this is only called in https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/network/common.py\n\nIt is called in a few places. Some just make the call with no checking of the results, but a couple of the calls from take_action return up the results of the call.\n\nIt looks like when that bubbles up to cliff, there could be a problem with this here:\n\nhttps://opendev.org/openstack/cliff/src/branch/master/cliff/display.py#L117\n\nSo probably should have this return some sane failure result.","commit_id":"0845720d26bc77189e997d7b75a15898afb40357"}]}