)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a2b70edd625fde40fccd63c120591705174c15e5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     David Shaughnessy \u003cdavid.shaughnessy@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-12-18 18:51:43 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Extension to the DSCP Marking Rule"},{"line_number":8,"context_line":"This extends the CLI to include the classification_group_id"},{"line_number":9,"context_line":"and the classification_priority value for deciding the relitive"},{"line_number":10,"context_line":"priority of the rules."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_4b6764b9","line":7,"updated":"2020-01-08 20:54:56.000000000","message":"Please add a blank line after the summary line, otherwise git wants to pull it all in as the online summary.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"b8679e9111caac4bd1293809788ab36599bd323d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a2b70edd625fde40fccd63c120591705174c15e5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Extension to the DSCP Marking Rule"},{"line_number":8,"context_line":"This extends the CLI to include the classification_group_id"},{"line_number":9,"context_line":"and the classification_priority value for deciding the relitive"},{"line_number":10,"context_line":"priority of the rules."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I83048af60d7ea5400275c06da91d7959f7a8254d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_6b6260a9","line":9,"range":{"start_line":9,"start_character":55,"end_line":9,"end_character":63},"updated":"2020-01-08 20:54:56.000000000","message":"nit: relative","commit_id":"b8679e9111caac4bd1293809788ab36599bd323d"}],"openstackclient/network/v2/network_classification.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a2b70edd625fde40fccd63c120591705174c15e5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        parser \u003d super(CreateClassification,"},{"line_number":27,"context_line":"                       self).get_parser(prog_name)"},{"line_number":28,"context_line":"        parser.add_argument("},{"line_number":29,"context_line":"            \u0027type\u0027, metavar\u003d\u0027type\u0027,"},{"line_number":30,"context_line":"            help\u003d(\u0027Classification type.\u0027))"},{"line_number":31,"context_line":"        parser.add_argument("},{"line_number":32,"context_line":"            \u0027name\u0027, metavar\u003d\u0027name\u0027, nargs\u003d\u0027?\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8b1f9c07","line":29,"range":{"start_line":29,"start_character":29,"end_line":29,"end_character":33},"updated":"2020-01-08 20:54:56.000000000","message":"Is there a reason for changing these?","commit_id":"b8679e9111caac4bd1293809788ab36599bd323d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a2b70edd625fde40fccd63c120591705174c15e5","unresolved":false,"context_lines":[{"line_number":292,"context_line":"            definition[\u0027flags_mask\u0027] \u003d parsed_args.flags_mask"},{"line_number":293,"context_line":"        # NOTE(davidsha) Ethernet Classification"},{"line_number":294,"context_line":"        if parsed_args.ethertype is not None:"},{"line_number":295,"context_line":"            eth_type \u003d parsed_args.ethertype if isinstance(eth_type, int)\\"},{"line_number":296,"context_line":"                       else int(eth_type, 16)"},{"line_number":297,"context_line":"            definition[\u0027ethertype\u0027] \u003d eth_type"},{"line_number":298,"context_line":"        # NOTE(davidsha) Common IP Classification Values"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ab1a9814","line":295,"range":{"start_line":295,"start_character":59,"end_line":295,"end_character":67},"updated":"2020-01-08 20:54:56.000000000","message":"Was this meant to be parsed_args.ethertype?\n\nBut looking, I don\u0027t think this needs to change. All args are passed in as strings. This also doesn\u0027t appear to be related to the commit message, so maybe this file was not supposed to be included?","commit_id":"b8679e9111caac4bd1293809788ab36599bd323d"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"c13674bf87f444fe94307c479af3fa7166702d6e","unresolved":false,"context_lines":[{"line_number":292,"context_line":"            definition[\u0027flags_mask\u0027] \u003d parsed_args.flags_mask"},{"line_number":293,"context_line":"        # NOTE(davidsha) Ethernet Classification"},{"line_number":294,"context_line":"        if parsed_args.ethertype is not None:"},{"line_number":295,"context_line":"            eth_type \u003d parsed_args.ethertype if isinstance(eth_type, int)\\"},{"line_number":296,"context_line":"                       else int(eth_type, 16)"},{"line_number":297,"context_line":"            definition[\u0027ethertype\u0027] \u003d eth_type"},{"line_number":298,"context_line":"        # NOTE(davidsha) Common IP Classification Values"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_a72b8ee7","line":295,"range":{"start_line":295,"start_character":59,"end_line":295,"end_character":67},"in_reply_to":"3fa7e38b_ab1a9814","updated":"2020-02-13 14:25:43.000000000","message":"Ya, sorry about this.\nThis patch was only supposed to have the QoSDSCPMarking rule changes.\nThese changes in the Neutron classifier cli should be included in the previous patch.","commit_id":"b8679e9111caac4bd1293809788ab36599bd323d"}],"openstackclient/network/v2/network_classification_group.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a2b70edd625fde40fccd63c120591705174c15e5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def get_parser(self, prog_name):"},{"line_number":26,"context_line":"        parser \u003d super(CreateClassificationGroup, self).get_parser(prog_name)"},{"line_number":27,"context_line":"        parser.add_argument("},{"line_number":28,"context_line":"            \u0027name\u0027, metavar\u003d\u0027name\u0027, nargs\u003d\u0027?\u0027,"},{"line_number":29,"context_line":"            help\u003d(\u0027Name of the Classification Group.\u0027))"},{"line_number":30,"context_line":"        parser.add_argument("},{"line_number":31,"context_line":"            \u0027--description\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_abdff835","line":28,"updated":"2020-01-08 20:54:56.000000000","message":"Changing this from a named argument to a positional one is not backwards compatible. I\u0027m not sure I see the reason for needing to do that either.\n\nAlso not able to tell how this change relates to what the commit message says this patch is doing.","commit_id":"b8679e9111caac4bd1293809788ab36599bd323d"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"c13674bf87f444fe94307c479af3fa7166702d6e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def get_parser(self, prog_name):"},{"line_number":26,"context_line":"        parser \u003d super(CreateClassificationGroup, self).get_parser(prog_name)"},{"line_number":27,"context_line":"        parser.add_argument("},{"line_number":28,"context_line":"            \u0027name\u0027, metavar\u003d\u0027name\u0027, nargs\u003d\u0027?\u0027,"},{"line_number":29,"context_line":"            help\u003d(\u0027Name of the Classification Group.\u0027))"},{"line_number":30,"context_line":"        parser.add_argument("},{"line_number":31,"context_line":"            \u0027--description\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_27655e49","line":28,"in_reply_to":"3fa7e38b_abdff835","updated":"2020-02-13 14:25:43.000000000","message":"Apologies, this should be in the previous patch this patch is based on!","commit_id":"b8679e9111caac4bd1293809788ab36599bd323d"}],"openstackclient/network/v2/network_qos_rule.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a2b70edd625fde40fccd63c120591705174c15e5","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        \u0027--classification-group-id\u0027,"},{"line_number":188,"context_line":"        dest\u003d\u0027classification_group_id\u0027,"},{"line_number":189,"context_line":"        metavar\u003d\u0027\u003cclassification-group-id\u003e\u0027,"},{"line_number":190,"context_line":"        help\u003d_(\u0027Classification Group ID: the ID of a classification group \u0027"},{"line_number":191,"context_line":"               \u0027to provide a SLA based on traffic class\u0027)"},{"line_number":192,"context_line":"    )"},{"line_number":193,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_2ba228ae","line":190,"range":{"start_line":190,"start_character":16,"end_line":190,"end_character":41},"updated":"2020-01-08 20:54:56.000000000","message":"I don\u0027t think these prefixes should be included since the help output will show the help text along with the relevant arg name.","commit_id":"b8679e9111caac4bd1293809788ab36599bd323d"}]}