)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"ba2660baf11aa2dd24ec419e0ab39134b9cb5a0e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"- Open temp files with \u0027w+\u0027 mode rather than the default \u0027w+b\u0027 (as an"},{"line_number":15,"context_line":"  alternative to encoding all the write and expected-read payloads as"},{"line_number":16,"context_line":"  bytes)."},{"line_number":17,"context_line":"- (This is a weird one) Explicitly raise SkipTest from unittest (rather"},{"line_number":18,"context_line":"  than unittest2, which is where cls.skipException landed). Not sure why"},{"line_number":19,"context_line":"  this is busted, but this moves the ball."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_f2e62adb","line":17,"updated":"2020-01-29 04:57:35.000000000","message":"I don\u0027t see that this is actually in this change. That\u0027s ok - but if you respin this for any other reason it would be good to remove this from the commit message.\n\nAlso - FWIW - self.skipTest() is a better choice than raise SkipTest ... but again, this doesn\u0027t really happen in this patch.","commit_id":"47f0277208362a3224f8e587bbdd60dd5aebf846"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"97b752e61c19db1ee0d3cabfb16121ab45defe7d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"- Open temp files with \u0027w+\u0027 mode rather than the default \u0027w+b\u0027 (as an"},{"line_number":15,"context_line":"  alternative to encoding all the write and expected-read payloads as"},{"line_number":16,"context_line":"  bytes)."},{"line_number":17,"context_line":"- (This is a weird one) Explicitly raise SkipTest from unittest (rather"},{"line_number":18,"context_line":"  than unittest2, which is where cls.skipException landed). Not sure why"},{"line_number":19,"context_line":"  this is busted, but this moves the ball."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_9586c015","line":17,"in_reply_to":"3fa7e38b_f2e62adb","updated":"2020-01-29 07:20:51.000000000","message":"Agree this can be removed. As background though, a couple things here.\n\nThis was in the class setup, so self.skipTest() is not an option at that point since there is no self. Not as common of a situation.\n\nThe other issue encountered with using the inherited skipTest() versus raising the exception directly was due to transitioning with the standard unittest module versus the unittest2 package. We currently inherit a lot from unittest2 base classes, so it ends up calling skipTest raises a unittest2.SkipException, whereas the test running would only be looking for a unittest.SkipException.\n\nI think the best fix for that is to have unittest2\u0027s SkipException inherit from unittest.SkipException, but considering it\u0027s been years since unittest2 has done a release, the best path forward, IMO, is to start migrating away from any direct unittest2 usage. It\u0027s not really needed now in a py3-only world.","commit_id":"47f0277208362a3224f8e587bbdd60dd5aebf846"}]}