)]}'
{"id":"openstack%2Fpython-openstackclient~705630","triplet_id":"openstack%2Fpython-openstackclient~stable%2Ftrain~I9e96d2978912c8dfeadae4a782c481a17cd7e348","project":"openstack/python-openstackclient","branch":"stable/train","topic":"bug/1845322","hashtags":[],"change_id":"I9e96d2978912c8dfeadae4a782c481a17cd7e348","subject":"Stop silently ignoring invalid \u0027server create --hint\u0027 options","status":"MERGED","created":"2020-02-04 10:55:25.000000000","updated":"2020-02-26 16:21:14.000000000","submitted":"2020-02-26 16:17:24.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"705630-1582733844317-e444febc","meta_rev_id":"7312831af72b7000a5b90deee075afa577adf3ec","_number":705630,"virtual_id_number":705630,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-02-26 16:17:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"date":"2020-02-19 13:23:17.000000000","_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-02-20 17:30:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":2,"date":"2020-02-19 16:48:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":1,"date":"2020-02-26 14:14:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-20 17:30:16.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2020-02-26 14:14:16.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-02-26 16:17:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"01d3c8dfb69a8e273bc250ba3631aed96f51e4e1","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-02-04 10:55:25.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"3cd10d3126eae252aec1df05c9b23704bcbc0a69","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-02-04 10:55:34.000000000","message":"Topic changed from bug/1845322-stable/train to bug/1845322","accounts_in_message":[],"_revision_number":1},{"id":"10f2e5522e07d69a70a2972c0f782d4c0eabc867","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-04 13:06:14.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/dfcc30a93998466b98998e437d3ce592 : SUCCESS in 8m 06s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2a03df8a894f437abcf2f80a5ea54f7c : SUCCESS in 5m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/21189ec544204d6688dce4ef3fdcfaf1 : SUCCESS in 4m 40s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/03366509add54affa40c076fa4bb4eea : SUCCESS in 4m 05s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/084e69de2ba6456cb7beec29362d5ea6 : SUCCESS in 4m 08s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/254a5b8385cf4b16a822a12cb2ff2527 : SUCCESS in 4m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8799dddb467b4db5bd24b071d665d09e : SUCCESS in 6m 31s\n- tempest-full https://zuul.opendev.org/t/openstack/build/605265f009af4fa48b21dfdec1752cfb : TIMED_OUT in 2h 06m 43s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/88676b1de08e467092a6ae9069a1e997 : SUCCESS in 1h 24m 08s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/4f193cc266194279910691963c9a4037 : SUCCESS in 55m 39s","accounts_in_message":[],"_revision_number":1},{"id":"a69e3d38fcd2e8860573b9b51d456684f8e85bcf","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-02-19 13:23:17.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"9f478e28a3bcc12493f8ac7d825a2ce935609c9e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-19 15:30:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a75a94cfc147407b9951545092124e1b : SUCCESS in 5m 54s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/468f7b83a40847328ff8a964ce8950be : SUCCESS in 6m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d602a784d9b24210b05e11dce25e95b3 : SUCCESS in 5m 19s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a1a6a413abed4bd18f4263759a722734 : SUCCESS in 7m 31s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8e549f9580e04e64ab254be829adb784 : SUCCESS in 6m 19s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/3a60016ad1c94789a646b9deaa29f266 : SUCCESS in 5m 52s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/52ca10c83de1418480627340ea258005 : SUCCESS in 6m 44s\n- tempest-full https://zuul.opendev.org/t/openstack/build/d8578ff553724f1b8515649c38bc50b5 : SUCCESS in 1h 56m 13s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/3e38ed8b80d0436f83bddc58913272a1 : SUCCESS in 1h 39m 02s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/5aba1359cf6a453b969a9c6387cc3972 : SUCCESS in 54m 50s","accounts_in_message":[],"_revision_number":1},{"id":"674ac6ac6a8cdda6d74f5130f4d921b9b1d7a7f6","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-02-19 16:48:53.000000000","message":"Patch Set 1: Code-Review+2\n\nMerged to master and a good thing to backport.","accounts_in_message":[],"_revision_number":1},{"id":"d03cac212e1094fecc5168cddd3cf94e1a46ab14","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-02-20 17:30:16.000000000","message":"Patch Set 1: Code-Review+2\n\nClean backport, LGTM","accounts_in_message":[],"_revision_number":1},{"id":"3eaf116732c2a5f9c2012f274bdb20adfc801424","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-02-26 14:14:16.000000000","message":"Patch Set 1: Workflow+1\n\nMerged to master, good to go.","accounts_in_message":[],"_revision_number":1},{"id":"beda0c9f627b06ec55300a4ebe1ecf548d30a3eb","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-26 14:14:28.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"d1a181b3514d034d37a09b1fa20146c28515cd92","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-26 16:17:24.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7aee4b3058c14ca4a66f1b80e7b73b62 : SUCCESS in 7m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/26a6e4e71d2f44d7a48a3de00dbb5ac6 : SUCCESS in 5m 41s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/d1c1b32a6c3b4ce7be3d76e17270862a : SUCCESS in 5m 56s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/52b68339fdf649dcb80ffacf7aa39ebf : SUCCESS in 6m 45s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/4ba37b1b4c0742ddab74cdd168e0f004 : SUCCESS in 6m 14s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f80b93ea0cb34dc78b6b1c2920043b4d : SUCCESS in 7m 38s\n- tempest-full https://zuul.opendev.org/t/openstack/build/a7d6dbbb18634c15add4d3bd6ca653be : SUCCESS in 1h 54m 16s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/e4a159e10b4a4963848d09b1d3b77c98 : SUCCESS in 1h 20m 54s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/ddf783a97e854445866de2c5c2255101 : SUCCESS in 58m 11s","accounts_in_message":[],"_revision_number":1},{"id":"ca90e4a49ad5b176db7f0ba6a9b59743ea64e3bc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-26 16:17:24.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"7312831af72b7000a5b90deee075afa577adf3ec","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-26 16:21:14.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b06a57077446497db9ddc7c9398e1066 : SUCCESS in 2m 19s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"576d9ecfd0ac27611ec89af6d34e7378b7a39fb3","revisions":{"576d9ecfd0ac27611ec89af6d34e7378b7a39fb3":{"kind":"REWORK","_number":1,"created":"2020-02-04 10:55:25.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/30/705630/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/30/705630/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/30/705630/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/30/705630/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/30/705630/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/30/705630/1"}}},"commit":{"parents":[{"commit":"b866202f54afddca66a77cd989b082e193a96956","subject":"Fix functional tests for py3","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b866202f54afddca66a77cd989b082e193a96956"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-09-27 11:19:29.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-02-04 10:55:25.000000000","tz":0},"subject":"Stop silently ignoring invalid \u0027server create --hint\u0027 options","message":"Stop silently ignoring invalid \u0027server create --hint\u0027 options\n\nThe \u0027--hint\u0027 option for \u0027server create\u0027 expects a key-value pair like so:\n\n  openstack server create --hint group\u003d245e1dfe-2d0e-4139-80a9-fce124948896 ...\n\nHowever, the command doesn\u0027t complain if this isn\u0027t the case, meaning\ntypos like the below aren\u0027t indicated to the user:\n\n  openstack server create --hint 245e1dfe-2d0e-4139-80a9-fce124948896\n\nDue to how we\u0027d implemented this here, this ultimately results in us\nPOSTing the following as part of the body to \u0027os-servers\u0027:\n\n  {\n    ...\n    \"OS-SCH-HNT:scheduler_hints\": {\n      \"245e1dfe-2d0e-4139-80a9-fce124948896\": null\n    }\n    ...\n  }\n\nWhich is unfortunately allowed and ignored by nova due to the use of\n\u0027additionalProperties\u0027 in the schema [1]\n\nDo what we do for loads of other options and explicitly fail on invalid\nvalues. This involves adding a new argparse action since none of those\ndefined in osc-lib work for us. This is included here to ease\nbackporting of the fix but will be moved to osc-lib in a future patch.\n\n[1] https://github.com/openstack/nova/blob/19.0.0/nova/api/openstack/compute/schemas/servers.py#L142-L146\n\nChange-Id: I9e96d2978912c8dfeadae4a782c481a17cd7e348\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\nStory: #2006628\nTask: #36840\nRelated-Bug: #1845322\n(cherry picked from commit ea27ebb0f918db9eab2f5751a1b065818faa0e6d)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/576d9ecfd0ac27611ec89af6d34e7378b7a39fb3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/576d9ecfd0ac27611ec89af6d34e7378b7a39fb3"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}