)]}'
{"id":"openstack%2Fpython-openstackclient~708653","triplet_id":"openstack%2Fpython-openstackclient~stable%2Frocky~I9e96d2978912c8dfeadae4a782c481a17cd7e348","project":"openstack/python-openstackclient","branch":"stable/rocky","topic":"bug/1845322","hashtags":[],"change_id":"I9e96d2978912c8dfeadae4a782c481a17cd7e348","subject":"Stop silently ignoring invalid \u0027server create --hint\u0027 options","status":"MERGED","created":"2020-02-19 13:34:26.000000000","updated":"2020-07-22 18:53:24.000000000","submitted":"2020-07-22 18:53:24.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"708653-1595444004960-798a8ba2","meta_rev_id":"4437274bfb782667eacd191f6e54998b730b973a","_number":708653,"virtual_id_number":708653,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-07-22 18:53:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"date":"2020-04-27 10:58:43.000000000","_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"recommended":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-05-05 12:18:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":2,"date":"2020-07-22 10:43:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":2,"date":"2020-07-22 17:17:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"date":"2020-04-27 10:58:35.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":1,"date":"2020-07-22 17:17:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"date":"2020-04-27 10:58:37.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-04-27 10:58:35.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2020-04-27 10:58:37.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2020-05-05 12:18:09.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2020-07-22 10:43:42.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2020-07-22 17:17:53.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-07-22 18:53:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1860f0c5c7c988511d6b18542aa5c8d754033baf","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-02-19 13:34:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"92533984dd4f998a83693c7de815ed1999e78eed","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-19 15:05:11.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ee1a0ca34b8b4e0da81ca98bac080d58 : SUCCESS in 9m 42s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/0f1cf97f2298490c9e4e560924a7a16e : SUCCESS in 5m 44s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/25b5b6339eb04d48bc0234ceef098b60 : SUCCESS in 6m 26s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/a80000e49afb46a5adf3982110c9286f : SUCCESS in 7m 30s\n- tempest-full https://zuul.opendev.org/t/openstack/build/d4ed71d5dc2a4fd88fac358474705293 : SUCCESS in 1h 26m 43s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/c06aff5eca424516aa2939f144d3a3be : FAILURE in 35m 34s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1daa1d81862841c89de58e3586433e53 : SUCCESS in 7m 27s","accounts_in_message":[],"_revision_number":1},{"id":"36b2627c5a1703f042588ae029cf5e427a6a7fce","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-02-19 16:41:01.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"c84feb6013fe030e7963cf4c144e256fb76143fa","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-19 18:18:12.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b25524f721874349944968fc17c73842 : SUCCESS in 5m 30s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/009ccf4b87424241ba821dc4fb665abc : SUCCESS in 5m 54s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/9109e6951a0c45a28076d7743bac1ae9 : SUCCESS in 5m 52s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/61f6ea5f97064770baf6c0e28e531aec : SUCCESS in 6m 33s\n- tempest-full https://zuul.opendev.org/t/openstack/build/d9944ab6207f4d09ad18706c51579b78 : SUCCESS in 1h 34m 06s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/5866a69c50954eea99598652898892df : FAILURE in 41m 05s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4bd4bb54649e49cd84bbd8040511b7ea : SUCCESS in 6m 35s","accounts_in_message":[],"_revision_number":1},{"id":"a740f2fe980bcbb675ffa7dc08b9bd14239b4148","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-04-27 10:58:43.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"e600e111996fc608b8fc05a1c3f2d82a83c23361","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-27 12:24:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ed60e4c62928425e9f82f6c40c763a6e : SUCCESS in 4m 10s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/2e701606c6844b44b92406f41a8a32f2 : SUCCESS in 3m 54s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/480f7a2c2bd4435b84082716b2288bc8 : SUCCESS in 6m 01s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/b69131257cbf494c94faead3ad82bcdc : SUCCESS in 5m 45s\n- tempest-full https://zuul.opendev.org/t/openstack/build/4b4cd1db772e47bd82567e779059d3ea : SUCCESS in 1h 23m 22s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/0fedc84980b9418abec7d89079395c9c : SUCCESS in 49m 33s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/fbb775476b9a44d69ad49a515b8f037a : SUCCESS in 5m 47s","accounts_in_message":[],"_revision_number":1},{"id":"d796627a99f49e2e0d365e49b39baf2d144c2735","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2020-05-05 12:18:09.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"c6b79b30733b35fa77a480edfa74ca098ca1db18","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-07-22 10:43:42.000000000","message":"Patch Set 1: Code-Review+2\n\nClean backport, LGTM","accounts_in_message":[],"_revision_number":1},{"id":"4e63c108896a7077278f3ea6d95635ef3a559c5d","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-07-22 10:44:29.000000000","message":"Patch Set 1:\n\nstein must be merged first","accounts_in_message":[],"_revision_number":1},{"id":"09a8542f131f8c2e811434b43e9c8481e129f2d0","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-07-22 17:17:53.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"3b0fe7710fe47e0ff869b8b9308f57c729646883","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-22 17:18:06.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"52fd697fb6db6448e4a59cc431c12bd616795a73","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-22 18:53:24.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bd3fa878f65544b59c704160aa15ee7c : SUCCESS in 5m 43s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/0d95d305329f4c28a6b4ea2740b9727f : SUCCESS in 8m 31s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/41f21595ce7b4263aa9c93bdb48199f3 : SUCCESS in 5m 00s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/b182daeafafc40db8174a6be4880283b : SUCCESS in 5m 38s\n- tempest-full https://zuul.opendev.org/t/openstack/build/210fd24c01534edcb3f12e69f38aa995 : SUCCESS in 1h 32m 08s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/18bef8acd31342a3808fd1cc35b49fda : SUCCESS in 47m 55s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9039ee0d385a4cf687f7a9912f90cf18 : SUCCESS in 6m 49s","accounts_in_message":[],"_revision_number":1},{"id":"308d8d4111f6e0b3a3e7269b4227a79f91fa84ac","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-22 18:53:24.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4c7a4587ca556897fc19a7684a6ee99484532161","revisions":{"4c7a4587ca556897fc19a7684a6ee99484532161":{"kind":"REWORK","_number":1,"created":"2020-02-19 13:34:26.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/53/708653/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/53/708653/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/53/708653/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/53/708653/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/53/708653/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/53/708653/1"}}},"commit":{"parents":[{"commit":"df872713c72de9a4b3d1422dd74aabe0bf26f145","subject":"Improve document \u0027openstack complete\u0027","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/df872713c72de9a4b3d1422dd74aabe0bf26f145"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-09-27 11:19:29.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2020-02-19 13:33:58.000000000","tz":0},"subject":"Stop silently ignoring invalid \u0027server create --hint\u0027 options","message":"Stop silently ignoring invalid \u0027server create --hint\u0027 options\n\nThe \u0027--hint\u0027 option for \u0027server create\u0027 expects a key-value pair like so:\n\n  openstack server create --hint group\u003d245e1dfe-2d0e-4139-80a9-fce124948896 ...\n\nHowever, the command doesn\u0027t complain if this isn\u0027t the case, meaning\ntypos like the below aren\u0027t indicated to the user:\n\n  openstack server create --hint 245e1dfe-2d0e-4139-80a9-fce124948896\n\nDue to how we\u0027d implemented this here, this ultimately results in us\nPOSTing the following as part of the body to \u0027os-servers\u0027:\n\n  {\n    ...\n    \"OS-SCH-HNT:scheduler_hints\": {\n      \"245e1dfe-2d0e-4139-80a9-fce124948896\": null\n    }\n    ...\n  }\n\nWhich is unfortunately allowed and ignored by nova due to the use of\n\u0027additionalProperties\u0027 in the schema [1]\n\nDo what we do for loads of other options and explicitly fail on invalid\nvalues. This involves adding a new argparse action since none of those\ndefined in osc-lib work for us. This is included here to ease\nbackporting of the fix but will be moved to osc-lib in a future patch.\n\n[1] https://github.com/openstack/nova/blob/19.0.0/nova/api/openstack/compute/schemas/servers.py#L142-L146\n\nChange-Id: I9e96d2978912c8dfeadae4a782c481a17cd7e348\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\nStory: #2006628\nTask: #36840\nRelated-Bug: #1845322\n(cherry picked from commit ea27ebb0f918db9eab2f5751a1b065818faa0e6d)\n(cherry picked from commit 576d9ecfd0ac27611ec89af6d34e7378b7a39fb3)\n(cherry picked from commit 38e1274f478219bee8899b6c9eaa09dbfd03bbcd)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4c7a4587ca556897fc19a7684a6ee99484532161"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4c7a4587ca556897fc19a7684a6ee99484532161"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}