)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b991f85477a6e2167139f4ce6288b3e967dc01d9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     hackertron \u003cjayadityagupta11@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-03-23 14:02:03 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"FIX for openstack quota set --force"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I1d1ac1ac46f49f64794ffc8631e166935537966c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"df33271e_0c5ce449","line":7,"updated":"2020-03-23 16:58:53.000000000","message":"Could you give a little more information about this, including what it does. Something like:\n\n  Add \u0027--force\u0027 parameter to \u0027openstack quota set\u0027\n\n  The compute service allows us to force set a quota, setting a\n  quota value that is less than the amount of the resource currently\n  consumed. Expose this feature by way of a \u0027--force\u0027 boolean\n  parameter.","commit_id":"425f46e2a654669754e9a01a8414118e8a9ddc1a"},{"author":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"change_message_id":"c56a4fcd8b420356f47973a940b5172491f131da","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     hackertron \u003cjayadityagupta11@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-03-23 14:02:03 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"FIX for openstack quota set --force"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I1d1ac1ac46f49f64794ffc8631e166935537966c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"df33271e_3dcc7388","line":7,"in_reply_to":"df33271e_0c5ce449","updated":"2020-03-23 20:11:48.000000000","message":"Done","commit_id":"425f46e2a654669754e9a01a8414118e8a9ddc1a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"51391f10b7436be46539db7886741ec07d0a110f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     hackertron \u003cjayadityagupta11@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-03-23 21:08:39 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027--force; parameter to \u0027openstack quota set\u0027/"},{"line_number":8,"context_line":"The compute service allows us to to force set a quota, setting a"},{"line_number":9,"context_line":"quota value that is less than the amount of the resource currently"},{"line_number":10,"context_line":"consumed. Expose this feature by way of a \u0027--force\u0027 boolean"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"df33271e_9d213fff","line":7,"range":{"start_line":7,"start_character":48,"end_line":7,"end_character":49},"updated":"2020-03-23 20:28:35.000000000","message":"Remove this and add a blank line between the summary title and the detailed body.","commit_id":"be59e7d59b77719cab1ae5fffdb4d6a3c1d4fb08"}],"openstackclient/common/quota.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9e90da0080e4c315f50ca2144ab6af12bcafbe11","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            help\u003d_(\u0027Set quotas for a specific \u003cvolume-type\u003e\u0027),"},{"line_number":518,"context_line":"        )"},{"line_number":519,"context_line":"        parser.add_argument("},{"line_number":520,"context_line":"        \t\u0027--force\u0027,"},{"line_number":521,"context_line":"        \taction\u003d\u0027store_true\u0027,"},{"line_number":522,"context_line":"        \thelp\u003d_(\u0027Force quota update\u0027),"},{"line_number":523,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_da3d9f8e","line":520,"range":{"start_line":520,"start_character":8,"end_line":520,"end_character":9},"updated":"2020-03-20 11:05:32.000000000","message":"You need to use spaces instead of tabs. I see you\u0027ve done that in a separate commit but it must be done here or this can\u0027t merge. Consider rebasing and squashing the follow up commit into this one","commit_id":"03b67cd4a52f3ddd7a09664902f47a0822be5074"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9e90da0080e4c315f50ca2144ab6af12bcafbe11","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        parser.add_argument("},{"line_number":520,"context_line":"        \t\u0027--force\u0027,"},{"line_number":521,"context_line":"        \taction\u003d\u0027store_true\u0027,"},{"line_number":522,"context_line":"        \thelp\u003d_(\u0027Force quota update\u0027),"},{"line_number":523,"context_line":"        )"},{"line_number":524,"context_line":"        return parser"},{"line_number":525,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_7a4eeb38","line":522,"range":{"start_line":522,"start_character":17,"end_line":522,"end_character":35},"updated":"2020-03-20 11:05:32.000000000","message":"Can you check to see if cinder or neutron support forcing this and extend support to those if they do. If they don\u0027t, you need to note here that this is only supported by nova and error out if someone attempts to provide it for a non-nova quota.","commit_id":"03b67cd4a52f3ddd7a09664902f47a0822be5074"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9e90da0080e4c315f50ca2144ab6af12bcafbe11","unresolved":false,"context_lines":[{"line_number":534,"context_line":"            if value is not None:"},{"line_number":535,"context_line":"                compute_kwargs[k] \u003d value"},{"line_number":536,"context_line":"            if parsed_args.force:"},{"line_number":537,"context_line":"            \tcompute_kwargs[\u0027force\u0027] \u003d True"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        volume_kwargs \u003d {}"},{"line_number":540,"context_line":"        for k, v in VOLUME_QUOTAS.items():"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_1a61f7a9","line":537,"range":{"start_line":537,"start_character":12,"end_line":537,"end_character":13},"updated":"2020-03-20 11:05:32.000000000","message":"Spaces instead","commit_id":"03b67cd4a52f3ddd7a09664902f47a0822be5074"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3272e1a09b95ef6fceaf3679d00f36fdf8efceac","unresolved":false,"context_lines":[{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        if parsed_args.force:"},{"line_number":561,"context_line":"            if volume_kwargs:"},{"line_number":562,"context_line":"                sys.stderr.write(\"--foce is only supported by compute. \\n\")"},{"line_number":563,"context_line":"            if network_kwargs:"},{"line_number":564,"context_line":"                sys.stderr.write(\"--force is only supported by compute. \\n\")"},{"line_number":565,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_67f7a6f7","line":562,"range":{"start_line":562,"start_character":36,"end_line":562,"end_character":40},"updated":"2020-03-20 16:04:39.000000000","message":"force","commit_id":"13e88d42c75d05c6bba7f44eb4ad3b07a5528351"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b991f85477a6e2167139f4ce6288b3e967dc01d9","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        parser.add_argument("},{"line_number":520,"context_line":"            \u0027--force\u0027,"},{"line_number":521,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":522,"context_line":"            help\u003d_(\u0027Force quota update for compute\u0027)"},{"line_number":523,"context_line":"        )"},{"line_number":524,"context_line":"        return parser"},{"line_number":525,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_91cbf11c","line":522,"range":{"start_line":522,"start_character":39,"end_line":522,"end_character":50},"updated":"2020-03-23 16:58:53.000000000","message":"Instead of this, can you say:\n\n  (only supported by compute)\n\nOr something similar to make it clear that this is a compute-only thing","commit_id":"425f46e2a654669754e9a01a8414118e8a9ddc1a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9a1f16e3fcb5aeba22f9b462308dcfed3ec22e62","unresolved":false,"context_lines":[{"line_number":533,"context_line":"            value \u003d getattr(parsed_args, k, None)"},{"line_number":534,"context_line":"            if value is not None:"},{"line_number":535,"context_line":"                compute_kwargs[k] \u003d value"},{"line_number":536,"context_line":"            if parsed_args.force:"},{"line_number":537,"context_line":"                compute_kwargs[\u0027force\u0027] \u003d True"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        volume_kwargs \u003d {}"},{"line_number":540,"context_line":"        for k, v in VOLUME_QUOTAS.items():"}],"source_content_type":"text/x-python","patch_set":14,"id":"df33271e_4e714976","line":537,"range":{"start_line":536,"start_character":12,"end_line":537,"end_character":46},"updated":"2020-04-09 15:16:17.000000000","message":"This should not happen inside the loop, it will just repeat the same setting for every COMPUTE_QUOTAS item.","commit_id":"87e63015c1455f1f5f7f7c297529e3c2bd7f08cf"}],"openstackclient/tests/functional/common/test_quota.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9a1f16e3fcb5aeba22f9b462308dcfed3ec22e62","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        self.assertTrue(cmd_output[\"snapshots\"] \u003e\u003d 0)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def test_quota_set_force(self):"},{"line_number":170,"context_line":"        \"\"\"Create server then set instance value by force \"\"\""},{"line_number":171,"context_line":"        self.openstack("},{"line_number":172,"context_line":"            \u0027quota set \u0027 + self.PROJECT_NAME + \u0027--instances 10 --force\u0027"},{"line_number":173,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":14,"id":"df33271e_0e2aa12a","line":170,"updated":"2020-04-09 15:16:17.000000000","message":"I don\u0027t see a server being created here.\n\nFor a real test, you\u0027d also need to create 10 servers and then decrease the quota to 9. Maybe you can test with some other object that isn\u0027t as resource intensive.","commit_id":"87e63015c1455f1f5f7f7c297529e3c2bd7f08cf"}],"openstackclient/tests/unit/common/test_quota.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b991f85477a6e2167139f4ce6288b3e967dc01d9","unresolved":false,"context_lines":[{"line_number":867,"context_line":"        )"},{"line_number":868,"context_line":"        self.assertIsNone(result)"},{"line_number":869,"context_line":"        self.assertNotCalled(self.network_mock.update_quota)"},{"line_number":870,"context_line":"        self.assertNotCalled(self.volume_quotas_mock.update_quota)"},{"line_number":871,"context_line":""},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"class TestQuotaShow(TestQuota):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_ec6c200a","line":870,"range":{"start_line":870,"start_character":0,"end_line":870,"end_character":66},"updated":"2020-03-23 16:58:53.000000000","message":"I\u0027d have expected this to be called, but I guess it\u0027s not being called because the quota hasn\u0027t changed? Could you change this so that it *is* called, just so we can make sure \u0027force\u0027 isn\u0027t being provided here. Ditto for network quotas","commit_id":"425f46e2a654669754e9a01a8414118e8a9ddc1a"}],"releasenotes/notes/force-flag-openstackclient-c172de2717e5cfac.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3272e1a09b95ef6fceaf3679d00f36fdf8efceac","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``--force`` options to the ``openstack quota set``"},{"line_number":4,"context_line":"    command. We can use this option to add force set quota for compute."},{"line_number":5,"context_line":"    It does not work with cinder or neutron"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_47d1c257","line":5,"updated":"2020-03-20 16:04:39.000000000","message":"Please end with a period.","commit_id":"13e88d42c75d05c6bba7f44eb4ad3b07a5528351"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"991e94b8368c0f2b87b1aa1b6f283ac4ad65a93b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``--force`` options to the ``openstack quota set``"},{"line_number":4,"context_line":"    command. We can use this option to add force set quota for compute."},{"line_number":5,"context_line":"    It is not ignored for storage for networking quotas."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df33271e_bd66c350","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":55},"updated":"2020-03-23 20:29:31.000000000","message":"I think this needs to be reworded. It makes it sound like it is only used when you have storage that is used for your networking quota.","commit_id":"be59e7d59b77719cab1ae5fffdb4d6a3c1d4fb08"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9a1f16e3fcb5aeba22f9b462308dcfed3ec22e62","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``--force`` options to the ``openstack quota set``"},{"line_number":4,"context_line":"    command. We can use this option to add force set quota for compute."},{"line_number":5,"context_line":"    It is not ignored for storage and networking quotas."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df33271e_6edd2d6f","line":4,"range":{"start_line":4,"start_character":13,"end_line":4,"end_character":71},"updated":"2020-04-09 15:16:17.000000000","message":"This sounds vague to me, maybe rather use the explicit description from the commit message.","commit_id":"87e63015c1455f1f5f7f7c297529e3c2bd7f08cf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9a1f16e3fcb5aeba22f9b462308dcfed3ec22e62","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``--force`` options to the ``openstack quota set``"},{"line_number":4,"context_line":"    command. We can use this option to add force set quota for compute."},{"line_number":5,"context_line":"    It is not ignored for storage and networking quotas."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df33271e_eed2dd5b","line":5,"range":{"start_line":5,"start_character":10,"end_line":5,"end_character":13},"updated":"2020-04-09 15:16:17.000000000","message":"I assume that it is ignored, so delete the \"not\". Otherwise describe what is done instead of ignoring.","commit_id":"87e63015c1455f1f5f7f7c297529e3c2bd7f08cf"}]}