)]}'
{"id":"openstack%2Fpython-openstackclient~717410","triplet_id":"openstack%2Fpython-openstackclient~master~Ibd39328c27b68190e2edbf1f52fcea52db3ae791","project":"openstack/python-openstackclient","branch":"master","topic":"unittest.mock","hashtags":[],"change_id":"Ibd39328c27b68190e2edbf1f52fcea52db3ae791","subject":"Use unittest.mock instead of third party mock","status":"MERGED","created":"2020-04-03 22:12:04.000000000","updated":"2020-04-17 21:41:20.000000000","submitted":"2020-04-17 21:37:39.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"717410-1587159459250-8efe962b","meta_rev_id":"00fb701900117db4ab2da5d3e51cc4c3b277ee3d","_number":717410,"virtual_id_number":717410,"owner":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2020-04-17 15:09:39.000000000","_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-04-17 21:37:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2020-04-04 14:34:48.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":1,"date":"2020-04-04 14:34:48.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-04-04 14:34:48.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2020-04-17 21:37:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8183ea58c395a6a1e7448513291458c7a41d608c","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-04-03 22:12:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fc92f66154119b0b3d6e77caf4e3465193f3675e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-03 23:26:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/593ef53a88a44e05a51547159d6c0ec3 : SUCCESS in 8m 48s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/888e7a02f1a34f6daf491dd157a0d58b : SUCCESS in 6m 55s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d8a0b45cdc2d4d93938a0972895eef32 : SUCCESS in 6m 12s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a81a093ffb0142f3850ca225f73f8587 : SUCCESS in 5m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8edae76995624893bbfd9a8757a77cac : SUCCESS in 4m 45s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/12197e88ebab4e25aed6eb5f6549a30b : SUCCESS in 5m 00s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/b5fdf252c3a645eb8fbca5a41fc640ef : SUCCESS in 4m 35s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/feeddfcd3177410198824af2efe1047a : SUCCESS in 5m 45s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f1c6a3fcc58449b8827b47f8a9a284be : SUCCESS in 6m 05s\n- requirements-check https://zuul.opendev.org/t/openstack/build/02b945ea6dd84505a1a094c100349424 : SUCCESS in 3m 10s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c1908f942b644b9ba21dc61db14d9f4e : SUCCESS in 5m 24s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/d2a148ffd62d4b71a19a3391c6e209cc : SUCCESS in 1h 12m 58s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/1e8afe56c4c648efbd0a681a0b5e9f34 : SUCCESS in 7m 33s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/51631655473a4f67a94f9f7f23f279d9 : SUCCESS in 1h 05m 32s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/f78f5508af3b449dac1cbdc06d973157 : SUCCESS in 1h 05m 55s\n\nWarning:\n  Job openstack-tox-lower-constraints: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/lower-constraints/lib/python3.6/site-packages/setuptools/dist.py in the commit\u0027\n  Job openstack-tox-docs: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/docs/lib/python3.6/site-packages/barbicanclient/__init__.py in the commit\u0027\n  Comments left for invalid file .tox/docs/lib/python3.6/site-packages/barbicanclient/__init__.py\n  Comments left for invalid file .tox/lower-constraints/lib/python3.6/site-packages/setuptools/dist.py","accounts_in_message":[],"_revision_number":1},{"id":"e79bf20db2e8d59bd1492d9922827e7ae564e35e","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-04-04 14:34:48.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"5e5c7ae0152b8ddc027b4411cd8d3311339a06be","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-04 14:35:00.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"f31e8c6907ba0d3d57721d6939c05a8949f8a1ec","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-04 16:16:31.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/143c520e40634614be659a4a76ceb98c : SUCCESS in 4m 36s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4caa217b9b434df4849cb66fb228c30a : SUCCESS in 4m 45s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/99194c913e5942f4a2825b4195fea936 : SUCCESS in 4m 32s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/40407d43f42f4ec7bafb5d0c5221268f : SUCCESS in 4m 40s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/b4e0156d60d2480f97bbe40a1146820f : SUCCESS in 5m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bbaadecdaa404548ab3726b52253a2da : SUCCESS in 6m 23s\n- requirements-check https://zuul.opendev.org/t/openstack/build/1871df823b96419a8518cc8540baa094 : SUCCESS in 2m 54s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/324a383b313d44da982919dcf693c9e9 : SUCCESS in 5m 38s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/365e5f69819740f0bccbb643c79305e2 : SUCCESS in 1h 39m 39s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/851607fac90e4273af09fb009c1921ee : SUCCESS in 9m 54s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/5bf956e650e348328f49abc98db2ff88 : FAILURE in 1h 10m 56s\n\nWarning:\n  Job openstack-tox-lower-constraints: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/lower-constraints/lib/python3.6/site-packages/setuptools/dist.py in the commit\u0027\n  Job openstack-tox-docs: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/docs/lib/python3.6/site-packages/barbicanclient/__init__.py in the commit\u0027\n  Comments left for invalid file .tox/docs/lib/python3.6/site-packages/barbicanclient/__init__.py\n  Comments left for invalid file .tox/lower-constraints/lib/python3.6/site-packages/setuptools/dist.py","accounts_in_message":[],"_revision_number":1},{"id":"6396f5478cd35344ea176fa9d8aa2733a2176aa7","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-04-17 15:09:39.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"588ee2534d510eadee10bf82cd5445c904a6043b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-17 16:32:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/fbbe9fc8295845898f4e54e1db377cb6 : SUCCESS in 6m 40s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/6f408f71807a40a780587477f86b95d2 : SUCCESS in 6m 41s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a1bc5bc456f24985b8eb2d242c7e31c2 : SUCCESS in 6m 12s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2358171148704504b9c9953a79df221a : SUCCESS in 8m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/47791876e7bb4b568d441d9b13c6bc20 : SUCCESS in 6m 07s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1744e274b92448518b5a153a4120fd62 : SUCCESS in 6m 38s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/6fe65b327ff4443888f1ba1a4908b6e0 : SUCCESS in 5m 08s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a6878356e3304eaeaea34c6300b404cc : SUCCESS in 5m 58s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/25e3106d83f54082aca9570b83225210 : SUCCESS in 6m 14s\n- requirements-check https://zuul.opendev.org/t/openstack/build/18d6656fc99142ebb70eab67f84225b7 : SUCCESS in 2m 46s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/aa3104e8b8da4542b8d06511e4e84f2d : SUCCESS in 8m 10s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/c548644337094739a0383ea8d7f29c2f : SUCCESS in 1h 13m 49s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/9a9f60e913c24cda84a6faf0bc1c4730 : SUCCESS in 8m 01s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/5f7af3188fa44cc88e841b6091d8760b : SUCCESS in 1h 06m 28s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/1b3b082cafb643f4940fa36fd6f6398b : SUCCESS in 57m 14s","accounts_in_message":[],"_revision_number":1},{"id":"023deaa84d70c0a2bbf4f2804751c59aa198f45e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-17 16:32:38.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"3ec410dd9ba74a272aca31f77105b6efbf4916c2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-17 21:37:38.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/78b1db8e4214409da17db69b01457823 : SUCCESS in 5m 44s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3e9a895186e54a11b3d3737c515f7579 : SUCCESS in 5m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1702289eb0b64f50ac5563b4403c2d89 : SUCCESS in 4m 23s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a6ad72704f9a414bbef86306626c9442 : SUCCESS in 7m 47s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/de35b226d21a4600a1363f278f4e20f3 : SUCCESS in 5m 14s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d628703dc3924fee966000a005f1f9f4 : SUCCESS in 6m 10s\n- requirements-check https://zuul.opendev.org/t/openstack/build/5bb8c60b982642b8a2fbd6d72294e7ab : SUCCESS in 4m 10s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/20a4c22d9607456ebdac5c5e929e1f2e : SUCCESS in 6m 50s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/e4b0ba0efb394da0b4adb549d429fae4 : SUCCESS in 1h 26m 26s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/60f6254bd3eb42408442449a4b180043 : SUCCESS in 8m 40s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/b4887f9bbc814060ac45387b96970f6c : SUCCESS in 53m 18s","accounts_in_message":[],"_revision_number":1},{"id":"fbc1d55f755e74a8ba289e514ad87e05370ffbe9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-17 21:37:39.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"8d4de918143de1ed71f8f0b96dc364e80194e91e","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-17 21:41:20.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b8c92b9ba2ae4e8cbc1c888a2cd86b00 : SUCCESS in 2m 34s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f663ca581c4747d099d92e75bd203c53 : SUCCESS in 1m 09s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/2455132bfbce4645881aebf01fe1e1de : SUCCESS in 1m 08s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"725e004d32d538f9d163c727308ee20385c0310d","revisions":{"725e004d32d538f9d163c727308ee20385c0310d":{"kind":"REWORK","_number":1,"created":"2020-04-03 22:12:04.000000000","uploader":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"ref":"refs/changes/10/717410/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/10/717410/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/10/717410/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/10/717410/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/10/717410/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/10/717410/1"}}},"commit":{"parents":[{"commit":"70f1ff375ac82f8231c259d9bb671293199d0f67","subject":"Merge \"Add command: router add/remove route --route\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/70f1ff375ac82f8231c259d9bb671293199d0f67"}]}],"author":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2020-04-03 22:11:40.000000000","tz":-300},"committer":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2020-04-03 22:11:40.000000000","tz":-300},"subject":"Use unittest.mock instead of third party mock","message":"Use unittest.mock instead of third party mock\n\nNow that we no longer support py27, we can use the standard library\nunittest.mock module instead of the third party mock lib.\n\nChange-Id: Ibd39328c27b68190e2edbf1f52fcea52db3ae791\nSigned-off-by: Sean McGinnis \u003csean.mcginnis@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/725e004d32d538f9d163c727308ee20385c0310d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/725e004d32d538f9d163c727308ee20385c0310d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}