)]}'
{"openstackclient/identity/v3/project.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"fbed728a2019fd0cfdeaa44a047783b51eeabb36","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        if parsed_args.property:"},{"line_number":104,"context_line":"            kwargs \u003d parsed_args.property.copy()"},{"line_number":105,"context_line":"        if \u0027is_domain\u0027 in kwargs.keys():"},{"line_number":106,"context_line":"            if kwargs[\u0027is_domain\u0027].lower() \u003d\u003d \"true\":"},{"line_number":107,"context_line":"                kwargs[\u0027is_domain\u0027] \u003d True"},{"line_number":108,"context_line":"            elif kwargs[\u0027is_domain\u0027].lower() \u003d\u003d \"false\":"},{"line_number":109,"context_line":"                kwargs[\u0027is_domain\u0027] \u003d False"},{"line_number":110,"context_line":"            elif kwargs[\u0027is_domain\u0027].lower() \u003d\u003d \"none\":"},{"line_number":111,"context_line":"                kwargs[\u0027is_domain\u0027] \u003d None"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        kwargs[\u0027tags\u0027] \u003d list(set(parsed_args.tags))"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_952525c5","line":111,"range":{"start_line":106,"start_character":12,"end_line":111,"end_character":42},"updated":"2020-06-01 17:02:09.000000000","message":"I think `None` could be the default value even if `is_domain` is not equal to `true`|`false`|`none` mostly to prevent other not accepted value to introduce side effects later in during execution.\n\nSo the last `elif` could be rewrited to become the default scenario.\n\nThoughts?","commit_id":"4189edfb6c06097674bd7265c849327a516aebd1"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"bc4c72b1b54d9bbb69a90d8b0357936889f8db54","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        if parsed_args.property:"},{"line_number":104,"context_line":"            kwargs \u003d parsed_args.property.copy()"},{"line_number":105,"context_line":"        if \u0027is_domain\u0027 in kwargs.keys():"},{"line_number":106,"context_line":"            if kwargs[\u0027is_domain\u0027].lower() \u003d\u003d \"true\":"},{"line_number":107,"context_line":"                kwargs[\u0027is_domain\u0027] \u003d True"},{"line_number":108,"context_line":"            elif kwargs[\u0027is_domain\u0027].lower() \u003d\u003d \"false\":"},{"line_number":109,"context_line":"                kwargs[\u0027is_domain\u0027] \u003d False"},{"line_number":110,"context_line":"            elif kwargs[\u0027is_domain\u0027].lower() \u003d\u003d \"none\":"},{"line_number":111,"context_line":"                kwargs[\u0027is_domain\u0027] \u003d None"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        kwargs[\u0027tags\u0027] \u003d list(set(parsed_args.tags))"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_40944537","line":111,"range":{"start_line":106,"start_character":12,"end_line":111,"end_character":42},"in_reply_to":"ff570b3c_0ebd82d7","updated":"2020-06-03 11:22:42.000000000","message":"oh right sorry I missed that this one is a cherry-pick.","commit_id":"4189edfb6c06097674bd7265c849327a516aebd1"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"de0fb65ba870abeac4963640da012a8e77af6e90","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        if parsed_args.property:"},{"line_number":104,"context_line":"            kwargs \u003d parsed_args.property.copy()"},{"line_number":105,"context_line":"        if \u0027is_domain\u0027 in kwargs.keys():"},{"line_number":106,"context_line":"            if kwargs[\u0027is_domain\u0027].lower() \u003d\u003d \"true\":"},{"line_number":107,"context_line":"                kwargs[\u0027is_domain\u0027] \u003d True"},{"line_number":108,"context_line":"            elif kwargs[\u0027is_domain\u0027].lower() \u003d\u003d \"false\":"},{"line_number":109,"context_line":"                kwargs[\u0027is_domain\u0027] \u003d False"},{"line_number":110,"context_line":"            elif kwargs[\u0027is_domain\u0027].lower() \u003d\u003d \"none\":"},{"line_number":111,"context_line":"                kwargs[\u0027is_domain\u0027] \u003d None"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        kwargs[\u0027tags\u0027] \u003d list(set(parsed_args.tags))"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_0ebd82d7","line":111,"range":{"start_line":106,"start_character":12,"end_line":111,"end_character":42},"in_reply_to":"ff570b3c_952525c5","updated":"2020-06-01 18:53:03.000000000","message":"Yes - that\u0027s probably true. I think if we were to change this we should do it in master.\n\nIf that\u0027s the case, we should wait on merging this until we have a fix landed there, too.","commit_id":"4189edfb6c06097674bd7265c849327a516aebd1"}]}