)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b8902fcd2556d22cd7b3963027e18c210b76f780","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jay \u003cjayadityagupta11@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-04 14:10:59 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes incorrect json output when command openstack server show -f json"},{"line_number":8,"context_line":"is executed. The security group json was nor correct."},{"line_number":9,"context_line":"Story: 2007755"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_c767b324","line":7,"updated":"2020-06-04 12:42:05.000000000","message":"This should have a summary line, followed by a couple line breaks, then the full description of the change. See https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure for an example.\n\nSince the release note should be updated, it would be great if you could reformat the commit message to follow guidelines as well.","commit_id":"1aabae7dc75d4b56672f9f03e3d08c891ac3bd72"},{"author":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"change_message_id":"7c1c139942ffd844c37096255fd99fbc991db508","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jay \u003cjayadityagupta11@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-04 14:10:59 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes incorrect json output when command openstack server show -f json"},{"line_number":8,"context_line":"is executed. The security group json was nor correct."},{"line_number":9,"context_line":"Story: 2007755"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_7ddf5a65","line":7,"in_reply_to":"ff570b3c_c767b324","updated":"2020-06-04 13:27:31.000000000","message":"Done","commit_id":"1aabae7dc75d4b56672f9f03e3d08c891ac3bd72"}],"openstackclient/compute/v2/server.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2ac1aa22db5f1905d3f69de77390d6d67a20a2b3","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    if \u0027security_groups\u0027 in info:"},{"line_number":174,"context_line":"        info.update("},{"line_number":175,"context_line":"            {"},{"line_number":176,"context_line":"                \u0027security_groups\u0027: info.pop(\u0027security_groups\u0027)"},{"line_number":177,"context_line":"            }"},{"line_number":178,"context_line":"        )"},{"line_number":179,"context_line":"    # NOTE(dtroyer): novaclient splits these into separate entries..."}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_2007751a","line":176,"updated":"2020-06-04 13:58:14.000000000","message":"This is a no-op, you could as well drop the whole if block.\n\nBut it renders normal output bad:\n\n$ openstack server show s1 -c security_groups \n+-----------------+--------------------------------------------+\n| Field           | Value                                      |\n+-----------------+--------------------------------------------+\n| security_groups | [{\u0027name\u0027: \u0027default\u0027}, {\u0027name\u0027: \u0027testing\u0027}] |\n+-----------------+--------------------------------------------+\n\ninstead of\n\n+-----------------+----------------+\n| Field           | Value          |\n+-----------------+----------------+\n| security_groups | name\u003d\u0027default\u0027 |\n|                 | name\u003d\u0027testing\u0027 |\n+-----------------+----------------+\n\nSo I think you need to find a solution based on output format.","commit_id":"d28954bf29e177e7bab3095c59589169e69ca11a"},{"author":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"change_message_id":"c0a57b998fc0d3cee7f308a1b57ea256b0d41c91","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    if \u0027security_groups\u0027 in info:"},{"line_number":174,"context_line":"        info.update("},{"line_number":175,"context_line":"            {"},{"line_number":176,"context_line":"                \u0027security_groups\u0027: info.pop(\u0027security_groups\u0027)"},{"line_number":177,"context_line":"            }"},{"line_number":178,"context_line":"        )"},{"line_number":179,"context_line":"    # NOTE(dtroyer): novaclient splits these into separate entries..."}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_005b51f5","line":176,"in_reply_to":"ff570b3c_2007751a","updated":"2020-06-04 14:10:40.000000000","message":"I didn\u0027t checked that my bad. True. I thought the tables ouput was being handled differently.\n\nI will fix that","commit_id":"d28954bf29e177e7bab3095c59589169e69ca11a"}],"openstackclient/tests/unit/compute/v2/test_server.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"151cac220e6fd5057014a69f6926d81706586b5e","unresolved":false,"context_lines":[{"line_number":5166,"context_line":"            \u0027tenant_id\u0027: u\u0027tenant-id-xxx\u0027,"},{"line_number":5167,"context_line":"            \u0027networks\u0027: {u\u0027public\u0027: [u\u002710.20.30.40\u0027, u\u00272001:db8::f\u0027]},"},{"line_number":5168,"context_line":"            \u0027links\u0027: u\u0027http://xxx.yyy.com\u0027,"},{"line_number":5169,"context_line":"            \u0027security_groups\u0027 : [{\"name\": \"group1\"}, {\"name\": \"group2\"}],"},{"line_number":5170,"context_line":"        }"},{"line_number":5171,"context_line":"        _server \u003d compute_fakes.FakeServer.create_one_server(attrs\u003dserver_info)"},{"line_number":5172,"context_line":"        find_resource.side_effect \u003d [_server, _flavor]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_fb0ed289","line":5169,"updated":"2020-06-04 15:08:04.000000000","message":"pep8: E203 whitespace before \u0027:\u0027","commit_id":"d28954bf29e177e7bab3095c59589169e69ca11a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"151cac220e6fd5057014a69f6926d81706586b5e","unresolved":false,"context_lines":[{"line_number":5183,"context_line":"            \u0027properties\u0027: \u0027\u0027,"},{"line_number":5184,"context_line":"            \u0027OS-EXT-STS:power_state\u0027: server._format_servers_list_power_state("},{"line_number":5185,"context_line":"                getattr(_server, \u0027OS-EXT-STS:power_state\u0027)),"},{"line_number":5186,"context_line":"            \u0027security_groups\u0027 : [{\"name\": \"group1\"}, {\"name\": \"group2\"}],"},{"line_number":5187,"context_line":"        }"},{"line_number":5188,"context_line":""},{"line_number":5189,"context_line":"        # Call _prep_server_detail()."}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_5b29bee3","line":5186,"updated":"2020-06-04 15:08:04.000000000","message":"pep8: E203 whitespace before \u0027:\u0027","commit_id":"d28954bf29e177e7bab3095c59589169e69ca11a"}],"releasenotes/notes/security-grp-json-fix.yaml-2af1f48a48034d64.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b8902fcd2556d22cd7b3963027e18c210b76f780","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - ``openstack server show -f json`` command was not outputting"},{"line_number":4,"context_line":"    json for security groups properly. This patch fixes it."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_e7bf575e","line":4,"range":{"start_line":4,"start_character":39,"end_line":4,"end_character":59},"updated":"2020-06-04 12:42:05.000000000","message":"Release notes are generated into a HTML document that includes all changes for a given release. So \"this patch\" is completely out of context then. This last sentence should be removed.","commit_id":"1aabae7dc75d4b56672f9f03e3d08c891ac3bd72"},{"author":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"change_message_id":"7c1c139942ffd844c37096255fd99fbc991db508","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - ``openstack server show -f json`` command was not outputting"},{"line_number":4,"context_line":"    json for security groups properly. This patch fixes it."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_8aa5c2a1","line":4,"range":{"start_line":4,"start_character":39,"end_line":4,"end_character":59},"in_reply_to":"ff570b3c_e7bf575e","updated":"2020-06-04 13:27:31.000000000","message":"Ah okay. Makes sense!","commit_id":"1aabae7dc75d4b56672f9f03e3d08c891ac3bd72"}]}
