)]}'
{"id":"openstack%2Fpython-openstackclient~736150","triplet_id":"openstack%2Fpython-openstackclient~master~I5f59959ba8a01aba49e29f4cb007397467344e58","project":"openstack/python-openstackclient","branch":"master","topic":"unmunch","hashtags":[],"change_id":"I5f59959ba8a01aba49e29f4cb007397467344e58","subject":"Revert \"Format location columns in network commands\"","status":"MERGED","created":"2020-06-17 10:07:12.000000000","updated":"2020-06-17 23:27:04.000000000","submitted":"2020-06-17 23:23:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"736150-1592436191809-889aaf46","meta_rev_id":"9235e15d3284c0c16c2d4d4a9d08f9a9f8a1c740","_number":736150,"virtual_id_number":736150,"owner":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-06-17 23:23:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2020-06-17 10:14:46.000000000","_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":2,"date":"2020-06-17 13:44:36.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":1,"date":"2020-06-17 21:37:54.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-17 10:07:12.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2020-06-17 21:37:54.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2020-06-17 23:23:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a48d9c08ad1aed1387bfb2505ce2431d0804470d","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-06-17 10:07:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f755426b9cbc803c514c3f461876683140143da3","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-06-17 10:09:52.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"dbc82a30c8523bf532d2eb056d005ac21b3b4874","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-06-17 10:14:46.000000000","message":"Patch Set 2:\n\nI think that this revert together with my patch on top is the better solution because:\n\na) the output is ugly, it makes the line length insanely long, leading to bad formatting on all but super-wide terminals\nb) the \"location\" is a synthetic field, but it is displayed as if it was a property of the object being shown, which is confusing\nc) the location is only shown for network objects, not for others, which might seem to imply that is it some neutron-related property, which is also confusing","accounts_in_message":[],"_revision_number":2},{"id":"86bec236d922073c3ed9cefadff9dec591a58fd3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-17 12:12:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/c926400fc35540b3854bb82e0b703a19 : FAILURE in 6m 28s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/738c542c926b418a966d59e0189d079a : SUCCESS in 6m 44s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/33f7ecc442cf4dcfb1d5db00402d7a16 : SUCCESS in 6m 41s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f8d9e064a1dd489fbbe2ffddcb6fc462 : SUCCESS in 7m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5a2bb2c98834455b9eb5f77d3ea2646e : SUCCESS in 5m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/fbd0e386b94b4fb29d36212504e4a378 : SUCCESS in 4m 50s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/aef196e3156340dd892f366904636544 : SUCCESS in 6m 54s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8ae13d2e9dbd4f439ffed08adbc84331 : SUCCESS in 8m 12s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/8724de3be33440468aa305e43a9b15c0 : SUCCESS in 1h 56m 27s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/d4ebd24f45f2415097eb9e84e275edef : SUCCESS in 9m 14s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/eadee96b03bb4a5e9bbb888749a6a843 : SUCCESS in 47m 51s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/76571a56eed041568ded894ccbdcb2fa : SUCCESS in 47m 25s","accounts_in_message":[],"_revision_number":2},{"id":"a451a57eaf0e3de057be00c4df04fc3e50b55496","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-06-17 13:44:36.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"a697e073bfd8ee800b6c3b69f0cbcf667c99ec2f","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-06-17 21:37:54.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"3c69060a7b9333f14837307400af1800b5fb1043","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-17 21:43:56.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"8d5adec7add1864e7d2b78c8dea45537401b94f2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-17 23:23:11.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"688a3eb2d161333d33ec60094cc7537a64888b46","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-17 23:23:11.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/4928796f99be4200853171b236dec2d8 : SUCCESS in 9m 32s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/db545e166e1141209f33c714a0e701b6 : SUCCESS in 8m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e0943a2002b44378a05d7d85c6056b5c : SUCCESS in 8m 24s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8cee9290fc644cb4b417b622cb593587 : SUCCESS in 7m 37s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/60714fa462e1410cbd55e760704bf44a : SUCCESS in 8m 31s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2da784f8bba74262a125fb88063e61ef : SUCCESS in 10m 48s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/2dfe58760f6842fbbd11e00df87928df : SUCCESS in 1h 26m 57s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/089415e20e2945b9a3cf94e94e09820b : SUCCESS in 13m 30s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/295fd9f8f5db4f448c3d21d1438bd0bf : SUCCESS in 59m 35s","accounts_in_message":[],"_revision_number":2},{"id":"6aaa29189333b951b4395889940d0367fd9bc07c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-17 23:27:04.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1a4e91959ff74618ae788a6369c87bf3 : SUCCESS in 3m 25s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/945307e1835e4889b18095f0a0dd692e : SUCCESS in 59s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a04172969a5e440af50127dfd27a80a6beb7ddb8","revisions":{"152234287ecc7db4fd3a545745da04c54ffa5409":{"kind":"REWORK","_number":1,"created":"2020-06-17 10:07:12.000000000","uploader":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"ref":"refs/changes/50/736150/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/50/736150/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/50/736150/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/50/736150/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/50/736150/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/50/736150/1"}}},"commit":{"parents":[{"commit":"6ee7b8d138e07bfc37c5cd887f7afa49cdabb02f","subject":"Format location columns in network commands","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/6ee7b8d138e07bfc37c5cd887f7afa49cdabb02f"}]}],"author":{"name":"Jens Harbott (frickler)","email":"j.harbott@x-ion.de","date":"2020-06-17 10:07:12.000000000","tz":0},"committer":{"name":"Jens Harbott (frickler)","email":"j.harbott@x-ion.de","date":"2020-06-17 10:07:12.000000000","tz":0},"subject":"Revert \"Format location columns in network commands\"","message":"Revert \"Format location columns in network commands\"\n\nThis reverts commit 6ee7b8d138e07bfc37c5cd887f7afa49cdabb02f.\n\nChange-Id: I5f59959ba8a01aba49e29f4cb007397467344e58\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/152234287ecc7db4fd3a545745da04c54ffa5409"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/152234287ecc7db4fd3a545745da04c54ffa5409"}]},"branch":"refs/heads/master"},"a04172969a5e440af50127dfd27a80a6beb7ddb8":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-06-17 10:09:52.000000000","uploader":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"ref":"refs/changes/50/736150/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/50/736150/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/50/736150/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/50/736150/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/50/736150/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/50/736150/2"}}},"commit":{"parents":[{"commit":"3e6874dc87c166a92ed95dce46900742385f3ba7","subject":"Merge \"Remove os-client-config references\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3e6874dc87c166a92ed95dce46900742385f3ba7"}]}],"author":{"name":"Jens Harbott (frickler)","email":"j.harbott@x-ion.de","date":"2020-06-17 10:07:12.000000000","tz":0},"committer":{"name":"Jens Harbott","email":"j.harbott@x-ion.de","date":"2020-06-17 10:09:36.000000000","tz":0},"subject":"Revert \"Format location columns in network commands\"","message":"Revert \"Format location columns in network commands\"\n\nThis reverts commit 6ee7b8d138e07bfc37c5cd887f7afa49cdabb02f.\n\nChange-Id: I5f59959ba8a01aba49e29f4cb007397467344e58\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a04172969a5e440af50127dfd27a80a6beb7ddb8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a04172969a5e440af50127dfd27a80a6beb7ddb8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
