)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"f481a165f4a351b40012ffeaff93433a558cdedd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d2b5e786_1fa566c9","updated":"2021-12-09 13:49:13.000000000","message":"recheck","commit_id":"c31bbded092058b223ad9531d229b27a65f92b31"}],"openstackclient/network/v2/router.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9cd490d3294325d6dbd027d899916e752db251a3","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        )"},{"line_number":363,"context_line":"        snat_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":364,"context_line":"        snat_group.add_argument("},{"line_number":365,"context_line":"            \u0027--enable-snat\u0027,"},{"line_number":366,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":367,"context_line":"            help\u003d_(\"Enable Source NAT on external gateway\")"},{"line_number":368,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_0d4dba99","line":365,"updated":"2020-06-19 10:49:49.000000000","message":"Maybe this option is not needed if it is the implicit default?","commit_id":"39e120110c6663a02ad6b451ad2d787dbcd92177"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e788af92ab9d740d243513b06c3e3574d159b726","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        )"},{"line_number":363,"context_line":"        snat_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":364,"context_line":"        snat_group.add_argument("},{"line_number":365,"context_line":"            \u0027--enable-snat\u0027,"},{"line_number":366,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":367,"context_line":"            help\u003d_(\"Enable Source NAT on external gateway\")"},{"line_number":368,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_ed1de673","line":365,"in_reply_to":"bf51134e_0d4dba99","updated":"2020-06-19 10:53:47.000000000","message":"In my understanding, OSC provides options for default values too, so we need this.","commit_id":"39e120110c6663a02ad6b451ad2d787dbcd92177"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a6d6565ba9bc266b4e5795bbe9c9646ac0a1cfe6","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        )"},{"line_number":363,"context_line":"        snat_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":364,"context_line":"        snat_group.add_argument("},{"line_number":365,"context_line":"            \u0027--enable-snat\u0027,"},{"line_number":366,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":367,"context_line":"            help\u003d_(\"Enable Source NAT on external gateway\")"},{"line_number":368,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"55ea9d86_2b8c5f1e","line":365,"in_reply_to":"bf51134e_549e1654","updated":"2021-11-30 08:25:24.000000000","message":"Right, so this is the argument why these options are needed as they stand. Have the possibility to override in both directions, but don\u0027t touch the provided setting by default.","commit_id":"39e120110c6663a02ad6b451ad2d787dbcd92177"},{"author":{"_account_id":26106,"name":"Tom Stappaerts","email":"tom.stappaerts@nokia.com","username":"TomStappaerts"},"change_message_id":"b80693b42bfb6fc0781266284ea51cf2d6162ae9","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        )"},{"line_number":363,"context_line":"        snat_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":364,"context_line":"        snat_group.add_argument("},{"line_number":365,"context_line":"            \u0027--enable-snat\u0027,"},{"line_number":366,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":367,"context_line":"            help\u003d_(\"Enable Source NAT on external gateway\")"},{"line_number":368,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_549e1654","line":365,"in_reply_to":"bf51134e_ed1de673","updated":"2020-06-19 13:54:03.000000000","message":"The default value of enable_snat is also dependent on the enable_snat_by_default option in neutron.conf","commit_id":"39e120110c6663a02ad6b451ad2d787dbcd92177"}]}