)]}'
{"id":"openstack%2Fpython-openstackclient~740455","triplet_id":"openstack%2Fpython-openstackclient~master~Ia48115974390a3e6a6a3d31b27cc0f3d3525c609","project":"openstack/python-openstackclient","branch":"master","topic":"story/2007860","hashtags":[],"change_id":"Ia48115974390a3e6a6a3d31b27cc0f3d3525c609","subject":"Fix for image property filter in OSC CLI","status":"ABANDONED","created":"2020-07-10 13:03:01.000000000","updated":"2020-10-01 12:51:33.000000000","total_comment_count":26,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"22847d532029d5136482d0647e298ebb4fd8efa5","_number":740455,"virtual_id_number":740455,"owner":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2020-08-24 15:21:10.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-09-08 01:17:28.000000000","_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},{"date":"2020-09-11 08:54:31.000000000","_account_id":32309,"name":"Jake.Chae","email":"cocahack@naver.com","username":"Jake.Chae"},{"date":"2020-09-09 14:27:51.000000000","_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"date":"2020-09-09 14:18:12.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":32309,"name":"Jake.Chae","email":"cocahack@naver.com","username":"Jake.Chae"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},{"_account_id":32309,"name":"Jake.Chae","email":"cocahack@naver.com","username":"Jake.Chae"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},{"_account_id":32309,"name":"Jake.Chae","email":"cocahack@naver.com","username":"Jake.Chae"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-17 09:23:12.000000000","updated_by":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"reviewer":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"state":"REVIEWER"},{"updated":"2020-07-20 11:31:09.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2020-08-23 16:08:15.000000000","updated_by":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"reviewer":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"state":"REVIEWER"},{"updated":"2020-08-24 15:21:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-09-08 01:17:28.000000000","updated_by":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"reviewer":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"state":"REVIEWER"},{"updated":"2020-09-09 14:18:12.000000000","updated_by":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"reviewer":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"state":"REVIEWER"},{"updated":"2020-09-11 08:54:31.000000000","updated_by":{"_account_id":32309,"name":"Jake.Chae","email":"cocahack@naver.com","username":"Jake.Chae"},"reviewer":{"_account_id":32309,"name":"Jake.Chae","email":"cocahack@naver.com","username":"Jake.Chae"},"state":"REVIEWER"}],"messages":[{"id":"0bc48f33cdf981cb43e253aaf6f02bbd8439acb2","author":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"date":"2020-07-10 13:03:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5da0ca188317db867571a54bfc6e1868075b90ec","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-07-10 13:46:25.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nlet\u0027s add a unit test that fails without the fix and passes with it to avoid regressing this","accounts_in_message":[],"_revision_number":1},{"id":"ef07da3d87415bc1202b65afb19ddb3f5cde9fb6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-10 14:21:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/2a0a4c776b21414196ee6c4683517464 : SUCCESS in 6m 11s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/98e96310cb414500995713166c5373e8 : SUCCESS in 6m 25s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d18e56692d644c049d612437aaf434db : SUCCESS in 5m 52s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c5d88f3a10d947838bb467ec93d3ad90 : SUCCESS in 5m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b72de21e55194735bc28ac59af08fb1c : SUCCESS in 4m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f56fec09709c44e38f23ce29922e9005 : SUCCESS in 4m 06s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a7fc91dc2ccf473fa1a9a83ddb6883e2 : SUCCESS in 4m 54s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8ad26d8bdf2c4638b84e2c2592159ff6 : SUCCESS in 5m 15s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/21f01209793f40c3abad7baa0a113677 : SUCCESS in 1h 16m 54s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/6103405b3f384d069c3ce60f3a4f5bf1 : SUCCESS in 7m 52s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/28a35d4defa64c6d8bf8cfc68460d6d7 : SUCCESS in 53m 13s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/ed2d1f01c6274be2a6f8a3bc4c43e384 : SUCCESS in 37m 58s","accounts_in_message":[],"_revision_number":1},{"id":"0cf07d365ab762fc289959d6813874ae47ea0b0d","author":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"date":"2020-07-13 07:11:03.000000000","message":"Patch Set 1:\n\nSure, I will add a test case.","accounts_in_message":[],"_revision_number":1},{"id":"4688b0e4b5b7e8d7ae33edfb1e25f14862041d5b","author":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"date":"2020-07-17 08:40:47.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"cd080fe6018e9e53877cd9fe6e5aa206e957c0ca","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-07-17 09:23:12.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"242348de95c2850d9a040213c6e6c12d2800c717","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-17 10:11:10.000000000","message":"Patch Set 2: Verified-1\n\n(6 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/bc73a84a6d6c4dff90f46478935ab9df : SUCCESS in 6m 54s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/794afb766bca48218b23999d744e8fe5 : SUCCESS in 6m 06s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a10a8c10499a401fb41d97d481204fc7 : SUCCESS in 5m 21s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/10bbe63aa66b4e50b444412a2667e3e6 : SUCCESS in 4m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ae5db888e6f241159d5f740262c73353 : FAILURE in 4m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/619dd14c816c4a778c1c1886e21f57cd : SUCCESS in 3m 41s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/44f53df761ff4683ad1766b44d1c39c3 : SUCCESS in 5m 25s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bf5548c68ac7412b9e4734286e846d10 : SUCCESS in 8m 09s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/82dc0bfbfc0c47f4848c0304dc27a3ba : SUCCESS in 4m 30s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/0dd2e8351e81423b942838da9fac1713 : SUCCESS in 1h 21m 00s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/9c39d98e7d6e435b9b33b4b20fc8d89c : SUCCESS in 7m 07s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/dc0805c5d199492884dc84a310355a52 : SUCCESS in 43m 59s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/d0a73c9b07044e08bd3a9f60547a0c01 : SUCCESS in 46m 41s","accounts_in_message":[],"_revision_number":2},{"id":"4213826975bebe81221d40b6c76029494b4afe5c","author":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"date":"2020-07-17 11:13:26.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"2a29862510e6aa28898f78c52a8335a520e695a8","author":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"date":"2020-07-17 11:17:14.000000000","message":"Patch Set 2:\n\n(1 comment)\n\n\"no idea what has changed here\" line 754-764 ? . This also add the properties in img_dict. The properties are stored as propertis ( key:value). It gets skipped in the for loop@766.","accounts_in_message":[],"_revision_number":2},{"id":"4e27ca57902e01c0e7c122a455ab87665dec347c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-17 12:31:54.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/f0cb9b603029404585e50aa10bd37739 : SUCCESS in 5m 19s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/82efa96b30b54805a978f55508ad25a6 : SUCCESS in 5m 44s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1c256960090541f1be0dd952b053fa4b : SUCCESS in 5m 33s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1b69748829ec4445bdc59def625bf041 : SUCCESS in 6m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/eae5c4f340d946498538154c5f81ad9f : SUCCESS in 5m 05s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/bba3eedc459141218735d14ecb2e8d8f : SUCCESS in 5m 04s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b47e669ad582436f8996016001fe022f : SUCCESS in 5m 25s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dca4c010217844d698eaafe57a474c88 : SUCCESS in 7m 08s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/8581cd17deb2496cb8f117d7e433cb48 : SUCCESS in 5m 07s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/b4f02b667d6d44cc8985513399940324 : SUCCESS in 1h 16m 22s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/7d1f15d0b1ff475db225c7e7f8b25be3 : SUCCESS in 9m 42s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/f9537a1515a64c99b710743d6b0c06b5 : FAILURE in 47m 36s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/c70eac46debb45018c4d9a4245079d1b : SUCCESS in 40m 23s","accounts_in_message":[],"_revision_number":3},{"id":"f57474eab40cfdbc9aace876405e42d434c2712a","author":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"date":"2020-07-20 07:48:19.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"8592a678499b815e7adffd9bdcc78957e0550e4d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-20 09:22:32.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/0d7d150254014514a9a6cd1d858fd9bd : SUCCESS in 5m 18s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/106bda5b7ff745bfb584b23d165610b2 : SUCCESS in 6m 45s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/56fca98eb9844a4d9a7cebbc59e5a8a0 : SUCCESS in 6m 05s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e53a5d407e2f484d93f221e8c14ae9ce : SUCCESS in 6m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3df4dc41ed16446baa15b3a0a19dc2ef : SUCCESS in 5m 24s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/be5c547c2057404da2293dcc67038ce2 : SUCCESS in 6m 02s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/205f05a2ac31498ab68a81eff5ed57f9 : SUCCESS in 5m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/66bf8c46bfbb41bf81b438eb1b27c2cb : SUCCESS in 7m 33s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/399f22bd004146fcb4c4237d966dca37 : SUCCESS in 6m 27s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/bbf606ca64ec442bb5c1380dab553de2 : SUCCESS in 1h 31m 38s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/8c6f1924b9a14f2e9816998991e0f2bd : SUCCESS in 8m 45s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/16b5b36364fd430e938d894b8f7c85b2 : SUCCESS in 1h 00m 59s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/5e16eec9c3bc4906ad2c29e0b4146a6c : SUCCESS in 1h 02m 22s","accounts_in_message":[],"_revision_number":3},{"id":"c061dc25b08b3042fc76e089729d01584a9ee2fa","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-07-20 11:31:09.000000000","message":"Patch Set 3:\n\n(2 comments)\n\nHello,\n\nthese changes LGTM, we just have a nits, and I\u0027ve an inline question.","accounts_in_message":[],"_revision_number":3},{"id":"d2a9b471864b3d6ad7e16acb3689bf1f89c239ce","author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"date":"2020-08-23 16:08:15.000000000","message":"Patch Set 3:\n\nWould you also see another patch to address the same Story: https://review.opendev.org/#/c/746405/ ? According to another contributor, this patch couldn\u0027t address another issue: images cannot be created with owner_specified.openstack.object key and --image-property condition.","accounts_in_message":[],"_revision_number":3},{"id":"da20a8f6d5a2f5423739ddd0c5b834e840607d34","author":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"date":"2020-08-24 09:47:47.000000000","message":"Patch Set 3:\n\nWhat do you suggest Ian ? What should be done ? Merge both of these patches by interacting with each other.","accounts_in_message":[],"_revision_number":3},{"id":"9f85a9599db6c20e4a46d73923a2dac16bb80fb3","author":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"date":"2020-08-24 10:25:47.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"b0b8d72dcc650f91cb6a4e5ad134ce58e720b33b","author":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"date":"2020-08-24 12:13:46.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"8aaebd2a2e9ca3d366891bc5a66040da48d66634","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 15:21:10.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/9946c3d1520c45edb859df5a7f48613b : SUCCESS in 4m 58s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/2889bfd132fb4e5abb07cd412e5fb74b : SUCCESS in 4m 42s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/346c2ef639a54b8685fb7f9ac3e2af5a : SUCCESS in 10m 20s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ab7bbd3ef02d4033a7baa8902181566a : SUCCESS in 5m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bc8bd0a4f71141eda12cf8f4686b2dce : SUCCESS in 4m 54s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8051ea54915745f6a791563e1b04f35d : SUCCESS in 9m 24s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/97d1ba1f0e4f4c979e5da4753528bec0 : SUCCESS in 5m 33s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/276055585bc144f8b0d56bd78e3e0818 : SUCCESS in 8m 04s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/daf3410408e041a1918298e38c0cf84f : SUCCESS in 5m 44s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/f84ee3d75f6a4645be29d160de6a003f : SUCCESS in 54m 16s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/6a2fada1be4241859a3e3a11589148de : SUCCESS in 6m 50s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/7517ddd13e1d4ae6a2a6c52a72f06ab6 : SUCCESS in 59m 46s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/c9561804a1244c3093519d2f7a84129d : SUCCESS in 55m 38s","accounts_in_message":[],"_revision_number":4},{"id":"e36dd03bc1d029c55d5dcacecb2a8ea93c0ce4d7","author":{"_account_id":32309,"name":"Jake.Chae","email":"cocahack@naver.com","username":"Jake.Chae"},"date":"2020-08-29 06:26:23.000000000","message":"Patch Set 4:\n\nI found the --image-property option not working when there were several images, and posted a patch that modified it in my review(https://review.opendev.org/#/c/740455/).\n\nMy patch also includes the part you committed, which I think is better what you did.\n\nI think both my review and your review will need to be merged to close the story.","accounts_in_message":[],"_revision_number":4},{"id":"c501ffd130a2d3784f280539b706315a721a5238","author":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"date":"2020-08-29 18:59:30.000000000","message":"Patch Set 4:\n\nI understand your point, let\u0027s take this issue on mailing list and IRC , hopefully someone will review both of our code and then we can close this ticket :) \n\nThanks for you work","accounts_in_message":[],"_revision_number":4},{"id":"d6f9157f9ce95046c6b780b9fc283bf6a6a2f9c7","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2020-09-06 12:39:48.000000000","message":"Patch Set 4: Code-Review+1\n\n(1 comment)\n\nBesides the need for a log message when an error happens, I think the code looks fine.","accounts_in_message":[],"_revision_number":4},{"id":"0581ac3143890ba2500e82498c09e87a2f0285aa","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-09-07 06:02:55.000000000","message":"Patch Set 4:\n\n(4 comments)\n\nLGTM over all, some comments inline.","accounts_in_message":[],"_revision_number":4},{"id":"cbb6379416017a50d24207a66538f2b7f69ba236","author":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"date":"2020-09-07 07:41:48.000000000","message":"Patch Set 4:\n\n\u003e (4 comments)\n \u003e \n \u003e LGTM over all, some comments inline.\n\nhow should we combine both of these patches ?","accounts_in_message":[],"_revision_number":4},{"id":"17f4a9150d9e16cd3861d1cb64b7dd5c5b4e376f","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-09-08 01:17:28.000000000","message":"Patch Set 4:\n\n\u003e \u003e (4 comments)\n \u003e \u003e\n \u003e \u003e LGTM over all, some comments inline.\n \u003e \n \u003e how should we combine both of these patches ?\n\nMaybe we shouldn’t need to consider performance loss here.\nI preefer to use https://review.opendev.org/#/c/746405/1/openstackclient/compute/v2/server.py@755 code logical, it looks like easy to read, and reduce the occurrence of duplicate code.","accounts_in_message":[],"_revision_number":4},{"id":"55d25d195d70247a10150fedd818c4eea4f4235a","author":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"date":"2020-09-09 07:45:01.000000000","message":"Patch Set 4:\n\n\u003e \u003e \u003e (4 comments)\n \u003e \u003e \u003e\n \u003e \u003e \u003e LGTM over all, some comments inline.\n \u003e \u003e\n \u003e \u003e how should we combine both of these patches ?\n \u003e \n \u003e Maybe we shouldn’t need to consider performance loss here.\n \u003e I preefer to use https://review.opendev.org/#/c/746405/1/openstackclient/compute/v2/server.py@755\n \u003e code logical, it looks like easy to read, and reduce the occurrence\n \u003e of duplicate code.\n\nIs it possible to have both patches OR we have to only merge 1 patch. I am fine with either way. Like mentioned the other patch code is better. So go ahead with that :) .","accounts_in_message":[],"_revision_number":4},{"id":"a174515ddb7674ab536f09d60289b6d433d34d7c","author":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"date":"2020-09-09 13:09:34.000000000","message":"Patch Set 4:\n\n(2 comments)\n\nrefer : https://review.opendev.org/#/c/746405/","accounts_in_message":[],"_revision_number":4},{"id":"e1c45c97e32dd28cc0bb41153f253ac10522cee1","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2020-09-09 13:11:22.000000000","message":"Patch Set 4: -Code-Review\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"0c92a525ccd5d8cc594245f624fe820142876af4","author":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"date":"2020-09-09 14:06:28.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"159e8e427735e1fa24ecad28de76eab986692d4f","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2020-09-09 14:18:12.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"1a78995c1bdebbc315ae23db5ac81b0209b878b9","author":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"date":"2020-09-09 14:27:51.000000000","message":"Patch Set 4:\n\n\u003e (1 comment)\n\nGot it. Like I mentioned above I think everyone thought : https://review.opendev.org/#/c/746405/ is better. Easy to read and no duplication so I think this will be followed(I am not author/owner of that patch) . That\u0027s why avoiding the code. \n\nthanks","accounts_in_message":[],"_revision_number":4},{"id":"cef05e22c188f86e4b404a3c20310f36ebe7e3e0","author":{"_account_id":32309,"name":"Jake.Chae","email":"cocahack@naver.com","username":"Jake.Chae"},"date":"2020-09-11 08:54:31.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"7043b9abe565a3544428ba07ce76b6e3c746493a","author":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"date":"2020-10-01 12:51:33.000000000","message":"Abandoned\n\nMerged : https://review.opendev.org/#/c/746405/","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"6b309cf783a0e01ee4432aca7349db40ee5cc8ef","revisions":{"36fd6c9876a8bf87f084042ea0366e3655231357":{"kind":"REWORK","_number":1,"created":"2020-07-10 13:03:01.000000000","uploader":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"ref":"refs/changes/55/740455/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/55/740455/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/740455/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/740455/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/740455/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/55/740455/1"}}},"commit":{"parents":[{"commit":"8aed5feab8a5ae65658ea03fe1f2c238f6ffd908","subject":"Merge \"Fix uploading an signed image does not work if private signing key is encrypted\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8aed5feab8a5ae65658ea03fe1f2c238f6ffd908"}]}],"author":{"name":"jay","email":"jayadityagupta11@gmail.com","date":"2020-07-10 13:00:49.000000000","tz":120},"committer":{"name":"jay","email":"jayadityagupta11@gmail.com","date":"2020-07-10 13:02:58.000000000","tz":120},"subject":"Fix for image property filter in OSC CLI","message":"Fix for image property filter in OSC CLI\n\nOSC CLI --image-property filter is not working properly. It fails\nto find image even though it exits\n\nChange-Id: Ia48115974390a3e6a6a3d31b27cc0f3d3525c609\nStory: #2007860\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/36fd6c9876a8bf87f084042ea0366e3655231357"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/36fd6c9876a8bf87f084042ea0366e3655231357"}]},"branch":"refs/heads/master"},"86b9fe698ae13370f157fb0db76f08820b66f8e6":{"kind":"REWORK","_number":2,"created":"2020-07-17 08:40:47.000000000","uploader":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"ref":"refs/changes/55/740455/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/55/740455/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/740455/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/740455/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/740455/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/55/740455/2"}}},"commit":{"parents":[{"commit":"8aed5feab8a5ae65658ea03fe1f2c238f6ffd908","subject":"Merge \"Fix uploading an signed image does not work if private signing key is encrypted\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8aed5feab8a5ae65658ea03fe1f2c238f6ffd908"}]}],"author":{"name":"jay","email":"jayadityagupta11@gmail.com","date":"2020-07-10 13:00:49.000000000","tz":120},"committer":{"name":"jay","email":"jayadityagupta11@gmail.com","date":"2020-07-17 08:40:19.000000000","tz":120},"subject":"Fix for image property filter in OSC CLI","message":"Fix for image property filter in OSC CLI\n\nOSC CLI --image-property filter is not working properly. It fails\nto find image even though it exits\n\nChange-Id: Ia48115974390a3e6a6a3d31b27cc0f3d3525c609\nStory: #2007860\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/86b9fe698ae13370f157fb0db76f08820b66f8e6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/86b9fe698ae13370f157fb0db76f08820b66f8e6"}]},"branch":"refs/heads/master"},"ed0f733d1945dcac3e0320f5ea0455b62e862a67":{"kind":"REWORK","_number":3,"created":"2020-07-17 11:13:26.000000000","uploader":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"ref":"refs/changes/55/740455/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/55/740455/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/740455/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/740455/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/740455/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/55/740455/3"}}},"commit":{"parents":[{"commit":"8aed5feab8a5ae65658ea03fe1f2c238f6ffd908","subject":"Merge \"Fix uploading an signed image does not work if private signing key is encrypted\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8aed5feab8a5ae65658ea03fe1f2c238f6ffd908"}]}],"author":{"name":"jay","email":"jayadityagupta11@gmail.com","date":"2020-07-10 13:00:49.000000000","tz":120},"committer":{"name":"jay","email":"jayadityagupta11@gmail.com","date":"2020-07-17 11:13:01.000000000","tz":120},"subject":"Fix for image property filter in OSC CLI","message":"Fix for image property filter in OSC CLI\n\nOSC CLI --image-property filter is not working properly. It fails\nto find image even though it exists\n\nChange-Id: Ia48115974390a3e6a6a3d31b27cc0f3d3525c609\nStory: #2007860\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ed0f733d1945dcac3e0320f5ea0455b62e862a67"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ed0f733d1945dcac3e0320f5ea0455b62e862a67"}]},"branch":"refs/heads/master"},"6b309cf783a0e01ee4432aca7349db40ee5cc8ef":{"kind":"REWORK","_number":4,"created":"2020-08-24 12:13:46.000000000","uploader":{"_account_id":31733,"name":"jayaditya gupta","email":"jayadityagupta11@gmail.com","username":"jgupta"},"ref":"refs/changes/55/740455/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/55/740455/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/740455/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/740455/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/740455/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/55/740455/4"}}},"commit":{"parents":[{"commit":"8aed5feab8a5ae65658ea03fe1f2c238f6ffd908","subject":"Merge \"Fix uploading an signed image does not work if private signing key is encrypted\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8aed5feab8a5ae65658ea03fe1f2c238f6ffd908"}]}],"author":{"name":"jay","email":"jayadityagupta11@gmail.com","date":"2020-07-10 13:00:49.000000000","tz":120},"committer":{"name":"jay","email":"jayadityagupta11@gmail.com","date":"2020-08-24 12:13:33.000000000","tz":120},"subject":"Fix for image property filter in OSC CLI","message":"Fix for image property filter in OSC CLI\n\nOSC CLI --image-property filter is not working properly. It fails\nto find image even though it exists\n\nChange-Id: Ia48115974390a3e6a6a3d31b27cc0f3d3525c609\nStory: #2007860\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/6b309cf783a0e01ee4432aca7349db40ee5cc8ef"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/6b309cf783a0e01ee4432aca7349db40ee5cc8ef"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}