)]}'
{"openstackclient/tests/functional/base.py":[{"author":{"_account_id":30690,"name":"manasareddybethi","email":"mb711d@att.com","username":"mb711d"},"change_message_id":"2ac06ce7aae190f357598c6c464d7b6196b845cb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import testtools"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"COMMON_DIR \u003d os.path.dirname(os.path.abspath(__file__))"},{"line_number":23,"context_line":"FUNCTIONAL_DIR \u003d os.path.normpath(os.path.join(COMMON_DIR, \u0027..\u0027))"},{"line_number":24,"context_line":"ROOT_DIR \u003d os.path.normpath(os.path.join(FUNCTIONAL_DIR, \u0027..\u0027))"},{"line_number":25,"context_line":"EXAMPLE_DIR \u003d os.path.join(ROOT_DIR, \u0027examples\u0027)"},{"line_number":26,"context_line":"ADMIN_CLOUD \u003d os.environ.get(\u0027OS_ADMIN_CLOUD\u0027, \u0027devstack-admin\u0027)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_373a84e6","side":"PARENT","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":48},"updated":"2020-07-23 21:10:49.000000000","message":"These globals arent used anywhere. So deleting them","commit_id":"82ebddca006d1dc61855fdd34b0616222039ea58"}],"openstackclient/tests/functional/examples/test_examples.py":[{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"d362adc5ca170288c14d76cec96fe82ce0fdfbd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bf51134e_34dac978","updated":"2020-07-20 21:40:10.000000000","message":"this test case was add 4 years ago and has not worked since then\nhttps://github.com/openstack/python-openstackclient/commits/master/openstackclient/tests/functional/examples/test_examples.py","commit_id":"aa10d885b553359bf0b6862391689436dc6932f6"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"47caa48484678e41e8024d855945bb7787cb3389","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    def test_common(self):"},{"line_number":20,"context_line":"        # NOTE(stevemar): If an examples has a non-zero return"},{"line_number":21,"context_line":"        # code, then execute will raise an error by default."},{"line_number":22,"context_line":"        base.execute(\u0027python \u0027 + base.EXAMPLE_DIR + \u0027/common.py --debug\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_object_api(self):"},{"line_number":25,"context_line":"        base.execute(\u0027python \u0027 + base.EXAMPLE_DIR + \u0027/object_api.py --debug\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_3783f6ab","line":22,"range":{"start_line":22,"start_character":32,"end_line":22,"end_character":63},"updated":"2020-07-20 12:13:31.000000000","message":"Not a big deal but it could be worth to use os.path.join here. (and bellow too)","commit_id":"aa10d885b553359bf0b6862391689436dc6932f6"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"d362adc5ca170288c14d76cec96fe82ce0fdfbd5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    def test_common(self):"},{"line_number":20,"context_line":"        # NOTE(stevemar): If an examples has a non-zero return"},{"line_number":21,"context_line":"        # code, then execute will raise an error by default."},{"line_number":22,"context_line":"        base.execute(\u0027python \u0027 + base.EXAMPLE_DIR + \u0027/common.py --debug\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_object_api(self):"},{"line_number":25,"context_line":"        base.execute(\u0027python \u0027 + base.EXAMPLE_DIR + \u0027/object_api.py --debug\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_14d7c551","line":22,"range":{"start_line":22,"start_character":8,"end_line":22,"end_character":73},"updated":"2020-07-20 21:40:10.000000000","message":"this test just runs a subprocess that reads args and it asserts nothing except return code\nhttps://github.com/openstack/python-openstackclient/blob/master/examples/common.py#L238\n\nhttps://github.com/openstack/python-openstackclient/blob/master/openstackclient/tests/functional/base.py#L29","commit_id":"aa10d885b553359bf0b6862391689436dc6932f6"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"81eb052e41b7aa5a13fe95ea5a24d877672ee916","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    def test_common(self):"},{"line_number":20,"context_line":"        # NOTE(stevemar): If an examples has a non-zero return"},{"line_number":21,"context_line":"        # code, then execute will raise an error by default."},{"line_number":22,"context_line":"        base.execute(\u0027python \u0027 + base.EXAMPLE_DIR + \u0027/common.py --debug\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_object_api(self):"},{"line_number":25,"context_line":"        base.execute(\u0027python \u0027 + base.EXAMPLE_DIR + \u0027/object_api.py --debug\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_9f90be44","line":22,"range":{"start_line":22,"start_character":8,"end_line":22,"end_character":73},"in_reply_to":"bf51134e_14d7c551","updated":"2020-07-24 12:33:50.000000000","message":"I\u0027m ok to keep this version","commit_id":"aa10d885b553359bf0b6862391689436dc6932f6"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"d362adc5ca170288c14d76cec96fe82ce0fdfbd5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        base.execute(\u0027python \u0027 + base.EXAMPLE_DIR + \u0027/common.py --debug\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_object_api(self):"},{"line_number":25,"context_line":"        base.execute(\u0027python \u0027 + base.EXAMPLE_DIR + \u0027/object_api.py --debug\u0027)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def test_osc_lib(self):"},{"line_number":28,"context_line":"        base.execute(\u0027python \u0027 + base.EXAMPLE_DIR + \u0027/osc-lib.py --debug\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_f457b1c9","line":25,"range":{"start_line":25,"start_character":52,"end_line":25,"end_character":68},"updated":"2020-07-20 21:40:10.000000000","message":"this test create an object list container and object but does not clean up the resources https://github.com/openstack/python-openstackclient/blob/master/examples/object_api.py\n\nand theses test cases cover that\ncontainer\nhttps://github.com/openstack/python-openstackclient/blob/master/openstackclient/tests/functional/object/v1/test_container.py#L46\nobject \nhttps://github.com/openstack/python-openstackclient/blob/master/openstackclient/tests/functional/object/v1/test_object.py#L41","commit_id":"aa10d885b553359bf0b6862391689436dc6932f6"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"d362adc5ca170288c14d76cec96fe82ce0fdfbd5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        base.execute(\u0027python \u0027 + base.EXAMPLE_DIR + \u0027/object_api.py --debug\u0027)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def test_osc_lib(self):"},{"line_number":28,"context_line":"        base.execute(\u0027python \u0027 + base.EXAMPLE_DIR + \u0027/osc-lib.py --debug\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_b42b7931","line":28,"range":{"start_line":28,"start_character":53,"end_line":28,"end_character":64},"updated":"2020-07-20 21:40:10.000000000","message":"these file run 3 tests container list, object list and flavor list\nhttps://github.com/openstack/python-openstackclient/blob/master/examples/osc-lib.py\n\nobject storage test are noted above and the flavor test is covered here https://github.com/openstack/python-openstackclient/blob/master/openstackclient/tests/functional/compute/v2/test_flavor.py#L71","commit_id":"aa10d885b553359bf0b6862391689436dc6932f6"}],"requirements.txt":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"47caa48484678e41e8024d855945bb7787cb3389","unresolved":false,"context_lines":[{"line_number":13,"context_line":"python-novaclient\u003e\u003d15.1.0 # Apache-2.0"},{"line_number":14,"context_line":"python-cinderclient\u003e\u003d3.3.0 # Apache-2.0"},{"line_number":15,"context_line":"stevedore\u003e\u003d2.0.1 # Apache-2.0"},{"line_number":16,"context_line":"os-client-config\u003d\u003d2.1.0"}],"source_content_type":"text/plain","patch_set":4,"id":"bf51134e_57d82aef","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":23},"updated":"2020-07-20 12:13:31.000000000","message":"I\u0027m not sure to seen why this requirement have been added here","commit_id":"aa10d885b553359bf0b6862391689436dc6932f6"},{"author":{"_account_id":30690,"name":"manasareddybethi","email":"mb711d@att.com","username":"mb711d"},"change_message_id":"fecdda7054b48fd59337c1c5c1acd969a653ed45","unresolved":false,"context_lines":[{"line_number":13,"context_line":"python-novaclient\u003e\u003d15.1.0 # Apache-2.0"},{"line_number":14,"context_line":"python-cinderclient\u003e\u003d3.3.0 # Apache-2.0"},{"line_number":15,"context_line":"stevedore\u003e\u003d2.0.1 # Apache-2.0"},{"line_number":16,"context_line":"os-client-config\u003d\u003d2.1.0"}],"source_content_type":"text/plain","patch_set":4,"id":"bf51134e_69cd9185","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":23},"in_reply_to":"bf51134e_57d82aef","updated":"2020-07-20 17:07:46.000000000","message":"Hi. I have added this requirement because the test case that Ive changed in this patchset fails saying there\u0027s no os-client-config imported.\n\nHowever, we have noticed that the testcase isnt needed as its not doing any asserts. So, we are going to delete the testcase in the next patchset. And, will add one more patchset to fix the existing testcase to not use os-client-config","commit_id":"aa10d885b553359bf0b6862391689436dc6932f6"}]}