)]}'
{"id":"openstack%2Fpython-openstackclient~742647","triplet_id":"openstack%2Fpython-openstackclient~master~I2ea2def607ec5be112e42d53a1e660fef0cdd69c","project":"openstack/python-openstackclient","branch":"master","topic":"fix_rbac_regression","hashtags":[],"change_id":"I2ea2def607ec5be112e42d53a1e660fef0cdd69c","subject":"Fix reverted osc-lib interface change","status":"MERGED","created":"2020-07-23 11:33:08.000000000","updated":"2020-08-03 14:54:44.000000000","submitted":"2020-08-03 14:52:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"742647-1596466337900-7b2e085e","meta_rev_id":"2628c11801bf7e02ed8a87ed90b62d1722d73a3b","_number":742647,"virtual_id_number":742647,"owner":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-03 14:52:17.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-08-03 12:21:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":2,"date":"2020-08-03 13:37:24.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":1,"date":"2020-08-03 13:37:24.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-03 12:21:19.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2020-08-03 13:37:24.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2020-08-03 14:52:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"97761e044a189aba2536dd2a87adfba34bd519ae","author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"date":"2020-07-23 11:33:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5a7be761f6e2cc4d02cbc09858919e275b8e0dc3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-23 12:48:08.000000000","message":"Patch Set 1: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/84a605b7ff634c02b6a92f64919c33c3 : SUCCESS in 6m 10s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/cb554701e5ec47a6af3a28c663066160 : SUCCESS in 5m 08s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/dd0ae2e1b9054fcba8dc8476d3fd29d3 : SUCCESS in 5m 44s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/dcaf99ad7de64e26bc186ca2bc72fadb : SUCCESS in 5m 32s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e0f65c65ecd34d029528ffb55f18ebcc : FAILURE in 4m 28s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/20cbdf9c5d6841319951bc4a38b75397 : SUCCESS in 4m 15s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4655d14da9664e1c8996f448dee835f1 : SUCCESS in 4m 05s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2ba42f770eba499fac7956116bce3678 : SUCCESS in 7m 16s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/9f3b3724e0174472ba46052a8582b333 : SUCCESS in 1h 12m 46s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/5ac045b2c61543178a83fefd1ead5853 : SUCCESS in 7m 47s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/419ffe13d70246a482d02ee6df21e671 : SUCCESS in 54m 45s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/9cef0b4331704ea4b10e5fa49866c912 : SUCCESS in 56m 25s","accounts_in_message":[],"_revision_number":1},{"id":"012381fa5c5a820e07f5deaeca97531faebd0508","author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"date":"2020-07-23 18:35:30.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0922016faea340d4f62a7dee82ad64d3e2ac6ab6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-23 20:13:52.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/88d0480f848945878c4bc2735a14b8da : SUCCESS in 7m 05s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/eb7b79cbb86e4689ab5a33a6b53a1454 : SUCCESS in 6m 27s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2fc1a42abfa3470c9d733a2e55d44e81 : SUCCESS in 5m 15s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/181b65009ba348c1bdd916ad3580cc26 : SUCCESS in 6m 38s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/38e7ef6cbd5b4843906a65aead1909d0 : SUCCESS in 4m 34s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/222831891275463486434fc51093da60 : SUCCESS in 5m 13s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c725887a641d44f9855305d858198937 : SUCCESS in 4m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/511987004c1a4efd8f922c42e2b6a249 : SUCCESS in 6m 57s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/3038e933ef314fe499141d8ced1c74bc : SUCCESS in 1h 22m 41s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/c569490351c4401fa357391a6e3bd534 : SUCCESS in 7m 59s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/3a0225eb9bfc4bd2a8cbd720b0a7964e : SUCCESS in 45m 39s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/35e88477e21d421baf22d8cd12dab74d : SUCCESS in 1h 01m 40s","accounts_in_message":[],"_revision_number":2},{"id":"0cb0d5a504ba685ac94beda71d0a4e115511594e","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-08-03 12:21:19.000000000","message":"Patch Set 2: Code-Review+2\n\nFTR, the issue is that something like \"openstack network rbac create --target-project $project --action access_as_shared --type network $network\" is failing as a non-admin user with OSC \u003e\u003d 5.0.0.","accounts_in_message":[],"_revision_number":2},{"id":"99b17214358ce25d695c1ff93f63860d543eb5ae","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-08-03 13:37:24.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"5bf0961c5e4731cf9055fed6062c7f636646c6e5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-03 13:37:54.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"25358e673321fa5daad9ba781b5a061d50d9f02f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-03 14:52:17.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/d2f6a0461c724a0ea4dbef8a4af95d59 : SUCCESS in 5m 32s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/535509be2a4a41b2913194d31aff2582 : SUCCESS in 4m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b725682e8761425d99d5f7c56763888d : SUCCESS in 3m 26s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4a59eff2c71d4d46a729511142428a91 : SUCCESS in 4m 38s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8b5cdbfdf0cd47bfbbdc84431fbf0f0b : SUCCESS in 7m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d89afe8471f44b88baa2a424252eb63c : SUCCESS in 6m 44s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/7ba4bb9f83794489825627ce291db689 : SUCCESS in 1h 09m 02s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/c187054a0e6c4a99aee08678975d6f65 : SUCCESS in 7m 18s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/cb8be170125b4d7f97f7d4444ab744ad : SUCCESS in 48m 56s","accounts_in_message":[],"_revision_number":2},{"id":"3ba47a179e2f1986fd32ada93110e58bba4ac04e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-03 14:52:17.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"72ff277c585579a6131ad4c03f404cb4f7c6a29f","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-03 14:54:44.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/eef5189a7c244039bbf95af83c97270b : SUCCESS in 2m 02s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/a172d4b33a5b44d885913d294a060bbb : SUCCESS in 40s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"0a8753dc3eaeda25554ccd769350de1e9792a62b","revisions":{"10692f5aaa33664780c70831dd2121d1a6a2e6b7":{"kind":"REWORK","_number":1,"created":"2020-07-23 11:33:08.000000000","uploader":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"ref":"refs/changes/47/742647/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/47/742647/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/47/742647/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/47/742647/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/47/742647/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/47/742647/1"}}},"commit":{"parents":[{"commit":"82ebddca006d1dc61855fdd34b0616222039ea58","subject":"Fix compatibility issue in 5.3","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/82ebddca006d1dc61855fdd34b0616222039ea58"}]}],"author":{"name":"Roger Luethi","email":"rl@patchworkscience.org","date":"2020-07-23 11:20:09.000000000","tz":120},"committer":{"name":"Roger Luethi","email":"rl@patchworkscience.org","date":"2020-07-23 11:20:09.000000000","tz":120},"subject":"Fix reverted osc-lib interface change","message":"Fix reverted osc-lib interface change\n\nThe patch https://review.opendev.org/#/c/673389/ introduced a regression\nby changing the osc-lib interface.\n\nTwo conflicting attempts to fix the regression were launched:\n\n1) Reverting the patch.\n\n2) The patch https://review.opendev.org/683119 changes the exception\n   from the generic CommandError back to a specific Forbidden exception.\n\n   The patch https://review.opendev.org/683118 catches this exception\n   and passes on, i.e. re-implements the same behavior as before.\n\nThe first idea was implemented, the initial patch reverted. The second\nidea was partially implemented. The change in python-openstackclient\n(683118) was merged. The change in osc-lib was approved but failed to\nmerge because the initial change had been reverted.\n\nNow we have again a situation where the exception produced in osc-lib\ndoes not match the exception expected by the caller.\n\nIt is unclear if the osc-lib interface will ever get a rebased version\nof https://review.opendev.org/683119 merged, so the safest way to\naddress the issue is to also catch the exception that used to be\nthrown before the inital change and is again thrown after the inital\nchange has been reverted.\n\nChange-Id: I2ea2def607ec5be112e42d53a1e660fef0cdd69c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/10692f5aaa33664780c70831dd2121d1a6a2e6b7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/10692f5aaa33664780c70831dd2121d1a6a2e6b7"}]},"branch":"refs/heads/master"},"0a8753dc3eaeda25554ccd769350de1e9792a62b":{"kind":"REWORK","_number":2,"created":"2020-07-23 18:35:30.000000000","uploader":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"ref":"refs/changes/47/742647/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/47/742647/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/47/742647/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/47/742647/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/47/742647/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/47/742647/2"}}},"commit":{"parents":[{"commit":"82ebddca006d1dc61855fdd34b0616222039ea58","subject":"Fix compatibility issue in 5.3","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/82ebddca006d1dc61855fdd34b0616222039ea58"}]}],"author":{"name":"Roger Luethi","email":"rl@patchworkscience.org","date":"2020-07-23 11:20:09.000000000","tz":120},"committer":{"name":"Roger Luethi","email":"rl@patchworkscience.org","date":"2020-07-23 18:35:21.000000000","tz":120},"subject":"Fix reverted osc-lib interface change","message":"Fix reverted osc-lib interface change\n\nThe patch https://review.opendev.org/#/c/673389/ introduced a regression\nby changing the osc-lib interface.\n\nTwo conflicting attempts to fix the regression were launched:\n\n1) Reverting the patch.\n\n2) The patch https://review.opendev.org/683119 changes the exception\n   from the generic CommandError back to a specific Forbidden exception.\n\n   The patch https://review.opendev.org/683118 catches this exception\n   and passes on, i.e. re-implements the same behavior as before.\n\nThe first idea was implemented, the initial patch reverted. The second\nidea was partially implemented. The change in python-openstackclient\n(683118) was merged. The change in osc-lib was approved but failed to\nmerge because the initial change had been reverted.\n\nNow we have again a situation where the exception produced in osc-lib\ndoes not match the exception expected by the caller.\n\nIt is unclear if the osc-lib interface will ever get a rebased version\nof https://review.opendev.org/683119 merged, so the safest way to\naddress the issue is to also catch the exception that used to be\nthrown before the inital change and is again thrown after the inital\nchange has been reverted.\n\nChange-Id: I2ea2def607ec5be112e42d53a1e660fef0cdd69c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0a8753dc3eaeda25554ccd769350de1e9792a62b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0a8753dc3eaeda25554ccd769350de1e9792a62b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}