)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b70f4f335c6b7ea99cf63dbee224ffcd7beceaee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e1aaad01_f8180f47","updated":"2024-01-26 21:24:29.000000000","message":"Can you guys review this one?","commit_id":"53af0ce7ec8dad60c0821f100b323e416db570f6"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"28ba5efb25bb08e2d3e06bd79e31b396a4609c5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"93d528eb_cec7737c","updated":"2024-01-29 11:19:22.000000000","message":"Hi Rafael, thanks for the patch, I have only a few questions about this new attribute.","commit_id":"6fa2c13b31a045740cb36c83fc0551cca639de75"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"17bacfdcef4902b75884d3c56228d58ba975197c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"37ff1471_581d59cd","updated":"2024-01-29 17:06:34.000000000","message":"Thanks!","commit_id":"2ed10e9a72524717e11b96b00a19d10d06280460"}],"openstackclient/identity/v3/mapping.py":[{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"28ba5efb25bb08e2d3e06bd79e31b396a4609c5d","unresolved":true,"context_lines":[{"line_number":195,"context_line":"            help\u003d_(\u0027Filename that contains a new set of mapping rules\u0027),"},{"line_number":196,"context_line":"        )"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        _RulesReader.add_federated_schema_version_option(parser)"},{"line_number":199,"context_line":"        return parser"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"75de9198_b15e8d36","line":198,"updated":"2024-01-29 11:19:22.000000000","message":"Just a few questions here: \n\n - Is this the method to update a mapping?\n - If a user does not set this \"schema version\" attribute when updating a mapping, wouldnt this method forcing a \"1.0\" value in the query?\n  - In this case, it whould override the current mapping version to \"1.0\" even the user not expecting it, right?\n  - Maybe for updates, you should leave its default as \"None\".\n  \n - I guess the backend is already setting a default value for the mapping in the API. I think that the CLI should not interfere in this behavior, so I would leave the default as \"None\" for both creating and updating mappings, otherwise, the configuration to define a default version for the mapping in the backend would not take any effect for the users that are using the CLI, What do you think?","commit_id":"6fa2c13b31a045740cb36c83fc0551cca639de75"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"52352a0db6b2c7ab3f13429cecd6ce0c049ffef3","unresolved":true,"context_lines":[{"line_number":195,"context_line":"            help\u003d_(\u0027Filename that contains a new set of mapping rules\u0027),"},{"line_number":196,"context_line":"        )"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        _RulesReader.add_federated_schema_version_option(parser)"},{"line_number":199,"context_line":"        return parser"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ce196dbc_16624d4a","line":198,"in_reply_to":"75de9198_b15e8d36","updated":"2024-01-29 11:33:32.000000000","message":"I agree with you. This change was done before that new property being introduced in the backend. Therefore, I am changing it here. The default will be \"None\". Therefore, the \"schema_version\" now will only be set/defined in the backend, if it is not defined here in the client by the user.","commit_id":"6fa2c13b31a045740cb36c83fc0551cca639de75"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"c4706551cb86ae87fc5e06c99cd67b9f86689624","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            help\u003d_(\u0027Filename that contains a new set of mapping rules\u0027),"},{"line_number":196,"context_line":"        )"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        _RulesReader.add_federated_schema_version_option(parser)"},{"line_number":199,"context_line":"        return parser"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"b3ad5ecc_ee133085","line":198,"in_reply_to":"ce196dbc_16624d4a","updated":"2024-01-29 11:38:51.000000000","message":"Done","commit_id":"6fa2c13b31a045740cb36c83fc0551cca639de75"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"e4b390e254b7087af1e9bf1e668f10cb0d149ba8","unresolved":true,"context_lines":[{"line_number":89,"context_line":"            required\u003dFalse,"},{"line_number":90,"context_line":"            default\u003dNone,"},{"line_number":91,"context_line":"            help\u003d_("},{"line_number":92,"context_line":"                \"The federated attribute mapping schema version. The \""},{"line_number":93,"context_line":"                \"default value is set to \u00271.0\u0027\""},{"line_number":94,"context_line":"            ),"},{"line_number":95,"context_line":"        )"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"f39dfac4_ec980b01","line":93,"range":{"start_line":92,"start_character":16,"end_line":93,"end_character":47},"updated":"2024-01-29 11:45:00.000000000","message":"Nice, guess you should change this one as well, right?","commit_id":"084e2b1c9ae8caa69916a6e05bcbbde109c8c126"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"1371fa452b40984f646e3c2d27eaa8fe9421ad1d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            required\u003dFalse,"},{"line_number":90,"context_line":"            default\u003dNone,"},{"line_number":91,"context_line":"            help\u003d_("},{"line_number":92,"context_line":"                \"The federated attribute mapping schema version. The \""},{"line_number":93,"context_line":"                \"default value is set to \u00271.0\u0027\""},{"line_number":94,"context_line":"            ),"},{"line_number":95,"context_line":"        )"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fac35107_7dd967f5","line":93,"range":{"start_line":92,"start_character":16,"end_line":93,"end_character":47},"in_reply_to":"f39dfac4_ec980b01","updated":"2024-01-29 11:51:07.000000000","message":"Done","commit_id":"084e2b1c9ae8caa69916a6e05bcbbde109c8c126"}]}