)]}'
{"openstackclient/compute/v2/keypair.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"acaa2357e6382337eb264cbc89ddaa70b548e6ea","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                \u0027Requires ``--os-compute-api-version`` 2.10 or greater.\u0027"},{"line_number":156,"context_line":"            ),"},{"line_number":157,"context_line":"        )"},{"line_number":158,"context_line":"        identity_common.add_user_domain_option_to_parser(parser)"},{"line_number":159,"context_line":"        user_group.add_argument("},{"line_number":160,"context_line":"            \u0027--all-users\u0027,"},{"line_number":161,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_651c2366","line":158,"updated":"2020-10-08 12:53:16.000000000","message":"This likely should also conflict with \"--all-users\" but I\u0027m not sure how that would be implemented.\n\nNot directly related: There also doesn\u0027t seem to be a test for the \"--user-domain-*\" options.","commit_id":"15cb3d8a68af708a80353c531000cd884d1d083b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9dee713cb4ea8e4b2c0107b7d00f1ac488acc172","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                \u0027Requires ``--os-compute-api-version`` 2.10 or greater.\u0027"},{"line_number":156,"context_line":"            ),"},{"line_number":157,"context_line":"        )"},{"line_number":158,"context_line":"        identity_common.add_user_domain_option_to_parser(parser)"},{"line_number":159,"context_line":"        user_group.add_argument("},{"line_number":160,"context_line":"            \u0027--all-users\u0027,"},{"line_number":161,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_71fea138","line":158,"in_reply_to":"9f560f44_651c2366","updated":"2020-10-08 16:04:21.000000000","message":"Hmm, yeah, I\u0027m not sure how to do that either :-\\ I guess it\u0027ll simply be ignored? That\u0027s what would happen if you specified any of them without the \u0027--user\u0027 option (for this and every other command that uses these, fwiw).\n\nI\u0027m also not sure if there\u0027s much value in adding tests for the \u0027--user-domain-*\u0027 options since they\u0027re standard and tested elsewhere. Okay to ignore them?","commit_id":"15cb3d8a68af708a80353c531000cd884d1d083b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"acaa2357e6382337eb264cbc89ddaa70b548e6ea","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            users \u003d identity_client.users.list()"},{"line_number":185,"context_line":"            for user in users:"},{"line_number":186,"context_line":"                data.extend(compute_client.keypairs.list(user_id\u003duser.id))"},{"line_number":187,"context_line":"        else:"},{"line_number":188,"context_line":"            if parsed_args.user:"},{"line_number":189,"context_line":"                kwargs[\u0027user_id\u0027] \u003d identity_common.find_user("},{"line_number":190,"context_line":"                    identity_client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_6503830d","line":187,"range":{"start_line":187,"start_character":8,"end_line":187,"end_character":12},"updated":"2020-10-08 12:53:16.000000000","message":"use \"elif\" instead of \"else if\"","commit_id":"15cb3d8a68af708a80353c531000cd884d1d083b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9dee713cb4ea8e4b2c0107b7d00f1ac488acc172","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            users \u003d identity_client.users.list()"},{"line_number":185,"context_line":"            for user in users:"},{"line_number":186,"context_line":"                data.extend(compute_client.keypairs.list(user_id\u003duser.id))"},{"line_number":187,"context_line":"        else:"},{"line_number":188,"context_line":"            if parsed_args.user:"},{"line_number":189,"context_line":"                kwargs[\u0027user_id\u0027] \u003d identity_common.find_user("},{"line_number":190,"context_line":"                    identity_client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_11bc856a","line":187,"range":{"start_line":187,"start_character":8,"end_line":187,"end_character":12},"in_reply_to":"9f560f44_6503830d","updated":"2020-10-08 16:04:21.000000000","message":"If I did that, I\u0027d have to duplicate the call to \u0027compute_client.keypairs.list\u0027 below to handle the \"no parameters specified\" case","commit_id":"15cb3d8a68af708a80353c531000cd884d1d083b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7d0250039eee6bbd16624c4a29ba1e973b5e5af4","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            for user in users:"},{"line_number":194,"context_line":"                data.extend(compute_client.keypairs.list(user_id\u003duser.id))"},{"line_number":195,"context_line":"        else:"},{"line_number":196,"context_line":"            if parsed_args.user:"},{"line_number":197,"context_line":"                kwargs[\u0027user_id\u0027] \u003d identity_common.find_user("},{"line_number":198,"context_line":"                    identity_client,"},{"line_number":199,"context_line":"                    parsed_args.user,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_4c54a4c6","line":196,"updated":"2020-10-08 16:22:22.000000000","message":"I wonder if the code would get simpler if you would wrap this into the block above. Something like\n\nusers \u003d list(find_user().id)\n\nand then loop over that.","commit_id":"915752e9cffb5e4cebba91480c9259441ac17b67"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2b4e70813ddbf8f0679abac8fb5cbde6f93a7534","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            for user in users:"},{"line_number":194,"context_line":"                data.extend(compute_client.keypairs.list(user_id\u003duser.id))"},{"line_number":195,"context_line":"        else:"},{"line_number":196,"context_line":"            if parsed_args.user:"},{"line_number":197,"context_line":"                kwargs[\u0027user_id\u0027] \u003d identity_common.find_user("},{"line_number":198,"context_line":"                    identity_client,"},{"line_number":199,"context_line":"                    parsed_args.user,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_8cc99c5b","line":196,"in_reply_to":"9f560f44_4c54a4c6","updated":"2020-10-08 16:55:23.000000000","message":"Probably not? We\u0027d still need another call to \u0027compute_client.keypairs.list\u0027 to handle the no-filter case.","commit_id":"915752e9cffb5e4cebba91480c9259441ac17b67"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7d0250039eee6bbd16624c4a29ba1e973b5e5af4","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                    parsed_args.user,"},{"line_number":200,"context_line":"                    parsed_args.user_domain,"},{"line_number":201,"context_line":"                ).id"},{"line_number":202,"context_line":"            data \u003d compute_client.keypairs.list(**kwargs)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        columns \u003d ("},{"line_number":205,"context_line":"            \"Name\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_cc8b9466","line":202,"updated":"2020-10-08 16:22:22.000000000","message":"As I totally missed that this line wasn\u0027t part of the \"if\" block, maybe add an empty line in front of it to make it more obvious.","commit_id":"915752e9cffb5e4cebba91480c9259441ac17b67"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2b4e70813ddbf8f0679abac8fb5cbde6f93a7534","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                    parsed_args.user,"},{"line_number":200,"context_line":"                    parsed_args.user_domain,"},{"line_number":201,"context_line":"                ).id"},{"line_number":202,"context_line":"            data \u003d compute_client.keypairs.list(**kwargs)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        columns \u003d ("},{"line_number":205,"context_line":"            \"Name\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_4ce144cf","line":202,"in_reply_to":"9f560f44_cc8b9466","updated":"2020-10-08 16:55:23.000000000","message":"Done","commit_id":"915752e9cffb5e4cebba91480c9259441ac17b67"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7d0250039eee6bbd16624c4a29ba1e973b5e5af4","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        columns \u003d ("},{"line_number":205,"context_line":"            \"Name\","},{"line_number":206,"context_line":"            \"Fingerprint\""},{"line_number":207,"context_line":"        )"},{"line_number":208,"context_line":"        return ("},{"line_number":209,"context_line":"            columns,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_8cf6bcd7","line":206,"updated":"2020-10-08 16:22:22.000000000","message":"Would it make sense to add the user (name or id) to the list of results?","commit_id":"915752e9cffb5e4cebba91480c9259441ac17b67"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2b4e70813ddbf8f0679abac8fb5cbde6f93a7534","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        columns \u003d ("},{"line_number":205,"context_line":"            \"Name\","},{"line_number":206,"context_line":"            \"Fingerprint\""},{"line_number":207,"context_line":"        )"},{"line_number":208,"context_line":"        return ("},{"line_number":209,"context_line":"            columns,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_acd100fb","line":206,"in_reply_to":"9f560f44_8cf6bcd7","updated":"2020-10-08 16:55:23.000000000","message":"Good idea. nova doesn\u0027t expose that via the API so I\u0027ll have to tack it on","commit_id":"915752e9cffb5e4cebba91480c9259441ac17b67"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a2e75f09ca77c3747961202b583bc302799bfd35","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        columns \u003d ("},{"line_number":205,"context_line":"            \"Name\","},{"line_number":206,"context_line":"            \"Fingerprint\""},{"line_number":207,"context_line":"        )"},{"line_number":208,"context_line":"        return ("},{"line_number":209,"context_line":"            columns,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_45caad9f","line":206,"in_reply_to":"9f560f44_acd100fb","updated":"2020-10-09 09:30:35.000000000","message":"I did this in a follow-up because I\u0027m still on the fence about it","commit_id":"915752e9cffb5e4cebba91480c9259441ac17b67"}],"releasenotes/notes/add-keypairs-user-filter-e1ce57a4c09c278b.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"acaa2357e6382337eb264cbc89ddaa70b548e6ea","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    It is now possible to list the keypairs for all users using the"},{"line_number":9,"context_line":"    ``--all-users`` parameter. This is an admin-only action by default and"},{"line_number":10,"context_line":"    requires Compute API microversion 2.10 or later."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_45563f07","line":10,"updated":"2020-10-08 12:53:16.000000000","message":"I\u0027d rather have a separate reno for this.","commit_id":"15cb3d8a68af708a80353c531000cd884d1d083b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9dee713cb4ea8e4b2c0107b7d00f1ac488acc172","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    It is now possible to list the keypairs for all users using the"},{"line_number":9,"context_line":"    ``--all-users`` parameter. This is an admin-only action by default and"},{"line_number":10,"context_line":"    requires Compute API microversion 2.10 or later."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_31b70988","line":10,"in_reply_to":"9f560f44_45563f07","updated":"2020-10-08 16:04:21.000000000","message":"Done","commit_id":"15cb3d8a68af708a80353c531000cd884d1d083b"}]}