)]}'
{"openstackclient/compute/v2/server.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"25200ea10d37a00b257610d88a95a57992b0bce1","unresolved":false,"context_lines":[{"line_number":647,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":648,"context_line":"            default\u003d[],"},{"line_number":649,"context_line":"            help\u003d_("},{"line_number":650,"context_line":"                \u0027**Deprecated** Security group to assign to this server \u0027"},{"line_number":651,"context_line":"                \u0027(name or ID) \u0027"},{"line_number":652,"context_line":"                \u0027(repeat option to set multiple groups)\u0027"},{"line_number":653,"context_line":"            ),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_bc8420b3","line":650,"range":{"start_line":650,"start_character":17,"end_line":650,"end_character":32},"updated":"2020-10-28 15:05:34.000000000","message":"I am a bit surprised it. I don\u0027t see no deprecation notice in the compute API reference. It is still useful when creating a server with a single port using non-default security group. What do you think is the recommended way if this option is deprecated?","commit_id":"c2afa47ed55acd649a6865b7f429bc47a2331d81"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"57af5b3d473f6ee761ba18d7db5dec9936e1998b","unresolved":false,"context_lines":[{"line_number":647,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":648,"context_line":"            default\u003d[],"},{"line_number":649,"context_line":"            help\u003d_("},{"line_number":650,"context_line":"                \u0027**Deprecated** Security group to assign to this server \u0027"},{"line_number":651,"context_line":"                \u0027(name or ID) \u0027"},{"line_number":652,"context_line":"                \u0027(repeat option to set multiple groups)\u0027"},{"line_number":653,"context_line":"            ),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_c1793130","line":650,"range":{"start_line":650,"start_character":17,"end_line":650,"end_character":32},"in_reply_to":"1f621f24_3fd64251","updated":"2020-10-28 22:41:29.000000000","message":"I tested it using the latest DevStack and confirmed --security-group option works expectedly.\nhttp://paste.openstack.org/show/799492/\n\nRegarding nova code, _create_port_minimal [1] calls create_port() of the neutronclient instance to create a port for a server. While I haven\u0027t checked the full code path, I guess a security group ID specified in the nova API is passed here.\n\n[1] https://opendev.org/openstack/nova/src/branch/master/nova/network/neutron.py#L488","commit_id":"c2afa47ed55acd649a6865b7f429bc47a2331d81"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d2ad513370cc7ee0321b6c30cab2b48bc7c595ba","unresolved":false,"context_lines":[{"line_number":647,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":648,"context_line":"            default\u003d[],"},{"line_number":649,"context_line":"            help\u003d_("},{"line_number":650,"context_line":"                \u0027**Deprecated** Security group to assign to this server \u0027"},{"line_number":651,"context_line":"                \u0027(name or ID) \u0027"},{"line_number":652,"context_line":"                \u0027(repeat option to set multiple groups)\u0027"},{"line_number":653,"context_line":"            ),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_3fd64251","line":650,"range":{"start_line":650,"start_character":17,"end_line":650,"end_character":32},"in_reply_to":"1f621f24_bc8420b3","updated":"2020-10-28 15:29:13.000000000","message":"I have probably gotten ahead of myself here. This is something I am fixing as part of the XenAPI cleanup. I probably shouldn\u0027t have included it here yet and can remove it.\n\nHowever, on the future deprecation, maybe I have misunderstood things but looking at the nova code I can\u0027t see this being passed to neutron. It\u0027s simply validated to make sure it exists and then removed. Does this work in your testing? All it does is verify that the SG exists in neutron - not that the port uses it.","commit_id":"c2afa47ed55acd649a6865b7f429bc47a2331d81"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"44c5bdab91816030511ba67eb7469adc7b7a9910","unresolved":false,"context_lines":[{"line_number":647,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":648,"context_line":"            default\u003d[],"},{"line_number":649,"context_line":"            help\u003d_("},{"line_number":650,"context_line":"                \u0027**Deprecated** Security group to assign to this server \u0027"},{"line_number":651,"context_line":"                \u0027(name or ID) \u0027"},{"line_number":652,"context_line":"                \u0027(repeat option to set multiple groups)\u0027"},{"line_number":653,"context_line":"            ),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_1a3267f2","line":650,"range":{"start_line":650,"start_character":17,"end_line":650,"end_character":32},"in_reply_to":"1f621f24_c1793130","updated":"2020-10-29 11:43:41.000000000","message":"Done","commit_id":"c2afa47ed55acd649a6865b7f429bc47a2331d81"}]}