)]}'
{"openstackclient/volume/client.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6b8f6e17208c93d0e37968a45c2ada2975512815","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    \"1\": \"cinderclient.v1.client.Client\","},{"line_number":30,"context_line":"    \"2\": \"cinderclient.v2.client.Client\","},{"line_number":31,"context_line":"    \"3\": \"cinderclient.v3.client.Client\","},{"line_number":32,"context_line":"    \"3.42\": \"cinderclient.v3.client.Client\","},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_20eb5a79","line":32,"updated":"2020-11-05 16:01:19.000000000","message":"Probably good for a follow-up, but what about specifying later versions, too? We shouldn\u0027t fail if a user wants 3.43 or later?","commit_id":"322f6aa653e004b464075cd7a7a84e0749fd684c"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d20b3ef56cd544956223327b1d854caf15791e05","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    \"1\": \"cinderclient.v1.client.Client\","},{"line_number":30,"context_line":"    \"2\": \"cinderclient.v2.client.Client\","},{"line_number":31,"context_line":"    \"3\": \"cinderclient.v3.client.Client\","},{"line_number":32,"context_line":"    \"3.42\": \"cinderclient.v3.client.Client\","},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_a0812a92","line":32,"in_reply_to":"1f621f24_20eb5a79","updated":"2020-11-05 16:08:17.000000000","message":"Tbh I\u0027m not sure what\u0027s the best approach here, as probably we also need to implement changes in client somewhere if we want to support more modern functionality. Ideally all api versions should be mentioned here, but then the list would be enormous. So I\u0027d rather leave that for the follow up and professionals:)","commit_id":"322f6aa653e004b464075cd7a7a84e0749fd684c"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"0c09c294b5291beeb2898e7e524c019ca79a48bc","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"DEFAULT_API_VERSION \u003d \u00273\u0027"},{"line_number":26,"context_line":"API_VERSION_OPTION \u003d \u0027os_volume_api_version\u0027"},{"line_number":27,"context_line":"API_NAME \u003d \"volume\""},{"line_number":28,"context_line":"API_VERSIONS \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_f478b690","line":25,"range":{"start_line":25,"start_character":23,"end_line":25,"end_character":24},"updated":"2020-11-12 12:27:02.000000000","message":"maybe worth setting it to 3.42?","commit_id":"4c0bfb03fc688575fa93667bb59d399fd1c6b41d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"01b008a7335f16a03ec0311e867b9a3f1cf99243","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"DEFAULT_API_VERSION \u003d \u00273\u0027"},{"line_number":26,"context_line":"API_VERSION_OPTION \u003d \u0027os_volume_api_version\u0027"},{"line_number":27,"context_line":"API_NAME \u003d \"volume\""},{"line_number":28,"context_line":"API_VERSIONS \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_1a10f9a7","line":25,"range":{"start_line":25,"start_character":23,"end_line":25,"end_character":24},"in_reply_to":"1f621f24_f478b690","updated":"2020-11-12 15:09:04.000000000","message":"I think defaulting to the base 3.0 version is the safest. At least with the cinder client, the behavior is to do this for making calls unless the user explicitly asks for a more recent microversion. That protects against behavior subtly changing between identical calls if the provider happens to do an upgrade in between.","commit_id":"4c0bfb03fc688575fa93667bb59d399fd1c6b41d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"01b008a7335f16a03ec0311e867b9a3f1cf99243","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    # convert to APIVersion object"},{"line_number":54,"context_line":"    version \u003d api_versions.get_api_version(version)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    if version.ver_major \u003d\u003d \u00271\u0027:"},{"line_number":57,"context_line":"        # Monkey patch for v1 cinderclient"},{"line_number":58,"context_line":"        volumes.Volume.NAME_ATTR \u003d \u0027display_name\u0027"},{"line_number":59,"context_line":"        volume_snapshots.Snapshot.NAME_ATTR \u003d \u0027display_name\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_9a1b69c8","line":56,"updated":"2020-11-12 15:09:04.000000000","message":"Not related to this patch, but cinder dropped the v1 API several releases ago now. I know we want to continue to support older deployments for as long as we can in osc, but it might be worth thinking about cleaning up some of this as cinder is now trying to drop v2 and get to the point where only v3 is supported.","commit_id":"4c0bfb03fc688575fa93667bb59d399fd1c6b41d"}],"openstackclient/volume/v2/volume.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6b8f6e17208c93d0e37968a45c2ada2975512815","unresolved":false,"context_lines":[{"line_number":611,"context_line":"                    msg \u003d (_(\"Volume is in %s state, it must be available \""},{"line_number":612,"context_line":"                           \"before size can be extended\") % volume.status)"},{"line_number":613,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":614,"context_line":"                if parsed_args.size \u003c\u003d volume.size:"},{"line_number":615,"context_line":"                    msg \u003d (_(\"New size must be greater than %s GB\")"},{"line_number":616,"context_line":"                           % volume.size)"},{"line_number":617,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":618,"context_line":"                volume_client.volumes.extend(volume.id, parsed_args.size)"},{"line_number":619,"context_line":"            except Exception as e:"},{"line_number":620,"context_line":"                LOG.error(_(\"Failed to set volume size: %s\"), e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_c0ca6618","line":617,"range":{"start_line":614,"start_character":16,"end_line":617,"end_character":54},"updated":"2020-11-05 16:01:19.000000000","message":"While looking at this, it would seem good to move this check in front of the volume.status check, otherwise the previous msg could be misleading if the user is actually trying to perform a reduction in size instead of an extension.","commit_id":"322f6aa653e004b464075cd7a7a84e0749fd684c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"58f61ef9c867de9870a444b9bad93f351db46cbb","unresolved":false,"context_lines":[{"line_number":610,"context_line":"                           % volume.size)"},{"line_number":611,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":612,"context_line":"                if volume.status !\u003d \u0027available\u0027 and \\"},{"line_number":613,"context_line":"                    not volume_client.api_version.matches(min_version\u003d\u00273.42\u0027):"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"                    msg \u003d (_(\"Volume is in %s state, it must be available \""},{"line_number":616,"context_line":"                           \"before size can be extended\") % volume.status)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_fa810a4c","line":613,"updated":"2020-11-05 19:01:55.000000000","message":"pep8: E125 continuation line with same indent as next logical line","commit_id":"5e1975d908c7f27740dbfed2a37fc3e411a78234"}]}