)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b77aa6046048f74b3663c84bf8fdb0704638eecd","unresolved":true,"context_lines":[{"line_number":11,"context_line":" + output to stdout if file not specified"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia01ff9b21a2dac5d0ccf2bd58a8640e88c5cbb36"},{"line_number":14,"context_line":"Story: 2007672"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dcc368f2_222053df","line":14,"updated":"2020-11-25 06:10:18.000000000","message":"You should add a reference to the matching task too, so that it will get updated when the patch is merged.","commit_id":"e65b708cb70d8699c34b4e68695978074ccedd6a"},{"author":{"_account_id":30447,"name":"Simon Merrick","email":"simonmerrick@catalyst.net.nz","username":"iokiwi"},"change_message_id":"392fd70b1ce3b40fee291e8417c47fb76a15803b","unresolved":false,"context_lines":[{"line_number":11,"context_line":" + output to stdout if file not specified"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia01ff9b21a2dac5d0ccf2bd58a8640e88c5cbb36"},{"line_number":14,"context_line":"Story: 2007672"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"65d86766_be3735d0","line":14,"in_reply_to":"dcc368f2_222053df","updated":"2020-11-25 08:28:38.000000000","message":"Done","commit_id":"e65b708cb70d8699c34b4e68695978074ccedd6a"}],"openstackclient/image/v1/image.py":[{"author":{"_account_id":30447,"name":"Simon Merrick","email":"simonmerrick@catalyst.net.nz","username":"iokiwi"},"change_message_id":"909f9db994465c03e5c32b0abfc009cb0d6b75c3","unresolved":false,"context_lines":[{"line_number":482,"context_line":"        if output_file is None:"},{"line_number":483,"context_line":"            output_file \u003d getattr(sys.stdout, \"buffer\", sys.stdout)"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        image_client.download_image(image.id, stream\u003dTrue, output\u003doutput_file)"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"class SetImage(command.Command):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fffc6b78_ccb0438f","line":485,"range":{"start_line":485,"start_character":8,"end_line":485,"end_character":78},"updated":"2020-11-19 07:25:13.000000000","message":"I think this breaks computation of md5 checksum.\nIs this a problem?\n\nhttps://docs.openstack.org/openstacksdk/latest/user/guides/image.html#download-image-stream-true\n\nHandling the image data and checksum manually inside SaveImage.take_action() is trivial, however is a PITA for unittesting","commit_id":"597ea5c82ed0c68b2ea7a995e59a5aff0a9439cc"},{"author":{"_account_id":30447,"name":"Simon Merrick","email":"simonmerrick@catalyst.net.nz","username":"iokiwi"},"change_message_id":"c276b6cb6787fd0f21c2c859b8a8ffa8a5e00e4f","unresolved":true,"context_lines":[{"line_number":482,"context_line":"        if output_file is None:"},{"line_number":483,"context_line":"            output_file \u003d getattr(sys.stdout, \"buffer\", sys.stdout)"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        image_client.download_image(image.id, stream\u003dTrue, output\u003doutput_file)"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"class SetImage(command.Command):"}],"source_content_type":"text/x-python","patch_set":1,"id":"b5aef8d8_e6e8e8cf","line":485,"range":{"start_line":485,"start_character":8,"end_line":485,"end_character":78},"in_reply_to":"f5cc440e_56732a84","updated":"2020-11-23 20:26:02.000000000","message":"I was having trouble adequately mocking file i/o in the test. I\u0027m sure its achievable - but I didn\u0027t have much luck after a few hours, gave up and just let the SDK handle the i/o without computing the checksum.","commit_id":"597ea5c82ed0c68b2ea7a995e59a5aff0a9439cc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"806c5128f664c9005ae2632b8407d8c0bd2b3a36","unresolved":true,"context_lines":[{"line_number":482,"context_line":"        if output_file is None:"},{"line_number":483,"context_line":"            output_file \u003d getattr(sys.stdout, \"buffer\", sys.stdout)"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        image_client.download_image(image.id, stream\u003dTrue, output\u003doutput_file)"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"class SetImage(command.Command):"}],"source_content_type":"text/x-python","patch_set":1,"id":"f5cc440e_56732a84","line":485,"range":{"start_line":485,"start_character":8,"end_line":485,"end_character":78},"in_reply_to":"fffc6b78_ccb0438f","updated":"2020-11-23 15:12:28.000000000","message":"I\u0027d really like to see that done as a follow-up, at least. Where does the difficulty in unit testing come from? Is this something we could functionally test?","commit_id":"597ea5c82ed0c68b2ea7a995e59a5aff0a9439cc"}],"releasenotes/notes/fix-openstak-image-save-sdk-port-eb160e8ffc92e514.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b77aa6046048f74b3663c84bf8fdb0704638eecd","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - Stream image download to avoid buffering data in memory which rapidly"},{"line_number":4,"context_line":"    exhausts memory resulting in OOM kill or system crash for all but the"},{"line_number":5,"context_line":"    smallest of images."},{"line_number":6,"context_line":"  - Restores default behavior of sending data to stdout."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4359d567_09154340","line":6,"updated":"2020-11-25 06:10:18.000000000","message":"The second note should also mention the \"image download\" command, as it may appear not next to the previous one in the final release notes.\n\nAlso both notes should mention the story as a link.","commit_id":"e65b708cb70d8699c34b4e68695978074ccedd6a"},{"author":{"_account_id":30447,"name":"Simon Merrick","email":"simonmerrick@catalyst.net.nz","username":"iokiwi"},"change_message_id":"392fd70b1ce3b40fee291e8417c47fb76a15803b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Stream image download to avoid buffering data in memory which rapidly"},{"line_number":4,"context_line":"    exhausts memory resulting in OOM kill or system crash for all but the"},{"line_number":5,"context_line":"    smallest of images."},{"line_number":6,"context_line":"  - Restores default behavior of sending data to stdout."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c7405cf4_1bdeac12","line":6,"in_reply_to":"4359d567_09154340","updated":"2020-11-25 08:28:38.000000000","message":"Done","commit_id":"e65b708cb70d8699c34b4e68695978074ccedd6a"}]}