)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c08619a45b359ef9146ced9e3bdb2f3e5b7ceb0","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Next patch in the series to switch nova bits towards SDK. This time it\u0027s"},{"line_number":10,"context_line":"hypervisors turn."},{"line_number":11,"context_line":"The code looks ugly and must be improved in a followup, here only the"},{"line_number":12,"context_line":"switch maintaining complatibility was done."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia94f98650cf309492ce8aa1da9e9c47a692fafe7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ab229199_71835798","line":12,"range":{"start_line":12,"start_character":19,"end_line":12,"end_character":33},"updated":"2021-10-06 11:29:59.000000000","message":"compatibility","commit_id":"a3899d98e61294fdc8e11dc575e34689e7e742b0"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"aca533b429c31912fe152b20de643f893ca44cdf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Next patch in the series to switch nova bits towards SDK. This time it\u0027s"},{"line_number":10,"context_line":"hypervisors turn."},{"line_number":11,"context_line":"The code looks ugly and must be improved in a followup, here only the"},{"line_number":12,"context_line":"switch maintaining complatibility was done."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia94f98650cf309492ce8aa1da9e9c47a692fafe7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"6ef7b4f8_5a16127e","line":12,"range":{"start_line":12,"start_character":19,"end_line":12,"end_character":33},"in_reply_to":"ab229199_71835798","updated":"2021-10-08 09:57:05.000000000","message":"Done","commit_id":"a3899d98e61294fdc8e11dc575e34689e7e742b0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"87888e1ac14682573e389fcd751652254f595835","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"22157eb5_0a6017d8","updated":"2021-10-21 10:43:54.000000000","message":"When I run \u0027hypervisor show\u0027 commands with this, I see the following:\n\n  $ openstack --os-compute-api-version 2.1 hypervisor show 1 -f yaml\n  The option [disk_available_least] has been deprecated. Please avoid using it.\n  The option [local_gb_used] has been deprecated. Please avoid using it.\n  The option [local_gb] has been deprecated. Please avoid using it.\n  The option [free_disk_gb] has been deprecated. Please avoid using it.\n  The option [memory_mb_used] has been deprecated. Please avoid using it.\n  The option [memory_mb] has been deprecated. Please avoid using it.\n  The option [free_ram_mb] has been deprecated. Please avoid using it.\n  The option [running_vms] has been deprecated. Please avoid using it.\n  The option [vcpus_used] has been deprecated. Please avoid using it.\n  The option [vcpus] has been deprecated. Please avoid using it.\n  aggregates: []\n  ...\n\nCan we disable those warnings from SDK? Other than this, it looks like it\u0027s generating the exact same output for various microversions and the tests are happy, so I\u0027m not going to block on this. Nice work!","commit_id":"9e53d65d0c03444d7083f88f109361cffafcf0bf"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"14aeeef0900034a598502b7be10eb68b6848828d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"118ddfcc_cefd22cf","updated":"2021-10-22 13:34:20.000000000","message":"ehm? No hypervisors are available in devstack?","commit_id":"9e53d65d0c03444d7083f88f109361cffafcf0bf"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"8e5919736ce4b783bdb39f2c6f9bc236beacb74e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d954d3f3_2df588b2","updated":"2021-10-22 13:34:50.000000000","message":"recheck","commit_id":"9e53d65d0c03444d7083f88f109361cffafcf0bf"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"1091249d88e16c026a08fa3acb0745d2b265014d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b18bab1f_a8a47c86","in_reply_to":"22157eb5_0a6017d8","updated":"2021-10-21 10:58:12.000000000","message":"hmm, we were recently adding marking attributes as deprecated in SDK exactly to give user hint that those should not be used. Now we see the side effect of it. Need to think how we should address this","commit_id":"9e53d65d0c03444d7083f88f109361cffafcf0bf"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"a674b5ba2daca899001b306697347f5e255f51e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"805aeba8_7ec72cd9","updated":"2021-10-22 17:13:28.000000000","message":"recheck","commit_id":"3534c4d22b9fa37c081e0148e5008267874ba370"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"b2c0f71817f41549122800ca078741af0a6dc5fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b65cd584_29e0a8c8","updated":"2021-10-25 17:23:41.000000000","message":"recheck","commit_id":"3534c4d22b9fa37c081e0148e5008267874ba370"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"58b49b1ed11b3b0de4bd5ce089af9c36652fe892","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"beea78bd_6e4562e8","updated":"2021-10-26 09:09:20.000000000","message":"recheck\nthe issue seems still absolutely sporadic.","commit_id":"3534c4d22b9fa37c081e0148e5008267874ba370"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"138fd9dfdbfbc70f62a95b1890823b347f4ae63e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f6dafb90_35b13760","updated":"2021-10-26 15:21:03.000000000","message":"recheck last time before starting hardcore debug","commit_id":"3534c4d22b9fa37c081e0148e5008267874ba370"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"58d899072d19f90199190d25590757eefa102220","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"631c0332_898bf50a","updated":"2021-11-04 09:56:27.000000000","message":"Still lgtm, but lets see if the CI is happy yet","commit_id":"e493ba3bf65b855829e7325f648dd2c316baa5b5"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"e77e1d3294f17072d72eb8177188c7b10619936e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9415ff95_b49ae10d","updated":"2022-10-28 15:20:34.000000000","message":"Another try to merge change after it being approved and failing in gate for long time","commit_id":"c385aa69324a43c0e9d0916c2f5655dc61dcccbd"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"4ed048820d7eb60a6748c72b2b081298c665f31c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"46f4bada_3e10d099","updated":"2021-11-05 10:05:54.000000000","message":"fixed rebase that broke pep8 tests and added dependency to the test change in SDK that drops deprecation warnings (maybe this is somehow hurting OSC to get to the real command output)","commit_id":"c385aa69324a43c0e9d0916c2f5655dc61dcccbd"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"a06aace0fe5dbc54eef9a7dce246886fb6033a29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1ec43f1b_b70bf8bf","updated":"2022-06-21 14:04:44.000000000","message":"recheck","commit_id":"c385aa69324a43c0e9d0916c2f5655dc61dcccbd"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"e9b2e81bab098998065e18828f85443a48d63e6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"2369753f_fdfbc3bf","updated":"2021-12-01 10:09:42.000000000","message":"recheck","commit_id":"c385aa69324a43c0e9d0916c2f5655dc61dcccbd"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"26580eab5ccdc4509ea4c3035ddbcf1d4c5c5497","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"32717bf0_24156280","updated":"2022-10-28 14:09:50.000000000","message":"recheck","commit_id":"c385aa69324a43c0e9d0916c2f5655dc61dcccbd"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"c120303f037082c810b5b5aff6eda5cc2746b77a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7904bc3a_3e67b460","updated":"2022-06-28 15:22:34.000000000","message":"recheck","commit_id":"c385aa69324a43c0e9d0916c2f5655dc61dcccbd"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"34ef1f0e046a22455b4f1bb5bb5941c4cade9e43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"837fac6b_51112f47","updated":"2022-06-28 09:55:17.000000000","message":"recheck","commit_id":"c385aa69324a43c0e9d0916c2f5655dc61dcccbd"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"dfad7b19111e084db838031f5d75f11828d72a1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"45183a3b_59265a2a","updated":"2022-06-27 14:41:24.000000000","message":"recheck\nanother try","commit_id":"c385aa69324a43c0e9d0916c2f5655dc61dcccbd"}],"openstackclient/compute/v2/hypervisor.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c08619a45b359ef9146ced9e3bdb2f3e5b7ceb0","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        if parsed_args.long:"},{"line_number":96,"context_line":"            column_headers +\u003d ("},{"line_number":97,"context_line":"                \"vCPUs Used\", \"vCPUs\", \"Memory MB Used\", \"Memory MB\")"},{"line_number":98,"context_line":"            columns +\u003d (\u0027vcpus_used\u0027, \u0027vcpus\u0027, \u0027memory_used\u0027, \u0027memory_size\u0027)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        query \u003d {}"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bd154b3d_71762db5","line":98,"updated":"2021-10-06 11:29:59.000000000","message":"Is there any reason to move these? It seems unrelated and makes the change larger than necessary. Could this be done separately or not at all?\n\nLater: Ah, I see you\u0027re introducing separate columns and column_headers variables. I still think this would be better left where it was if possible, to minimise the diff","commit_id":"a3899d98e61294fdc8e11dc575e34689e7e742b0"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"aca533b429c31912fe152b20de643f893ca44cdf","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        if parsed_args.long:"},{"line_number":96,"context_line":"            column_headers +\u003d ("},{"line_number":97,"context_line":"                \"vCPUs Used\", \"vCPUs\", \"Memory MB Used\", \"Memory MB\")"},{"line_number":98,"context_line":"            columns +\u003d (\u0027vcpus_used\u0027, \u0027vcpus\u0027, \u0027memory_used\u0027, \u0027memory_size\u0027)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        query \u003d {}"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"35e9a40f_213418da","line":98,"in_reply_to":"bd154b3d_71762db5","updated":"2021-10-08 09:57:05.000000000","message":"Yeah, it is now clash of rebase","commit_id":"a3899d98e61294fdc8e11dc575e34689e7e742b0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c08619a45b359ef9146ced9e3bdb2f3e5b7ceb0","unresolved":true,"context_lines":[{"line_number":131,"context_line":"        return (column_headers,"},{"line_number":132,"context_line":"                (utils.get_item_properties("},{"line_number":133,"context_line":"                    s, columns,"},{"line_number":134,"context_line":"                ) for s in data))"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"class ShowHypervisor(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":6,"id":"6a9933bd_dcbc2477","line":134,"updated":"2021-10-06 11:29:59.000000000","message":"Could you undo the changes to this formatting? It\u0027s unrelated and tbh, what was there previously was better IMO","commit_id":"a3899d98e61294fdc8e11dc575e34689e7e742b0"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"aca533b429c31912fe152b20de643f893ca44cdf","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        return (column_headers,"},{"line_number":132,"context_line":"                (utils.get_item_properties("},{"line_number":133,"context_line":"                    s, columns,"},{"line_number":134,"context_line":"                ) for s in data))"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"class ShowHypervisor(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":6,"id":"d770b225_42cfcb14","line":134,"in_reply_to":"6a9933bd_dcbc2477","updated":"2021-10-08 09:57:05.000000000","message":"Done","commit_id":"a3899d98e61294fdc8e11dc575e34689e7e742b0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c08619a45b359ef9146ced9e3bdb2f3e5b7ceb0","unresolved":true,"context_lines":[{"line_number":155,"context_line":"                # we expect that hypervisor should be found with it, but nova"},{"line_number":156,"context_line":"                # will not satisfy us unless we also pin the microversion."},{"line_number":157,"context_line":"                # So try to check whether microversion was not set and"},{"line_number":158,"context_line":"                # something like int was given."},{"line_number":159,"context_line":"                int(parsed_args.hypervisor)"},{"line_number":160,"context_line":"                compute_client.default_microversion \u003d \u00272.52\u0027"},{"line_number":161,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":6,"id":"6e150662_393cf771","line":158,"updated":"2021-10-06 11:29:59.000000000","message":"I don\u0027t fully understand this comment. I _think_ what you\u0027re saying is that if the user requested an integer ID, then we should fall back to using an older microversion. That makes sense, though tbh this was already an issue with the existing code and I\u0027m not sure we should fix it in this code. Perhaps you could split this out into a separate precursor change? Also, you can do:\n\n  if (\n      not compute_client.default_microversion and\n      parsed_args.hypervisor.isdigit()\n  ):\n\nYou might also want to insert a friendly warning if we\u0027re using microversion \u003e\u003d 2.53 and an integer hypervisor ID. I don\u0027t know what API you\u0027d use to check this, tbh","commit_id":"a3899d98e61294fdc8e11dc575e34689e7e742b0"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"aca533b429c31912fe152b20de643f893ca44cdf","unresolved":true,"context_lines":[{"line_number":155,"context_line":"                # we expect that hypervisor should be found with it, but nova"},{"line_number":156,"context_line":"                # will not satisfy us unless we also pin the microversion."},{"line_number":157,"context_line":"                # So try to check whether microversion was not set and"},{"line_number":158,"context_line":"                # something like int was given."},{"line_number":159,"context_line":"                int(parsed_args.hypervisor)"},{"line_number":160,"context_line":"                compute_client.default_microversion \u003d \u00272.52\u0027"},{"line_number":161,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":6,"id":"6032e807_d8128e7c","line":158,"in_reply_to":"6e150662_393cf771","updated":"2021-10-08 09:57:05.000000000","message":"I am not sure it is worse of effort now to do this separately. It was not really an issue before, cause we defaulted on min microversion. Now we rely on highest and this might lead to situations, that users remember hypervisor id (1,2, etc) and try to do `show` now and this will fail (I personally faced this during testing comparing behavior before and after patch in different consoles).\nI ack what you say, but I do not really think it is helpful to separate this out.","commit_id":"a3899d98e61294fdc8e11dc575e34689e7e742b0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c08619a45b359ef9146ced9e3bdb2f3e5b7ceb0","unresolved":true,"context_lines":[{"line_number":215,"context_line":"        del hypervisor[\"service\"]"},{"line_number":216,"context_line":"        del hypervisor[\"location\"]"},{"line_number":217,"context_line":"        del hypervisor[\"name\"]"},{"line_number":218,"context_line":"        del hypervisor[\"servers\"]"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        if isinstance(hypervisor[\u0027cpu_info\u0027], str):"},{"line_number":221,"context_line":"            # microversion 2.28 transformed this to a JSON blob rather than a"}],"source_content_type":"text/x-python","patch_set":6,"id":"cb960312_43b987bc","line":218,"updated":"2021-10-06 11:29:59.000000000","message":"I assume we can\u0027t use \u0027utils.get_osc_show_columns_for_sdk_resource\u0027 for this?","commit_id":"a3899d98e61294fdc8e11dc575e34689e7e742b0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"87888e1ac14682573e389fcd751652254f595835","unresolved":true,"context_lines":[{"line_number":96,"context_line":"            if not sdk_utils.supports_microversion(compute_client, \u00272.33\u0027):"},{"line_number":97,"context_line":"                msg \u003d _("},{"line_number":98,"context_line":"                    \u0027--os-compute-api-version 2.33 or greater is required to \u0027"},{"line_number":99,"context_line":"                    \u0027support the --marker option\u0027"},{"line_number":100,"context_line":"                )"},{"line_number":101,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":102,"context_line":"            query[\u0027marker\u0027] \u003d parsed_args.marker"}],"source_content_type":"text/x-python","patch_set":7,"id":"25583183_e3823d7d","line":99,"updated":"2021-10-21 10:43:54.000000000","message":"Is this message a bit of a lie now? I need to double check but I think \u0027supports_microversion\u0027 defaults to checking the supported server range unless the client suggested something. We probably want a check like:\n\n  if not client requested suitable microversion:\n      warn that we need to use 2.33 or greater\n  else if server does not support microversion\n      warn that server is not new enough\n\nThis is a broad enough issue though and can probably be resolved later. Just bringing it to your attention","commit_id":"9e53d65d0c03444d7083f88f109361cffafcf0bf"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"1091249d88e16c026a08fa3acb0745d2b265014d","unresolved":true,"context_lines":[{"line_number":96,"context_line":"            if not sdk_utils.supports_microversion(compute_client, \u00272.33\u0027):"},{"line_number":97,"context_line":"                msg \u003d _("},{"line_number":98,"context_line":"                    \u0027--os-compute-api-version 2.33 or greater is required to \u0027"},{"line_number":99,"context_line":"                    \u0027support the --marker option\u0027"},{"line_number":100,"context_line":"                )"},{"line_number":101,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":102,"context_line":"            query[\u0027marker\u0027] \u003d parsed_args.marker"}],"source_content_type":"text/x-python","patch_set":7,"id":"aca51c32_c924771d","line":99,"in_reply_to":"25583183_e3823d7d","updated":"2021-10-21 10:58:12.000000000","message":"perhaps you are right. In this case it is anyway a merge conflict resolution issue. But it is totally right that we need to address --marker --limit and co centrally.\nHowever overall sdk_utils.supports_microversion means: \"if both client and server understand X.Y\"","commit_id":"9e53d65d0c03444d7083f88f109361cffafcf0bf"}],"openstackclient/compute/v2/hypervisor_stats.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c08619a45b359ef9146ced9e3bdb2f3e5b7ceb0","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        # The command is deprecated since it is being dropped in Nova."},{"line_number":44,"context_line":"        self.log.warning("},{"line_number":45,"context_line":"            _(\"This command is deprecated.\")"},{"line_number":46,"context_line":"        )"},{"line_number":47,"context_line":"        compute_client \u003d self.app.client_manager.sdk_connection.compute"},{"line_number":48,"context_line":"        response \u003d compute_client.get("},{"line_number":49,"context_line":"            \u0027/os-hypervisors/statistics\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"b70d75ca_38020b11","line":46,"updated":"2021-10-06 11:29:59.000000000","message":"Do we have other examples of doing this? I thought we normally put the deprecation notice in the help text?","commit_id":"a3899d98e61294fdc8e11dc575e34689e7e742b0"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"aca533b429c31912fe152b20de643f893ca44cdf","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        # The command is deprecated since it is being dropped in Nova."},{"line_number":44,"context_line":"        self.log.warning("},{"line_number":45,"context_line":"            _(\"This command is deprecated.\")"},{"line_number":46,"context_line":"        )"},{"line_number":47,"context_line":"        compute_client \u003d self.app.client_manager.sdk_connection.compute"},{"line_number":48,"context_line":"        response \u003d compute_client.get("},{"line_number":49,"context_line":"            \u0027/os-hypervisors/statistics\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"d11c73d4_9ffbbe94","line":46,"in_reply_to":"b70d75ca_38020b11","updated":"2021-10-08 09:57:05.000000000","message":"https://opendev.org/openstack/osc-lib/src/branch/master/osc_lib/command/command.py#L48 - this is exactly how the help text warning is emitted. The issue is that we currently only support deprecating parameters, but not the whole commands","commit_id":"a3899d98e61294fdc8e11dc575e34689e7e742b0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c08619a45b359ef9146ced9e3bdb2f3e5b7ceb0","unresolved":true,"context_lines":[{"line_number":45,"context_line":"            _(\"This command is deprecated.\")"},{"line_number":46,"context_line":"        )"},{"line_number":47,"context_line":"        compute_client \u003d self.app.client_manager.sdk_connection.compute"},{"line_number":48,"context_line":"        response \u003d compute_client.get("},{"line_number":49,"context_line":"            \u0027/os-hypervisors/statistics\u0027,"},{"line_number":50,"context_line":"            microversion\u003d\u00272.1\u0027)"},{"line_number":51,"context_line":"        hypervisor_stats \u003d response.json().get(\u0027hypervisor_statistics\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"46267542_a69fa128","line":48,"updated":"2021-10-06 11:29:59.000000000","message":"Could you put a NOTE in here explaining that we\u0027re making manual requests because the SDK doesn\u0027t and won\u0027t support this?","commit_id":"a3899d98e61294fdc8e11dc575e34689e7e742b0"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"aca533b429c31912fe152b20de643f893ca44cdf","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            _(\"This command is deprecated.\")"},{"line_number":46,"context_line":"        )"},{"line_number":47,"context_line":"        compute_client \u003d self.app.client_manager.sdk_connection.compute"},{"line_number":48,"context_line":"        response \u003d compute_client.get("},{"line_number":49,"context_line":"            \u0027/os-hypervisors/statistics\u0027,"},{"line_number":50,"context_line":"            microversion\u003d\u00272.1\u0027)"},{"line_number":51,"context_line":"        hypervisor_stats \u003d response.json().get(\u0027hypervisor_statistics\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"23c8a14f_4678f838","line":48,"in_reply_to":"46267542_a69fa128","updated":"2021-10-08 09:57:05.000000000","message":"Done","commit_id":"a3899d98e61294fdc8e11dc575e34689e7e742b0"}],"openstackclient/tests/unit/compute/v2/test_hypervisor.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c08619a45b359ef9146ced9e3bdb2f3e5b7ceb0","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        # Get a shortcut to the compute client aggregates mock"},{"line_number":39,"context_line":"        self.aggregates_mock \u003d self.app.client_manager.compute.aggregates"},{"line_number":40,"context_line":"        self.aggregates_mock.reset_mock()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class TestHypervisorList(TestHypervisor):"}],"source_content_type":"text/x-python","patch_set":6,"id":"22744b03_b84ceca7","side":"PARENT","line":40,"updated":"2021-10-06 11:29:59.000000000","message":"Can we delete these attributes now, assuming they\u0027re set somewhere in the fakes module?","commit_id":"ff372ffdfbfe036993f84be20cd18262599b37de"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"aca533b429c31912fe152b20de643f893ca44cdf","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        # Get a shortcut to the compute client aggregates mock"},{"line_number":39,"context_line":"        self.aggregates_mock \u003d self.app.client_manager.compute.aggregates"},{"line_number":40,"context_line":"        self.aggregates_mock.reset_mock()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class TestHypervisorList(TestHypervisor):"}],"source_content_type":"text/x-python","patch_set":6,"id":"22206ab8_bc69fbed","side":"PARENT","line":40,"in_reply_to":"22744b03_b84ceca7","updated":"2021-10-08 09:57:05.000000000","message":"Yupp. I wanted anyway to do bigger cleanup later, cause we currently have quite a mess with mocks. Additionally there is still big amount of code that can be de-duplicated in the mock area.","commit_id":"ff372ffdfbfe036993f84be20cd18262599b37de"}]}