)]}'
{"openstackclient/compute/v2/server.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9e0b3efd5dc10f06cf8851cf9e62b158bcb7959e","unresolved":true,"context_lines":[{"line_number":1368,"context_line":"        parser.add_argument("},{"line_number":1369,"context_line":"            \u0027--availability-zone\u0027,"},{"line_number":1370,"context_line":"            metavar\u003d\u0027\u003cavailability-zone\u003e\u0027,"},{"line_number":1371,"context_line":"            help\u003d_(\u0027Only return instances that match the availability zone\u0027),"},{"line_number":1372,"context_line":"        )"},{"line_number":1373,"context_line":"        parser.add_argument("},{"line_number":1374,"context_line":"            \u0027--reservation-id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ccfd11c1_819b7bf5","line":1371,"updated":"2020-12-01 10:54:10.000000000","message":"As noted below, this was present but admin-only before 2.83. We should say as much here.","commit_id":"cf7a5077762f304fcc92f6df1ea2d84ff50aee5d"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7905cb52d8cb5d8c55e0c687f8451b1bcbc1f106","unresolved":false,"context_lines":[{"line_number":1368,"context_line":"        parser.add_argument("},{"line_number":1369,"context_line":"            \u0027--availability-zone\u0027,"},{"line_number":1370,"context_line":"            metavar\u003d\u0027\u003cavailability-zone\u003e\u0027,"},{"line_number":1371,"context_line":"            help\u003d_(\u0027Only return instances that match the availability zone\u0027),"},{"line_number":1372,"context_line":"        )"},{"line_number":1373,"context_line":"        parser.add_argument("},{"line_number":1374,"context_line":"            \u0027--reservation-id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ce3a276f_b7d50c57","line":1371,"in_reply_to":"ccfd11c1_819b7bf5","updated":"2020-12-01 11:45:09.000000000","message":"Done","commit_id":"cf7a5077762f304fcc92f6df1ea2d84ff50aee5d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9e0b3efd5dc10f06cf8851cf9e62b158bcb7959e","unresolved":true,"context_lines":[{"line_number":1579,"context_line":"                                               ignore_missing\u003dFalse).id"},{"line_number":1580,"context_line":""},{"line_number":1581,"context_line":"        search_opts \u003d {"},{"line_number":1582,"context_line":"            \u0027availability_zone\u0027: parsed_args.availability_zone,"},{"line_number":1583,"context_line":"            \u0027reservation_id\u0027: parsed_args.reservation_id,"},{"line_number":1584,"context_line":"            \u0027ip\u0027: parsed_args.ip,"},{"line_number":1585,"context_line":"            \u0027ip6\u0027: parsed_args.ip6,"}],"source_content_type":"text/x-python","patch_set":1,"id":"2d684982_ff7ca533","line":1582,"updated":"2020-12-01 10:54:10.000000000","message":"IIRC, this was present but admin-only before 2.83. What happens if this is unset before that on a non-admin user? In other words, should we be instead doing:\n\n  if parsed_args.availability_zone:\n      search_opts[\u0027availability_zone\u0027] \u003d parsed_args.availability_zone","commit_id":"cf7a5077762f304fcc92f6df1ea2d84ff50aee5d"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4215cbfa44633c39ff7b103a43885b0826d90aa3","unresolved":true,"context_lines":[{"line_number":1579,"context_line":"                                               ignore_missing\u003dFalse).id"},{"line_number":1580,"context_line":""},{"line_number":1581,"context_line":"        search_opts \u003d {"},{"line_number":1582,"context_line":"            \u0027availability_zone\u0027: parsed_args.availability_zone,"},{"line_number":1583,"context_line":"            \u0027reservation_id\u0027: parsed_args.reservation_id,"},{"line_number":1584,"context_line":"            \u0027ip\u0027: parsed_args.ip,"},{"line_number":1585,"context_line":"            \u0027ip6\u0027: parsed_args.ip6,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6f23dde0_709e1448","line":1582,"in_reply_to":"2d684982_ff7ca533","updated":"2020-12-01 11:42:03.000000000","message":"As said in nova doc https://docs.openstack.org/api-ref/compute/?expanded\u003dlist-servers-detail:\n`If non-admin users specify this parameter on a microversion less than 2.83, it will be ignored.`\n\nSo I\u0027d say it\u0027s up to user to take care about arg?","commit_id":"cf7a5077762f304fcc92f6df1ea2d84ff50aee5d"}]}