)]}'
{"id":"openstack%2Fpython-openstackclient~770131","triplet_id":"openstack%2Fpython-openstackclient~master~I69449112027736152c9fb62f5fe427efd6a25107","project":"openstack/python-openstackclient","branch":"master","topic":"bp/address-groups-in-sg-rules","hashtags":[],"change_id":"I69449112027736152c9fb62f5fe427efd6a25107","subject":"network: Address nits for I3c313fc9329837dde67815901528a34dca98ebcc","status":"MERGED","created":"2021-01-11 14:29:39.000000000","updated":"2021-01-12 13:56:08.000000000","submitted":"2021-01-12 13:54:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"770131-bp/address-groups-in-sg-rules","meta_rev_id":"df72818fd863296859c7133ec5be7beb60973774","_number":770131,"virtual_id_number":770131,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-01-12 13:54:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":2,"date":"2021-01-12 10:08:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":1,"date":"2021-01-12 10:08:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"}],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-11 16:42:32.000000000","updated_by":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"reviewer":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"state":"REVIEWER"},{"updated":"2021-01-11 17:05:17.000000000","updated_by":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"reviewer":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"state":"REVIEWER"},{"updated":"2021-01-11 18:20:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b71949591125f11c3dd1c865b14643ddf6484746","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-11 14:29:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8e74d777cfb7cc14e93ef98c0e25bd9d3e01e6e3","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2021-01-11 17:05:17.000000000","message":"Patch Set 1: Code-Review+1\n\nThanks a lot for addressing those comments","accounts_in_message":[],"_revision_number":1},{"id":"343985d0c9efb2995aa0256a65da2a4a84b7cb36","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-11 18:20:02.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/fb7d02dece3f489bab6a5be03eb4cf98 : SUCCESS in 5m 23s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/0760c4c9baa4403ba9e04b774ed2ab02 : FAILURE in 4m 54s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e96a3d24af3c46dc807b645fa5c6cb2e : FAILURE in 4m 23s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f7b0604a9822401f9775fac1ef2618c4 : FAILURE in 5m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bd07cdd990474e2a89ff7615fe142153 : SUCCESS in 4m 28s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c84d2a79d07e434bbd903aa1d1d0de54 : FAILURE in 4m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a7fc4ecab8de442ca3768be624ca913b : FAILURE in 4m 04s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/3799ebfb18b747a2a92a169a32235882 : FAILURE in 4m 06s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/77f39989c14e4561ab46628564ffb9aa : SUCCESS in 6m 54s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/1d3c367370e24827945f4e1b485477b4 : SUCCESS in 7m 33s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/882b65f044384b17a7bbd23543a53685 : SUCCESS in 53m 22s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/ba3689116de74fb4bc2e2652c27679f5 : SUCCESS in 57m 31s","accounts_in_message":[],"_revision_number":1},{"id":"f06b99cdaec32515c3cd349341962ff14a0811b2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-12 10:08:14.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"bf7136a1264082cce8c493ee0db4195d61972dde","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-12 10:08:55.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nFixed the two failing tests. ralonsoh was happy with this and it\u0027s a trivial change so merging in","accounts_in_message":[],"_revision_number":2},{"id":"9ea703f93ec69cc62cde8990d3c1733302ea993f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-12 12:20:30.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/5cb4aadb8aa8455fbabe34d29ed76130 : SUCCESS in 7m 36s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/1940b4ceacd24122a7c3c537ff712a64 : SUCCESS in 4m 24s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e0e3cb3f22ec4e96ac356f64bb388dce : SUCCESS in 4m 33s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/939a5c6d5083491fa421a239b75a0681 : SUCCESS in 4m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8b5dcfce6e0743d38d9eab3a7200b014 : SUCCESS in 3m 38s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4530fc8653cf4b729f71ca25cc2dc02c : SUCCESS in 5m 13s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1d86f733a07b4d37a18c643bdb5c7e94 : SUCCESS in 4m 08s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ce5a58a3604a43b086d88e5322578de8 : SUCCESS in 4m 30s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/975234f8fe9d4a4bb079d2a8c1a79e2d : SUCCESS in 5m 51s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/02a5e4e7136d44fe86b0ae5ed6f59d64 : SUCCESS in 7m 14s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/efbb20b1e87445eb9addfee893b7ac1d : SUCCESS in 1h 11m 11s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/20564d94d1314f528a6c1739adb99472 : SUCCESS in 1h 05m 44s","accounts_in_message":[],"_revision_number":2},{"id":"bac9583fd6665fd94061c53a1119c648b4debf42","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-12 12:20:45.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"577cb6c4609752a7c36ad55f09545dcc15c131c3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-12 13:54:10.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/a25633b15893489eae58c5f370b82d6e : SUCCESS in 4m 50s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5c478c0c5a9e4015bf48caa439638abd : SUCCESS in 4m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/62a26fc53ed645cf91bc1f7b8d310c2e : SUCCESS in 4m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d581acba188743958d9b7896f9d4ba1d : SUCCESS in 3m 48s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/44132abe71d54166a5e5f026e61a5655 : SUCCESS in 4m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f139c08ace6a4f9481fb5dd6dc86d99b : SUCCESS in 6m 56s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/9d0b6e9c5da8444c8e5b7fdb32c9f520 : SUCCESS in 10m 36s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/121d4a6d33c44f09a49afdd249b48693 : SUCCESS in 1h 04m 53s","accounts_in_message":[],"_revision_number":2},{"id":"d70b20cb94c95add41d94eacefc5c3ca3a21056f","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-12 13:54:11.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"df72818fd863296859c7133ec5be7beb60973774","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-12 13:56:08.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cf0a36784296494c9cd9fe2112e37c1e : SUCCESS in 1m 11s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/5eff6ef7456a4e439d9b2dcbd2511576 : SUCCESS in 1m 07s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"dd89efd5acbabcd4de0f071a2f7fbb93d067a950","revisions":{"f3bfeaae4942d25bc6599321d1de7b817d6fd58b":{"kind":"REWORK","_number":1,"created":"2021-01-11 14:29:39.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/31/770131/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/31/770131/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/31/770131/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/31/770131/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/31/770131/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/31/770131/1"}}},"commit":{"parents":[{"commit":"f57e10b903fa71d02a6e104717824d004178bbf5","subject":"Support Neutron Address Group CRUD","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f57e10b903fa71d02a6e104717824d004178bbf5"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2021-01-11 14:28:54.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2021-01-11 14:28:54.000000000","tz":0},"subject":"network: Address nits for I3c313fc9329837dde67815901528a34dca98ebcc","message":"network: Address nits for I3c313fc9329837dde67815901528a34dca98ebcc\n\nAddress comments left in the review for $subject.\n\nChange-Id: I69449112027736152c9fb62f5fe427efd6a25107\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f3bfeaae4942d25bc6599321d1de7b817d6fd58b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f3bfeaae4942d25bc6599321d1de7b817d6fd58b"}]},"branch":"refs/heads/master"},"dd89efd5acbabcd4de0f071a2f7fbb93d067a950":{"kind":"REWORK","_number":2,"created":"2021-01-12 10:08:14.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/31/770131/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/31/770131/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/31/770131/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/31/770131/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/31/770131/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/31/770131/2"}}},"commit":{"parents":[{"commit":"f57e10b903fa71d02a6e104717824d004178bbf5","subject":"Support Neutron Address Group CRUD","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f57e10b903fa71d02a6e104717824d004178bbf5"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2021-01-11 14:28:54.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2021-01-12 10:07:58.000000000","tz":0},"subject":"network: Address nits for I3c313fc9329837dde67815901528a34dca98ebcc","message":"network: Address nits for I3c313fc9329837dde67815901528a34dca98ebcc\n\nAddress comments left in the review for $subject.\n\nChange-Id: I69449112027736152c9fb62f5fe427efd6a25107\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/dd89efd5acbabcd4de0f071a2f7fbb93d067a950"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/dd89efd5acbabcd4de0f071a2f7fbb93d067a950"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}