)]}'
{"id":"openstack%2Fpython-openstackclient~771691","triplet_id":"openstack%2Fpython-openstackclient~master~I670ff5109522d533ef4e62a79116e49a35c4e8fa","project":"openstack/python-openstackclient","branch":"master","topic":"osc-first","hashtags":[],"change_id":"I670ff5109522d533ef4e62a79116e49a35c4e8fa","subject":"compute: Improve \u0027server create --nic\u0027 option parsing","status":"MERGED","created":"2021-01-20 18:20:34.000000000","updated":"2021-03-04 13:25:10.000000000","submitted":"2021-03-04 13:21:31.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"771691-osc-first","meta_rev_id":"83c18cd06484e6974f4b2133cb366cbb6acb4995","_number":771691,"virtual_id_number":771691,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-03-04 13:21:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-03-03 10:59:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-03-04 11:51:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-20 23:03:00.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-03 10:59:20.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"}],"messages":[{"id":"213e2e709a7c5279a4f125595d7325b847830a55","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-20 18:20:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"525add563a8087460519867d77ea5b988ad5231b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-20 23:03:00.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/e356ae4772564ea2ad9b2dc332e541d2 : SUCCESS in 4m 49s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/f17fb1c7504f47d9825a9fda89135708 : SUCCESS in 5m 27s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e78402c0a71742219e15bc3c7b0d6eed : SUCCESS in 5m 09s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ce1275ee0f43437fa81413eb210eb60d : SUCCESS in 4m 20s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3b5f92f8bf2a4ee188011f6bf608e47d : FAILURE in 3m 49s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b09285993dcb4e80aba508b38a008524 : SUCCESS in 4m 11s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/5c21714a8d654c448a424368e3af1892 : SUCCESS in 4m 00s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/76be4298b97a4465ab98e9c43e31e245 : SUCCESS in 4m 35s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6a13128535874838b31cb24c8fe4961c : FAILURE in 4m 40s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/f92e088b85c54da4b212a5e721d18efb : SUCCESS in 7m 26s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/a0083c22fd37432d8a598192eba05446 : SUCCESS in 54m 20s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/5771970983ce4c5899ba314ba83b0aba : SUCCESS in 53m 44s\n\nWarning:\n  Comments left for invalid file openstackclient/tests/unit/compute/v2/test_server_event.py","accounts_in_message":[],"_revision_number":1},{"id":"b8becdf302b35f343ce4c68ed81dc399831205f4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-21 11:02:16.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"74922c02d3eaad260a780feefd2c55b90bfe4f46","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-21 17:56:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/82582ca580244585bb377abf112c70df : SUCCESS in 6m 09s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/afc6d551a747441ab3f9647c6fc6e590 : SUCCESS in 7m 02s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/eceaa4eecfe74413861f5a1a7d00d7e3 : SUCCESS in 5m 15s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f09c54ffeb20401d916746b3b2e4f5e0 : SUCCESS in 5m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8ac9f6d2b6714d56b93486cd5e553812 : SUCCESS in 5m 31s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c4384fa85c5945a6a499d0da06be00a0 : SUCCESS in 4m 23s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2d5630f745d249df97b0b05f971b631e : SUCCESS in 4m 57s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/af1f8b1c4d6d4d8ca560bd24a8da2e48 : SUCCESS in 5m 12s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b5651387d7264a06946c229cfd68c0aa : SUCCESS in 8m 05s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/acdc39f9c78146ae923d535b5bc1d0e7 : SUCCESS in 9m 09s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/3897ee51466d4320852b55492a32ee39 : SUCCESS in 1h 14m 38s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/916a7f7edf3947a79351b34ca5960af6 : SUCCESS in 57m 44s","accounts_in_message":[],"_revision_number":2},{"id":"a5a6a8fe6f1e67d50702a745c562e38cb7110993","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2021-03-03 10:59:20.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"3464fae52538391f01f99857c69f8e29da16e939","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2021-03-04 11:51:36.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"7f542aa72774ca8f70e9b7c4be1b089f0da4bcac","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-04 11:52:17.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"1ed8a8fd31ef066330e720cce5be6441f9974f47","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-04 13:21:28.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/bafdd4cc0f9f4c1394b09aa4245f7547 : SUCCESS in 9m 50s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/bd88dd4db49a41c4837e135476081bbd : SUCCESS in 5m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/77466c46e7bf49f7aadf363c22ad654e : SUCCESS in 4m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3e09421117b044aaa3561d9c4ebcfe19 : SUCCESS in 5m 46s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/84cde934b11648aeab73da4c0d2e90e2 : SUCCESS in 5m 10s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/afa771ec888346999439da3b30a86a86 : SUCCESS in 7m 44s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/7a5b5a309f2544498bf9f382c5af4e00 : SUCCESS in 8m 42s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/e236cf1640f641a59974a8abd861ec45 : SUCCESS in 55m 44s","accounts_in_message":[],"_revision_number":2},{"id":"8a08e7c60d2c3f0f3b219f45e8eed4802b757a3c","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-04 13:21:31.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"83c18cd06484e6974f4b2133cb366cbb6acb4995","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-04 13:25:10.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/720d093586a0486b95b56948b9ef6096 : SUCCESS in 1m 01s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/ced745ea71c341f0a7da6494d8cb29f8 : SUCCESS in 53s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c7d582379ad6b22c6dd8b7334b34a51ec59b69d4","revisions":{"f83c15d109893f152d91eb9124b2dcbeae071909":{"kind":"REWORK","_number":1,"created":"2021-01-20 18:20:34.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/91/771691/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/91/771691/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/771691/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/771691/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/771691/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/91/771691/1"}}},"commit":{"parents":[{"commit":"429d82114fbd25837c2891668aa42d29439f48d2","subject":"compute: Shuffle options for \u0027server create\u0027","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/429d82114fbd25837c2891668aa42d29439f48d2"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2020-12-10 15:06:03.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2021-01-20 18:20:25.000000000","tz":0},"subject":"compute: Improve \u0027server create --nic\u0027 option parsing","message":"compute: Improve \u0027server create --nic\u0027 option parsing\n\nSimplify the parsing of this option by making use of a custom action.\n\nChange-Id: I670ff5109522d533ef4e62a79116e49a35c4e8fa\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f83c15d109893f152d91eb9124b2dcbeae071909"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f83c15d109893f152d91eb9124b2dcbeae071909"}]},"branch":"refs/heads/master"},"c7d582379ad6b22c6dd8b7334b34a51ec59b69d4":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-01-21 11:02:16.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/91/771691/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/91/771691/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/771691/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/771691/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/771691/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/91/771691/2"}}},"commit":{"parents":[{"commit":"d6c9b7f198b94ef05c96dc72fc71d34f019e9350","subject":"compute: Shuffle options for \u0027server create\u0027","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d6c9b7f198b94ef05c96dc72fc71d34f019e9350"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2020-12-10 15:06:03.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2021-01-21 11:01:15.000000000","tz":0},"subject":"compute: Improve \u0027server create --nic\u0027 option parsing","message":"compute: Improve \u0027server create --nic\u0027 option parsing\n\nSimplify the parsing of this option by making use of a custom action.\n\nChange-Id: I670ff5109522d533ef4e62a79116e49a35c4e8fa\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c7d582379ad6b22c6dd8b7334b34a51ec59b69d4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c7d582379ad6b22c6dd8b7334b34a51ec59b69d4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}