)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a5c37ee2abd86a3f8942a5f6f8a8b0ab6a13d28c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d30dfb52_5e6a1407","updated":"2021-11-25 14:38:15.000000000","message":"This has been here long enough. @Brian Sorry for the delay. Feel free to ping us on IRC for things that fall through the cracks like this","commit_id":"e4e9fb594d003ea6c3ec29aab0bccf72ffab6781"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"10af76149047a9ceca4a093f22221a266b12ea74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4371c9f4_ce6e50b0","updated":"2021-11-22 21:19:29.000000000","message":"recheck\n\nBeen a while so making sure it still passes.","commit_id":"e4e9fb594d003ea6c3ec29aab0bccf72ffab6781"}],"openstackclient/network/v2/subnet.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d2f3b7028239a0d3965fb54ab7ac4640a07dc3ae","unresolved":true,"context_lines":[{"line_number":489,"context_line":"                   \"e.g.: --subnet-range 10.10.0.0/16\")"},{"line_number":490,"context_line":"        )"},{"line_number":491,"context_line":"        parser.add_argument("},{"line_number":492,"context_line":"            \u0027--subnet-pool\u0027,"},{"line_number":493,"context_line":"            metavar\u003d\u0027\u003csubnet-pool\u003e\u0027,"},{"line_number":494,"context_line":"            help\u003d_(\"List only subnets which belong to a given subnet pool \""},{"line_number":495,"context_line":"                   \"in output (Name or ID)\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"14e99ef1_fd7f91dd","line":492,"range":{"start_line":492,"start_character":15,"end_line":492,"end_character":22},"updated":"2021-03-16 15:09:37.000000000","message":"Does it make sense to drop the prefix, given we\u0027re already talking about subnets. \u0027subnet list --subnet-pool foo\u0027 sounds a bit redundant. Are there other kinds of pool one could mistake by making this generic?\n\n(Yes, by the same extension the above should be \u0027--subnet-range\u0027 but that ship has sailed)","commit_id":"e4e9fb594d003ea6c3ec29aab0bccf72ffab6781"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4351d2ea13fdf787a72f5cbe0bd8ef6fa5910201","unresolved":true,"context_lines":[{"line_number":489,"context_line":"                   \"e.g.: --subnet-range 10.10.0.0/16\")"},{"line_number":490,"context_line":"        )"},{"line_number":491,"context_line":"        parser.add_argument("},{"line_number":492,"context_line":"            \u0027--subnet-pool\u0027,"},{"line_number":493,"context_line":"            metavar\u003d\u0027\u003csubnet-pool\u003e\u0027,"},{"line_number":494,"context_line":"            help\u003d_(\"List only subnets which belong to a given subnet pool \""},{"line_number":495,"context_line":"                   \"in output (Name or ID)\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"fafff063_af71c2ee","line":492,"range":{"start_line":492,"start_character":15,"end_line":492,"end_character":22},"in_reply_to":"14e99ef1_fd7f91dd","updated":"2021-03-16 18:36:26.000000000","message":"The \u0027create\u0027 call already uses --subnet-pool, so I think we should be consistent.  That\u0027s been there since 2016.","commit_id":"e4e9fb594d003ea6c3ec29aab0bccf72ffab6781"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"85f37856d9239a8c7e99893a822bd9256afab45b","unresolved":false,"context_lines":[{"line_number":489,"context_line":"                   \"e.g.: --subnet-range 10.10.0.0/16\")"},{"line_number":490,"context_line":"        )"},{"line_number":491,"context_line":"        parser.add_argument("},{"line_number":492,"context_line":"            \u0027--subnet-pool\u0027,"},{"line_number":493,"context_line":"            metavar\u003d\u0027\u003csubnet-pool\u003e\u0027,"},{"line_number":494,"context_line":"            help\u003d_(\"List only subnets which belong to a given subnet pool \""},{"line_number":495,"context_line":"                   \"in output (Name or ID)\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"d53ca7d3_f4fba551","line":492,"range":{"start_line":492,"start_character":15,"end_line":492,"end_character":22},"in_reply_to":"70677b32_158c563f","updated":"2021-03-16 19:14:20.000000000","message":"Ack, wfm","commit_id":"e4e9fb594d003ea6c3ec29aab0bccf72ffab6781"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ccb030e7f6eab3ae2774cec857a21c0c6d816880","unresolved":true,"context_lines":[{"line_number":489,"context_line":"                   \"e.g.: --subnet-range 10.10.0.0/16\")"},{"line_number":490,"context_line":"        )"},{"line_number":491,"context_line":"        parser.add_argument("},{"line_number":492,"context_line":"            \u0027--subnet-pool\u0027,"},{"line_number":493,"context_line":"            metavar\u003d\u0027\u003csubnet-pool\u003e\u0027,"},{"line_number":494,"context_line":"            help\u003d_(\"List only subnets which belong to a given subnet pool \""},{"line_number":495,"context_line":"                   \"in output (Name or ID)\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"70677b32_158c563f","line":492,"range":{"start_line":492,"start_character":15,"end_line":492,"end_character":22},"in_reply_to":"fafff063_af71c2ee","updated":"2021-03-16 18:53:05.000000000","message":"Also the object by which we are filtering is called \"subnet-pool\", not just \"pool\".","commit_id":"e4e9fb594d003ea6c3ec29aab0bccf72ffab6781"}]}
