)]}'
{"id":"openstack%2Fpython-openstackclient~778763","triplet_id":"openstack%2Fpython-openstackclient~master~I1718be965f57c3bbdb8a14f3cfac967dd4c55b4d","project":"openstack/python-openstackclient","branch":"master","topic":"osc-first","hashtags":[],"change_id":"I1718be965f57c3bbdb8a14f3cfac967dd4c55b4d","subject":"compute: Add functional tests for --block-device","status":"MERGED","created":"2021-03-04 18:37:42.000000000","updated":"2021-03-11 12:46:38.000000000","submitted":"2021-03-11 12:44:47.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"778763-osc-first","meta_rev_id":"eba45826454c94427f566c6810ee3d67d8c9f1a5","_number":778763,"virtual_id_number":778763,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-03-11 12:44:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":2,"date":"2021-03-11 09:58:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":1,"date":"2021-03-11 09:58:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-04 20:38:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-11 09:58:16.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"}],"messages":[{"id":"e6900779be395180c3dca06c294e64c0c79db733","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-03-04 18:37:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b76de6aa9bdb63c191553bf15910cdb09d4703a4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-04 20:38:48.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/29fd979c617b4e2fbb1142a57400e35c : SUCCESS in 6m 35s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/0ac38759b4c2464bb70ffe0fe8795761 : SUCCESS in 6m 46s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/bbcde8b0f93843f08802252a5ef4dced : SUCCESS in 5m 56s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6d32e403b77247e09e46c0cd4877676d : SUCCESS in 6m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fe7b037cc1f0461f8992b595f8d7d6a1 : SUCCESS in 5m 59s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/600ddcc5948b48a8b2f709ccdf914613 : SUCCESS in 7m 31s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/23479aaa5eaf41059e74e9c19238bb61 : SUCCESS in 5m 55s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/03631e505a39417a9ad436400ce9ee96 : SUCCESS in 6m 00s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/232141667a2f41d98a8d2a2ffbb2fbf2 : SUCCESS in 7m 46s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/61e68db574f748bbb05eece37fb033bf : SUCCESS in 8m 20s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/c69065ac298f4252a8d7190b9432627b : FAILURE in 55m 57s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/becfa2945b9848fe8487c86e1ad23df6 : FAILURE in 55m 05s","accounts_in_message":[],"_revision_number":1},{"id":"7a7b9f78da5fc76d757fc83e0879b754f07ce77d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-03-05 12:05:02.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"75d816dfc22f1fff3a5b92a07b36ffb64e9d2c4d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-03-05 12:05:41.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"2676b205d5d1943093cd5b67949d00aad1e08f67","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-05 13:08:16.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/e552a60999c7479a919974c79de255f1 : SUCCESS in 5m 26s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/be5103953a12401889337a043f3e077c : FAILURE in 7m 22s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/702f7859837a4b6ea1d2fd3af4fcef55 : FAILURE in 4m 13s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/533696afc24243aab5aedac38fea8c62 : FAILURE in 5m 03s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/38c5d19a056949af99fc47eb30415e6e : SUCCESS in 4m 26s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e04a184b78c44f24a6b3566cc968c54c : FAILURE in 4m 37s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a6b5651f9c58497a920a250dc61d0eba : FAILURE in 4m 26s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/cc9af141dfd24eaab14f94d9b24f8d21 : FAILURE in 4m 57s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2cd2a16f7e134fbc82b6e38b3f4ce40f : SUCCESS in 6m 23s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/6b42f7ae11e34ea3be04d1f5f6593f7c : SUCCESS in 8m 32s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/3997b448edb84dfaa08591a34ecd7f0b : SUCCESS in 59m 38s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/135b8a3e3c024e0e80db50b27fd1fcb9 : SUCCESS in 51m 28s","accounts_in_message":[],"_revision_number":3},{"id":"6a97a417f5cbfe1d1c705efca6c5418ccef51864","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-03-05 13:11:29.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"1d816676966d9ea7952d78c53bafcd6830937891","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-05 15:51:25.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/cdd0b738d83f468ebabaf8ae9bdf6ee0 : SUCCESS in 5m 46s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/80374d64d707419cb52f715e7706ab9e : SUCCESS in 5m 49s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/37e6cf496670423b913f025e66fc223f : SUCCESS in 5m 21s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/84b90818caa543b5a3e7050b12294f07 : SUCCESS in 6m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4af4f62121184b8fba188c94a8dd46aa : SUCCESS in 4m 15s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/979190e1fbd44f79927726d1e45f461d : SUCCESS in 7m 44s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/58618728479542dd9e04985d57387e1d : SUCCESS in 6m 10s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/cea3d6325ab74e3d9cd5c971fcd87e35 : SUCCESS in 7m 22s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/df43a677fd734efebee8b9a53d490bb2 : SUCCESS in 7m 40s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/18dbb8ebc0e041b6be055c7c9bfe48a9 : SUCCESS in 8m 55s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/5740bfe0bc254e5f9502a4fb7dc5ed59 : SUCCESS in 1h 11m 11s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/5baab459d964484ba783f42f86aeb6c2 : SUCCESS in 56m 45s","accounts_in_message":[],"_revision_number":4},{"id":"eb2f4b187a13abdee22d9cda00bb352ad24c3d96","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2021-03-11 09:58:16.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"afea52ba6911314c259ec0742832615daac16fda","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-11 09:58:37.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"611e5476be52841bca588d974eb6aeef9f40fd18","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-11 12:44:38.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/981a66277752468d85191d11c94e61bc : SUCCESS in 5m 49s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e5a91f6cf6074a819fa5c20a86e4a65c : SUCCESS in 5m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/91f5a582659b4c37ad2374f2e5658875 : SUCCESS in 4m 29s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/79d64d5c909a436eb2c3e8b0de83b15f : SUCCESS in 4m 34s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/f616a2fd74cf473b9a748e1b67fc00a6 : SUCCESS in 4m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/86bf37f82e614a60acc6e196ee433aea : SUCCESS in 8m 50s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/ad598583d2824678b632d417994365f6 : SUCCESS in 8m 14s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/7fe8a88248a946cfacc7f55a3a22ca2d : SUCCESS in 57m 26s","accounts_in_message":[],"_revision_number":4},{"id":"d6bc336e1579c3215d6d59eb47a8e03ca217211d","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-11 12:44:47.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"eba45826454c94427f566c6810ee3d67d8c9f1a5","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-11 12:46:38.000000000","message":"Patch Set 4:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d3e28ac195e64deba32eb799869bdf38 : SUCCESS in 1m 14s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/c61a8e3355084eff88d2dfe803c4a9f2 : SUCCESS in 45s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"7c1d6f769c4f0d2afe61410fefd8bc8f26a22980","revisions":{"2fe2669b4f718a1d7f026a18a867c0babb621df8":{"kind":"REWORK","_number":1,"created":"2021-03-04 18:37:42.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/63/778763/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/63/778763/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/63/778763/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/63/778763/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/63/778763/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/63/778763/1"}}},"commit":{"parents":[{"commit":"70480fa86236f7de583c7b098cc53f0acedfd91d","subject":"compute: Remove deprecated \u0027server migrate --live\u0027 option","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/70480fa86236f7de583c7b098cc53f0acedfd91d"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2021-03-04 18:34:00.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2021-03-04 18:34:00.000000000","tz":0},"subject":"compute: Add functional tests for --block-device","message":"compute: Add functional tests for --block-device\n\nThis mostly reuses the existing tests for \u0027--block-device-mapping\u0027,\nwhich can hopefully be removed at some point in the future.\n\nChange-Id: I1718be965f57c3bbdb8a14f3cfac967dd4c55b4d\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2fe2669b4f718a1d7f026a18a867c0babb621df8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2fe2669b4f718a1d7f026a18a867c0babb621df8"}]},"branch":"refs/heads/master"},"847547c16f9433ba22a4e0e62eb48f9a57aed968":{"kind":"REWORK","_number":2,"created":"2021-03-05 12:05:02.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/63/778763/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/63/778763/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/63/778763/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/63/778763/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/63/778763/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/63/778763/2"}}},"commit":{"parents":[{"commit":"a507fb50f8b98b026be88de41f1bac49bafe19bf","subject":"Merge \"compute: Remove deprecated \u0027server migrate --live\u0027 option\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a507fb50f8b98b026be88de41f1bac49bafe19bf"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2021-03-04 18:34:00.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2021-03-05 11:58:34.000000000","tz":0},"subject":"compute: Add functional tests for --block-device","message":"compute: Add functional tests for --block-device\n\nThis mostly reuses the existing tests for \u0027--block-device-mapping\u0027,\nwhich can hopefully be removed at some point in the future.\n\nThis highlights two issues with the implementation of this option.\nFirstly, the \u0027boot_index\u0027 parameter is not required so don\u0027t mandate it.\nSecondly, and more significantly, we were defaulting the destination\ntype for the \u0027image\u0027 source type to \u0027local\u0027. Nova only allows you to\nattach a single image to local mapping [1], which means this default\nwould only make sense if you were expecting users to use the\n\u0027--block-device\u0027 option exclusively and omit the \u0027--image\u0027 option. This\nis the *less common* case so this is a bad default. Default instead to a\ndestination type of \u0027volume\u0027 like everything else, and require users\nspecifying \u0027--block-device\u0027 alone to pass \u0027destination_type\u003dlocal\u0027\nexplicitly.\n\nChange-Id: I1718be965f57c3bbdb8a14f3cfac967dd4c55b4d\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/847547c16f9433ba22a4e0e62eb48f9a57aed968"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/847547c16f9433ba22a4e0e62eb48f9a57aed968"}]},"branch":"refs/heads/master"},"5481910c367d11ddd3c6a9f2409e3ab60df7d4e4":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2021-03-05 12:05:41.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/63/778763/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/63/778763/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/63/778763/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/63/778763/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/63/778763/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/63/778763/3"}}},"commit":{"parents":[{"commit":"a507fb50f8b98b026be88de41f1bac49bafe19bf","subject":"Merge \"compute: Remove deprecated \u0027server migrate --live\u0027 option\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a507fb50f8b98b026be88de41f1bac49bafe19bf"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2021-03-04 18:34:00.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2021-03-05 12:05:30.000000000","tz":0},"subject":"compute: Add functional tests for --block-device","message":"compute: Add functional tests for --block-device\n\nThis mostly reuses the existing tests for \u0027--block-device-mapping\u0027,\nwhich can hopefully be removed at some point in the future.\n\nThis highlights two issues with the implementation of this option.\nFirstly, the \u0027boot_index\u0027 parameter is not required so don\u0027t mandate it.\nSecondly, and more significantly, we were defaulting the destination\ntype for the \u0027image\u0027 source type to \u0027local\u0027. Nova only allows you to\nattach a single image to local mapping [1], which means this default\nwould only make sense if you were expecting users to use the\n\u0027--block-device\u0027 option exclusively and omit the \u0027--image\u0027 option. This\nis the *less common* case so this is a bad default. Default instead to a\ndestination type of \u0027volume\u0027 like everything else, and require users\nspecifying \u0027--block-device\u0027 alone to pass \u0027destination_type\u003dlocal\u0027\nexplicitly.\n\n[1] https://github.com/openstack/nova/blob/c8a6f8d2e/nova/block_device.py#L193-L206\n\nChange-Id: I1718be965f57c3bbdb8a14f3cfac967dd4c55b4d\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5481910c367d11ddd3c6a9f2409e3ab60df7d4e4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5481910c367d11ddd3c6a9f2409e3ab60df7d4e4"}]},"branch":"refs/heads/master"},"7c1d6f769c4f0d2afe61410fefd8bc8f26a22980":{"kind":"REWORK","_number":4,"created":"2021-03-05 13:11:29.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/63/778763/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/63/778763/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/63/778763/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/63/778763/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/63/778763/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/63/778763/4"}}},"commit":{"parents":[{"commit":"a507fb50f8b98b026be88de41f1bac49bafe19bf","subject":"Merge \"compute: Remove deprecated \u0027server migrate --live\u0027 option\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a507fb50f8b98b026be88de41f1bac49bafe19bf"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2021-03-04 18:34:00.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2021-03-05 12:44:52.000000000","tz":0},"subject":"compute: Add functional tests for --block-device","message":"compute: Add functional tests for --block-device\n\nThis mostly reuses the existing tests for \u0027--block-device-mapping\u0027,\nwhich can hopefully be removed at some point in the future.\n\nThis highlights two issues with the implementation of this option.\nFirstly, the \u0027boot_index\u0027 parameter is not required so don\u0027t mandate it.\nSecondly, and more significantly, we were defaulting the destination\ntype for the \u0027image\u0027 source type to \u0027local\u0027. Nova only allows you to\nattach a single image to local mapping [1], which means this default\nwould only make sense if you were expecting users to use the\n\u0027--block-device\u0027 option exclusively and omit the \u0027--image\u0027 option. This\nis the *less common* case so this is a bad default. Default instead to a\ndestination type of \u0027volume\u0027 like everything else, and require users\nspecifying \u0027--block-device\u0027 alone to pass \u0027destination_type\u003dlocal\u0027\nexplicitly.\n\n[1] https://github.com/openstack/nova/blob/c8a6f8d2e/nova/block_device.py#L193-L206\n\nChange-Id: I1718be965f57c3bbdb8a14f3cfac967dd4c55b4d\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7c1d6f769c4f0d2afe61410fefd8bc8f26a22980"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7c1d6f769c4f0d2afe61410fefd8bc8f26a22980"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}